bamf-0.5.6-1.fc41

List of Defects

Error: CPPCHECK_WARNING: [#def1]
bamf-0.5.6-build/bamf-0.5.6/doc/reference/libbamf/libbamf-scan.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CLANG_WARNING: [#def2]
bamf-0.5.6-build/bamf-0.5.6/doc/reference/libbamf/libbamf-scan.c:194:16: warning[deadcode.DeadStores]: Although the value stored to 'event_num' is used in the enclosing expression, the value is never actually read from 'event_num'

Error: CPPCHECK_WARNING: [#def3]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf-private/bamf-gdbus-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def4]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf-private/bamf-gdbus-view-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def5]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/bamf-application.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def6]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/bamf-factory.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CLANG_WARNING: [#def7]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/bamf-factory.c:146:15: warning[deadcode.DeadStores]: Value stored to 'removed' is never read
#  144|               {
#  145|                 g_hash_table_iter_remove (&iter);
#  146|->               removed = TRUE;
#  147|                 break;
#  148|               }

Error: CPPCHECK_WARNING: [#def8]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/bamf-matcher.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def9]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/bamf-view.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CLANG_WARNING: [#def10]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/bamf-view.c:608:27: warning[deadcode.DeadStores]: Although the value stored to 'priv' is used in the enclosing expression, the value is never actually read from 'priv'
#  606|   bamf_view_on_name_owner_changed (BamfDBusItemView *proxy, GParamSpec *param, BamfView *self)
#  607|   {
#  608|->   BamfViewPrivate *priv = priv = bamf_view_get_instance_private (self);
#  609|   
#  610|     /* This is called when the bamfdaemon is killed / started */

Error: CPPCHECK_WARNING: [#def11]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/bamf-window.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def12]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/tmp-introspectj5s6e_lp/Bamf-3.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CLANG_WARNING: [#def13]
bamf-0.5.6-build/bamf-0.5.6/lib/libbamf/tmp-introspectj5s6e_lp/Bamf-3.c:799:27: warning[core.NullDereference]: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')

Error: CPPCHECK_WARNING: [#def14]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-application.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CLANG_WARNING: [#def15]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-application.c:1299:15: warning[deadcode.DeadStores]: Value stored to 'type' during its initialization is never read
# 1297|                                    BamfApplication *self)
# 1298|   {
# 1299|->   const char *type = "";
# 1300|   
# 1301|     switch (self->priv->app_type)

Error: CPPCHECK_WARNING: [#def16]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: COMPILER_WARNING (CWE-477): [#def17]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c: scope_hint: In function ‘bamf_legacy_screen_inject_window’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c:329:3: warning[-Wdeprecated-declarations]: ‘wnck_window_get’ is deprecated: Use 'wnck_handle_get_window' instead
/usr/include/libwnck-3.0/libwnck/libwnck.h:28: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.h:30: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.h:24: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c:20: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/window.h:293:13: note: declared here
#  327|       }
#  328|   
#  329|->   WnckWindow *legacy_window = wnck_window_get (xid);
#  330|   
#  331|     if (WNCK_IS_WINDOW (legacy_window))

Error: COMPILER_WARNING (CWE-477): [#def18]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c: scope_hint: In function ‘bamf_legacy_screen_get_default’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c:591:3: warning[-Wdeprecated-declarations]: ‘wnck_set_default_icon_size’ is deprecated: Use 'wnck_handle_set_default_icon_size' instead
/usr/include/libwnck-3.0/libwnck/wnck-handle.h:27: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/libwnck.h:26: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/util.h:110:6: note: declared here
#  589|       return static_screen;
#  590|   
#  591|->   wnck_set_default_icon_size (BAMF_DEFAULT_ICON_SIZE);
#  592|     wnck_set_default_mini_icon_size (BAMF_DEFAULT_MINI_ICON_SIZE);
#  593|   

Error: COMPILER_WARNING (CWE-477): [#def19]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c:592:3: warning[-Wdeprecated-declarations]: ‘wnck_set_default_mini_icon_size’ is deprecated: Use 'wnck_handle_set_default_mini_icon_size' instead
/usr/include/libwnck-3.0/libwnck/util.h:113:6: note: declared here
#  590|   
#  591|     wnck_set_default_icon_size (BAMF_DEFAULT_ICON_SIZE);
#  592|->   wnck_set_default_mini_icon_size (BAMF_DEFAULT_MINI_ICON_SIZE);
#  593|   
#  594|     self->priv->legacy_screen = wnck_screen_get_default ();

Error: COMPILER_WARNING (CWE-477): [#def20]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-screen.c:594:3: warning[-Wdeprecated-declarations]: ‘wnck_screen_get_default’ is deprecated: Use 'wnck_handle_get_default_screen' instead
/usr/include/libwnck-3.0/libwnck/wnck-handle.h:26: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/screen.h:198:16: note: declared here
#  592|     wnck_set_default_mini_icon_size (BAMF_DEFAULT_MINI_ICON_SIZE);
#  593|   
#  594|->   self->priv->legacy_screen = wnck_screen_get_default ();
#  595|   
#  596|     dpy = gdk_x11_get_default_xdisplay ();

Error: CPPCHECK_WARNING: [#def21]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: COMPILER_WARNING (CWE-477): [#def22]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c: scope_hint: In function ‘bamf_legacy_window_is_active’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c:70:3: warning[-Wdeprecated-declarations]: ‘wnck_screen_get_default’ is deprecated: Use 'wnck_handle_get_default_screen' instead
/usr/include/libwnck-3.0/libwnck/wnck-handle.h:26: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/libwnck.h:26: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.h:30: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c:23: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/screen.h:198:16: note: declared here
#   68|       return BAMF_LEGACY_WINDOW_GET_CLASS (self)->is_active (self);
#   69|   
#   70|->   active = wnck_screen_get_active_window (wnck_screen_get_default ());
#   71|   
#   72|     return active == self->priv->legacy_window;

Error: COMPILER_WARNING (CWE-477): [#def23]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c: scope_hint: In function ‘bamf_legacy_window_save_mini_icon’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c:322:3: warning[-Wdeprecated-declarations]: ‘wnck_window_get_icon’ is deprecated: Use 'wnck_window_get_icon_surface' instead
/usr/include/libwnck-3.0/libwnck/libwnck.h:28: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/window.h:385:12: note: declared here
#  320|   
#  321|     output = g_io_stream_get_output_stream (G_IO_STREAM (iostream));
#  322|->   pbuf = wnck_window_get_icon (window);
#  323|   
#  324|     if (gdk_pixbuf_save_to_stream (pbuf, output, "png", NULL, NULL, NULL))

Error: COMPILER_WARNING (CWE-477): [#def24]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c: scope_hint: In function ‘top_window_action_menu’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c:546:3: warning[-Wdeprecated-declarations]: ‘gdk_screen_get_monitor_scale_factor’ is deprecated: Use 'gdk_monitor_get_scale_factor' instead
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/util.h:30: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/wnck-handle.h:27: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkscreen.h:103:15: note: declared here
#  544|     gint w, h, scale;
#  545|   
#  546|->   scale = gdk_screen_get_monitor_scale_factor (gdk_screen_get_default (), 0);
#  547|     scale = !scale ? 1: scale;
#  548|   

Error: COMPILER_WARNING (CWE-477): [#def25]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c: scope_hint: In function ‘bamf_legacy_window_show_action_menu’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c:607:3: warning[-Wdeprecated-declarations]: ‘gtk_menu_popup’ is deprecated: Use '(gtk_menu_popup_at_widget, gtk_menu_popup_at_pointer, gtk_menu_popup_at_rect)' instead
/usr/include/gtk-3.0/gtk/gtklabel.h:34: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtkaccellabel.h:35: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:33: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtkmenu.h:138:12: note: declared here
#  605|   
#  606|     GtkMenuPositionFunc position = button ? NULL : top_window_action_menu;
#  607|->   gtk_menu_popup (GTK_MENU (menu), NULL, NULL, position, self, button, time);
#  608|   }
#  609|   

Error: COMPILER_WARNING (CWE-477): [#def26]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c: scope_hint: In function ‘bamf_legacy_window_dispose’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c:675:3: warning[-Wdeprecated-declarations]: ‘wnck_screen_get_default’ is deprecated: Use 'wnck_handle_get_default_screen' instead
/usr/include/libwnck-3.0/libwnck/screen.h:198:16: note: declared here
#  673|     g_clear_pointer (&self->priv->working_dir, g_free);
#  674|   
#  675|->   g_signal_handlers_disconnect_by_data (wnck_screen_get_default (), self);
#  676|   
#  677|     if (self->priv->legacy_window)

Error: COMPILER_WARNING (CWE-477): [#def27]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c: scope_hint: In function ‘bamf_legacy_window_init’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.c:707:3: warning[-Wdeprecated-declarations]: ‘wnck_screen_get_default’ is deprecated: Use 'wnck_handle_get_default_screen' instead
/usr/include/libwnck-3.0/libwnck/screen.h:198:16: note: declared here
#  705|     self->priv = bamf_legacy_window_get_instance_private (self);
#  706|   
#  707|->   g_signal_connect (wnck_screen_get_default (), "window-closed",
#  708|                       (GCallback) handle_window_closed, self);
#  709|   }

Error: CPPCHECK_WARNING: [#def28]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-matcher.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def29]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-view.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def30]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-window.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: COMPILER_WARNING (CWE-477): [#def31]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-window.c: scope_hint: In function ‘bamf_window_get_monitor’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-window.c:368:3: warning[-Wdeprecated-declarations]: ‘gdk_screen_get_monitor_at_point’ is deprecated: Use 'gdk_display_get_monitor_at_point' instead
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/util.h:30: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/wnck-handle.h:27: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/libwnck.h:26: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-legacy-window.h:30: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-window.h:24: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-application.h:25: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-window.c:20: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkscreen.h:87:15: note: declared here
#  366|     bamf_legacy_window_get_geometry (self->priv->legacy_window, &x, &y, &width, &height);
#  367|   
#  368|->   return gdk_screen_get_monitor_at_point (gdk_screen, x + width/2, y + height/2);
#  369|   }
#  370|   

Error: CPPCHECK_WARNING: [#def32]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: COMPILER_WARNING (CWE-477): [#def33]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c: scope_hint: In function ‘gdk_error_trap_pop_and_print’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c:51:3: warning[-Wdeprecated-declarations]: ‘gdk_flush’ is deprecated: Use 'gdk_display_flush' instead
#   51 |   gdk_flush ();
#      |   ^~~~~~~~~
/usr/include/gtk-3.0/gdk/gdk.h:50: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkx.h:28: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.h:26: included_from: Included from here.
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c:21: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkmain.h:124:6: note: declared here
#  124 | void gdk_flush (void);
#      |      ^~~~~~~~~
#   49|   gdk_error_trap_pop_and_print (Display *dpy)
#   50|   {
#   51|->   gdk_flush ();
#   52|     gint error_code = gdk_error_trap_pop ();
#   53|   

Error: COMPILER_WARNING (CWE-477): [#def34]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c:52:3: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_pop’ is deprecated: Use 'gdk_x11_display_error_trap_pop' instead
#   52 |   gint error_code = gdk_error_trap_pop ();
#      |   ^~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:73:32: note: declared here
#   73 | G_GNUC_WARN_UNUSED_RESULT gint gdk_error_trap_pop         (void);
#      |                                ^~~~~~~~~~~~~~~~~~
#   50|   {
#   51|     gdk_flush ();
#   52|->   gint error_code = gdk_error_trap_pop ();
#   53|   
#   54|     if (error_code)

Error: COMPILER_WARNING (CWE-477): [#def35]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c: scope_hint: In function ‘bamf_xutils_get_string_window_hint_and_type’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c:98:3: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_push’ is deprecated: Use 'gdk_x11_display_error_trap_push' instead
#   98 |   gdk_error_trap_push ();
#      |   ^~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:70:32: note: declared here
#   70 | void                           gdk_error_trap_push        (void);
#      |                                ^~~~~~~~~~~~~~~~~~~
#   96|     }
#   97|   
#   98|->   gdk_error_trap_push ();
#   99|   
#  100|     int result = XGetWindowProperty (XDisplay,  xid,

Error: COMPILER_WARNING (CWE-477): [#def36]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c: scope_hint: In function ‘bamf_xutils_set_string_window_hint’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c:176:3: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_push’ is deprecated: Use 'gdk_x11_display_error_trap_push' instead
#  176 |   gdk_error_trap_push ();
#      |   ^~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:70:32: note: declared here
#   70 | void                           gdk_error_trap_push        (void);
#      |                                ^~~~~~~~~~~~~~~~~~~
#  174|       }
#  175|   
#  176|->   gdk_error_trap_push ();
#  177|   
#  178|     XChangeProperty (XDisplay, xid, gdk_x11_get_xatom_by_name (atom_name),

Error: COMPILER_WARNING (CWE-477): [#def37]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c: scope_hint: In function ‘bamf_xutils_unset_window_hint’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c:204:3: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_push’ is deprecated: Use 'gdk_x11_display_error_trap_push' instead
#  204 |   gdk_error_trap_push ();
#      |   ^~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:70:32: note: declared here
#   70 | void                           gdk_error_trap_push        (void);
#      |                                ^~~~~~~~~~~~~~~~~~~
#  202|     }
#  203|   
#  204|->   gdk_error_trap_push ();
#  205|     XDeleteProperty (XDisplay, xid, gdk_x11_get_xatom_by_name (atom_name));
#  206|     gdk_error_trap_pop_and_print (XDisplay);

Error: COMPILER_WARNING (CWE-477): [#def38]
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c: scope_hint: In function ‘bamf_xutils_get_window_class_hints’
bamf-0.5.6-build/bamf-0.5.6/src/bamf-xutils.c:230:3: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_push’ is deprecated: Use 'gdk_x11_display_error_trap_push' instead
#  230 |   gdk_error_trap_push ();
#      |   ^~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:70:32: note: declared here
#   70 | void                           gdk_error_trap_push        (void);
#      |                                ^~~~~~~~~~~~~~~~~~~
#  228|     class_hint.res_class = NULL;
#  229|   
#  230|->   gdk_error_trap_push ();
#  231|   
#  232|     XGetClassHint (xdisplay, xid, &class_hint);

Error: CPPCHECK_WARNING: [#def39]
bamf-0.5.6-build/bamf-0.5.6/tests/bamfdaemon/test-application.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def40]
bamf-0.5.6-build/bamf-0.5.6/tests/bamfdaemon/test-matcher.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Scan Properties