Fixed defects

List of Defects

Error: COMPILER_WARNING (CWE-477): [#def1]
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/account/gis-account-page-local.c: scope_hint: In function ‘avatar_callback’
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/account/gis-account-page-local.c:215:5: warning[-Wdeprecated-declarations]: ‘gtk_image_set_from_pixbuf’ is deprecated: Use 'gtk_image_set_from_paintable' instead
/usr/include/gtk-4.0/gtk/gtkentry.h:40: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkimage.h:95:6: note: declared here
#  213|   
#  214|     if (rounded != NULL) {
#  215|->     gtk_image_set_from_pixbuf (GTK_IMAGE (page->avatar_image), rounded);
#  216|     }
#  217|     else {

Error: COMPILER_WARNING (CWE-477): [#def2]
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/account/um-photo-dialog.c: scope_hint: In function ‘create_face_widget’
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/account/um-photo-dialog.c:101:17: warning[-Wdeprecated-declarations]: ‘gtk_image_new_from_pixbuf’ is deprecated: Use 'gtk_image_new_from_paintable' instead
/usr/include/gtk-4.0/gtk/gtkentry.h:40: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtktreeview.h:27: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkcombobox.h:26: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:94: included_from: Included from here.
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/account/um-photo-dialog.c:29: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkimage.h:78:12: note: declared here
#   99|   
#  100|           if (pixbuf != NULL)
#  101|->                 image = gtk_image_new_from_pixbuf (round_image (pixbuf));
#  102|           else
#  103|                   image = gtk_image_new ();

Error: COMPILER_WARNING (CWE-477): [#def3]
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/account/um-utils.c: scope_hint: In function ‘round_image’
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/account/um-utils.c:563:9: warning[-Wdeprecated-declarations]: ‘gdk_pixbuf_get_from_surface’ is deprecated
/usr/include/gtk-4.0/gdk/gdkcairo.h:25: included_from: Included from here.
/usr/include/gtk-4.0/gdk/gdk.h:30: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:30: included_from: Included from here.
/usr/include/gtk-4.0/gdk/deprecated/gdkpixbuf.h:37:12: note: declared here
#  561|           cairo_paint (cr);
#  562|   
#  563|->         dest = gdk_pixbuf_get_from_surface (surface, 0, 0, size, size);
#  564|           cairo_surface_destroy (surface);
#  565|           cairo_destroy (cr);

Error: CLANG_WARNING: [#def4]
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/keyboard/gis-keyboard-page.c:251:30: warning[core.NullDereference]: Array access (from variable 'layouts') results in a null pointer dereference
#  249|                   n = 0;
#  250|   
#  251|->         for (i = 0; i < n && layouts[i][0]; i++) {
#  252|                   if (variants && variants[i] && variants[i][0])
#  253|                           id = g_strdup_printf ("%s+%s", layouts[i], variants[i]);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/keyboard/gis-keyboard-page.c: scope_hint: In function ‘get_localed_input’
gnome-initial-setup-46.alpha-build/gnome-initial-setup-46.alpha/gnome-initial-setup/pages/keyboard/gis-keyboard-page.c:251:37: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘layouts’
#  249|                   n = 0;
#  250|   
#  251|->         for (i = 0; i < n && layouts[i][0]; i++) {
#  252|                   if (variants && variants[i] && variants[i][0])
#  253|                           id = g_strdup_printf ("%s+%s", layouts[i], variants[i]);

Scan Properties