Fixed defects

List of Defects

Error: GCC_ANALYZER_WARNING (CWE-476): [#def1]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-ctl.c: scope_hint: In function ‘print_rdp_status’
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-ctl.c:563:7: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘error’
/usr/include/glib-2.0/glib/gmacros.h:1358:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:56:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
/usr/include/glib-2.0/glib/glib-autocleanups.h: scope_hint: In function ‘print_rdp_status’
/usr/include/glib-2.0/glib/gmacros.h:1358:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:56:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:56:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
#  561|     if (!credentials)
#  562|       {
#  563|->       fprintf (stderr, "Failed to initialize credential manager: %s\n",
#  564|                  error->message);
#  565|         return;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def2]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-ctl.c: scope_hint: In function ‘print_vnc_status’
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-ctl.c:628:7: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘error’
/usr/include/glib-2.0/glib/gmacros.h:1358:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:56:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
/usr/include/glib-2.0/glib/glib-autocleanups.h: scope_hint: In function ‘print_vnc_status’
/usr/include/glib-2.0/glib/gmacros.h:1358:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:56:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:56:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
#  626|     if (!credentials)
#  627|       {
#  628|->       fprintf (stderr, "Failed to initialize credential manager: %s\n",
#  629|                  error->message);
#  630|         return;

Error: CPPCHECK_WARNING: [#def3]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-display-control.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def4]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-dvc.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def5]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-gfx-surface.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CLANG_WARNING: [#def6]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-layout-manager.c:586:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read
#  584|     GHashTableIter iter;
#  585|   
#  586|->   locker = g_mutex_locker_new (&layout_manager->state_mutex);
#  587|     if (layout_manager->state != UPDATE_STATE_AWAIT_CONFIG)
#  588|       return FALSE;

Error: CLANG_WARNING: [#def7]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-layout-manager.c:723:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read
#  721|     g_autoptr (GMutexLocker) locker = NULL;
#  722|   
#  723|->   locker = g_mutex_locker_new (&layout_manager->monitor_config_mutex);
#  724|     if (!layout_manager->pending_monitor_config)
#  725|       return FALSE;

Error: CLANG_WARNING: [#def8]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-pipewire-stream.c:729:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read
#  727|       g_assert_not_reached ();
#  728|   
#  729|->   locker = g_mutex_locker_new (&stream->dequeue_mutex);
#  730|   
#  731|     /* Ensure buffer is not locked any more */

Error: CLANG_WARNING: [#def9]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-pipewire-stream.c:1140:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read
# 1138|     struct pw_buffer *next_buffer;
# 1139|   
# 1140|->   locker = g_mutex_locker_new (&stream->dequeue_mutex);
# 1141|     if (stream->dequeuing_disallowed)
# 1142|       return;

Error: CPPCHECK_WARNING: [#def10]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-server.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def11]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-rdp-telemetry.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CLANG_WARNING: [#def12]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-session-rdp.c:325:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read
#  323|     g_assert (session_rdp->peer);
#  324|   
#  325|->   locker = g_mutex_locker_new (&rdp_surface->surface_mutex);
#  326|     if (!rdp_surface->pending_framebuffer)
#  327|       return;

Error: CLANG_WARNING: [#def13]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-session-rdp.c:532:34: warning[core.NullDereference]: Access to field 'cache_index' results in a dereference of a null pointer (loaded from variable 'lru_pointer')
#  530|   
#  531|         g_hash_table_steal (session_rdp->pointer_cache, lru_pointer);
#  532|->       new_pointer->cache_index = lru_pointer->cache_index;
#  533|   
#  534|         g_free (lru_pointer->bitmap);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def14]
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-session-rdp.c: scope_hint: In function ‘grd_session_rdp_update_pointer’
gnome-remote-desktop-45.1-build/gnome-remote-desktop-45.1/src/grd-session-rdp.c:532:45: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘lru_pointer’
#  530|   
#  531|         g_hash_table_steal (session_rdp->pointer_cache, lru_pointer);
#  532|->       new_pointer->cache_index = lru_pointer->cache_index;
#  533|   
#  534|         g_free (lru_pointer->bitmap);

Scan Properties