kf5-kpackage-5.116.0-1.fc41

List of Defects

Error: COMPILER_WARNING (CWE-252): [#def1]
kf5-kpackage-5.116.0-build/kpackage-5.116.0/autotests/querytest.cpp: scope_hint: In member function ‘void QueryTest::installAndQuery()’
kf5-kpackage-5.116.0-build/kpackage-5.116.0/autotests/querytest.cpp:60:11: warning[-Wunused-result]: ignoring return value of ‘int system(const char*)’ declared with attribute ‘warn_unused_result’
#   60 |     system("find '/Users/alex/.qttest/Library/Application Support'");
#      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   58|       QVERIFY(checkedInstall(ps, QFINDTESTDATA("data/testfallbackpackage"), KJob::NoError));
#   59|       QVERIFY(checkedInstall(ps, QFINDTESTDATA("data/testjsonmetadatapackage"), KJob::NoError));
#   60|->     system("find '/Users/alex/.qttest/Library/Application Support'");
#   61|       QCOMPARE(KPackage::PackageLoader::self()->listPackages(QStringLiteral("KPackage/Generic")).count(), 3);
#   62|   

Error: COMPILER_WARNING (CWE-477): [#def2]
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.cpp: scope_hint: In member function ‘void KPackage::PackagePrivate::createPackageMetadata(const QString&)’
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.cpp:989:52: warning[-Wdeprecated-declarations]: ‘static KPluginMetaData KPluginMetaData::fromDesktopFile(const QString&, const QStringList&)’ is deprecated: Since 5.92. Use json files or embedded json metadata directly
#  989 |         metadata = KPluginMetaData::fromDesktopFile(path + QStringLiteral("/metadata.desktop"), {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#      |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF5/KCoreAddons/KPluginMetaData:1: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.h:15: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.cpp:10: included_from: Included from here.
/usr/include/KF5/KCoreAddons/kpluginmetadata.h:247:28: note: declared here
#  247 |     static KPluginMetaData fromDesktopFile(const QString &file, const QStringList &serviceTypes = QStringList());
#      |                            ^~~~~~~~~~~~~~~
#  987|   #if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 92)
#  988|       } else if (isDir && QFile::exists(path + QStringLiteral("/metadata.desktop"))) {
#  989|->         metadata = KPluginMetaData::fromDesktopFile(path + QStringLiteral("/metadata.desktop"), {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#  990|   #endif
#  991|       } else {

Error: COMPILER_WARNING (CWE-477): [#def3]
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.cpp:996:56: warning[-Wdeprecated-declarations]: ‘static KPluginMetaData KPluginMetaData::fromDesktopFile(const QString&, const QStringList&)’ is deprecated: Since 5.92. Use json files or embedded json metadata directly
#  996 |             metadata = KPluginMetaData::fromDesktopFile(path, {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF5/KCoreAddons/kpluginmetadata.h:247:28: note: declared here
#  247 |     static KPluginMetaData fromDesktopFile(const QString &file, const QStringList &serviceTypes = QStringList());
#      |                            ^~~~~~~~~~~~~~~
#  994|   #if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 92)
#  995|           } else if (path.endsWith(QLatin1String(".desktop"))) {
#  996|->             metadata = KPluginMetaData::fromDesktopFile(path, {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#  997|   #endif
#  998|           } else {

Error: COMPILER_WARNING (CWE-477): [#def4]
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/packageloader.cpp: scope_hint: In member function ‘QList<KPluginMetaData> KPackage::PackageLoader::listPackages(const QString&, const QString&)’
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/packageloader.cpp:188:56: warning[-Wdeprecated-declarations]: ‘static KPluginMetaData KPluginMetaData::fromDesktopFile(const QString&, const QStringList&)’ is deprecated: Since 5.92. Use json files or embedded json metadata directly
#  188 |                 info = KPluginMetaData::fromDesktopFile(metadataPath);
#      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
/usr/include/KF5/KCoreAddons/KPluginMetaData:1: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.h:15: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/redhat-linux-build/src/kpackage/kpackage/package.h:1: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/packageloader.h:10: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/packageloader.cpp:7: included_from: Included from here.
/usr/include/KF5/KCoreAddons/kpluginmetadata.h:247:28: note: declared here
#  247 |     static KPluginMetaData fromDesktopFile(const QString &file, const QStringList &serviceTypes = QStringList());
#      |                            ^~~~~~~~~~~~~~~
#  186|   #if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 92)
#  187|               if (metadataPath.endsWith(QLatin1String(".desktop"))) {
#  188|->                 info = KPluginMetaData::fromDesktopFile(metadataPath);
#  189|               } else {
#  190|                   info = KPluginMetaData::fromJsonFile(metadataPath);

Error: COMPILER_WARNING (CWE-477): [#def5]
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/private/packagejobthread.cpp: scope_hint: In member function ‘bool KPackage::PackageJobThread::installPackage(const QString&, const QString&, OperationType)’
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/private/packagejobthread.cpp:222:52: warning[-Wdeprecated-declarations]: ‘static KPluginMetaData KPluginMetaData::fromDesktopFile(const QString&, const QStringList&)’ is deprecated: Since 5.92. Use json files or embedded json metadata directly
#  222 |             meta = KPluginMetaData::fromDesktopFile(metadataFilePath, {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#      |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF5/KCoreAddons/KPluginMetaData:1: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.h:15: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/private/packagejobthread_p.h:11: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/private/packagejobthread.cpp:8: included_from: Included from here.
/usr/include/KF5/KCoreAddons/kpluginmetadata.h:247:28: note: declared here
#  247 |     static KPluginMetaData fromDesktopFile(const QString &file, const QStringList &serviceTypes = QStringList());
#      |                            ^~~~~~~~~~~~~~~
#  220|   #if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 92)
#  221|           if (metadataFilePath.endsWith(QLatin1String(".desktop"))) {
#  222|->             meta = KPluginMetaData::fromDesktopFile(metadataFilePath, {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#  223|           } else {
#  224|               meta = KPluginMetaData::fromJsonFile(metadataFilePath);

Error: COMPILER_WARNING (CWE-477): [#def6]
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/private/packagejobthread.cpp:275:59: warning[-Wdeprecated-declarations]: ‘static KPluginMetaData KPluginMetaData::fromDesktopFile(const QString&, const QStringList&)’ is deprecated: Since 5.92. Use json files or embedded json metadata directly
#  275 |                 oldMeta = KPluginMetaData::fromDesktopFile(targetName + QLatin1String("/metadata.desktop"));
#      |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF5/KCoreAddons/kpluginmetadata.h:247:28: note: declared here
#  247 |     static KPluginMetaData fromDesktopFile(const QString &file, const QStringList &serviceTypes = QStringList());
#      |                            ^~~~~~~~~~~~~~~
#  273|   #if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 92)
#  274|               } else if (QFileInfo::exists(targetName + QLatin1String("/metadata.desktop"))) {
#  275|->                 oldMeta = KPluginMetaData::fromDesktopFile(targetName + QLatin1String("/metadata.desktop"));
#  276|   #endif
#  277|               }

Error: COMPILER_WARNING (CWE-477): [#def7]
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackagetool/kpackagetool.cpp: scope_hint: In member function ‘void KPackage::PackageTool::showAppstreamInfo(const QString&)’
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackagetool/kpackagetool.cpp:408:45: warning[-Wdeprecated-declarations]: ‘static KPluginMetaData KPluginMetaData::fromDesktopFile(const QString&, const QStringList&)’ is deprecated: Since 5.92. Use json files or embedded json metadata directly
#  408 |         i = KPluginMetaData::fromDesktopFile(pluginName + QStringLiteral("/metadata.desktop"), {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF5/KCoreAddons/KPluginMetaData:1: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackage/package.h:15: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/redhat-linux-build/src/kpackage/kpackage/package.h:1: included_from: Included from here.
kf5-kpackage-5.116.0-build/kpackage-5.116.0/src/kpackagetool/kpackagetool.cpp:16: included_from: Included from here.
/usr/include/KF5/KCoreAddons/kpluginmetadata.h:247:28: note: declared here
#  247 |     static KPluginMetaData fromDesktopFile(const QString &file, const QStringList &serviceTypes = QStringList());
#      |                            ^~~~~~~~~~~~~~~
#  406|   #if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 92)
#  407|       } else if (QFile::exists(pluginName + QStringLiteral("/metadata.desktop"))) {
#  408|->         i = KPluginMetaData::fromDesktopFile(pluginName + QStringLiteral("/metadata.desktop"), {QStringLiteral(":/kservicetypes5/kpackage-generic.desktop")});
#  409|   #endif
#  410|       } else {

Scan Properties