Fixed defects

List of Defects

Error: CLANG_WARNING: [#def1]
libzypp-17.31.32-build/libzypp-17.31.32/tests/zypp/PtrTypes_test.cc:100:5: warning[cplusplus.NewDeleteLeaks]: Potential leak of memory pointed to by 'ptr2._dptr.px'
#   98|      }
#   99|       // assign
#  100|->     ptr.reset( 0 );
#  101|       T_NULL;
#  102|       T_UNIQUE;

Error: CLANG_WARNING: [#def2]
libzypp-17.31.32-build/libzypp-17.31.32/tests/zypp/PtrTypes_test.cc:131:3: warning[cplusplus.NewDeleteLeaks]: Potential leak of memory pointed to by 'ptr2._dptr.px'
#  129|       unsigned long ptrid2 = ptr2->numericId();
#  130|       assert( ptrid != ptrid2 );
#  131|->   }
#  132|   
#  133|   /******************************************************************

Error: CLANG_WARNING: [#def3]
libzypp-17.31.32-build/libzypp-17.31.32/tests/zypp/PtrTypes_test.cc:6: included_from: Included from here.
libzypp-17.31.32-build/libzypp-17.31.32/zypp/base/PtrTypes.h:1: included_from: Included from here.
libzypp-17.31.32-build/libzypp-17.31.32/zypp-core/base/PtrTypes.h:313:42: warning[cplusplus.NewDeleteLeaks]: Potential leak of memory pointed to by field 'px'
#  311|   
#  312|           void reset( typename PtrType::element_type * dptr )
#  313|->         { PtrType( dptr ).swap( _dptr ); }
#  314|   
#  315|           void swap( RW_pointer & rhs )

Error: CLANG_WARNING: [#def4]
libzypp-17.31.32-build/libzypp-17.31.32/zypp-core/zyppng/base/eventdispatcher_glib.cc:239:20: warning[core.NullDereference]: Access to field '_idleSource' results in a dereference of a null pointer (loaded from variable 'dPtr')
#  237|     }
#  238|   
#  239|->   g_source_unref ( dPtr->_idleSource );
#  240|     dPtr->_idleSource = nullptr;
#  241|   

Error: CPPCHECK_WARNING: [#def5]
libzypp-17.31.32-build/libzypp-17.31.32/zypp-core/zyppng/rpc/rpc.cc: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: COMPILER_WARNING: [#def6]
libzypp-17.31.32-build/libzypp-17.31.32/zypp/media/MediaMultiCurl.cc: scope_hint: In member function ‘zypp::media::multifetchworker::continueJob()’
libzypp-17.31.32-build/libzypp-17.31.32/zypp/media/MediaMultiCurl.cc:904:12: warning[-Wstringop-truncation]: ‘strncpy’ specified bound 256 equals destination size
#  904 |     strncpy( _curlError, _multiByteHandler->lastErrorMessage().c_str(), CURL_ERROR_SIZE );
#      |            ^
#  902|     bool hadRangeFail = _multiByteHandler->lastError() == MultiByteHandler::Code::RangeFail;
#  903|     if ( !_multiByteHandler->prepareToContinue() ) {
#  904|->     strncpy( _curlError, _multiByteHandler->lastErrorMessage().c_str(), CURL_ERROR_SIZE );
#  905|       return false;
#  906|     }

Error: COMPILER_WARNING: [#def7]
libzypp-17.31.32-build/libzypp-17.31.32/zypp/media/MediaMultiCurl.cc: scope_hint: In member function ‘zypp::media::multifetchworker::run()’
libzypp-17.31.32-build/libzypp-17.31.32/zypp/media/MediaMultiCurl.cc:933:12: warning[-Wstringop-truncation]: ‘strncpy’ specified bound 256 equals destination size
#  933 |     strncpy( _curlError, _multiByteHandler->lastErrorMessage ().c_str() , CURL_ERROR_SIZE );
#      |            ^
#  931|       _request->_activeworkers--;
#  932|       _state = WORKER_BROKEN;
#  933|->     strncpy( _curlError, _multiByteHandler->lastErrorMessage ().c_str() , CURL_ERROR_SIZE );
#  934|       return;
#  935|     }

Error: COMPILER_WARNING: [#def8]
libzypp-17.31.32-build/libzypp-17.31.32/zypp/media/MediaMultiCurl.cc: scope_hint: In member function ‘zypp::media::multifetchrequest::run(std::vector<zypp::Url, std::allocator<zypp::Url> >&)’
libzypp-17.31.32-build/libzypp-17.31.32/zypp/media/MediaMultiCurl.cc:1177:22: warning[-Wstringop-truncation]: ‘strncpy’ specified bound 256 equals destination size
# 1177 |               strncpy(worker->_curlError, str.c_str(), CURL_ERROR_SIZE);
#      |                      ^
# 1175|               worker->_state = WORKER_BROKEN;
# 1176|               if ( !str.empty () )
# 1177|->               strncpy(worker->_curlError, str.c_str(), CURL_ERROR_SIZE);
# 1178|               _activeworkers--;
# 1179|   

Error: COMPILER_WARNING (CWE-697): [#def9]
libzypp-17.31.32-build/libzypp-17.31.32/zypp/target/TargetImpl.cc: scope_hint: In member function ‘zypp::ZYppCommitResult zypp::target::TargetImpl::commit(zypp::ResPool, const zypp::ZYppCommitPolicy&)’
libzypp-17.31.32-build/libzypp-17.31.32/zypp/target/TargetImpl.cc:1367:41: warning[-Waddress]: the address of ‘bool zypp::env::TRANSACTIONAL_UPDATE()’ will never be NULL
# 1367 |       if ( (root() == "/" || zypp::env::TRANSACTIONAL_UPDATE) && ! policy_r.dryRun() )
#      |                                         ^~~~~~~~~~~~~~~~~~~~
libzypp-17.31.32-build/libzypp-17.31.32/zypp/target/TargetImpl.cc:85:15: note: ‘bool zypp::env::TRANSACTIONAL_UPDATE()’ declared here
#   85 |   inline bool TRANSACTIONAL_UPDATE()
#      |               ^~~~~~~~~~~~~~~~~~~~
# 1365|         PluginExecutor commitPlugins;
# 1366|   
# 1367|->       if ( (root() == "/" || zypp::env::TRANSACTIONAL_UPDATE) && ! policy_r.dryRun() )
# 1368|         {
# 1369|           commitPlugins.load( ZConfig::instance().pluginsPath()/"commit" );

Scan Properties