Fixed defects

List of Defects

Error: GCC_ANALYZER_WARNING (CWE-401): [#def1]
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c: scope_hint: In function ‘print_hex’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:118:1: warning[-Wanalyzer-malloc-leak]: leak of ‘<unknown>’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:805:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:806:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:807:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:330:49: note: in definition of macro ‘MEMEQ’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c: scope_hint: In function ‘print_hex’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c: scope_hint: In function ‘print_hex’
#  116|       }
#  117|     printf("\n");
#  118|-> }
#  119|   
#  120|   int verbose = 0;

Error: GCC_ANALYZER_WARNING (CWE-688): [#def2]
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:818:7: warning[-Wanalyzer-possible-null-argument]: use of possibly-NULL ‘xalloc(*cleartext.length + (long unsigned int)*aead.block_size + 18446744073709551615)’ where non-null expected
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:805:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:806:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:807:3: note: in expansion of macro ‘ASSERT’
<built-in>: note: argument 1 of ‘__builtin_memcpy’ must be non-null
#  816|         unsigned out_align = 3*in_align % aead->block_size;
#  817|         size_t offset;
#  818|->       memcpy (in + in_align, cleartext->data, cleartext->length);
#  819|         for (offset = 0; offset <= cleartext->length; offset += aead->block_size)
#  820|   	{

Error: GCC_ANALYZER_WARNING (CWE-401): [#def3]
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:841:14: warning[-Wanalyzer-malloc-leak]: leak of ‘xalloc(*cleartext.length + (long unsigned int)*aead.block_size + 18446744073709551615) + (sizetype)in_align’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:805:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:806:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:807:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:330:49: note: in definition of macro ‘MEMEQ’
#  839|   			  out + out_align + offset, in + in_align + offset);
#  840|   
#  841|-> 	  if (!MEMEQ(cleartext->length, out + out_align, ciphertext->data))
#  842|   	    {
#  843|   	      fprintf(stderr, "aead->encrypt failed (offset = %u):\nclear: ",

Error: GCC_ANALYZER_WARNING (CWE-401): [#def4]
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:857:18: warning[-Wanalyzer-malloc-leak]: leak of ‘xalloc(*cleartext.length + (long unsigned int)*aead.block_size + 18446744073709551615) + (sizetype)in_align’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:805:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:806:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:807:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:330:49: note: in definition of macro ‘MEMEQ’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:854:15: note: in expansion of macro ‘ASSERT’
#  855|   	      memset(buffer, 0, aead->digest_size);
#  856|   	      aead->digest(ctx, digest->length, buffer);
#  857|-> 	      if (!MEMEQ(digest->length, buffer, digest->data))
#  858|   		{
#  859|   		  fprintf(stderr, "aead->digest failed (offset = %u):\n  got: ",

Error: GCC_ANALYZER_WARNING (CWE-401): [#def5]
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:8: warning[-Wanalyzer-malloc-leak]: leak of ‘xalloc(*cleartext.length + (long unsigned int)*aead.block_size + 18446744073709551615) + (sizetype)in_align’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:854:15: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:805:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:806:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:807:3: note: in expansion of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:330:49: note: in definition of macro ‘MEMEQ’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.h:336:11: note: in definition of macro ‘ASSERT’
nettle-3.9.1-build/nettle-3.9.1/testsuite/testutils.c:854:15: note: in expansion of macro ‘ASSERT’
#  334|   
#  335|   #define ASSERT(x) do {							\
#  336|->     if (!(x))								\
#  337|         {									\
#  338|   	fprintf(stderr, "Assert failed: %s:%d: %s\n", \

Error: CLANG_WARNING: [#def6]
nettle-3.9.1-build/nettle-3.9.1/umac-l2.c:149:19: warning[deadcode.DeadStores]: Although the value stored to 'yl' is used in the enclosing expression, the value is never actually read from 'yl'
#  147|   	    {
#  148|   	      state[0] = 0;
#  149|-> 	      state[1] = yl -= UMAC_P128_LO;
#  150|   	    }
#  151|   	}

Scan Properties