Newly introduced defects

List of Defects

Error: COMPILER_WARNING (CWE-697): [#def1]
rsync-3.3.0-build/rsync-3.3.0/flist.c: scope_hint: In function ‘fattr_compare’
rsync-3.3.0-build/rsync-3.3.0/flist.c:293:13: warning[-Waddress]: the comparison will always evaluate as ‘true’ for the address of ‘basename’ will never be NULL
#  293 |         if (!f1->basename || !S_ISREG(f1->mode) || !len1) {
#      |             ^
rsync-3.3.0-build/rsync-3.3.0/flist.c:23: included_from: Included from here.
rsync-3.3.0-build/rsync-3.3.0/rsync.h:808:20: note: ‘basename’ declared here
#  808 |         const char basename[];  /* The basename (AKA filename) follows */
#      |                    ^~~~~~~~
#  291|   	int diff;
#  292|   
#  293|-> 	if (!f1->basename || !S_ISREG(f1->mode) || !len1) {
#  294|   		if (!f2->basename || !S_ISREG(f2->mode) || !len2)
#  295|   			return 0;

Error: COMPILER_WARNING (CWE-697): [#def2]
rsync-3.3.0-build/rsync-3.3.0/flist.c:294:21: warning[-Waddress]: the comparison will always evaluate as ‘true’ for the address of ‘basename’ will never be NULL
#  294 |                 if (!f2->basename || !S_ISREG(f2->mode) || !len2)
#      |                     ^
rsync-3.3.0-build/rsync-3.3.0/rsync.h:808:20: note: ‘basename’ declared here
#  808 |         const char basename[];  /* The basename (AKA filename) follows */
#      |                    ^~~~~~~~
#  292|   
#  293|   	if (!f1->basename || !S_ISREG(f1->mode) || !len1) {
#  294|-> 		if (!f2->basename || !S_ISREG(f2->mode) || !len2)
#  295|   			return 0;
#  296|   		return 1;

Error: COMPILER_WARNING (CWE-697): [#def3]
rsync-3.3.0-build/rsync-3.3.0/flist.c:298:13: warning[-Waddress]: the comparison will always evaluate as ‘true’ for the address of ‘basename’ will never be NULL
#  298 |         if (!f2->basename || !S_ISREG(f2->mode) || !len2)
#      |             ^
rsync-3.3.0-build/rsync-3.3.0/rsync.h:808:20: note: ‘basename’ declared here
#  808 |         const char basename[];  /* The basename (AKA filename) follows */
#      |                    ^~~~~~~~
#  296|   		return 1;
#  297|   	}
#  298|-> 	if (!f2->basename || !S_ISREG(f2->mode) || !len2)
#  299|   		return -1;
#  300|   

Error: COMPILER_WARNING (CWE-697): [#def4]
rsync-3.3.0-build/rsync-3.3.0/flist.c: scope_hint: In function ‘recv_file_list’
rsync-3.3.0-build/rsync-3.3.0/flist.c:2778:29: warning[-Waddress]: the comparison will always evaluate as ‘true’ for the address of ‘basename’ will never be NULL
# 2778 |                         if (fp->basename && S_ISREG(fp->mode) && F_LENGTH(fp))
#      |                             ^~
rsync-3.3.0-build/rsync-3.3.0/rsync.h:808:20: note: ‘basename’ declared here
#  808 |         const char basename[];  /* The basename (AKA filename) follows */
#      |                    ^~~~~~~~
# 2776|   		while (j-- > 0) {
# 2777|   			struct file_struct *fp = the_fattr_list.files[j];
# 2778|-> 			if (fp->basename && S_ISREG(fp->mode) && F_LENGTH(fp))
# 2779|   				break;
# 2780|   		}

Error: CLANG_WARNING: [#def5]
rsync-3.3.0-build/rsync-3.3.0/options.c:1480:4: warning[deadcode.DeadStores]: Value stored to 'argv' is never read
# 1478|   			} else if (poptDupArgv(argc, argv, argc_p, argv_p) != 0)
# 1479|   				out_of_memory("parse_arguments");
# 1480|-> 			argv = *argv_p;
# 1481|   			poptFreeContext(pc);
# 1482|   

Scan Properties