Fixed defects

List of Defects

Error: COMPILER_WARNING (CWE-195): [#def1]
snappy-1.1.10-build/snappy-1.1.10/snappy.cc:1293:37: warning[-Wsign-compare]: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘ptrdiff_t’ {aka ‘long int’}
# 1293 |              (op + deferred_length) < op_limit_min_slop);
#      |              ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
snappy-1.1.10-build/snappy-1.1.10/snappy.cc: scope_hint: In instantiation of ‘std::pair<const unsigned char*, long int> snappy::DecompressBranchless(const uint8_t*, const uint8_t*, ptrdiff_t, T, ptrdiff_t) [with T = long unsigned int; uint8_t = unsigned char; ptrdiff_t = long int]’
#/builddir/build/BUILD/snappy-1.1.10-build/snappy-1.1.10/snappy.cc:1405:35:   required from ‘void snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer = snappy::SnappyDecompressionValidator]’
# 1405 |               DecompressBranchless(reinterpret_cast<const uint8_t*>(ip),
#      |               ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1406 |                                    reinterpret_cast<const uint8_t*>(ip_limit_),
#      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1407 |                                    op - op_base, op_base, op_limit_min_slop);
#      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1600 |   decompressor->DecompressAllTags(writer);
#      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
#/builddir/build/BUILD/snappy-1.1.10-build/snappy-1.1.10/snappy.cc:1587:35:   required from ‘bool snappy::InternalUncompress(Source*, Writer*) [with Writer = SnappyDecompressionValidator]’
# 1587 |   return InternalUncompressAllTags(&decompressor, writer, r->Available(),
#      |          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1588 |                                    uncompressed_len);
#      |                                    ~~~~~~~~~~~~~~~~~
# 2101 |   return InternalUncompress(&reader, &writer);
#      |          ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
# 1291|         }
# 1292|       } while (ip < ip_limit_min_slop &&
# 1293|->              (op + deferred_length) < op_limit_min_slop);
# 1294|     exit:
# 1295|       ip--;

Error: COMPILER_WARNING (CWE-195): [#def2]
snappy-1.1.10-build/snappy-1.1.10/snappy.cc: scope_hint: In function ‘constexpr bool snappy::VerifyCalculateNeeded()’
snappy-1.1.10-build/snappy-1.1.10/snappy.cc:1508:28: warning[-Wsign-compare]: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int’
# 1508 |     if (CalculateNeeded(i) != (char_table[i] >> 11) + 1) return false;
#      |         ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
snappy-1.1.10-build/snappy-1.1.10/snappy.cc: scope_hint: In instantiation of ‘std::pair<const unsigned char*, long int> snappy::DecompressBranchless(const uint8_t*, const uint8_t*, ptrdiff_t, T, ptrdiff_t) [with T = char*; uint8_t = unsigned char; ptrdiff_t = long int]’
#/builddir/build/BUILD/snappy-1.1.10-build/snappy-1.1.10/snappy.cc:1405:35:   required from ‘void snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer = snappy::SnappyArrayWriter]’
# 1405 |               DecompressBranchless(reinterpret_cast<const uint8_t*>(ip),
#      |               ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1406 |                                    reinterpret_cast<const uint8_t*>(ip_limit_),
#      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1407 |                                    op - op_base, op_base, op_limit_min_slop);
#      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1600 |   decompressor->DecompressAllTags(writer);
#      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
#/builddir/build/BUILD/snappy-1.1.10-build/snappy-1.1.10/snappy.cc:2415:44:   required from here
# 2415 |     bool result = InternalUncompressAllTags(&decompressor, &writer,
#      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
# 2416 |                                             compressed_len, uncompressed_len);
#      |                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1506|   constexpr bool VerifyCalculateNeeded() {
# 1507|     for (int i = 0; i < 1; i++) {
# 1508|->     if (CalculateNeeded(i) != (char_table[i] >> 11) + 1) return false;
# 1509|     }
# 1510|     return true;

Scan Properties