Fixed defects

List of Defects

Error: GCC_ANALYZER_WARNING (CWE-121): [#def1]
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c: scope_hint: In function ‘ConvertUTCToLocalUsingC’
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1108:5: warning[-Wanalyzer-out-of-bounds]: stack-based buffer overflow
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1108:5: note: write of 1 byte to beyond the end of ‘buffer’
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1108:5: note: valid subscripts for ‘buffer’ are ‘[0]’ to ‘[15]’
# 1106|   	*buffer = '+';
# 1107|       }
# 1108|->     sprintf(buffer+1, "%02d", diff / 3600);
# 1109|       diff %= 3600;
# 1110|       sprintf(buffer+3, "%02d", diff / 60);

Error: GCC_ANALYZER_WARNING (CWE-121): [#def2]
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1110:5: warning[-Wanalyzer-out-of-bounds]: stack-based buffer overflow
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1110:5: note: write of 3 bytes to beyond the end of ‘buffer’
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1110:5: note: valid subscripts for ‘buffer’ are ‘[0]’ to ‘[15]’
# 1108|       sprintf(buffer+1, "%02d", diff / 3600);
# 1109|       diff %= 3600;
# 1110|->     sprintf(buffer+3, "%02d", diff / 60);
# 1111|       diff %= 60;
# 1112|       if (diff > 0) {

Error: GCC_ANALYZER_WARNING (CWE-121): [#def3]
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1113:9: warning[-Wanalyzer-out-of-bounds]: stack-based buffer overflow
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1113:9: note: write of 5 bytes to beyond the end of ‘buffer’
tcl-8.6.13-build/tcl8.6.13/generic/tclClock.c:1113:9: note: valid subscripts for ‘buffer’ are ‘[0]’ to ‘[15]’
# 1111|       diff %= 60;
# 1112|       if (diff > 0) {
# 1113|-> 	sprintf(buffer+5, "%02d", diff);
# 1114|       }
# 1115|       fields->tzName = Tcl_NewStringObj(buffer, -1);

Error: COMPILER_WARNING: [#def4]
tcl-8.6.13-build/tcl8.6.13/generic/tclObj.c: scope_hint: In function ‘ParseBoolean’
tcl-8.6.13-build/tcl8.6.13/generic/tclObj.c:2056:23: warning[-Wstringop-overflow=]: writing 1 byte into a region of size 0
# 2056 |     lowerCase[length] = 0;
#      |     ~~~~~~~~~~~~~~~~~~^~~
tcl-8.6.13-build/tcl8.6.13/generic/tclObj.c:2009:10: note: at offset [-2147483648, -1] into destination object ‘lowerCase’ of size 6
# 2009 |     char lowerCase[6];
#      |          ^~~~~~~~~
# 2054|   	}
# 2055|       }
# 2056|->     lowerCase[length] = 0;
# 2057|       switch (lowerCase[0]) {
# 2058|       case 'y':

Scan Properties