Fixed defects

List of Defects

Error: COMPILER_WARNING (CWE-477): [#def1]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc: scope_hint: In function ‘void vteapp_window_parse_geometry(VteappWindow*)’
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:1684:52: warning[-Wdeprecated-declarations]: ‘gboolean gtk_window_parse_geometry(GtkWindow*, const gchar*)’ is deprecated
# 1684 |                 auto rv = gtk_window_parse_geometry(GTK_WINDOW(window), options.geometry);
#      |                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/gtkdialog.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtkaboutdialog.h:30: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:31: included_from: Included from here.
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:33: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtkwindow.h:443:10: note: declared here
#  443 | gboolean gtk_window_parse_geometry   (GtkWindow   *window,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
# 1682|   
# 1683|           if (options.geometry != nullptr) {
# 1684|->                 auto rv = gtk_window_parse_geometry(GTK_WINDOW(window), options.geometry);
# 1685|   
# 1686|                   if (!rv)

Error: COMPILER_WARNING (CWE-477): [#def2]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:1695:54: warning[-Wdeprecated-declarations]: ‘void gtk_window_resize_to_geometry(GtkWindow*, gint, gint)’ is deprecated: Use 'gtk_window_resize' instead
# 1695 |                         gtk_window_resize_to_geometry(GTK_WINDOW(window), columns, rows);
#      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/gtkwindow.h:451:6: note: declared here
#  451 | void gtk_window_resize_to_geometry   (GtkWindow *window,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1693|                           gtk_window_get_default_size(GTK_WINDOW(window), &columns, &rows);
# 1694|                           vte_terminal_set_size(window->terminal, columns, rows);
# 1695|->                         gtk_window_resize_to_geometry(GTK_WINDOW(window), columns, rows);
# 1696|                   } else {
# 1697|                           /* Approximate the grid width from the passed pixel size. */

Error: COMPILER_WARNING (CWE-477): [#def3]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:1714:56: warning[-Wdeprecated-declarations]: ‘void gtk_window_set_default_geometry(GtkWindow*, gint, gint)’ is deprecated: Use 'gtk_window_set_default_size' instead
# 1714 |                         gtk_window_set_default_geometry(GTK_WINDOW(window),
#      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
# 1715 |                                                         vte_terminal_get_column_count(window->terminal),
#      |                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1716 |                                                         vte_terminal_get_row_count(window->terminal));
#      |                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/gtkwindow.h:447:6: note: declared here
#  447 | void gtk_window_set_default_geometry (GtkWindow *window,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1712|                   if (!options.no_geometry_hints) {
# 1713|                           /* Grid based */
# 1714|->                         gtk_window_set_default_geometry(GTK_WINDOW(window),
# 1715|                                                           vte_terminal_get_column_count(window->terminal),
# 1716|                                                           vte_terminal_get_row_count(window->terminal));

Error: COMPILER_WARNING (CWE-477): [#def4]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc: scope_hint: In function ‘bool vteapp_window_show_context_menu(VteappWindow*, guint, guint32, GdkEvent*)’
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:2126:23: warning[-Wdeprecated-declarations]: ‘void gtk_menu_popup(GtkMenu*, GtkWidget*, GtkWidget*, GtkMenuPositionFunc, gpointer, guint, guint32)’ is deprecated: Use '(gtk_menu_popup_at_widget, gtk_menu_popup_at_pointer, gtk_menu_popup_at_rect)' instead
# 2126 |         gtk_menu_popup(GTK_MENU(popup), nullptr, nullptr, nullptr, nullptr, button, timestamp);
#      |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/gtklabel.h:34: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtkaccellabel.h:35: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:33: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtkmenu.h:138:12: note: declared here
#  138 | void       gtk_menu_popup                 (GtkMenu             *menu,
#      |            ^~~~~~~~~~~~~~
# 2124|   
# 2125|           gtk_menu_attach_to_widget(GTK_MENU(popup), GTK_WIDGET(window->terminal), nullptr);
# 2126|->         gtk_menu_popup(GTK_MENU(popup), nullptr, nullptr, nullptr, nullptr, button, timestamp);
# 2127|           if (button == 0)
# 2128|                   gtk_menu_shell_select_first(GTK_MENU_SHELL(popup), true);

Error: COMPILER_WARNING (CWE-1164): [#def5]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:2297:1: warning[-Wunused-function]: ‘void notification_received_cb(VteTerminal*, const gchar*, const gchar*)’ defined but not used
# 2297 | notification_received_cb(VteTerminal *terminal,
#      | ^~~~~~~~~~~~~~~~~~~~~~~~
# 2295|   
# 2296|   static void
# 2297|-> notification_received_cb(VteTerminal *terminal,
# 2298|                            const gchar *summary,
# 2299|                            const gchar *body)

Error: COMPILER_WARNING (CWE-1164): [#def6]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:2305:1: warning[-Wunused-function]: ‘void shell_precmd_cb(VteTerminal*)’ defined but not used
# 2305 | shell_precmd_cb(VteTerminal *terminal)
#      | ^~~~~~~~~~~~~~~
# 2303|   
# 2304|   static void
# 2305|-> shell_precmd_cb(VteTerminal *terminal)
# 2306|   {
# 2307|           g_print("[shell] showing command prompt\n");

Error: COMPILER_WARNING (CWE-1164): [#def7]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:2311:1: warning[-Wunused-function]: ‘void shell_preexec_cb(VteTerminal*)’ defined but not used
# 2311 | shell_preexec_cb(VteTerminal *terminal)
#      | ^~~~~~~~~~~~~~~~
# 2309|   
# 2310|   static void
# 2311|-> shell_preexec_cb(VteTerminal *terminal)
# 2312|   {
# 2313|           g_print("[shell] executing command\n");

Error: COMPILER_WARNING (CWE-477): [#def8]
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc: scope_hint: In function ‘int main(int, char**)’
vte291-0.74.2-build/vte-0.74.2/src/app/app.cc:3144:44: warning[-Wdeprecated-declarations]: ‘void gdk_window_set_debug_updates(gboolean)’ is deprecated
# 3144 |                gdk_window_set_debug_updates(true);
#      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/usr/include/gtk-3.0/gdk/gdkseat.h:28: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkdisplay.h:33: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkscreen.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkwindow.h:1074:12: note: declared here
# 1074 | void       gdk_window_set_debug_updates   (gboolean      setting);
#      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 3142|   #if VTE_GTK == 3
# 3143|          if (options.debug)
# 3144|->                gdk_window_set_debug_updates(true);
# 3145|   #endif /* VTE_GTK == 3 */
# 3146|   

Error: CPPCHECK_WARNING: [#def9]
vte291-0.74.2-build/vte-0.74.2/src/drawing-cairo.cc: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def10]
vte291-0.74.2-build/vte-0.74.2/src/parser-cat.cc: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: CPPCHECK_WARNING: [#def11]
vte291-0.74.2-build/vte-0.74.2/src/parser-test.cc: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches.

Error: COMPILER_WARNING (CWE-477): [#def12]
vte291-0.74.2-build/vte-0.74.2/src/vtegtk.cc: scope_hint: In function ‘void vte_terminal_class_init(VteTerminalClass*)’
vte291-0.74.2-build/vte-0.74.2/src/vtegtk.cc:1228:71: warning[-Wdeprecated-declarations]: ‘void gdk_window_set_debug_updates(gboolean)’ is deprecated
# 1228 |         _VTE_DEBUG_IF (VTE_DEBUG_UPDATES) gdk_window_set_debug_updates(TRUE);
#      |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/usr/include/gtk-3.0/gdk/gdkseat.h:28: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkdisplay.h:33: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkscreen.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
vte291-0.74.2-build/vte-0.74.2/src/vtegtk.cc:46: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkwindow.h:1074:12: note: declared here
# 1074 | void       gdk_window_set_debug_updates   (gboolean      setting);
#      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1226|   
# 1227|   #if VTE_GTK == 3
# 1228|-> 	_VTE_DEBUG_IF (VTE_DEBUG_UPDATES) gdk_window_set_debug_updates(TRUE);
# 1229|   #endif
# 1230|   

Error: COMPILER_WARNING (CWE-477): [#def13]
vte291-0.74.2-build/vte-0.74.2/src/vteseq.cc: scope_hint: In member function ‘void vte::terminal::Terminal::XTERM_WM(const vte::parser::Sequence&)’
vte291-0.74.2-build/vte-0.74.2/src/vteseq.cc:9111:51: warning[-Wdeprecated-declarations]: ‘gint gdk_screen_get_height(GdkScreen*)’ is deprecated
# 9111 |                 int height = gdk_screen_get_height(gdkscreen);
#      |                              ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
vte291-0.74.2-build/vte-0.74.2/src/vte/vte.h:21: included_from: Included from here.
vte291-0.74.2-build/vte-0.74.2/src/vteseq.cc:33: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkscreen.h:60:14: note: declared here
#   60 | gint         gdk_screen_get_height            (GdkScreen   *screen);
#      |              ^~~~~~~~~~~~~~~~~~~~~
# 9109|   #if VTE_GTK == 3
# 9110|                   auto gdkscreen = gtk_widget_get_screen(m_widget);
# 9111|->                 int height = gdk_screen_get_height(gdkscreen);
# 9112|                   int width = gdk_screen_get_width(gdkscreen);
# 9113|                   _vte_debug_print(VTE_DEBUG_EMULATION,

Error: COMPILER_WARNING (CWE-477): [#def14]
vte291-0.74.2-build/vte-0.74.2/src/vteseq.cc:9112:49: warning[-Wdeprecated-declarations]: ‘gint gdk_screen_get_width(GdkScreen*)’ is deprecated
# 9112 |                 int width = gdk_screen_get_width(gdkscreen);
#      |                             ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkscreen.h:58:14: note: declared here
#   58 | gint         gdk_screen_get_width             (GdkScreen   *screen);
#      |              ^~~~~~~~~~~~~~~~~~~~
# 9110|                   auto gdkscreen = gtk_widget_get_screen(m_widget);
# 9111|                   int height = gdk_screen_get_height(gdkscreen);
# 9112|->                 int width = gdk_screen_get_width(gdkscreen);
# 9113|                   _vte_debug_print(VTE_DEBUG_EMULATION,
# 9114|                                    "Reporting screen size as %dx%d cells.\n",

Scan Properties