Newly introduced defects

List of Defects

Error: CLANG_WARNING: [#def1]
vim91/src/ops.c:1354:7: warning[deadcode.DeadStores]: Value stored to 'ptr' is never read
# 1352|   		while (pos.lnum < oap->end.lnum)
# 1353|   		{
# 1354|-> 		    ptr = ml_get_buf(curbuf, pos.lnum, FALSE);
# 1355|   		    count = ml_get_buf_len(curbuf, pos.lnum) - pos.col;
# 1356|   		    netbeans_removed(curbuf, pos.lnum, pos.col, (long)count);

Error: GCC_ANALYZER_WARNING (CWE-457): [#def2]
vim91/src/os_unix.c: scope_hint: In function ‘mch_call_shell_fork’
vim91/src/os_unix.c:4938:21: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘fd_toshell[0]’
vim91/src/os_unix.c:4920:13: note: in expansion of macro ‘UNBLOCK_SIGNALS’
vim91/src/os_unix.c: scope_hint: In function ‘mch_call_shell_fork’
# 4936|   # endif
# 4937|   		{
# 4938|-> 		    close(fd_toshell[0]);
# 4939|   		    close(fd_toshell[1]);
# 4940|   		    close(fd_fromshell[0]);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def3]
vim91/src/os_unix.c:5050:37: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘vim_ignored’
# 5048|   		    {
# 5049|   			close(2);
# 5050|-> 			vim_ignored = dup(pty_slave_fd);
# 5051|   		    }
# 5052|   

Error: GCC_ANALYZER_WARNING (CWE-457): [#def4]
vim91/src/os_unix.c:5059:21: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘fd_toshell[1]’
# 5057|   		{
# 5058|   		    // set up stdin for the child
# 5059|-> 		    close(fd_toshell[1]);
# 5060|   		    close(0);
# 5061|   		    vim_ignored = dup(fd_toshell[0]);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def5]
vim91/src/os_unix.c:5067:33: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘vim_ignored’
vim91/src/os_unix.c:4916:9: note: in expansion of macro ‘BLOCK_SIGNALS’
# 5065|   		    close(fd_fromshell[0]);
# 5066|   		    close(1);
# 5067|-> 		    vim_ignored = dup(fd_fromshell[1]);
# 5068|   		    close(fd_fromshell[1]);
# 5069|   

Error: GCC_ANALYZER_WARNING (CWE-775): [#def6]
vim91/src/os_unix.c:5075:37: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘vim_ignored’
vim91/src/os_unix.c:4916:9: note: in expansion of macro ‘BLOCK_SIGNALS’
# 5073|   			// set up stderr for the child
# 5074|   			close(2);
# 5075|-> 			vim_ignored = dup(1);
# 5076|   		    }
# 5077|   # endif

Error: GCC_ANALYZER_WARNING (CWE-910): [#def7]
vim91/src/os_unix.c:5075:39: warning[-Wanalyzer-fd-use-after-close]: ‘dup’ on closed file descriptor ‘1’
vim91/src/os_unix.c:4916:9: note: in expansion of macro ‘BLOCK_SIGNALS’
# 5073|   			// set up stderr for the child
# 5074|   			close(2);
# 5075|-> 			vim_ignored = dup(1);
# 5076|   		    }
# 5077|   # endif

Scan Properties

analyzer-version-clang18.1.3
analyzer-version-cppcheck2.13.0
analyzer-version-gcc14.0.1
analyzer-version-gcc-analyzer14.0.1
analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-clang18.1.3
diffbase-analyzer-version-cppcheck2.13.0
diffbase-analyzer-version-gcc14.0.1
diffbase-analyzer-version-gcc-analyzer14.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-enabled-pluginsclang, cppcheck, gcc, shellcheck
diffbase-exit-code0
diffbase-hostip-172-16-1-247.us-west-2.compute.internal
diffbase-mock-configfedora-41-x86_64
diffbase-project-namevim-9.1.158-1.fc40
diffbase-store-results-to/tmp/tmpp7ojlufa/vim-9.1.158-1.fc40.tar.xz
diffbase-time-created2024-04-22 11:17:55
diffbase-time-finished2024-04-22 11:37:02
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-41-x86_64' '-t' 'cppcheck,gcc,clang,shellcheck' '-o' '/tmp/tmpp7ojlufa/vim-9.1.158-1.fc40.tar.xz' '--gcc-analyze' '/tmp/tmpp7ojlufa/vim-9.1.158-1.fc40.src.rpm'
diffbase-tool-versioncsmock-3.5.3-1.el9
enabled-pluginsclang, cppcheck, gcc, shellcheck
exit-code0
hostip-172-16-1-247.us-west-2.compute.internal
mock-configfedora-41-x86_64
project-namevim-9.1.309-1.fc41
store-results-to/tmp/tmplhxhiugx/vim-9.1.309-1.fc41.tar.xz
time-created2024-04-22 11:37:28
time-finished2024-04-22 11:55:56
titleNewly introduced defects
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-41-x86_64' '-t' 'cppcheck,gcc,clang,shellcheck' '-o' '/tmp/tmplhxhiugx/vim-9.1.309-1.fc41.tar.xz' '--gcc-analyze' '/tmp/tmplhxhiugx/vim-9.1.309-1.fc41.src.rpm'
tool-versioncsmock-3.5.3-1.el9