annobin-12.70-1.fc42

List of Findings

Error: COMPILER_WARNING (CWE-563): [#def1]
annobin-12.70-build/annobin-12.70/annocheck/annocheck.c: scope_hint: In function ‘process_command_line’
annobin-12.70-build/annobin-12.70/annocheck/annocheck.c:2383:21: warning[-Wunused-variable]: unused variable ‘used’
# 2383 |       bool          used = false;
#      |                     ^~~~
# 2381|         const char *  parameter;
# 2382|         const char *  arg = argv[a];
# 2383|->       bool          used = false;
# 2384|         checker *     tool;
# 2385|         const char *  orig_arg = arg;

Error: COMPILER_WARNING (CWE-681): [#def2]
annobin-12.70-build/annobin-12.70/annocheck/built-by.c: scope_hint: In function ‘tool_found’
annobin-12.70-build/annobin-12.70/annocheck/built-by.c:398:42: warning[-Wpointer-sign]: pointer targets in passing argument 4 of ‘parse_tool’ differ in signedness
#  398 |   parse_tool (filename, tool, & program, & proglen, & version, & verlen, source);
#      |                                          ^~~~~~~~~
#      |                                          |
#      |                                          unsigned int *
annobin-12.70-build/annobin-12.70/annocheck/built-by.c:276:28: note: expected ‘int *’ but argument is of type ‘unsigned int *’
#  276 |             int *          proglen_return,
#      |             ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
#  396|     unsigned int  verlen = 0;
#  397|   
#  398|->   parse_tool (filename, tool, & program, & proglen, & version, & verlen, source);
#  399|     
#  400|     if (nottool_list != NULL && on_strlist (nottool_list, program, proglen))

Error: COMPILER_WARNING (CWE-681): [#def3]
annobin-12.70-build/annobin-12.70/annocheck/built-by.c:398:64: warning[-Wpointer-sign]: pointer targets in passing argument 6 of ‘parse_tool’ differ in signedness
#  398 |   parse_tool (filename, tool, & program, & proglen, & version, & verlen, source);
#      |                                                                ^~~~~~~~
#      |                                                                |
#      |                                                                unsigned int *
annobin-12.70-build/annobin-12.70/annocheck/built-by.c:278:28: note: expected ‘int *’ but argument is of type ‘unsigned int *’
#  278 |             int *          verlen_return,
#      |             ~~~~~~~~~~~~~~~^~~~~~~~~~~~~
#  396|     unsigned int  verlen = 0;
#  397|   
#  398|->   parse_tool (filename, tool, & program, & proglen, & version, & verlen, source);
#  399|     
#  400|     if (nottool_list != NULL && on_strlist (nottool_list, program, proglen))

Error: COMPILER_WARNING: [#def4]
annobin-12.70-build/annobin-12.70/annocheck/built-by.c: scope_hint: In function ‘parse_dw_at_language’
annobin-12.70-build/annobin-12.70/annocheck/built-by.c:689:76: warning[-Wformat=]: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘Dwarf_Word’ {aka ‘long unsigned int’}
#  689 |       einfo (WARN, "%s: unrecognised value for DW_AT_language attribute: %#x", data->filename, val);
#      |                                                                          ~~^                   ~~~
#      |                                                                            |                   |
#      |                                                                            unsigned int        Dwarf_Word {aka long unsigned int}
#      |                                                                          %#lx
#  687|         
#  688|       default:
#  689|->       einfo (WARN, "%s: unrecognised value for DW_AT_language attribute: %#x", data->filename, val);
#  690|         break;
#  691|       }

Error: COMPILER_WARNING (CWE-569): [#def5]
annobin-12.70-build/annobin-12.70/annocheck/hardened.c: scope_hint: In function ‘set_lang’
annobin-12.70-build/annobin-12.70/annocheck/hardened.c:2688:30: warning[-Wparentheses]: suggest parentheses around ‘&&’ within ‘||’
# 2688 |           || lang == LANG_GO && (per_file.langs[LANG_C] || per_file.langs[LANG_CXX])))
#      |              ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 2686|         && untested (TEST_ONLY_GO)
# 2687|         && ((lang != LANG_GO && per_file.langs[LANG_GO])
# 2688|-> 	  || lang == LANG_GO && (per_file.langs[LANG_C] || per_file.langs[LANG_CXX])))
# 2689|       {
# 2690|         /* FIXME: This FAIL is currently disabled as the user can do nothing to correct the problem.

Error: CPPCHECK_WARNING (CWE-562): [#def6]
annobin-12.70-build/annobin-12.70/annocheck/libiberty/cp-demangle.c:5133: error[autoVariables]: Address of local auto-variable assigned to a function parameter.
# 5131|   
# 5132|   	    adpm[i].next = dpi->modifiers;
# 5133|-> 	    dpi->modifiers = &adpm[i];
# 5134|   	    adpm[i].mod = typed_name;
# 5135|   	    adpm[i].printed = 0;

Error: CPPCHECK_WARNING (CWE-562): [#def7]
annobin-12.70-build/annobin-12.70/annocheck/libiberty/cp-demangle.c:5171: error[autoVariables]: Address of local auto-variable assigned to a function parameter.
# 5169|   		adpm[i] = adpm[i - 1];
# 5170|   		adpm[i].next = &adpm[i - 1];
# 5171|-> 		dpi->modifiers = &adpm[i];
# 5172|   
# 5173|   		adpm[i - 1].mod = typed_name;

Error: CPPCHECK_WARNING (CWE-562): [#def8]
annobin-12.70-build/annobin-12.70/annocheck/libiberty/cp-demangle.c:5192: error[autoVariables]: Address of local auto-variable assigned to a function parameter.
# 5190|   	  {
# 5191|   	    dpt.next = dpi->templates;
# 5192|-> 	    dpi->templates = &dpt;
# 5193|   	    dpt.template_decl = typed_name;
# 5194|   	  }

Error: CPPCHECK_WARNING (CWE-562): [#def9]
annobin-12.70-build/annobin-12.70/annocheck/libiberty/cp-demangle.c:5651: error[autoVariables]: Address of local auto-variable assigned to a function parameter.
# 5649|   
# 5650|   	adpm[0].next = hold_modifiers;
# 5651|-> 	dpi->modifiers = &adpm[0];
# 5652|   	adpm[0].mod = dc;
# 5653|   	adpm[0].printed = 0;

Scan Properties