Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-398): [#def1]
/usr/bin/bashbug-64:135:7: error[SC1073]: Couldn't parse this test expression. Fix to allow more checks.
#  133|   	elif [ -x /usr/bin/xemacs ]; then
#  134|   		DEFEDITOR=xemacs
#  135|-> 	elif [ -x /usr/bin/vim; then
#  136|   		DEFEDITOR=vim
#  137|   	elif [ -x /usr/bin/gvim; then

Error: SHELLCHECK_WARNING (CWE-398): [#def2]
/usr/bin/bashbug-64:135:24: error[SC1072]: Expected test to end here (don't wrap commands in []/[[]]). Fix any mentioned problems and try again.
#  133|   	elif [ -x /usr/bin/xemacs ]; then
#  134|   		DEFEDITOR=xemacs
#  135|-> 	elif [ -x /usr/bin/vim; then
#  136|   		DEFEDITOR=vim
#  137|   	elif [ -x /usr/bin/gvim; then

Error: COMPILER_WARNING: [#def3]
bash-5.2.32-build/bash-5.2/general.h:168:41: warning[-Wuse-after-free]: pointer ‘t_408’ may be used after ‘free’
#  168 |                                   : ((a)[0] == (b)[0] && strncmp(a, b, n) == 0))
#      |                                      ~~~^~~
bash-5.2.32-build/bash-5.2/subst.c:4290:15: note: call to ‘free’ here
# 4290 |               free (t);
#      |               ^~~~~~~~
#  166|   #define STREQ(a, b) ((a)[0] == (b)[0] && strcmp(a, b) == 0)
#  167|   #define STREQN(a, b, n) ((n == 0) ? (1) \
#  168|-> 				  : ((a)[0] == (b)[0] && strncmp(a, b, n) == 0))
#  169|   
#  170|   /* More convenience definitions that possibly save system or libc calls. */

Error: COMPILER_WARNING: [#def4]
bash-5.2.32-build/bash-5.2/shell.h:29: included_from: Included from here.
bash-5.2.32-build/bash-5.2/subst.c:46: included_from: Included from here.
bash-5.2.32-build/bash-5.2/subst.c: scope_hint: In function ‘expand_string_dollar_quote’
bash-5.2.32-build/bash-5.2/general.h:168:58: warning[-Wuse-after-free]: pointer ‘t_408’ may be used after ‘free’
#  168 |                                   : ((a)[0] == (b)[0] && strncmp(a, b, n) == 0))
#      |                                                          ^~~~~~~~~~~~~~~~
bash-5.2.32-build/bash-5.2/subst.c:4290:15: note: call to ‘free’ here
# 4290 |               free (t);
#      |               ^~~~~~~~
#  166|   #define STREQ(a, b) ((a)[0] == (b)[0] && strcmp(a, b) == 0)
#  167|   #define STREQN(a, b, n) ((n == 0) ? (1) \
#  168|-> 				  : ((a)[0] == (b)[0] && strncmp(a, b, n) == 0))
#  169|   
#  170|   /* More convenience definitions that possibly save system or libc calls. */

Error: GCC_ANALYZER_WARNING (CWE-775): [#def5]
bash-5.2.32-build/bash-5.2/lib/readline/util.c: scope_hint: In function ‘_rl_audit_tty’
bash-5.2.32-build/bash-5.2/lib/readline/util.c:555:5: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘fd’
#  553|     fd = socket (PF_NETLINK, SOCK_RAW, NETLINK_AUDIT);
#  554|     if (fd < 0)
#  555|->     return;
#  556|     size = strlen (string) + 1;
#  557|   

Scan Properties

analyzer-version-clippy1.82.0
analyzer-version-cppcheck2.16.0
analyzer-version-gcc14.2.1
analyzer-version-gcc-analyzer15.0.0
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.82.0
diffbase-analyzer-version-cppcheck2.16.0
diffbase-analyzer-version-gcc14.2.1
diffbase-analyzer-version-gcc-analyzer15.0.0
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-66.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-gcc-latest-x86_64
diffbase-project-namebash-5.2.37-1.fc42
diffbase-store-results-to/tmp/tmp9vp47ivr/bash-5.2.37-1.fc42.tar.xz
diffbase-time-created2024-11-12 23:14:57
diffbase-time-finished2024-11-12 23:18:26
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmp9vp47ivr/bash-5.2.37-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmp9vp47ivr/bash-5.2.37-1.fc42.src.rpm'
diffbase-tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-66.us-west-2.compute.internal
mock-configfedora-rawhide-gcc-latest-x86_64
project-namebash-5.2.32-1.fc41
store-results-to/tmp/tmpgtz63n8y/bash-5.2.32-1.fc41.tar.xz
time-created2024-11-12 23:10:49
time-finished2024-11-12 23:14:32
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpgtz63n8y/bash-5.2.32-1.fc41.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpgtz63n8y/bash-5.2.32-1.fc41.src.rpm'
tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9