Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-252): [#def1]
/usr/bin/find-debuginfo:671:4: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
#  669|     # directory (which is why we match against ^ or /).
#  670|     LC_ALL=C sort -z -u "$SOURCEFILE" | grep -E -v -z '(^|/)<[a-z _-]+>$' |
#  671|->   (cd "${debug_base_name}"; cpio -pd0mL "${RPM_BUILD_ROOT}${debug_dest_name}")
#  672|     # stupid cpio creates new directories in mode 0700,
#  673|     # and non-standard modes may be inherented from original directories, fixup

Error: GCC_ANALYZER_WARNING (CWE-688): [#def2]
debugedit-5.0-build/debugedit-5.0/tools/debugedit.c: scope_hint: In function ‘edit_dwarf2’
debugedit-5.0-build/debugedit-5.0/tools/debugedit.c:2829:13: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
debugedit-5.0-build/debugedit-5.0/tools/debugedit.c:31: included_from: Included from here.
/usr/include/string.h:159:12: note: argument 1 of ‘strncmp’ must be non-null
# 2827|   				   dso->shdr[i].sh_name);
# 2828|   
# 2829|-> 	if (strncmp (name, ".debug_", sizeof (".debug_") - 1) == 0)
# 2830|   	  {
# 2831|   	    for (j = 0; debug_sections[j].name; ++j)

Error: GCC_ANALYZER_WARNING (CWE-401): [#def3]
debugedit-5.0-build/debugedit-5.0/tools/debugedit.c: scope_hint: In function ‘main’
debugedit-5.0-build/debugedit-5.0/tools/debugedit.c:3358:11: warning[-Wanalyzer-malloc-leak]: leak of ‘fdopen_dso(open(file, 2), file)’
# 3356|       }
# 3357|   
# 3358|->   if (ehdr.e_type != ET_DYN && ehdr.e_type != ET_EXEC && ehdr.e_type != ET_REL)
# 3359|       {
# 3360|         error (0, 0, "\"%s\" is not a shared library", name);

Error: GCC_ANALYZER_WARNING (CWE-688): [#def4]
debugedit-5.0-build/debugedit-5.0/tools/debugedit.c:3707:15: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
/usr/include/string.h:156:12: note: argument 1 of ‘strcmp’ must be non-null
# 3705|   	  name = strptr (dso, dso->ehdr.e_shstrndx, dso->shdr[i].sh_name);
# 3706|   	  /* TODO: Handle stabs */
# 3707|-> 	  if (strcmp (name, ".stab") == 0)
# 3708|   	    {
# 3709|   	      error (0, 0, "Stabs debuginfo not supported: %s", file);

Error: GCC_ANALYZER_WARNING (CWE-401): [#def5]
debugedit-5.0-build/debugedit-5.0/tools/debugedit.c:3881:6: warning[-Wanalyzer-malloc-leak]: leak of ‘<unknown>’
# 3879|       handle_build_id (dso, build_id, build_id_offset, build_id_size);
# 3880|   
# 3881|->   if (elf_update (dso->elf, ELF_C_WRITE) < 0)
# 3882|       {
# 3883|         error (1, 0, "Failed to write file: %s", elf_errmsg (elf_errno()));

Scan Properties