Fixed findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
device-mapper-persistent-data-1.0.12-build/src/era/invalidate.rs:188:22: warning: usage of a legacy numeric method
#      |
#  188 |         if n == u64::max_value() {
#      |                      ^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
#      = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
#  help: use the associated constant instead
#      |
#  188 |         if n == u64::MAX {
#      |                      ~~~

Error: CLIPPY_WARNING: [#def2]
device-mapper-persistent-data-1.0.12-build/src/ioctl.rs:18:5: warning: unexpected `cfg` condition value: `powerpc64le`
#     |
#  18 |     target_arch = "powerpc64le",
#     |     ^^^^^^^^^^^^^^-------------
#     |                   |
#     |                   help: there is a expected value with a similar name: `"powerpc64"`
#     |
#     = note: expected values for `target_arch` are: `aarch64`, `arm`, `arm64ec`, `avr`, `bpf`, `csky`, `hexagon`, `loongarch64`, `m68k`, `mips`, `mips32r6`, `mips64`, `mips64r6`, `msp430`, `nvptx64`, `powerpc`, `powerpc64`, `riscv32`, `riscv64`, `s390x`, `sparc`, `sparc64`, `wasm32`, `wasm64`, `x86`, `x86_64`, and `xtensa`
#     = help: consider using a Cargo feature instead
#     = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
#              [lints.rust]
#              unexpected_cfgs = { level = "warn", check-cfg = ['cfg(target_arch, values("powerpc64le"))'] }
#     = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(target_arch, values(\"powerpc64le\"))");` to the top of the `build.rs`
#     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
#     = note: `#[warn(unexpected_cfgs)]` on by default

Error: CLIPPY_WARNING: [#def3]
device-mapper-persistent-data-1.0.12-build/src/ioctl.rs:36:5: warning: unexpected `cfg` condition value: `powerpc64le`
#     |
#  36 |     target_arch = "powerpc64le",
#     |     ^^^^^^^^^^^^^^-------------
#     |                   |
#     |                   help: there is a expected value with a similar name: `"powerpc64"`
#     |
#     = note: expected values for `target_arch` are: `aarch64`, `arm`, `arm64ec`, `avr`, `bpf`, `csky`, `hexagon`, `loongarch64`, `m68k`, `mips`, `mips32r6`, `mips64`, `mips64r6`, `msp430`, `nvptx64`, `powerpc`, `powerpc64`, `riscv32`, `riscv64`, `s390x`, `sparc`, `sparc64`, `wasm32`, `wasm64`, `x86`, `x86_64`, and `xtensa`
#     = help: consider using a Cargo feature instead
#     = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
#              [lints.rust]
#              unexpected_cfgs = { level = "warn", check-cfg = ['cfg(target_arch, values("powerpc64le"))'] }
#     = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(target_arch, values(\"powerpc64le\"))");` to the top of the `build.rs`
#     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Error: CLIPPY_WARNING: [#def4]
device-mapper-persistent-data-1.0.12-build/src/pack/toplevel.rs:41:22: warning: clamp-like pattern without using clamp function
#     |
#  41 |     let chunk_size = min(4 * 1024u64, max(128u64, nr_blocks / (nr_jobs * 64)));
#     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(nr_blocks / (nr_jobs * 64)).clamp(128u64, 4 * 1024u64)`
#     |
#     = note: clamp will panic if max < min
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
#     = note: `#[warn(clippy::manual_clamp)]` on by default

Error: CLIPPY_WARNING: [#def5]
device-mapper-persistent-data-1.0.12-build/src/pack/vm.rs:69:22: warning: usage of a legacy numeric constant
#     |
#  69 |             if *n <= std::u8::MAX as u64 {
#     |                      ^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
#  help: use the associated constant instead
#     |
#  69 |             if *n <= u8::MAX as u64 {
#     |                      ~~~~~~~

Error: CLIPPY_WARNING: [#def6]
device-mapper-persistent-data-1.0.12-build/src/pack/vm.rs:72:29: warning: usage of a legacy numeric constant
#     |
#  72 |             } else if *n <= std::u16::MAX as u64 {
#     |                             ^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
#  help: use the associated constant instead
#     |
#  72 |             } else if *n <= u16::MAX as u64 {
#     |                             ~~~~~~~~

Error: CLIPPY_WARNING: [#def7]
device-mapper-persistent-data-1.0.12-build/src/thin/ls.rs:92:1: warning: direct implementation of `ToString`
#      |
#  92  | / impl ToString for OutputField {
#  93  | |     fn to_string(&self) -> String {
#  94  | |         use OutputField::*;
#  ...   |
#  118 | |     }
#  119 | | }
#      | |_^
#      |
#      = help: prefer implementing `Display` instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
#      = note: `#[warn(clippy::to_string_trait_impl)]` on by default

Error: CLIPPY_WARNING: [#def8]
device-mapper-persistent-data-1.0.12-build/src/thin/runs.rs:82:25: warning: unnecessary use of `get(&b).is_none()`
#     |
#  82 |         if self.entries.get(&b).is_none() {
#     |            -------------^^^^^^^^^^^^^^^^^
#     |            |
#     |            help: replace it with: `!self.entries.contains_key(&b)`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
#     = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default

Error: CLIPPY_WARNING: [#def9]
device-mapper-persistent-data-1.0.12-build/src/units.rs:123:1: warning: direct implementation of `ToString`
#      |
#  123 | / impl ToString for Units {
#  124 | |     fn to_string(&self) -> String {
#  125 | |         use Units::*;
#  ...   |
#  145 | |     }
#  146 | | }
#      | |_^
#      |
#      = help: prefer implementing `Display` instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

Error: CLIPPY_WARNING: [#def10]
device-mapper-persistent-data-1.0.12-build/src/units.rs:223:1: warning: direct implementation of `ToString`
#      |
#  223 | / impl ToString for StorageSize {
#  224 | |     fn to_string(&self) -> String {
#  225 | |         let mut s = self.multiple.to_string();
#  226 | |         s.push_str(&self.unit.to_string_short());
#  227 | |         s
#  228 | |     }
#  229 | | }
#      | |_^
#      |
#      = help: prefer implementing `Display` instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

Scan Properties