Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-563): [#def1]
/usr/share/firewalld/testsuite/integration/testsuite:996:1: warning[SC2034]: at_banner_text_1 appears unused. Verify use (or export if used externally).
#  994|   # Banner 1. networkmanager.at:1
#  995|   # Category starts at test group 1.
#  996|-> at_banner_text_1="NetworkManager"
#  997|   # Banner 2. polkit.at:1
#  998|   # Category starts at test group 5.

Error: SHELLCHECK_WARNING (CWE-563): [#def2]
/usr/share/firewalld/testsuite/integration/testsuite:1008:1: warning[SC2034]: at_banner_text_5 appears unused. Verify use (or export if used externally).
# 1006|   # Banner 5. podman.at:1
# 1007|   # Category starts at test group 10.
# 1008|-> at_banner_text_5="podman"
# 1009|   
# 1010|   # Take any -C into account.

Error: SHELLCHECK_WARNING: [#def3]
/usr/share/firewalld/testsuite/integration/testsuite:7249:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 7247|       fi
# 7248|       if test "$ULIMIT_VAL" -ne 0 ; then
# 7249|->         ulimit -d "$ULIMIT_VAL"
# 7250|       fi
# 7251|   

Error: SHELLCHECK_WARNING (CWE-156): [#def4]
/usr/share/firewalld/testsuite/integration/testsuite:7569:6: warning[SC2046]: Quote this to prevent word splitting.
# 7567|       test $pid -eq 0 || { kill -9 $pid; sleep 3; }
# 7568|   
# 7569|-> test $(basename ${PODMAN}) = "podman" && {
# 7570|       podman network reload --all
# 7571|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def5]
/usr/share/firewalld/testsuite/integration/testsuite:7572:6: warning[SC2046]: Quote this to prevent word splitting.
# 7570|       podman network reload --all
# 7571|   }
# 7572|-> test $(basename ${PODMAN}) = "docker" && {
# 7573|       systemctl restart docker
# 7574|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def6]
/usr/share/firewalld/testsuite/integration/testsuite:8071:92: warning[SC2046]: Quote this to prevent word splitting.
# 8069|   
# 8070|   
# 8071|-> pod_address=$($PODMAN inspect -f '{{range.NetworkSettings.Networks}}{{.IPAddress}}{{end}}' $(cat ./pod_name))
# 8072|   
# 8073|   

Error: SHELLCHECK_WARNING: [#def7]
/usr/share/firewalld/testsuite/integration/testsuite:8188:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 8186|       fi
# 8187|       if test "$ULIMIT_VAL" -ne 0 ; then
# 8188|->         ulimit -d "$ULIMIT_VAL"
# 8189|       fi
# 8190|   

Error: SHELLCHECK_WARNING (CWE-156): [#def8]
/usr/share/firewalld/testsuite/integration/testsuite:8508:6: warning[SC2046]: Quote this to prevent word splitting.
# 8506|       test $pid -eq 0 || { kill -9 $pid; sleep 3; }
# 8507|   
# 8508|-> test $(basename ${PODMAN}) = "podman" && {
# 8509|       podman network reload --all
# 8510|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def9]
/usr/share/firewalld/testsuite/integration/testsuite:8511:6: warning[SC2046]: Quote this to prevent word splitting.
# 8509|       podman network reload --all
# 8510|   }
# 8511|-> test $(basename ${PODMAN}) = "docker" && {
# 8512|       systemctl restart docker
# 8513|   }

Scan Properties

analyzer-version-clippy1.82.0
analyzer-version-cppcheck2.16.0
analyzer-version-gcc14.2.1
analyzer-version-gcc-analyzer15.0.0
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.82.0
diffbase-analyzer-version-cppcheck2.16.0
diffbase-analyzer-version-gcc14.2.1
diffbase-analyzer-version-gcc-analyzer15.0.0
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-35.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-gcc-latest-x86_64
diffbase-project-namefirewalld-2.2.1-1.fc41
diffbase-store-results-to/tmp/tmpwalicr6x/firewalld-2.2.1-1.fc41.tar.xz
diffbase-time-created2024-11-12 23:46:18
diffbase-time-finished2024-11-12 23:48:38
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpwalicr6x/firewalld-2.2.1-1.fc41.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpwalicr6x/firewalld-2.2.1-1.fc41.src.rpm'
diffbase-tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-35.us-west-2.compute.internal
mock-configfedora-rawhide-gcc-latest-x86_64
project-namefirewalld-2.3.0-1.fc42
store-results-to/tmp/tmpyiy1gizg/firewalld-2.3.0-1.fc42.tar.xz
time-created2024-11-12 23:49:02
time-finished2024-11-12 23:50:56
titleNewly introduced findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpyiy1gizg/firewalld-2.3.0-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpyiy1gizg/firewalld-2.3.0-1.fc42.src.rpm'
tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9