firewalld-2.3.0-1.fc42

List of Findings

Error: SHELLCHECK_WARNING (CWE-156): [#def1]
/usr/lib/firewalld/xmlschema/check.sh:10:20: warning[SC2046]: Quote this to prevent word splitting.
#    8|   
#    9|   prog="$(basename $0)"
#   10|-> BASEDIR=$(realpath $(dirname $0))
#   11|   
#   12|   checkdir="$PWD"

Error: SHELLCHECK_WARNING (CWE-563): [#def2]
/usr/share/firewalld/testsuite/integration/testsuite:17:3: warning[SC2034]: NULLCMD appears unused. Verify use (or export if used externally).
#   15|   then :
#   16|     emulate sh
#   17|->   NULLCMD=:
#   18|     # Pre-4.2 versions of Zsh do word splitting on ${1+"$@"}, which
#   19|     # is contrary to our usage.  Disable this feature.

Error: SHELLCHECK_WARNING (CWE-398): [#def3]
/usr/share/firewalld/testsuite/integration/testsuite:20:12: error[SC2142]: Aliases can't use positional parameters. Use a function.
#   18|     # Pre-4.2 versions of Zsh do word splitting on ${1+"$@"}, which
#   19|     # is contrary to our usage.  Disable this feature.
#   20|->   alias -g '${1+"$@"}'='"$@"'
#   21|     setopt NO_GLOB_SUBST
#   22|   else case e in #(

Error: SHELLCHECK_WARNING: [#def4]
/usr/share/firewalld/testsuite/integration/testsuite:22:11: warning[SC2194]: This word is constant. Did you forget the $ on a variable?
#   20|     alias -g '${1+"$@"}'='"$@"'
#   21|     setopt NO_GLOB_SUBST
#   22|-> else case e in #(
#   23|     e) case `(set -o) 2>/dev/null` in #(
#   24|     *posix*) :

Error: SHELLCHECK_WARNING: [#def5]
/usr/share/firewalld/testsuite/integration/testsuite:25:12: warning[SC3040]: In POSIX sh, set option posix is undefined.
#   23|     e) case `(set -o) 2>/dev/null` in #(
#   24|     *posix*) :
#   25|->     set -o posix ;; #(
#   26|     *) :
#   27|        ;;

Error: SHELLCHECK_WARNING (CWE-569): [#def6]
/usr/share/firewalld/testsuite/integration/testsuite:62:16: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it.
#   60|   # in other old shells (e.g. bash 2.01 and pdksh 5.2.14).
#   61|   for as_var in BASH_ENV ENV MAIL MAILPATH CDPATH
#   62|-> do eval test \${$as_var+y} \
#   63|     && ( (unset $as_var) || exit 1) >/dev/null 2>&1 && unset $as_var || :
#   64|   done

Error: SHELLCHECK_WARNING (CWE-569): [#def7]
/usr/share/firewalld/testsuite/integration/testsuite:62:26: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it.
#   60|   # in other old shells (e.g. bash 2.01 and pdksh 5.2.14).
#   61|   for as_var in BASH_ENV ENV MAIL MAILPATH CDPATH
#   62|-> do eval test \${$as_var+y} \
#   63|     && ( (unset $as_var) || exit 1) >/dev/null 2>&1 && unset $as_var || :
#   64|   done

Error: SHELLCHECK_WARNING (CWE-563): [#def8]
/usr/share/firewalld/testsuite/integration/testsuite:75:24: warning[SC2034]: FPATH appears unused. Verify use (or export if used externally).
#   73|     PATH_SEPARATOR=:
#   74|     (PATH='/bin;/bin'; FPATH=$PATH; sh -c :) >/dev/null 2>&1 && {
#   75|->     (PATH='/bin:/bin'; FPATH=$PATH; sh -c :) >/dev/null 2>&1 ||
#   76|         PATH_SEPARATOR=';'
#   77|     }

Error: SHELLCHECK_WARNING: [#def9]
/usr/share/firewalld/testsuite/integration/testsuite:160:11: warning[SC2194]: This word is constant. Did you forget the $ on a variable?
#  158|   then :
#  159|     as_have_required=yes
#  160|-> else case e in #(
#  161|     e) as_have_required=no ;;
#  162|   esac

Error: SHELLCHECK_WARNING: [#def10]
/usr/share/firewalld/testsuite/integration/testsuite:167:11: warning[SC2194]: This word is constant. Did you forget the $ on a variable?
#  165|   then :
#  166|   
#  167|-> else case e in #(
#  168|     e) as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
#  169|   as_found=false

Error: SHELLCHECK_WARNING: [#def11]
/usr/share/firewalld/testsuite/integration/testsuite:201:11: warning[SC2194]: This word is constant. Did you forget the $ on a variable?
#  199|   then :
#  200|   
#  201|-> else case e in #(
#  202|     e) if { test -f "$SHELL" || test -f "$SHELL.exe"; } &&
#  203|   	      as_run=a "$SHELL" -c "$as_bourne_compatible""$as_required" 2>/dev/null

Error: SHELLCHECK_WARNING (CWE-563): [#def12]
/usr/share/firewalld/testsuite/integration/testsuite:255:1: warning[SC2034]: CLICOLOR_FORCE appears unused. Verify use (or export if used externally).
#  253|   export SHELL
#  254|   # Unset more variables known to interfere with behavior of common tools.
#  255|-> CLICOLOR_FORCE= GREP_OPTIONS=
#  256|   unset CLICOLOR_FORCE GREP_OPTIONS
#  257|   

Error: SHELLCHECK_WARNING (CWE-480): [#def13]
/usr/share/firewalld/testsuite/integration/testsuite:255:16: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  253|   export SHELL
#  254|   # Unset more variables known to interfere with behavior of common tools.
#  255|-> CLICOLOR_FORCE= GREP_OPTIONS=
#  256|   unset CLICOLOR_FORCE GREP_OPTIONS
#  257|   

Error: SHELLCHECK_WARNING (CWE-563): [#def14]
/usr/share/firewalld/testsuite/integration/testsuite:255:17: warning[SC2034]: GREP_OPTIONS appears unused. Verify use (or export if used externally).
#  253|   export SHELL
#  254|   # Unset more variables known to interfere with behavior of common tools.
#  255|-> CLICOLOR_FORCE= GREP_OPTIONS=
#  256|   unset CLICOLOR_FORCE GREP_OPTIONS
#  257|   

Error: SHELLCHECK_WARNING (CWE-563): [#def15]
/usr/share/firewalld/testsuite/integration/testsuite:268:1: warning[SC2034]: as_unset appears unused. Verify use (or export if used externally).
#  266|     { eval $1=; unset $1;}
#  267|   }
#  268|-> as_unset=as_fn_unset
#  269|   
#  270|   

Error: SHELLCHECK_WARNING: [#def16]
/usr/share/firewalld/testsuite/integration/testsuite:356:11: warning[SC2194]: This word is constant. Did you forget the $ on a variable?
#  354|       eval $1+=\$2
#  355|     }'
#  356|-> else case e in #(
#  357|     e) as_fn_append ()
#  358|     {

Error: SHELLCHECK_WARNING: [#def17]
/usr/share/firewalld/testsuite/integration/testsuite:375:11: warning[SC2194]: This word is constant. Did you forget the $ on a variable?
#  373|       as_val=$(( $* ))
#  374|     }'
#  375|-> else case e in #(
#  376|     e) as_fn_arith ()
#  377|     {

Error: SHELLCHECK_WARNING (CWE-456): [#def18]
/usr/share/firewalld/testsuite/integration/testsuite:402:3: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string).
#  400|   if expr a : '\(a\)' >/dev/null 2>&1 &&
#  401|      test "X`expr 00001 : '.*\(...\)'`" = X001; then
#  402|->   as_expr=expr
#  403|   else
#  404|     as_expr=false

Error: SHELLCHECK_WARNING (CWE-456): [#def19]
/usr/share/firewalld/testsuite/integration/testsuite:408:3: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string).
#  406|   
#  407|   if (basename -- /) >/dev/null 2>&1 && test "X`basename -- / 2>&1`" = "X/"; then
#  408|->   as_basename=basename
#  409|   else
#  410|     as_basename=false

Error: SHELLCHECK_WARNING (CWE-456): [#def20]
/usr/share/firewalld/testsuite/integration/testsuite:433:3: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string).
#  431|   
#  432|   if (as_dir=`dirname -- /` && test "X$as_dir" = X/) >/dev/null 2>&1; then
#  433|->   as_dirname=dirname
#  434|   else
#  435|     as_dirname=false

Error: SHELLCHECK_WARNING (CWE-563): [#def21]
/usr/share/firewalld/testsuite/integration/testsuite:446:3: warning[SC2034]: as_lineno_1 appears unused. Verify use (or export if used externally).
#  444|   
#  445|   
#  446|->   as_lineno_1=$LINENO as_lineno_1a=$LINENO
#  447|     as_lineno_2=$LINENO as_lineno_2a=$LINENO
#  448|     eval 'test "x$as_lineno_1'$as_run'" != "x$as_lineno_2'$as_run'" &&

Error: SHELLCHECK_WARNING (CWE-563): [#def22]
/usr/share/firewalld/testsuite/integration/testsuite:446:23: warning[SC2034]: as_lineno_1a appears unused. Verify use (or export if used externally).
#  444|   
#  445|   
#  446|->   as_lineno_1=$LINENO as_lineno_1a=$LINENO
#  447|     as_lineno_2=$LINENO as_lineno_2a=$LINENO
#  448|     eval 'test "x$as_lineno_1'$as_run'" != "x$as_lineno_2'$as_run'" &&

Error: SHELLCHECK_WARNING (CWE-563): [#def23]
/usr/share/firewalld/testsuite/integration/testsuite:447:3: warning[SC2034]: as_lineno_2 appears unused. Verify use (or export if used externally).
#  445|   
#  446|     as_lineno_1=$LINENO as_lineno_1a=$LINENO
#  447|->   as_lineno_2=$LINENO as_lineno_2a=$LINENO
#  448|     eval 'test "x$as_lineno_1'$as_run'" != "x$as_lineno_2'$as_run'" &&
#  449|     test "x`expr $as_lineno_1'$as_run' + 1`" = "x$as_lineno_2'$as_run'"' || {

Error: SHELLCHECK_WARNING (CWE-563): [#def24]
/usr/share/firewalld/testsuite/integration/testsuite:447:23: warning[SC2034]: as_lineno_2a appears unused. Verify use (or export if used externally).
#  445|   
#  446|     as_lineno_1=$LINENO as_lineno_1a=$LINENO
#  447|->   as_lineno_2=$LINENO as_lineno_2a=$LINENO
#  448|     eval 'test "x$as_lineno_1'$as_run'" != "x$as_lineno_2'$as_run'" &&
#  449|     test "x`expr $as_lineno_1'$as_run' + 1`" = "x$as_lineno_2'$as_run'"' || {

Error: SHELLCHECK_WARNING (CWE-457): [#def25]
/usr/share/firewalld/testsuite/integration/testsuite:448:29: warning[SC2154]: as_run is referenced but not assigned.
#  446|     as_lineno_1=$LINENO as_lineno_1a=$LINENO
#  447|     as_lineno_2=$LINENO as_lineno_2a=$LINENO
#  448|->   eval 'test "x$as_lineno_1'$as_run'" != "x$as_lineno_2'$as_run'" &&
#  449|     test "x`expr $as_lineno_1'$as_run' + 1`" = "x$as_lineno_2'$as_run'"' || {
#  450|     # Blame Lee E. McMahon (1931-1989) for sed's syntax.  :-)

Error: SHELLCHECK_WARNING (CWE-480): [#def26]
/usr/share/firewalld/testsuite/integration/testsuite:487:8: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  485|   # These variables are no longer used directly by Autoconf, but are AC_SUBSTed
#  486|   # for compatibility with existing Makefiles.
#  487|-> ECHO_C= ECHO_N= ECHO_T=
#  488|   case `echo -n x` in #(((((
#  489|   -n*)

Error: SHELLCHECK_WARNING (CWE-480): [#def27]
/usr/share/firewalld/testsuite/integration/testsuite:487:16: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  485|   # These variables are no longer used directly by Autoconf, but are AC_SUBSTed
#  486|   # for compatibility with existing Makefiles.
#  487|-> ECHO_C= ECHO_N= ECHO_T=
#  488|   case `echo -n x` in #(((((
#  489|   -n*)

Error: SHELLCHECK_WARNING: [#def28]
/usr/share/firewalld/testsuite/integration/testsuite:488:12: warning[SC3037]: In POSIX sh, echo flags are undefined.
#  486|   # for compatibility with existing Makefiles.
#  487|   ECHO_C= ECHO_N= ECHO_T=
#  488|-> case `echo -n x` in #(((((
#  489|   -n*)
#  490|     case `echo 'xy\c'` in

Error: SHELLCHECK_WARNING (CWE-563): [#def29]
/usr/share/firewalld/testsuite/integration/testsuite:492:8: warning[SC2034]: ECHO_C appears unused. Verify use (or export if used externally).
#  490|     case `echo 'xy\c'` in
#  491|     *c*) ECHO_T='	';;	# ECHO_T is single tab character.
#  492|->   xy)  ECHO_C='\c';;
#  493|     *)   echo `echo ksh88 bug on AIX 6.1` > /dev/null
#  494|          ECHO_T='	';;

Error: SHELLCHECK_WARNING (CWE-156): [#def30]
/usr/share/firewalld/testsuite/integration/testsuite:493:13: warning[SC2046]: Quote this to prevent word splitting.
#  491|     *c*) ECHO_T='	';;	# ECHO_T is single tab character.
#  492|     xy)  ECHO_C='\c';;
#  493|->   *)   echo `echo ksh88 bug on AIX 6.1` > /dev/null
#  494|          ECHO_T='	';;
#  495|     esac;;

Error: SHELLCHECK_WARNING (CWE-563): [#def31]
/usr/share/firewalld/testsuite/integration/testsuite:494:8: warning[SC2034]: ECHO_T appears unused. Verify use (or export if used externally).
#  492|     xy)  ECHO_C='\c';;
#  493|     *)   echo `echo ksh88 bug on AIX 6.1` > /dev/null
#  494|->        ECHO_T='	';;
#  495|     esac;;
#  496|   *)

Error: SHELLCHECK_WARNING (CWE-563): [#def32]
/usr/share/firewalld/testsuite/integration/testsuite:497:3: warning[SC2034]: ECHO_N appears unused. Verify use (or export if used externally).
#  495|     esac;;
#  496|   *)
#  497|->   ECHO_N='-n';;
#  498|   esac
#  499|   

Error: SHELLCHECK_WARNING (CWE-563): [#def33]
/usr/share/firewalld/testsuite/integration/testsuite:503:1: warning[SC2034]: as_echo appears unused. Verify use (or export if used externally).
#  501|   # the shell variables $as_echo and $as_echo_n.  New code should use
#  502|   # AS_ECHO(["message"]) and AS_ECHO_N(["message"]), respectively.
#  503|-> as_echo='printf %s\n'
#  504|   as_echo_n='printf %s'
#  505|   

Error: SHELLCHECK_WARNING (CWE-563): [#def34]
/usr/share/firewalld/testsuite/integration/testsuite:504:1: warning[SC2034]: as_echo_n appears unused. Verify use (or export if used externally).
#  502|   # AS_ECHO(["message"]) and AS_ECHO_N(["message"]), respectively.
#  503|   as_echo='printf %s\n'
#  504|-> as_echo_n='printf %s'
#  505|   
#  506|   rm -f conf$$ conf$$.exe conf$$.file

Error: SHELLCHECK_WARNING (CWE-456): [#def35]
/usr/share/firewalld/testsuite/integration/testsuite:523:5: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string).
#  521|         as_ln_s='cp -pR'
#  522|     elif ln conf$$.file conf$$ 2>/dev/null; then
#  523|->     as_ln_s=ln
#  524|     else
#  525|       as_ln_s='cp -pR'

Error: SHELLCHECK_WARNING (CWE-563): [#def36]
/usr/share/firewalld/testsuite/integration/testsuite:528:3: warning[SC2034]: as_ln_s appears unused. Verify use (or export if used externally).
#  526|     fi
#  527|   else
#  528|->   as_ln_s='cp -pR'
#  529|   fi
#  530|   rm -f conf$$ conf$$.exe conf$$.dir/conf$$.file conf$$.file

Error: SHELLCHECK_WARNING (CWE-563): [#def37]
/usr/share/firewalld/testsuite/integration/testsuite:540:1: warning[SC2034]: as_test_x appears unused. Verify use (or export if used externally).
#  538|   fi
#  539|   
#  540|-> as_test_x='test -x'
#  541|   as_executable_p=as_fn_executable_p
#  542|   

Error: SHELLCHECK_WARNING (CWE-563): [#def38]
/usr/share/firewalld/testsuite/integration/testsuite:541:1: warning[SC2034]: as_executable_p appears unused. Verify use (or export if used externally).
#  539|   
#  540|   as_test_x='test -x'
#  541|-> as_executable_p=as_fn_executable_p
#  542|   
#  543|   # Sed expression to map a string onto a valid CPP name.

Error: SHELLCHECK_WARNING (CWE-563): [#def39]
/usr/share/firewalld/testsuite/integration/testsuite:545:1: warning[SC2034]: as_tr_cpp appears unused. Verify use (or export if used externally).
#  543|   # Sed expression to map a string onto a valid CPP name.
#  544|   as_sed_cpp="y%*$as_cr_letters%P$as_cr_LETTERS%;s%[^_$as_cr_alnum]%_%g"
#  545|-> as_tr_cpp="eval sed '$as_sed_cpp'" # deprecated
#  546|   
#  547|   # Sed expression to map a string onto a valid variable name.

Error: SHELLCHECK_WARNING (CWE-563): [#def40]
/usr/share/firewalld/testsuite/integration/testsuite:549:1: warning[SC2034]: as_tr_sh appears unused. Verify use (or export if used externally).
#  547|   # Sed expression to map a string onto a valid variable name.
#  548|   as_sed_sh="y%*+%pp%;s%[^_$as_cr_alnum]%_%g"
#  549|-> as_tr_sh="eval sed '$as_sed_sh'" # deprecated
#  550|   
#  551|   

Error: SHELLCHECK_WARNING (CWE-569): [#def41]
/usr/share/firewalld/testsuite/integration/testsuite:558:13: warning[SC2124]: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
#  556|   
#  557|   # How were we run?
#  558|-> at_cli_args="$@"
#  559|   
#  560|   

Error: SHELLCHECK_WARNING (CWE-456): [#def42]
/usr/share/firewalld/testsuite/integration/testsuite:712:2: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string).
#  710|       --trace | -x )
#  711|   	at_traceon='set -x'
#  712|-> 	at_trace_echo=echo
#  713|   	at_check_filter_trace=at_fn_filter_trace
#  714|   	;;

Error: SHELLCHECK_WARNING (CWE-456): [#def43]
/usr/share/firewalld/testsuite/integration/testsuite:793:6: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
#  791|   	at_save_IFS=$IFS
#  792|   	IFS=,
#  793|-> 	set X $at_optarg
#  794|   	shift
#  795|   	IFS=$at_save_IFS

Error: SHELLCHECK_WARNING (CWE-398): [#def44]
/usr/share/firewalld/testsuite/integration/testsuite:807:46: error[SC1087]: Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
#  805|   	  # It is on purpose that we match the test group titles too.
#  806|   	  at_groups_selected=`printf "%s\n" "$at_groups_selected" |
#  807|-> 	      grep -i $at_invert "^[1-9][^;]*;.*[; ]$at_keyword[ ;]"`
#  808|   	done
#  809|   	# Smash the keywords.

Error: SHELLCHECK_WARNING (CWE-398): [#def45]
/usr/share/firewalld/testsuite/integration/testsuite:826:9: warning[SC2163]: This does not export 'at_envvar'. Remove $/${} for that, or use ${var?} to quiet.
#  824|   	at_value=`printf "%s\n" "$at_optarg" | sed "s/'/'\\\\\\\\''/g"`
#  825|   	# Export now, but save eval for later and for debug scripts.
#  826|-> 	export $at_envvar
#  827|   	as_fn_append at_debug_args " $at_envvar='$at_value'"
#  828|   	;;

Error: SHELLCHECK_WARNING (CWE-480): [#def46]
/usr/share/firewalld/testsuite/integration/testsuite:874:10: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  872|     at_std=`printf '\033[m'`
#  873|   else
#  874|->   at_red= at_grn= at_lgn= at_blu= at_std=
#  875|   fi
#  876|   

Error: SHELLCHECK_WARNING (CWE-480): [#def47]
/usr/share/firewalld/testsuite/integration/testsuite:874:18: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  872|     at_std=`printf '\033[m'`
#  873|   else
#  874|->   at_red= at_grn= at_lgn= at_blu= at_std=
#  875|   fi
#  876|   

Error: SHELLCHECK_WARNING (CWE-480): [#def48]
/usr/share/firewalld/testsuite/integration/testsuite:874:26: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  872|     at_std=`printf '\033[m'`
#  873|   else
#  874|->   at_red= at_grn= at_lgn= at_blu= at_std=
#  875|   fi
#  876|   

Error: SHELLCHECK_WARNING (CWE-480): [#def49]
/usr/share/firewalld/testsuite/integration/testsuite:874:34: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  872|     at_std=`printf '\033[m'`
#  873|   else
#  874|->   at_red= at_grn= at_lgn= at_blu= at_std=
#  875|   fi
#  876|   

Error: SHELLCHECK_WARNING (CWE-563): [#def50]
/usr/share/firewalld/testsuite/integration/testsuite:996:1: warning[SC2034]: at_banner_text_1 appears unused. Verify use (or export if used externally).
#  994|   # Banner 1. networkmanager.at:1
#  995|   # Category starts at test group 1.
#  996|-> at_banner_text_1="NetworkManager"
#  997|   # Banner 2. polkit.at:1
#  998|   # Category starts at test group 5.

Error: SHELLCHECK_WARNING (CWE-563): [#def51]
/usr/share/firewalld/testsuite/integration/testsuite:999:1: warning[SC2034]: at_banner_text_2 appears unused. Verify use (or export if used externally).
#  997|   # Banner 2. polkit.at:1
#  998|   # Category starts at test group 5.
#  999|-> at_banner_text_2="polkit"
# 1000|   # Banner 3. dbus.at:1
# 1001|   # Category starts at test group 8.

Error: SHELLCHECK_WARNING (CWE-563): [#def52]
/usr/share/firewalld/testsuite/integration/testsuite:1002:1: warning[SC2034]: at_banner_text_3 appears unused. Verify use (or export if used externally).
# 1000|   # Banner 3. dbus.at:1
# 1001|   # Category starts at test group 8.
# 1002|-> at_banner_text_3="dbus"
# 1003|   # Banner 4. failsafe.at:1
# 1004|   # Category starts at test group 9.

Error: SHELLCHECK_WARNING (CWE-563): [#def53]
/usr/share/firewalld/testsuite/integration/testsuite:1005:1: warning[SC2034]: at_banner_text_4 appears unused. Verify use (or export if used externally).
# 1003|   # Banner 4. failsafe.at:1
# 1004|   # Category starts at test group 9.
# 1005|-> at_banner_text_4="startup failsafe"
# 1006|   # Banner 5. podman.at:1
# 1007|   # Category starts at test group 10.

Error: SHELLCHECK_WARNING (CWE-563): [#def54]
/usr/share/firewalld/testsuite/integration/testsuite:1008:1: warning[SC2034]: at_banner_text_5 appears unused. Verify use (or export if used externally).
# 1006|   # Banner 5. podman.at:1
# 1007|   # Category starts at test group 10.
# 1008|-> at_banner_text_5="podman"
# 1009|   
# 1010|   # Take any -C into account.

Error: SHELLCHECK_WARNING (CWE-457): [#def55]
/usr/share/firewalld/testsuite/integration/testsuite:1032:13: warning[SC2154]: at_top_srcdir is referenced but not assigned.
# 1030|   # atconfig delivers names relative to the directory the test suite is
# 1031|   # in, but the groups themselves are run in testsuite-dir/group-dir.
# 1032|-> if test -n "$at_top_srcdir"; then
# 1033|     builddir=../..
# 1034|     for at_dir_var in srcdir top_srcdir top_build_prefix

Error: SHELLCHECK_WARNING (CWE-563): [#def56]
/usr/share/firewalld/testsuite/integration/testsuite:1033:3: warning[SC2034]: builddir appears unused. Verify use (or export if used externally).
# 1031|   # in, but the groups themselves are run in testsuite-dir/group-dir.
# 1032|   if test -n "$at_top_srcdir"; then
# 1033|->   builddir=../..
# 1034|     for at_dir_var in srcdir top_srcdir top_build_prefix
# 1035|     do

Error: SHELLCHECK_WARNING (CWE-457): [#def57]
/usr/share/firewalld/testsuite/integration/testsuite:1037:10: warning[SC2154]: at_val is referenced but not assigned (did you mean 'as_val'?).
# 1035|     do
# 1036|       eval at_val=\$at_$at_dir_var
# 1037|->     case $at_val in
# 1038|         [\\/$]* | ?:[\\/]* ) at_prefix= ;;
# 1039|         *) at_prefix=../../ ;;

Error: SHELLCHECK_WARNING (CWE-563): [#def58]
/usr/share/firewalld/testsuite/integration/testsuite:1039:10: warning[SC2034]: at_prefix appears unused. Verify use (or export if used externally).
# 1037|       case $at_val in
# 1038|         [\\/$]* | ?:[\\/]* ) at_prefix= ;;
# 1039|->       *) at_prefix=../../ ;;
# 1040|       esac
# 1041|       eval "$at_dir_var=\$at_prefix\$at_val"

Error: SHELLCHECK_WARNING (CWE-691): [#def59]
/usr/share/firewalld/testsuite/integration/testsuite:1154:3: warning[SC2254]: Quote expansions in case patterns to match literally rather than as a glob.
# 1152|   case $PATH_SEPARATOR$at_new_path$PATH_SEPARATOR in
# 1153|     *$PATH_SEPARATOR$as_dir$PATH_SEPARATOR*) ;;
# 1154|->   $PATH_SEPARATOR$PATH_SEPARATOR) at_new_path=$as_dir ;;
# 1155|     *) as_fn_append at_new_path "$PATH_SEPARATOR$as_dir" ;;
# 1156|   esac

Error: SHELLCHECK_WARNING (CWE-457): [#def60]
/usr/share/firewalld/testsuite/integration/testsuite:1261:10: warning[SC2154]: at_banner_text is referenced but not assigned (did you mean 'at_banner_text_1'?).
# 1259|     $at_print_banners || return 0
# 1260|     eval at_banner_text=\$at_banner_text_$1
# 1261|->   test "x$at_banner_text" = "x " && return 0
# 1262|     eval "at_banner_text_$1=\" \""
# 1263|     if test -z "$at_banner_text"; then

Error: SHELLCHECK_WARNING (CWE-691): [#def61]
/usr/share/firewalld/testsuite/integration/testsuite:1353:5: warning[SC2254]: Quote expansions in case patterns to match literally rather than as a glob.
# 1351|   {
# 1352|     case $2 in
# 1353|->     $1 ) ;;
# 1354|       77) echo 77 > "$at_status_file"; exit 77;;
# 1355|       99) echo 99 > "$at_status_file"; at_failed=:

Error: SHELLCHECK_WARNING (CWE-457): [#def62]
/usr/share/firewalld/testsuite/integration/testsuite:1378:8: warning[SC2154]: at_sed is referenced but not assigned (did you mean 'at_red'?).
# 1376|   {
# 1377|     eval at_sed=\$at_sed$1
# 1378|->   sed "$at_sed" "$at_myself" > "$at_test_source"
# 1379|   }
# 1380|   

Error: SHELLCHECK_WARNING (CWE-569): [#def63]
/usr/share/firewalld/testsuite/integration/testsuite:1419:3: warning[SC2188]: This redirection doesn't have a command. Move to its command (or use 'true' as no-op).
# 1417|   else
# 1418|     at_devnull=$at_suite_dir/devnull
# 1419|->   >"$at_devnull"
# 1420|   fi
# 1421|   

Error: SHELLCHECK_WARNING (CWE-456): [#def64]
/usr/share/firewalld/testsuite/integration/testsuite:1427:3: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string).
# 1425|     at_diff='diff -u'
# 1426|   else
# 1427|->   at_diff=diff
# 1428|   fi
# 1429|   

Error: SHELLCHECK_WARNING (CWE-456): [#def65]
/usr/share/firewalld/testsuite/integration/testsuite:1450:5: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1448|   
# 1449|   # Set number of jobs for '-j'; avoid more jobs than test groups.
# 1450|-> set X $at_groups; shift; at_max_jobs=$#
# 1451|   if test $at_max_jobs -eq 0; then
# 1452|     at_jobs=1

Error: SHELLCHECK_WARNING (CWE-252): [#def66]
/usr/share/firewalld/testsuite/integration/testsuite:1497:3: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
# 1495|   
# 1496|     # Be sure to come back to the top test directory.
# 1497|->   cd "$at_suite_dir"
# 1498|   
# 1499|     # Clearly separate the test groups when verbose.

Error: SHELLCHECK_WARNING (CWE-398): [#def67]
/usr/share/firewalld/testsuite/integration/testsuite:1522:10: warning[SC2115]: Use "${var:?}" to ensure this never expands to /* .
# 1520|   then
# 1521|     find "$at_group_dir" -type d ! -perm -700 -exec chmod u+rwx {} \;
# 1522|->   rm -fr "$at_group_dir"/* "$at_group_dir"/.[!.] "$at_group_dir"/.??*
# 1523|   fi ||
# 1524|       { printf "%s\n" "$as_me:${as_lineno-$LINENO}: WARNING: test directory for $at_group_normalized could not be cleaned" >&5

Error: SHELLCHECK_WARNING (CWE-252): [#def68]
/usr/share/firewalld/testsuite/integration/testsuite:1566:3: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
# 1564|     # Be sure to come back to the suite directory, in particular
# 1565|     # since below we might 'rm' the group directory we are in currently.
# 1566|->   cd "$at_suite_dir"
# 1567|   
# 1568|     if test ! -f "$at_check_line_file"; then

Error: SHELLCHECK_WARNING (CWE-457): [#def69]
/usr/share/firewalld/testsuite/integration/testsuite:1678:8: warning[SC2154]: at_pgid is referenced but not assigned.
# 1676|   
# 1677|   for at_signal in 1 2 15; do
# 1678|->   trap 'set +x; set +e
# 1679|   	$at_job_control_off
# 1680|   	at_signal='"$at_signal"'

Error: SHELLCHECK_WARNING (CWE-457): [#def70]
/usr/share/firewalld/testsuite/integration/testsuite:1678:8: warning[SC2154]: at_pgids is referenced but not assigned.
# 1676|   
# 1677|   for at_signal in 1 2 15; do
# 1678|->   trap 'set +x; set +e
# 1679|   	$at_job_control_off
# 1680|   	at_signal='"$at_signal"'

Error: SHELLCHECK_WARNING (CWE-457): [#def71]
/usr/share/firewalld/testsuite/integration/testsuite:1678:8: warning[SC2154]: at_signame is referenced but not assigned (did you mean 'at_signal'?).
# 1676|   
# 1677|   for at_signal in 1 2 15; do
# 1678|->   trap 'set +x; set +e
# 1679|   	$at_job_control_off
# 1680|   	at_signal='"$at_signal"'

Error: SHELLCHECK_WARNING (CWE-457): [#def72]
/usr/share/firewalld/testsuite/integration/testsuite:1678:8: warning[SC2154]: exit_status is referenced but not assigned.
# 1676|   
# 1677|   for at_signal in 1 2 15; do
# 1678|->   trap 'set +x; set +e
# 1679|   	$at_job_control_off
# 1680|   	at_signal='"$at_signal"'

Error: SHELLCHECK_WARNING (CWE-398): [#def73]
/usr/share/firewalld/testsuite/integration/testsuite:1707:52: error[SC2173]: SIGKILL/SIGSTOP can not be trapped.
# 1705|        rm -f "$at_job_fifo" &&
# 1706|        test -n "$at_job_group" &&
# 1707|->      ( mkfifo "$at_job_fifo" && trap 'exit 1' PIPE STOP TSTP ) 2>/dev/null
# 1708|   then
# 1709|     # FIFO job dispatcher.

Error: SHELLCHECK_WARNING (CWE-457): [#def74]
/usr/share/firewalld/testsuite/integration/testsuite:1711:8: warning[SC2154]: at_pid is referenced but not assigned.
# 1709|     # FIFO job dispatcher.
# 1710|   
# 1711|->   trap 'at_pids=
# 1712|   	for at_pid in `jobs -p`; do
# 1713|   	  at_pids="$at_pids $at_job_group$at_pid"

Error: SHELLCHECK_WARNING (CWE-457): [#def75]
/usr/share/firewalld/testsuite/integration/testsuite:1711:8: warning[SC2154]: at_pids is referenced but not assigned.
# 1709|     # FIFO job dispatcher.
# 1710|   
# 1711|->   trap 'at_pids=
# 1712|   	for at_pid in `jobs -p`; do
# 1713|   	  at_pids="$at_pids $at_job_group$at_pid"

Error: SHELLCHECK_WARNING (CWE-457): [#def76]
/usr/share/firewalld/testsuite/integration/testsuite:1711:8: warning[SC2154]: at_sig is referenced but not assigned.
# 1709|     # FIFO job dispatcher.
# 1710|   
# 1711|->   trap 'at_pids=
# 1712|   	for at_pid in `jobs -p`; do
# 1713|   	  at_pids="$at_pids $at_job_group$at_pid"

Error: SHELLCHECK_WARNING (CWE-456): [#def77]
/usr/share/firewalld/testsuite/integration/testsuite:1727:7: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1725|     at_joblist=`printf "%s\n" "$at_groups" | sed -n 1,${at_jobs}p`
# 1726|   
# 1727|->   set X $at_joblist
# 1728|     shift
# 1729|     for at_group in $at_groups; do

Error: SHELLCHECK_WARNING (CWE-456): [#def78]
/usr/share/firewalld/testsuite/integration/testsuite:1764:11: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1762|       if test $# -gt 0; then :; else
# 1763|         read at_token <&6 || break
# 1764|->       set x $*
# 1765|       fi
# 1766|       test -f "$at_stop_file" && break

Error: SHELLCHECK_WARNING (CWE-569): [#def79]
/usr/share/firewalld/testsuite/integration/testsuite:1764:13: warning[SC2048]: Use "$@" (with quotes) to prevent whitespace problems.
# 1762|       if test $# -gt 0; then :; else
# 1763|         read at_token <&6 || break
# 1764|->       set x $*
# 1765|       fi
# 1766|       test -f "$at_stop_file" && break

Error: SHELLCHECK_WARNING (CWE-456): [#def80]
/usr/share/firewalld/testsuite/integration/testsuite:1770:7: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1768|     exec 7>&-
# 1769|     # Read back the remaining ($at_jobs - 1) tokens.
# 1770|->   set X $at_joblist
# 1771|     shift
# 1772|     if test $# -gt 0; then

Error: SHELLCHECK_WARNING (CWE-563): [#def81]
/usr/share/firewalld/testsuite/integration/testsuite:1774:5: warning[SC2034]: at_job appears unused. Verify use (or export if used externally).
# 1772|     if test $# -gt 0; then
# 1773|       shift
# 1774|->     for at_job
# 1775|       do
# 1776|         read at_token

Error: SHELLCHECK_WARNING (CWE-563): [#def82]
/usr/share/firewalld/testsuite/integration/testsuite:1776:12: warning[SC2034]: at_token appears unused. Verify use (or export if used externally).
# 1774|       for at_job
# 1775|       do
# 1776|->       read at_token
# 1777|       done <&6
# 1778|     fi

Error: SHELLCHECK_WARNING (CWE-252): [#def83]
/usr/share/firewalld/testsuite/integration/testsuite:1799:1: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
# 1797|   
# 1798|   # Wrap up the test suite with summary statistics.
# 1799|-> cd "$at_helper_dir"
# 1800|   
# 1801|   # Use ?..???? when the list must remain sorted, the faster * otherwise.

Error: SHELLCHECK_WARNING (CWE-456): [#def84]
/usr/share/firewalld/testsuite/integration/testsuite:1810:5: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1808|   		echo $f; done | sed '/?/d; s,/fail,,'`
# 1809|   
# 1810|-> set X $at_pass_list $at_xpass_list $at_xfail_list $at_fail_list $at_skip_list
# 1811|   shift; at_group_count=$#
# 1812|   set X $at_xpass_list; shift; at_xpass_count=$#; at_xpass_list=$*

Error: SHELLCHECK_WARNING (CWE-456): [#def85]
/usr/share/firewalld/testsuite/integration/testsuite:1812:5: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1810|   set X $at_pass_list $at_xpass_list $at_xfail_list $at_fail_list $at_skip_list
# 1811|   shift; at_group_count=$#
# 1812|-> set X $at_xpass_list; shift; at_xpass_count=$#; at_xpass_list=$*
# 1813|   set X $at_xfail_list; shift; at_xfail_count=$#
# 1814|   set X $at_fail_list; shift; at_fail_count=$#; at_fail_list=$*

Error: SHELLCHECK_WARNING (CWE-456): [#def86]
/usr/share/firewalld/testsuite/integration/testsuite:1813:5: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1811|   shift; at_group_count=$#
# 1812|   set X $at_xpass_list; shift; at_xpass_count=$#; at_xpass_list=$*
# 1813|-> set X $at_xfail_list; shift; at_xfail_count=$#
# 1814|   set X $at_fail_list; shift; at_fail_count=$#; at_fail_list=$*
# 1815|   set X $at_skip_list; shift; at_skip_count=$#

Error: SHELLCHECK_WARNING (CWE-456): [#def87]
/usr/share/firewalld/testsuite/integration/testsuite:1814:5: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1812|   set X $at_xpass_list; shift; at_xpass_count=$#; at_xpass_list=$*
# 1813|   set X $at_xfail_list; shift; at_xfail_count=$#
# 1814|-> set X $at_fail_list; shift; at_fail_count=$#; at_fail_list=$*
# 1815|   set X $at_skip_list; shift; at_skip_count=$#
# 1816|   

Error: SHELLCHECK_WARNING (CWE-456): [#def88]
/usr/share/firewalld/testsuite/integration/testsuite:1815:5: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
# 1813|   set X $at_xfail_list; shift; at_xfail_count=$#
# 1814|   set X $at_fail_list; shift; at_fail_count=$#; at_fail_list=$*
# 1815|-> set X $at_skip_list; shift; at_skip_count=$#
# 1816|   
# 1817|   as_fn_arith $at_group_count - $at_skip_count && at_run_count=$as_val

Error: SHELLCHECK_WARNING (CWE-252): [#def89]
/usr/share/firewalld/testsuite/integration/testsuite:1822:1: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
# 1820|   
# 1821|   # Back to the top directory.
# 1822|-> cd "$at_dir"
# 1823|   rm -rf "$at_helper_dir"
# 1824|   

Error: SHELLCHECK_WARNING: [#def90]
/usr/share/firewalld/testsuite/integration/testsuite:2044:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 2042|       fi
# 2043|       if test "$ULIMIT_VAL" -ne 0 ; then
# 2044|->         ulimit -d "$ULIMIT_VAL"
# 2045|       fi
# 2046|   

Error: SHELLCHECK_WARNING (CWE-457): [#def91]
/usr/share/firewalld/testsuite/integration/testsuite:2049:16: warning[SC2154]: at_srcdir is referenced but not assigned.
# 2047|           if test "x${FIREWALLD_DEFAULT_CONFIG}" != x ; then
# 2048|           { set +x
# 2049|-> printf "%s\n" "$at_srcdir/rhbz1773809.at:1: if ! cp \"\${FIREWALLD_DEFAULT_CONFIG}/firewalld.conf\" ./firewalld.conf; then exit 77; fi"
# 2050|   at_fn_check_prepare_notrace 'a ${...} parameter expansion' "rhbz1773809.at:1"
# 2051|   ( $at_check_trace; if ! cp "${FIREWALLD_DEFAULT_CONFIG}/firewalld.conf" ./firewalld.conf; then exit 77; fi

Error: SHELLCHECK_WARNING: [#def92]
/usr/share/firewalld/testsuite/integration/testsuite:2747:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 2745|       fi
# 2746|       if test "$ULIMIT_VAL" -ne 0 ; then
# 2747|->         ulimit -d "$ULIMIT_VAL"
# 2748|       fi
# 2749|   

Error: SHELLCHECK_WARNING: [#def93]
/usr/share/firewalld/testsuite/integration/testsuite:3327:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 3325|       fi
# 3326|       if test "$ULIMIT_VAL" -ne 0 ; then
# 3327|->         ulimit -d "$ULIMIT_VAL"
# 3328|       fi
# 3329|   

Error: SHELLCHECK_WARNING: [#def94]
/usr/share/firewalld/testsuite/integration/testsuite:3842:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 3840|       fi
# 3841|       if test "$ULIMIT_VAL" -ne 0 ; then
# 3842|->         ulimit -d "$ULIMIT_VAL"
# 3843|       fi
# 3844|   

Error: SHELLCHECK_WARNING: [#def95]
/usr/share/firewalld/testsuite/integration/testsuite:4458:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 4456|       fi
# 4457|       if test "$ULIMIT_VAL" -ne 0 ; then
# 4458|->         ulimit -d "$ULIMIT_VAL"
# 4459|       fi
# 4460|   

Error: SHELLCHECK_WARNING: [#def96]
/usr/share/firewalld/testsuite/integration/testsuite:5100:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 5098|       fi
# 5099|       if test "$ULIMIT_VAL" -ne 0 ; then
# 5100|->         ulimit -d "$ULIMIT_VAL"
# 5101|       fi
# 5102|   

Error: SHELLCHECK_WARNING: [#def97]
/usr/share/firewalld/testsuite/integration/testsuite:5742:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 5740|       fi
# 5741|       if test "$ULIMIT_VAL" -ne 0 ; then
# 5742|->         ulimit -d "$ULIMIT_VAL"
# 5743|       fi
# 5744|   

Error: SHELLCHECK_WARNING: [#def98]
/usr/share/firewalld/testsuite/integration/testsuite:6306:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 6304|       fi
# 6305|       if test "$ULIMIT_VAL" -ne 0 ; then
# 6306|->         ulimit -d "$ULIMIT_VAL"
# 6307|       fi
# 6308|   

Error: SHELLCHECK_WARNING: [#def99]
/usr/share/firewalld/testsuite/integration/testsuite:6776:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 6774|       fi
# 6775|       if test "$ULIMIT_VAL" -ne 0 ; then
# 6776|->         ulimit -d "$ULIMIT_VAL"
# 6777|       fi
# 6778|   

Error: SHELLCHECK_WARNING: [#def100]
/usr/share/firewalld/testsuite/integration/testsuite:7249:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 7247|       fi
# 7248|       if test "$ULIMIT_VAL" -ne 0 ; then
# 7249|->         ulimit -d "$ULIMIT_VAL"
# 7250|       fi
# 7251|   

Error: SHELLCHECK_WARNING (CWE-156): [#def101]
/usr/share/firewalld/testsuite/integration/testsuite:7569:6: warning[SC2046]: Quote this to prevent word splitting.
# 7567|       test $pid -eq 0 || { kill -9 $pid; sleep 3; }
# 7568|   
# 7569|-> test $(basename ${PODMAN}) = "podman" && {
# 7570|       podman network reload --all
# 7571|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def102]
/usr/share/firewalld/testsuite/integration/testsuite:7572:6: warning[SC2046]: Quote this to prevent word splitting.
# 7570|       podman network reload --all
# 7571|   }
# 7572|-> test $(basename ${PODMAN}) = "docker" && {
# 7573|       systemctl restart docker
# 7574|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def103]
/usr/share/firewalld/testsuite/integration/testsuite:8071:92: warning[SC2046]: Quote this to prevent word splitting.
# 8069|   
# 8070|   
# 8071|-> pod_address=$($PODMAN inspect -f '{{range.NetworkSettings.Networks}}{{.IPAddress}}{{end}}' $(cat ./pod_name))
# 8072|   
# 8073|   

Error: SHELLCHECK_WARNING: [#def104]
/usr/share/firewalld/testsuite/integration/testsuite:8188:16: warning[SC3045]: In POSIX sh, ulimit -d is undefined.
# 8186|       fi
# 8187|       if test "$ULIMIT_VAL" -ne 0 ; then
# 8188|->         ulimit -d "$ULIMIT_VAL"
# 8189|       fi
# 8190|   

Error: SHELLCHECK_WARNING (CWE-156): [#def105]
/usr/share/firewalld/testsuite/integration/testsuite:8508:6: warning[SC2046]: Quote this to prevent word splitting.
# 8506|       test $pid -eq 0 || { kill -9 $pid; sleep 3; }
# 8507|   
# 8508|-> test $(basename ${PODMAN}) = "podman" && {
# 8509|       podman network reload --all
# 8510|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def106]
/usr/share/firewalld/testsuite/integration/testsuite:8511:6: warning[SC2046]: Quote this to prevent word splitting.
# 8509|       podman network reload --all
# 8510|   }
# 8511|-> test $(basename ${PODMAN}) = "docker" && {
# 8512|       systemctl restart docker
# 8513|   }

Error: SHELLCHECK_WARNING (CWE-563): [#def107]
/usr/share/firewalld/testsuite/integration/testsuite:8530:5: warning[SC2034]: I appears unused. Verify use (or export if used externally).
# 8528|           WANTED_CODE=""
# 8529|       up=0
# 8530|->     for I in $(seq 60); do
# 8531|               firewall-cmd --state
# 8532|           RC=$?

Scan Properties