Fixed findings

List of Findings

Error: CPPCHECK_WARNING (CWE-457): [#def1]
gdm-46.2-build/gdm-46.2/chooser/gdm-host-chooser-widget.c:251: error[uninitvar]: Uninitialized variable: clnt_ss
#  249|           ss_len = (int) sizeof (clnt_ss);
#  250|   
#  251|->         res = XdmcpFill (widget->socket_fd, &buf, (XdmcpNetaddr)&clnt_ss, &ss_len);
#  252|           if G_UNLIKELY (! res) {
#  253|                   g_debug (_("XDMCP: Could not create XDMCP buffer!"));

Error: GCC_ANALYZER_WARNING (CWE-688): [#def2]
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c: scope_hint: In function ‘gdm_xdmcp_send_willing’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:838:25: warning[-Wanalyzer-null-argument]: use of NULL ‘status.data’ where non-null expected
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:46: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1251:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:2958:12: note: in expansion of macro ‘G_UNLIKELY’
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1251:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:2964:12: note: in expansion of macro ‘G_UNLIKELY’
/usr/include/glib-2.0/glib/gmacros.h:1243:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1251:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:2969:12: note: in expansion of macro ‘G_UNLIKELY’
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1251:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:2969:12: note: in expansion of macro ‘G_UNLIKELY’
/usr/include/glib-2.0/glib.h:64: included_from: Included from here.
/usr/include/glib-2.0/glib/gmessages.h:370:32: note: in definition of macro ‘g_debug’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c: scope_hint: In function ‘gdm_xdmcp_send_willing’
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1251:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:1036:12: note: in expansion of macro ‘G_UNLIKELY’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c: scope_hint: In function ‘gdm_xdmcp_send_willing’
/usr/include/glib-2.0/glib/gmessages.h:370:32: note: in definition of macro ‘g_debug’
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:835:41: note: in expansion of macro ‘g_strdup’
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c: scope_hint: In function ‘gdm_xdmcp_send_willing’
<built-in>: note: argument 1 of ‘__builtin_strlen’ must be non-null
#  836|           }
#  837|   
#  838|->         status.length = strlen ((char *) status.data);
#  839|   
#  840|           header.opcode   = (CARD16) WILLING;

Error: CPPCHECK_WARNING (CWE-457): [#def3]
gdm-46.2-build/gdm-46.2/daemon/gdm-xdmcp-display-factory.c:2957: error[uninitvar]: Uninitialized variable: clnt_ss
# 2955|           ss_len = (int) sizeof (clnt_ss);
# 2956|   
# 2957|->         res = XdmcpFill (factory->socket_fd, &factory->buf, (XdmcpNetaddr)&clnt_ss, &ss_len);
# 2958|           if G_UNLIKELY (! res) {
# 2959|                   g_debug ("GdmXdmcpDisplayFactory: Could not create XDMCP buffer!");

Error: COMPILER_WARNING (CWE-477): [#def4]
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c: scope_hint: In function ‘screenshot_grab_lock’
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:77:9: warning[-Wdeprecated-declarations]: ‘gdk_pointer_grab’ is deprecated: Use 'gdk_device_grab' instead
#   77 |         gdk_pointer_grab (gtk_widget_get_window (selection_window), FALSE, 0, NULL,
#      |         ^~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdk.h:50: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:30: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkmain.h:86:15: note: declared here
#   86 | GdkGrabStatus gdk_pointer_grab       (GdkWindow    *window,
#      |               ^~~~~~~~~~~~~~~~
#   75|   
#   76|           cursor = gdk_cursor_new_for_display (gdk_display_get_default (), GDK_WATCH);
#   77|->         gdk_pointer_grab (gtk_widget_get_window (selection_window), FALSE, 0, NULL,
#   78|                             cursor, GDK_CURRENT_TIME);
#   79|           g_object_unref (cursor);

Error: COMPILER_WARNING (CWE-477): [#def5]
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:85:9: warning[-Wdeprecated-declarations]: ‘gdk_flush’ is deprecated: Use 'gdk_display_flush' instead
#   85 |         gdk_flush ();
#      |         ^~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:124:6: note: declared here
#  124 | void gdk_flush (void);
#      |      ^~~~~~~~~
#   83|    out:
#   84|           XUngrabServer (GDK_DISPLAY_XDISPLAY (gdk_display_get_default ()));
#   85|->         gdk_flush ();
#   86|   
#   87|           return result;

Error: COMPILER_WARNING (CWE-477): [#def6]
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c: scope_hint: In function ‘screenshot_release_lock’
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:98:9: warning[-Wdeprecated-declarations]: ‘gdk_flush’ is deprecated: Use 'gdk_display_flush' instead
#   98 |         gdk_flush ();
#      |         ^~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:124:6: note: declared here
#  124 | void gdk_flush (void);
#      |      ^~~~~~~~~
#   96|                   selection_window = NULL;
#   97|           }
#   98|->         gdk_flush ();
#   99|   }
#  100|   

Error: COMPILER_WARNING (CWE-477): [#def7]
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c: scope_hint: In function ‘screenshot_get_pixbuf’
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:140:9: warning[-Wdeprecated-declarations]: ‘gdk_screen_width’ is deprecated
#  140 |         if (x_orig + width > gdk_screen_width ()) {
#      |         ^~
/usr/include/gtk-3.0/gdk/gdkmain.h:108:6: note: declared here
#  108 | gint gdk_screen_width  (void) G_GNUC_CONST;
#      |      ^~~~~~~~~~~~~~~~
#  138|           }
#  139|   
#  140|->         if (x_orig + width > gdk_screen_width ()) {
#  141|                   width = gdk_screen_width () - x_orig;
#  142|           }

Error: COMPILER_WARNING (CWE-477): [#def8]
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:141:17: warning[-Wdeprecated-declarations]: ‘gdk_screen_width’ is deprecated
#  141 |                 width = gdk_screen_width () - x_orig;
#      |                 ^~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:108:6: note: declared here
#  108 | gint gdk_screen_width  (void) G_GNUC_CONST;
#      |      ^~~~~~~~~~~~~~~~
#  139|   
#  140|           if (x_orig + width > gdk_screen_width ()) {
#  141|->                 width = gdk_screen_width () - x_orig;
#  142|           }
#  143|           if (y_orig + height > gdk_screen_height ()) {

Error: COMPILER_WARNING (CWE-477): [#def9]
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:143:9: warning[-Wdeprecated-declarations]: ‘gdk_screen_height’ is deprecated
#  143 |         if (y_orig + height > gdk_screen_height ()) {
#      |         ^~
/usr/include/gtk-3.0/gdk/gdkmain.h:110:6: note: declared here
#  110 | gint gdk_screen_height (void) G_GNUC_CONST;
#      |      ^~~~~~~~~~~~~~~~~
#  141|                   width = gdk_screen_width () - x_orig;
#  142|           }
#  143|->         if (y_orig + height > gdk_screen_height ()) {
#  144|                   height = gdk_screen_height () - y_orig;
#  145|           }

Error: COMPILER_WARNING (CWE-477): [#def10]
gdm-46.2-build/gdm-46.2/utils/gdm-screenshot.c:144:17: warning[-Wdeprecated-declarations]: ‘gdk_screen_height’ is deprecated
#  144 |                 height = gdk_screen_height () - y_orig;
#      |                 ^~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:110:6: note: declared here
#  110 | gint gdk_screen_height (void) G_GNUC_CONST;
#      |      ^~~~~~~~~~~~~~~~~
#  142|           }
#  143|           if (y_orig + height > gdk_screen_height ()) {
#  144|->                 height = gdk_screen_height () - y_orig;
#  145|           }
#  146|   

Scan Properties