gnome-bluetooth-47.1-1.fc42

List of Findings

Error: CPPCHECK_WARNING (CWE-457): [#def1]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/lib/bluetooth-settings-widget.c:449: error[legacyUninitvar]: Uninitialized variable: mode
#  447|   
#  448|   	g_object_set_data_full (G_OBJECT (self->pairing_dialog), "name", g_strdup (name), g_free);
#  449|-> 	g_object_set_data (G_OBJECT (self->pairing_dialog), "mode", GUINT_TO_POINTER (mode));
#  450|   
#  451|   	if (confirm_pin) {

Error: COMPILER_WARNING (CWE-477): [#def2]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c: scope_hint: In function ‘handle_error’
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:144:9: warning[-Wdeprecated-declarations]: ‘gtk_widget_show’ is deprecated: Use 'gtk_widget_set_visible or gtk_window_present' instead
#  144 |         gtk_widget_show (image_status);
#      |         ^~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtkapplication.h:26: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwindow.h:32: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkaboutdialog.h:29: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:33: included_from: Included from here.
/usr/include/libadwaita-1/adwaita.h:9: included_from: Included from here.
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:31: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwidget.h:271:12: note: declared here
#  271 | void       gtk_widget_show                (GtkWidget           *widget);
#      |            ^~~~~~~~~~~~~~~
#  142|   	message = cleanup_error (error);
#  143|   
#  144|-> 	gtk_widget_show (image_status);
#  145|   	gtk_label_set_markup (GTK_LABEL (label_status), message);
#  146|   	g_clear_error (&error);

Error: COMPILER_WARNING (CWE-477): [#def3]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:153:9: warning[-Wdeprecated-declarations]: ‘gtk_dialog_set_response_sensitive’ is deprecated
#  153 |         gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, TRUE);
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkappchooserdialog.h:31: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:43: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:153:6: note: declared here
#  153 | void gtk_dialog_set_response_sensitive (GtkDialog *dialog,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  151|   	gtk_progress_bar_set_text (GTK_PROGRESS_BAR (progress), "");
#  152|   
#  153|-> 	gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, TRUE);
#  154|   }
#  155|   

Error: COMPILER_WARNING (CWE-477): [#def4]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c: scope_hint: In function ‘response_callback’
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:399:17: warning[-Wdeprecated-declarations]: ‘gtk_dialog_set_response_sensitive’ is deprecated
#  399 |                 gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, FALSE);
#      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:153:6: note: declared here
#  153 | void gtk_dialog_set_response_sensitive (GtkDialog *dialog,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  397|   	if (response == RESPONSE_RETRY) {
#  398|   		/* Reset buttons */
#  399|-> 		gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, FALSE);
#  400|   
#  401|   		/* Reset status and progress bar */

Error: COMPILER_WARNING (CWE-477): [#def5]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:405:17: warning[-Wdeprecated-declarations]: ‘gtk_widget_hide’ is deprecated: Use 'gtk_widget_set_visible' instead
#  405 |                 gtk_widget_hide (image_status);
#      |                 ^~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtkwidget.h:273:12: note: declared here
#  273 | void       gtk_widget_hide                (GtkWidget           *widget);
#      |            ^~~~~~~~~~~~~~~
#  403|   					  _("Connecting…"));
#  404|   		gtk_label_set_text (GTK_LABEL (label_status), "");
#  405|-> 		gtk_widget_hide (image_status);
#  406|   
#  407|   		/* If we have a session, we don't need to create another one. */

Error: COMPILER_WARNING (CWE-477): [#def6]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c: scope_hint: In function ‘create_window’
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:446:9: warning[-Wdeprecated-declarations]: ‘gtk_dialog_add_buttons’ is deprecated
#  446 |         gtk_dialog_add_buttons(GTK_DIALOG (dialog),
#      |         ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:148:12: note: declared here
#  148 | void       gtk_dialog_add_buttons       (GtkDialog   *dialog,
#      |            ^~~~~~~~~~~~~~~~~~~~~~
#  444|   			       "title", _("Bluetooth File Transfer"),
#  445|   			       NULL);
#  446|-> 	gtk_dialog_add_buttons(GTK_DIALOG (dialog),
#  447|   			       _("_Cancel"), GTK_RESPONSE_CANCEL,
#  448|   			       _("_Retry"), RESPONSE_RETRY,

Error: COMPILER_WARNING (CWE-477): [#def7]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:450:9: warning[-Wdeprecated-declarations]: ‘gtk_dialog_set_response_sensitive’ is deprecated
#  450 |         gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, FALSE);
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:153:6: note: declared here
#  153 | void gtk_dialog_set_response_sensitive (GtkDialog *dialog,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  448|   			       _("_Retry"), RESPONSE_RETRY,
#  449|   			       NULL);
#  450|-> 	gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, FALSE);
#  451|   	gtk_window_set_default_size(GTK_WINDOW(dialog), 400, -1);
#  452|   

Error: COMPILER_WARNING (CWE-477): [#def8]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:509:9: warning[-Wdeprecated-declarations]: ‘gtk_widget_hide’ is deprecated: Use 'gtk_widget_set_visible' instead
#  509 |         gtk_widget_hide(image_status);
#      |         ^~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtkwidget.h:273:12: note: declared here
#  273 | void       gtk_widget_hide                (GtkWidget           *widget);
#      |            ^~~~~~~~~~~~~~~
#  507|   
#  508|   	image_status = gtk_image_new_from_icon_name ("dialog-warning");
#  509|-> 	gtk_widget_hide(image_status);
#  510|   	gtk_box_append(GTK_BOX(hbox), image_status);
#  511|   

Error: COMPILER_WARNING (CWE-477): [#def9]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c: scope_hint: In function ‘on_transfer_complete’
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:658:17: warning[-Wdeprecated-declarations]: ‘gtk_dialog_get_widget_for_response’ is deprecated
#  658 |                 button = gtk_dialog_get_widget_for_response(GTK_DIALOG (dialog), GTK_RESPONSE_CANCEL);
#      |                 ^~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:160:12: note: declared here
#  160 | GtkWidget* gtk_dialog_get_widget_for_response (GtkDialog *dialog,
#      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  656|   		g_free (complete);
#  657|   
#  658|-> 		button = gtk_dialog_get_widget_for_response(GTK_DIALOG (dialog), GTK_RESPONSE_CANCEL);
#  659|   		gtk_button_set_label (GTK_BUTTON (button), _("_Close"));
#  660|   	} else {

Error: COMPILER_WARNING (CWE-477): [#def10]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c: scope_hint: In function ‘on_transfer_error’
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:668:9: warning[-Wdeprecated-declarations]: ‘gtk_widget_show’ is deprecated: Use 'gtk_widget_set_visible or gtk_window_present' instead
#  668 |         gtk_widget_show (image_status);
#      |         ^~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtkwidget.h:271:12: note: declared here
#  271 | void       gtk_widget_show                (GtkWidget           *widget);
#      |            ^~~~~~~~~~~~~~~
#  666|   on_transfer_error (void)
#  667|   {
#  668|-> 	gtk_widget_show (image_status);
#  669|   	gtk_label_set_markup (GTK_LABEL (label_status), _("There was an error"));
#  670|   

Error: COMPILER_WARNING (CWE-477): [#def11]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:671:9: warning[-Wdeprecated-declarations]: ‘gtk_dialog_set_response_sensitive’ is deprecated
#  671 |         gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, TRUE);
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:153:6: note: declared here
#  153 | void gtk_dialog_set_response_sensitive (GtkDialog *dialog,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  669|   	gtk_label_set_markup (GTK_LABEL (label_status), _("There was an error"));
#  670|   
#  671|-> 	gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), RESPONSE_RETRY, TRUE);
#  672|   
#  673|   	g_object_unref (current_transfer);

Error: COMPILER_WARNING (CWE-477): [#def12]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c: scope_hint: In function ‘show_select_dialog’
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:698:9: warning[-Wdeprecated-declarations]: ‘gtk_dialog_add_buttons’ is deprecated
#  698 |         gtk_dialog_add_buttons(GTK_DIALOG (dialog),
#      |         ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:148:12: note: declared here
#  148 | void       gtk_dialog_add_buttons       (GtkDialog   *dialog,
#      |            ^~~~~~~~~~~~~~~~~~~~~~
#  696|   			       "hide-on-close", TRUE,
#  697|   			       NULL);
#  698|-> 	gtk_dialog_add_buttons(GTK_DIALOG (dialog),
#  699|   			       _("_Cancel"), GTK_RESPONSE_CANCEL,
#  700|   			       _("Select"), GTK_RESPONSE_ACCEPT, NULL);

Error: COMPILER_WARNING (CWE-477): [#def13]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:701:9: warning[-Wdeprecated-declarations]: ‘gtk_file_chooser_set_select_multiple’ is deprecated
#  701 |         gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), TRUE);
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtk.h:130: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkfilechooser.h:98:22: note: declared here
#   98 | void                 gtk_file_chooser_set_select_multiple (GtkFileChooser       *chooser,
#      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  699|   			       _("_Cancel"), GTK_RESPONSE_CANCEL,
#  700|   			       _("Select"), GTK_RESPONSE_ACCEPT, NULL);
#  701|-> 	gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), TRUE);
#  702|   
#  703|   	button = gtk_dialog_get_widget_for_response(GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);

Error: COMPILER_WARNING (CWE-477): [#def14]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:703:9: warning[-Wdeprecated-declarations]: ‘gtk_dialog_get_widget_for_response’ is deprecated
#  703 |         button = gtk_dialog_get_widget_for_response(GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);
#      |         ^~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkdialog.h:160:12: note: declared here
#  160 | GtkWidget* gtk_dialog_get_widget_for_response (GtkDialog *dialog,
#      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  701|   	gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), TRUE);
#  702|   
#  703|-> 	button = gtk_dialog_get_widget_for_response(GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);
#  704|   	gtk_widget_add_css_class(button, "suggested-action");
#  705|   

Error: COMPILER_WARNING (CWE-477): [#def15]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:708:9: warning[-Wdeprecated-declarations]: ‘gtk_widget_show’ is deprecated: Use 'gtk_widget_set_visible or gtk_window_present' instead
#  708 |         gtk_widget_show(dialog);
#      |         ^~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtkwidget.h:271:12: note: declared here
#  271 | void       gtk_widget_show                (GtkWidget           *widget);
#      |            ^~~~~~~~~~~~~~~
#  706|   	g_signal_connect(dialog, "response", G_CALLBACK(select_dialog_response_callback), NULL);
#  707|   
#  708|-> 	gtk_widget_show(dialog);
#  709|   
#  710|   	select_dialog_mainloop = g_main_loop_new(NULL, FALSE);

Error: COMPILER_WARNING (CWE-477): [#def16]
gnome-bluetooth-47.1-build/gnome-bluetooth-47.1/sendto/main.c:717:17: warning[-Wdeprecated-declarations]: ‘gtk_file_chooser_get_files’ is deprecated
#  717 |                 selected_files = gtk_file_chooser_get_files(GTK_FILE_CHOOSER(dialog));
#      |                 ^~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkfilechooser.h:125:22: note: declared here
#  125 | GListModel *         gtk_file_chooser_get_files           (GtkFileChooser       *chooser);
#      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
#  715|   		guint i, n_items;
#  716|   
#  717|-> 		selected_files = gtk_file_chooser_get_files(GTK_FILE_CHOOSER(dialog));
#  718|   		n_items = g_list_model_get_n_items(selected_files);
#  719|   

Scan Properties