gnome-desktop3-44.1-2.fc42

List of Findings

Error: CPPCHECK_WARNING (CWE-664): [#def1]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:347: error[va_end_missing]: va_list 'args' was opened but not closed by va_end().
#  345|                   if (strcmp (l1->data, l2->data) != 0) {
#  346|                           g_list_free (stack);
#  347|->                         return FALSE;
#  348|                   }
#  349|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def2]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c: scope_hint: In function ‘handle_text’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:397:33: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
#  395|           else if (stack_is (self, "duration", "static", "background", NULL) ||
#  396|                    stack_is (self, "duration", "transition", "background", NULL)) {
#  397|->                 slide->duration = g_strtod (text, NULL);
#  398|                   self->priv->total_duration += slide->duration;
#  399|           }

Error: GCC_ANALYZER_WARNING (CWE-476): [#def3]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:412:32: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
/usr/include/glib-2.0/glib/glist.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/ghash.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:52: included_from: Included from here.
/usr/include/glib-2.0/glib/gmem.h:318:57: note: in expansion of macro ‘_G_NEW’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:408:22: note: in expansion of macro ‘g_new’
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:411:28: note: in expansion of macro ‘g_strdup’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c: scope_hint: In function ‘handle_text’
#  410|                   fs->height = -1;
#  411|                   fs->file = g_strdup (text);
#  412|->                 slide->file1 = g_slist_prepend (slide->file1, fs);
#  413|                   if (slide->file1->next != NULL)
#  414|                           self->priv->has_multiple_sizes = TRUE;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:418:27: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
#  416|           else if (stack_is (self, "size", "file", "static", "background", NULL) ||
#  417|                    stack_is (self, "size", "from", "transition", "background", NULL)) {
#  418|->                 fs = slide->file1->data;
#  419|                   fs->file = g_strdup (text);
#  420|                   if (slide->file1->next != NULL)

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:434:32: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
/usr/include/glib-2.0/glib/gmem.h:318:57: note: in expansion of macro ‘_G_NEW’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:430:22: note: in expansion of macro ‘g_new’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:433:28: note: in expansion of macro ‘g_strdup’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c: scope_hint: In function ‘handle_text’
#  432|                   fs->height = -1;
#  433|                   fs->file = g_strdup (text);
#  434|->                 slide->file2 = g_slist_prepend (slide->file2, fs);
#  435|                   if (slide->file2->next != NULL)
#  436|                           self->priv->has_multiple_sizes = TRUE;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def6]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:439:27: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
#  437|           }
#  438|           else if (stack_is (self, "size", "to", "transition", "background", NULL)) {
#  439|->                 fs = slide->file2->data;
#  440|                   fs->file = g_strdup (text);
#  441|                   if (slide->file2->next != NULL)

Error: GCC_ANALYZER_WARNING (CWE-476): [#def7]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c: scope_hint: In function ‘find_best_size’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:478:74: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘best’
#  476|                           }
#  477|   			else if (d == distance) {
#  478|-> 				if (abs (size->width - width) < abs (best->width - width)) {
#  479|   					best = size;
#  480|   				}

Error: CPPCHECK_WARNING (CWE-476): [#def8]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:488: warning[nullPointer]: Possible null pointer dereference: best
#  486|   	}
#  487|   
#  488|-> 	return best->file;
#  489|   }
#  490|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def9]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg-slide-show.c:488:20: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘best’
#  486|   	}
#  487|   
#  488|-> 	return best->file;
#  489|   }
#  490|   

Error: CPPCHECK_WARNING (CWE-664): [#def10]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:347: error[va_end_missing]: va_list 'args' was opened but not closed by va_end().
#  345|                   if (strcmp (l1->data, l2->data) != 0) {
#  346|                           g_list_free (stack);
#  347|->                         return FALSE;
#  348|                   }
#  349|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def11]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c: scope_hint: In function ‘handle_text’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:397:33: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
#  395|           else if (stack_is (self, "duration", "static", "background", NULL) ||
#  396|                    stack_is (self, "duration", "transition", "background", NULL)) {
#  397|->                 slide->duration = g_strtod (text, NULL);
#  398|                   self->priv->total_duration += slide->duration;
#  399|           }

Error: GCC_ANALYZER_WARNING (CWE-476): [#def12]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:412:32: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
/usr/include/glib-2.0/glib/glist.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/ghash.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:52: included_from: Included from here.
/usr/include/glib-2.0/glib/gmem.h:318:57: note: in expansion of macro ‘_G_NEW’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:408:22: note: in expansion of macro ‘g_new’
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:411:28: note: in expansion of macro ‘g_strdup’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c: scope_hint: In function ‘handle_text’
#  410|                   fs->height = -1;
#  411|                   fs->file = g_strdup (text);
#  412|->                 slide->file1 = g_slist_prepend (slide->file1, fs);
#  413|                   if (slide->file1->next != NULL)
#  414|                           self->priv->has_multiple_sizes = TRUE;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def13]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:418:27: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
#  416|           else if (stack_is (self, "size", "file", "static", "background", NULL) ||
#  417|                    stack_is (self, "size", "from", "transition", "background", NULL)) {
#  418|->                 fs = slide->file1->data;
#  419|                   fs->file = g_strdup (text);
#  420|                   if (slide->file1->next != NULL)

Error: GCC_ANALYZER_WARNING (CWE-476): [#def14]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:434:32: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
/usr/include/glib-2.0/glib/gmem.h:318:57: note: in expansion of macro ‘_G_NEW’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:430:22: note: in expansion of macro ‘g_new’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:433:28: note: in expansion of macro ‘g_strdup’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c: scope_hint: In function ‘handle_text’
#  432|                   fs->height = -1;
#  433|                   fs->file = g_strdup (text);
#  434|->                 slide->file2 = g_slist_prepend (slide->file2, fs);
#  435|                   if (slide->file2->next != NULL)
#  436|                           self->priv->has_multiple_sizes = TRUE;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def15]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:439:27: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘slide’
#  437|           }
#  438|           else if (stack_is (self, "size", "to", "transition", "background", NULL)) {
#  439|->                 fs = slide->file2->data;
#  440|                   fs->file = g_strdup (text);
#  441|                   if (slide->file2->next != NULL)

Error: GCC_ANALYZER_WARNING (CWE-476): [#def16]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c: scope_hint: In function ‘find_best_size’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:478:74: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘best’
#  476|                           }
#  477|   			else if (d == distance) {
#  478|-> 				if (abs (size->width - width) < abs (best->width - width)) {
#  479|   					best = size;
#  480|   				}

Error: CPPCHECK_WARNING (CWE-476): [#def17]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:488: warning[nullPointer]: Possible null pointer dereference: best
#  486|   	}
#  487|   
#  488|-> 	return best->file;
#  489|   }
#  490|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def18]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-bg/gnome-bg-slide-show.c:488:20: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘best’
#  486|   	}
#  487|   
#  488|-> 	return best->file;
#  489|   }
#  490|   

Error: GCC_ANALYZER_WARNING (CWE-688): [#def19]
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c: scope_hint: In function ‘language_name_get_codeset_details’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:310:28: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:34: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1243:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:515:9: note: in expansion of macro ‘g_return_val_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:515:9: note: in expansion of macro ‘g_return_val_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:371:9: note: in expansion of macro ‘g_return_val_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1243:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:372:9: note: in expansion of macro ‘g_return_val_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:372:9: note: in expansion of macro ‘g_return_val_if_fail’
gnome-desktop3-44.1-build/gnome-desktop-44.1/libgnome-desktop/gnome-languages.c:28: included_from: Included from here.
/usr/include/string.h:156:12: note: argument 1 of ‘strcmp’ must be non-null
#  308|                   g_autofree char *normalized_codeset = normalize_codeset (codeset);
#  309|   
#  310|->                 *is_utf8 = strcmp (normalized_codeset, "UTF-8") == 0;
#  311|           }
#  312|   

Error: COMPILER_WARNING (CWE-252): [#def20]
gnome-desktop3-44.1-build/gnome-desktop-44.1/tests/bg-slide-show.c: scope_hint: In function ‘main’
gnome-desktop3-44.1-build/gnome-desktop-44.1/tests/bg-slide-show.c:95:9: warning[-Wunused-result]: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’
#   95 |         chdir (basedir);
#      |         ^~~~~~~~~~~~~~~
#   93|   	 * slide show easily.
#   94|   	 */
#   95|-> 	chdir (basedir);
#   96|   
#   97|   	g_test_add_func ("/bg-slide-show/starttime-no-dst", test_starttime_no_dst);

Error: CPPCHECK_WARNING (CWE-682): [#def21]
gnome-desktop3-44.1-build/gnome-desktop-44.1/tests/wallclock-reftest.c:347: error[nullPointerArithmetic]: Pointer addition with NULL pointer.
#  345|         const guint32 *row_a = (const guint32 *) (buf_a + y * stride_a);
#  346|         const guint32 *row_b = (const guint32 *) (buf_b + y * stride_b);
#  347|->       guint32 *row = (guint32 *) (buf_diff + y * stride_diff);
#  348|   
#  349|         for (x = 0; x < width; x++)

Error: COMPILER_WARNING (CWE-252): [#def22]
gnome-desktop3-44.1-build/gnome-desktop-44.1/tests/wallclock-reftest.c: scope_hint: In function ‘main’
gnome-desktop3-44.1-build/gnome-desktop-44.1/tests/wallclock-reftest.c:610:3: warning[-Wunused-result]: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’
#  610 |   chdir (basedir);
#      |   ^~~~~~~~~~~~~~~
#  608|      * "file" property of GtkImage as a relative path in builder files.
#  609|      */
#  610|->   chdir (basedir);
#  611|   
#  612|     return g_test_run ();

Scan Properties