Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-670): [#def1]
gtk4-4.16.3-build/gtk-4.16.3/demos/gtk-demo/main.c: scope_hint: In function ‘activate_about’
gtk4-4.16.3-build/gtk-4.16.3/demos/gtk-demo/main.c:204:74: warning[-Wduplicated-branches]: this condition has identical branches
#  204 |                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#      |                                                                          ^
#  202|                                PACKAGE_VERSION,
#  203|                                g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
#  204|->                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#  205|                                gtk_get_major_version (),
#  206|                                gtk_get_minor_version (),

Error: COMPILER_WARNING (CWE-670): [#def2]
gtk4-4.16.3-build/gtk-4.16.3/demos/gtk-demo/main.c: scope_hint: In function ‘print_version’
gtk4-4.16.3-build/gtk-4.16.3/demos/gtk-demo/main.c:1122:56: warning[-Wduplicated-branches]: this condition has identical branches
# 1122 |            g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "");
#      |                                                        ^
# 1120|              PACKAGE_VERSION,
# 1121|              g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
# 1122|->            g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "");
# 1123|   }
# 1124|   

Error: COMPILER_WARNING (CWE-670): [#def3]
gtk4-4.16.3-build/gtk-4.16.3/demos/icon-browser/iconbrowserapp.c: scope_hint: In function ‘about_activated’
gtk4-4.16.3-build/gtk-4.16.3/demos/icon-browser/iconbrowserapp.c:83:74: warning[-Wduplicated-branches]: this condition has identical branches
#   83 |                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#      |                                                                          ^
#   81|                                PACKAGE_VERSION,
#   82|                                g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
#   83|->                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#   84|                                gtk_get_major_version (),
#   85|                                gtk_get_minor_version (),

Error: COMPILER_WARNING (CWE-670): [#def4]
gtk4-4.16.3-build/gtk-4.16.3/demos/node-editor/node-editor-application.c: scope_hint: In function ‘activate_about’
gtk4-4.16.3-build/gtk-4.16.3/demos/node-editor/node-editor-application.c:104:74: warning[-Wduplicated-branches]: this condition has identical branches
#  104 |                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#      |                                                                          ^
#  102|                                PACKAGE_VERSION,
#  103|                                g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
#  104|->                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#  105|                                gtk_get_major_version (),
#  106|                                gtk_get_minor_version (),

Error: COMPILER_WARNING (CWE-670): [#def5]
gtk4-4.16.3-build/gtk-4.16.3/demos/node-editor/node-editor-application.c: scope_hint: In function ‘print_version’
gtk4-4.16.3-build/gtk-4.16.3/demos/node-editor/node-editor-application.c:260:56: warning[-Wduplicated-branches]: this condition has identical branches
#  260 |            g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "");
#      |                                                        ^
#  258|              PACKAGE_VERSION,
#  259|              g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
#  260|->            g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "");
#  261|   }
#  262|   

Error: COMPILER_WARNING (CWE-670): [#def6]
gtk4-4.16.3-build/gtk-4.16.3/demos/print-editor/print-editor.c: scope_hint: In function ‘activate_about’
gtk4-4.16.3-build/gtk-4.16.3/demos/print-editor/print-editor.c:623:74: warning[-Wduplicated-branches]: this condition has identical branches
#  623 |                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#      |                                                                          ^
#  621|                                PACKAGE_VERSION,
#  622|                                g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
#  623|->                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#  624|                                gtk_get_major_version (),
#  625|                                gtk_get_minor_version (),

Error: COMPILER_WARNING (CWE-670): [#def7]
gtk4-4.16.3-build/gtk-4.16.3/demos/widget-factory/widget-factory.c: scope_hint: In function ‘activate_about’
gtk4-4.16.3-build/gtk-4.16.3/demos/widget-factory/widget-factory.c:338:74: warning[-Wduplicated-branches]: this condition has identical branches
#  338 |                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#      |                                                                          ^
#  336|                                PACKAGE_VERSION,
#  337|                                g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
#  338|->                              g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "",
#  339|                                gtk_get_major_version (),
#  340|                                gtk_get_minor_version (),

Error: COMPILER_WARNING (CWE-670): [#def8]
gtk4-4.16.3-build/gtk-4.16.3/demos/widget-factory/widget-factory.c: scope_hint: In function ‘print_version’
gtk4-4.16.3-build/gtk-4.16.3/demos/widget-factory/widget-factory.c:2510:56: warning[-Wduplicated-branches]: this condition has identical branches
# 2510 |            g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "");
#      |                                                        ^
# 2508|              PACKAGE_VERSION,
# 2509|              g_strcmp0 (PROFILE, "devel") == 0 ? "-" : "",
# 2510|->            g_strcmp0 (PROFILE, "devel") == 0 ? VCS_TAG : "");
# 2511|   }
# 2512|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def9]
gtk4-4.16.3-build/gtk-4.16.3/gdk/gdkglcontext.c: scope_hint: In function ‘gdk_gl_context_import_dmabuf’
gtk4-4.16.3-build/gtk-4.16.3/gdk/gdkglcontext.c:2265:7: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
# 2263|     gdk_dmabuf_egl_init (display);
# 2264|   
# 2265|->   if (gdk_dmabuf_formats_contains (display->egl_dmabuf_formats, dmabuf->fourcc, dmabuf->modifier))
# 2266|       {
# 2267|         /* This is the path for modern drivers that support modifiers */

Error: CPPCHECK_WARNING (CWE-823): [#def10]
gtk4-4.16.3-build/gtk-4.16.3/gsk/gskrendernodeparser.c:1757: error[arrayIndexOutOfBounds]: Array '"AAFF00"[7]' accessed at index 7, which is out of bounds.
# 1755|     if (stops == NULL)
# 1756|       {
# 1757|->       GskColorStop from = { 0.0, GDK_RGBA("AAFF00") };
# 1758|         GskColorStop to = { 1.0, GDK_RGBA("FF00CC") };
# 1759|   

Error: CPPCHECK_WARNING (CWE-823): [#def11]
gtk4-4.16.3-build/gtk-4.16.3/gsk/gskrendernodeparser.c:1758: error[arrayIndexOutOfBounds]: Array '"FF00CC"[7]' accessed at index 7, which is out of bounds.
# 1756|       {
# 1757|         GskColorStop from = { 0.0, GDK_RGBA("AAFF00") };
# 1758|->       GskColorStop to = { 1.0, GDK_RGBA("FF00CC") };
# 1759|   
# 1760|         stops = g_array_new (FALSE, FALSE, sizeof (GskColorStop));

Error: CPPCHECK_WARNING (CWE-823): [#def12]
gtk4-4.16.3-build/gtk-4.16.3/gsk/gskrendernodeparser.c:1815: error[arrayIndexOutOfBounds]: Array '"AAFF00"[7]' accessed at index 7, which is out of bounds.
# 1813|     if (stops == NULL)
# 1814|       {
# 1815|->       GskColorStop from = { 0.0, GDK_RGBA("AAFF00") };
# 1816|         GskColorStop to = { 1.0, GDK_RGBA("FF00CC") };
# 1817|   

Error: CPPCHECK_WARNING (CWE-823): [#def13]
gtk4-4.16.3-build/gtk-4.16.3/gsk/gskrendernodeparser.c:1816: error[arrayIndexOutOfBounds]: Array '"FF00CC"[7]' accessed at index 7, which is out of bounds.
# 1814|       {
# 1815|         GskColorStop from = { 0.0, GDK_RGBA("AAFF00") };
# 1816|->       GskColorStop to = { 1.0, GDK_RGBA("FF00CC") };
# 1817|   
# 1818|         stops = g_array_new (FALSE, FALSE, sizeof (GskColorStop));

Error: CPPCHECK_WARNING (CWE-823): [#def14]
gtk4-4.16.3-build/gtk-4.16.3/gsk/gskrendernodeparser.c:1877: error[arrayIndexOutOfBounds]: Array '"AAFF00"[7]' accessed at index 7, which is out of bounds.
# 1875|     if (stops == NULL)
# 1876|       {
# 1877|->       GskColorStop from = { 0.0, GDK_RGBA("AAFF00") };
# 1878|         GskColorStop to = { 1.0, GDK_RGBA("FF00CC") };
# 1879|   

Error: CPPCHECK_WARNING (CWE-823): [#def15]
gtk4-4.16.3-build/gtk-4.16.3/gsk/gskrendernodeparser.c:1878: error[arrayIndexOutOfBounds]: Array '"FF00CC"[7]' accessed at index 7, which is out of bounds.
# 1876|       {
# 1877|         GskColorStop from = { 0.0, GDK_RGBA("AAFF00") };
# 1878|->       GskColorStop to = { 1.0, GDK_RGBA("FF00CC") };
# 1879|   
# 1880|         stops = g_array_new (FALSE, FALSE, sizeof (GskColorStop));

Scan Properties

analyzer-version-clippy1.82.0
analyzer-version-cppcheck2.16.0
analyzer-version-gcc14.2.1
analyzer-version-gcc-analyzer15.0.0
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.82.0
diffbase-analyzer-version-cppcheck2.16.0
diffbase-analyzer-version-gcc14.2.1
diffbase-analyzer-version-gcc-analyzer15.0.0
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-19.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-gcc-latest-x86_64
diffbase-project-namegtk4-4.17.0-1.fc42
diffbase-store-results-to/tmp/tmp564nfykc/gtk4-4.17.0-1.fc42.tar.xz
diffbase-time-created2024-11-13 00:34:30
diffbase-time-finished2024-11-13 00:59:16
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmp564nfykc/gtk4-4.17.0-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmp564nfykc/gtk4-4.17.0-1.fc42.src.rpm'
diffbase-tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-19.us-west-2.compute.internal
mock-configfedora-rawhide-gcc-latest-x86_64
project-namegtk4-4.16.3-1.fc41
store-results-to/tmp/tmpw5f9i3mb/gtk4-4.16.3-1.fc41.tar.xz
time-created2024-11-13 00:08:02
time-finished2024-11-13 00:33:58
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpw5f9i3mb/gtk4-4.16.3-1.fc41.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpw5f9i3mb/gtk4-4.16.3-1.fc41.src.rpm'
tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9