Fixed findings

List of Findings

Error: COMPILER_WARNING: [#def1]
leptonica-1.84.1-build/leptonica-1.84.1/prog/blend2_reg.c:42:19: warning[-Wunused-const-variable=]: ‘fname_bmp’ defined but not used
#   42 | static const char fname_bmp[64] = "/tmp/lept/regout/blend2.14.bmp";
#      |                   ^~~~~~~~~
#   40|       /* In case libpng is not enabled */
#   41|   static const char fname_png[64] = "/tmp/lept/regout/blend2.14.png";
#   42|-> static const char fname_bmp[64] = "/tmp/lept/regout/blend2.14.bmp";
#   43|   
#   44|   

Error: COMPILER_WARNING (CWE-563): [#def2]
leptonica-1.84.1-build/leptonica-1.84.1/prog/cleanpdf.c: scope_hint: In function ‘main’
leptonica-1.84.1-build/leptonica-1.84.1/prog/cleanpdf.c:155:63: warning[-Wunused-but-set-variable]: variable ‘ret’ set but not used
#  155 | l_int32  i, n, res, contrast, rotation, opensize, render_res, ret;
#      |                                                               ^~~
#  153|   char    *basedir, *fname, *tail, *basename, *imagedir, *firstfile, *title;
#  154|   char    *fileout;
#  155|-> l_int32  i, n, res, contrast, rotation, opensize, render_res, ret;
#  156|   SARRAY  *sa;
#  157|   

Error: COMPILER_WARNING (CWE-563): [#def3]
leptonica-1.84.1-build/leptonica-1.84.1/prog/compresspdf.c: scope_hint: In function ‘main’
leptonica-1.84.1-build/leptonica-1.84.1/prog/compresspdf.c:133:65: warning[-Wunused-but-set-variable]: variable ‘ret’ set but not used
#  133 | l_int32    imres, render_res, onebit, savecolor, quality, i, n, ret;
#      |                                                                 ^~~
#  131|   char       buf[256];
#  132|   char      *basedir, *fname, *tail, *basename, *imagedir, *title, *fileout;
#  133|-> l_int32    imres, render_res, onebit, savecolor, quality, i, n, ret;
#  134|   l_float32  scalefactor;
#  135|   SARRAY    *sa;

Error: COMPILER_WARNING (CWE-563): [#def4]
leptonica-1.84.1-build/leptonica-1.84.1/prog/croppdf.c: scope_hint: In function ‘main’
leptonica-1.84.1-build/leptonica-1.84.1/prog/croppdf.c:103:30: warning[-Wunused-but-set-variable]: variable ‘ret’ set but not used
#  103 | l_int32    render_res, i, n, ret;
#      |                              ^~~
#  101|   char      *basedir, *fname, *tail, *basename, *imagedir, *title, *fileout;
#  102|   l_int32    lrclear, tbclear, edgeclean, lradd, tbadd;
#  103|-> l_int32    render_res, i, n, ret;
#  104|   l_float32  maxwiden;
#  105|   SARRAY    *sa;

Error: COMPILER_WARNING (CWE-563): [#def5]
leptonica-1.84.1-build/leptonica-1.84.1/prog/livre_makefigs.c: scope_hint: In function ‘main’
leptonica-1.84.1-build/leptonica-1.84.1/prog/livre_makefigs.c:46:10: warning[-Wunused-but-set-variable]: variable ‘ignore’ set but not used
#   46 | l_int32  ignore;
#      |          ^~~~~~
#   44|   {
#   45|   char     buf[256];
#   46|-> l_int32  ignore;
#   47|   
#   48|       if (argc != 1)

Error: COMPILER_WARNING (CWE-563): [#def6]
leptonica-1.84.1-build/leptonica-1.84.1/prog/printsplitimage.c:76:42: warning[-Wunused-but-set-variable]: variable ‘ignore’ set but not used
#   76 | l_int32      nx, ny, i, w, h, ws, hs, n, ignore, index;
#      |                                          ^~~~~~
#   74|   char        *filein, *fname, *printer;
#   75|   char         buf[512];
#   76|-> l_int32      nx, ny, i, w, h, ws, hs, n, ignore, index;
#   77|   l_float32    scale;
#   78|   FILE        *fp;

Error: COMPILER_WARNING (CWE-563): [#def7]
leptonica-1.84.1-build/leptonica-1.84.1/prog/printtiff.c: scope_hint: In function ‘main’
leptonica-1.84.1-build/leptonica-1.84.1/prog/printtiff.c:67:14: warning[-Wunused-but-set-variable]: variable ‘ret’ set but not used
#   67 | l_int32      ret;
#      |              ^~~
#   65|            char **argv)
#   66|   {
#   67|-> l_int32      ret;
#   68|   char        *filein, *tempfile, *printer;
#   69|   char         buf[512];

Error: COMPILER_WARNING (CWE-563): [#def8]
leptonica-1.84.1-build/leptonica-1.84.1/prog/splitpdf.c: scope_hint: In function ‘main’
leptonica-1.84.1-build/leptonica-1.84.1/prog/splitpdf.c:58:32: warning[-Wunused-but-set-variable]: variable ‘ret’ set but not used
#   58 | l_int32  i, n, npages, nfiles, ret, val, start, end;
#      |                                ^~~
#   56|   char    *filein, *rootname;
#   57|   char     outname[512], buffer[1024];
#   58|-> l_int32  i, n, npages, nfiles, ret, val, start, end;
#   59|   NUMA    *naeach;
#   60|   

Error: COMPILER_WARNING (CWE-563): [#def9]
leptonica-1.84.1-build/leptonica-1.84.1/prog/tiffpdftest.c: scope_hint: In function ‘main’
leptonica-1.84.1-build/leptonica-1.84.1/prog/tiffpdftest.c:48:12: warning[-Wunused-but-set-variable]: variable ‘ret’ set but not used
#   48 | l_int32    ret;
#      |            ^~~
#   46|   {
#   47|   char       buf[256];
#   48|-> l_int32    ret;
#   49|   l_float32  fract;
#   50|   PIX       *pix1, *pix2, *pix3, *pix4;

Error: COMPILER_WARNING: [#def10]
leptonica-1.84.1-build/leptonica-1.84.1/src/alltypes.h:37: included_from: Included from here.
leptonica-1.84.1-build/leptonica-1.84.1/src/allheaders.h:35: included_from: Included from here.
leptonica-1.84.1-build/leptonica-1.84.1/src/gplot.c:153: included_from: Included from here.
leptonica-1.84.1-build/leptonica-1.84.1/src/gplot.c: scope_hint: In function ‘gplotGenCommandFile’
leptonica-1.84.1-build/leptonica-1.84.1/src/environ.h:583:32: warning[-Wuse-after-free]: pointer ‘cmdstr_91’ may be used after ‘free’
#  583 |       IF_SEV(L_SEVERITY_ERROR, returnErrorInt1((a), (f), (b), (c)), \
#      |                                ^
leptonica-1.84.1-build/leptonica-1.84.1/src/environ.h:379:44: note: call to ‘free’ here
#  379 |   #define LEPT_FREE(ptr)                   free(ptr)
#      |                                            ^~~~~~~~~
#  581|   
#  582|     #define ERROR_INT_1(a, f, b, c) \
#  583|->       IF_SEV(L_SEVERITY_ERROR, returnErrorInt1((a), (f), (b), (c)), \
#  584|                (l_int32)(c))
#  585|     #define ERROR_FLOAT_1(a, f, b, c) \

Error: COMPILER_WARNING (CWE-483): [#def11]
leptonica-1.84.1-build/leptonica-1.84.1/src/partify.c: scope_hint: In function ‘boxaRemoveVGaps’
leptonica-1.84.1-build/leptonica-1.84.1/src/partify.c:306:5: warning[-Wmisleading-indentation]: this ‘if’ clause does not guard...
#  306 |     if ((nbox = boxaGetCount(boxa)) == 0);
#      |     ^~
leptonica-1.84.1-build/leptonica-1.84.1/src/partify.c:307:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
#  307 |         return ERROR_INT("boxa is empty", __func__, 1);
#      |         ^~~~~~
#  304|       if (!boxa)
#  305|           return ERROR_INT("boxa not defined", __func__, 1);
#  306|->     if ((nbox = boxaGetCount(boxa)) == 0);
#  307|           return ERROR_INT("boxa is empty", __func__, 1);
#  308|       for (i = 0; i < nbox - 1; i++) {

Error: GCC_ANALYZER_WARNING (CWE-457): [#def12]
leptonica-1.84.1-build/leptonica-1.84.1/src/selgen.c: scope_hint: In function ‘pixSubsampleBoundaryPixels.part.0’
leptonica-1.84.1-build/leptonica-1.84.1/src/selgen.c:828:15: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘xa’
#  826|           count = 0;
#  827|           while (adjacentOnPixelInRaster(pixt, x, y, &xa, &ya)) {
#  828|->             x = xa;
#  829|               y = ya;
#  830|               pixSetPixel(pixt, x, y, 0);

Error: COMPILER_WARNING (CWE-563): [#def13]
leptonica-1.84.1-build/leptonica-1.84.1/src/utils2.c: scope_hint: In function ‘callSystemDebug’
leptonica-1.84.1-build/leptonica-1.84.1/src/utils2.c:2673:10: warning[-Wunused-but-set-variable]: variable ‘ret’ set but not used
# 2673 | l_int32  ret;
#      |          ^~~
# 2671|   callSystemDebug(const char *cmd)
# 2672|   {
# 2673|-> l_int32  ret;
# 2674|   
# 2675|       if (!cmd) {

Scan Properties

analyzer-version-clippy1.82.0
analyzer-version-cppcheck2.16.0
analyzer-version-gcc14.2.1
analyzer-version-gcc-analyzer15.0.0
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.82.0
diffbase-analyzer-version-cppcheck2.16.0
diffbase-analyzer-version-gcc14.2.1
diffbase-analyzer-version-gcc-analyzer15.0.0
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-118.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-gcc-latest-x86_64
diffbase-project-nameleptonica-1.85.0-1.fc42
diffbase-store-results-to/tmp/tmpm2ws3w92/leptonica-1.85.0-1.fc42.tar.xz
diffbase-time-created2024-11-13 01:26:26
diffbase-time-finished2024-11-13 01:38:09
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpm2ws3w92/leptonica-1.85.0-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpm2ws3w92/leptonica-1.85.0-1.fc42.src.rpm'
diffbase-tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-118.us-west-2.compute.internal
mock-configfedora-rawhide-gcc-latest-x86_64
project-nameleptonica-1.84.1-4.fc41
store-results-to/tmp/tmpqqozi7hc/leptonica-1.84.1-4.fc41.tar.xz
time-created2024-11-13 01:13:24
time-finished2024-11-13 01:25:56
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpqqozi7hc/leptonica-1.84.1-4.fc41.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpqqozi7hc/leptonica-1.84.1-4.fc41.src.rpm'
tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9