librsvg2-2.59.2-1.fc42

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-688): [#def1]
librsvg2-2.59.2-build/librsvg-2.59.2/librsvg-c/tests-c/api.c: scope_hint: In function ‘load_n_bytes_at_a_time’
librsvg2-2.59.2-build/librsvg-2.59.2/librsvg-c/tests-c/api.c:1723:20: warning[-Wanalyzer-null-argument]: use of NULL ‘fopen(g_build_filename(test_utils_get_test_data_path(), *(const LoadingTestData *)data.fixture, 0), "rb")’ where non-null expected
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
librsvg2-2.59.2-build/librsvg-2.59.2/librsvg-c/tests-c/api.c:14: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:255:49: note: in expansion of macro ‘G_LIKELY’
librsvg2-2.59.2-build/librsvg-2.59.2/librsvg-c/tests-c/api.c:1714:5: note: in expansion of macro ‘g_assert_nonnull’
/usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:255:49: note: in expansion of macro ‘G_LIKELY’
librsvg2-2.59.2-build/librsvg-2.59.2/librsvg-c/tests-c/api.c:1714:5: note: in expansion of macro ‘g_assert_nonnull’
/usr/include/glib-2.0/glib.h:89: included_from: Included from here.
librsvg2-2.59.2-build/librsvg-2.59.2/librsvg-c/tests-c/api.c:1714:5: note: in expansion of macro ‘g_assert_nonnull’
librsvg2-2.59.2-build/librsvg-2.59.2/librsvg-c/tests-c/api.c:13: included_from: Included from here.
/usr/include/stdio.h:728:15: note: argument 4 of ‘fread’ must be non-null
# 1721|           size_t num_read;
# 1722|   
# 1723|->         num_read = fread (buf, 1, fixture_data->buf_size, file);
# 1724|   
# 1725|           if (num_read > 0) {

Error: CLIPPY_WARNING: [#def2]
librsvg2-2.59.2-build/rsvg/src/document.rs:615:15: warning: unexpected `cfg` condition value: `avif`
#      |
#  615 |         #[cfg(feature = "avif")]
#      |               ^^^^^^^^^^^^^^^^
#      |
#      = note: expected values for `feature` are: `capi`, `test-utils`, and `yeslogic-fontconfig-sys`
#      = help: consider adding `avif` as a feature in `Cargo.toml`
#      = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
#      = note: requested on the command line with `-W unexpected-cfgs`

Error: CLIPPY_WARNING: [#def3]
librsvg2-2.59.2-build/rsvg/src/surface_utils/mod.rs:146:18: warning: use of deprecated method `rgb::legacy::internal::rgba::<impl rgb::Rgba<T, A>>::map_rgb`: Renamed to map_colors()
#      |
#  146 |             self.map_rgb(|x| ((f32::from(x) / alpha) + 0.5) as u8)
#      |                  ^^^^^^^
#      |
#      = note: `#[warn(deprecated)]` on by default

Error: CLIPPY_WARNING: [#def4]
librsvg2-2.59.2-build/rsvg/src/surface_utils/mod.rs:154:14: warning: use of deprecated method `rgb::legacy::internal::rgba::<impl rgb::Rgba<T, A>>::map_rgb`: Renamed to map_colors()
#      |
#  154 |         self.map_rgb(|x| (((x as u32) * a + 127) / 255) as u8)
#      |              ^^^^^^^

Error: CLIPPY_WARNING: [#def5]
librsvg2-2.59.2-build/rsvg/src/xml/mod.rs:723:9: warning: variable does not need to be mutable
#      |
#  723 |     let mut tokenizer = XmlTokenizer::new(sink, XmlTokenizerOpts::default());
#      |         ----^^^^^^^^^
#      |         |
#      |         help: remove this `mut`
#      |
#  note: the lint level is defined here
#     --> rsvg/src/lib.rs:140:46
#      |
#  140 | #![warn(nonstandard_style, rust_2018_idioms, unused)]
#      |                                              ^^^^^^
#      = note: `#[warn(unused_mut)]` implied by `#[warn(unused)]`

Error: CLIPPY_WARNING: [#def6]
librsvg2-2.59.2-build/rsvg/src/xml/mod.rs:724:19: warning: the method `run` doesn't need a mutable reference
#      |
#  724 |     tokenizer.run(&mut queue);
#      |                   ^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
#      = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default

Scan Properties