Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-477): [#def1]
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/restrict-applications-selector.c: scope_hint: In function ‘create_row_for_app_cb’
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/restrict-applications-selector.c:352:3: warning[-Wdeprecated-declarations]: ‘gtk_widget_get_style_context’ is deprecated
#  352 |   context = gtk_widget_get_style_context (w);
#      |   ^~~~~~~
/usr/include/gtk-4.0/gtk/gtkapplication.h:26: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwindow.h:32: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkaboutdialog.h:29: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:33: included_from: Included from here.
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/restrict-applications-selector.c:30: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwidget.h:710:19: note: declared here
#  710 | GtkStyleContext * gtk_widget_get_style_context (GtkWidget *widget);
#      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  350|                       "valign", GTK_ALIGN_CENTER,
#  351|                       NULL);
#  352|->   context = gtk_widget_get_style_context (w);
#  353|     gtk_style_context_add_class (context, "restricts");
#  354|     gtk_style_context_add_provider (context,

Error: COMPILER_WARNING (CWE-477): [#def2]
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/restrict-applications-selector.c:353:3: warning[-Wdeprecated-declarations]: ‘gtk_style_context_add_class’ is deprecated
#  353 |   gtk_style_context_add_class (context, "restricts");
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtk.h:267: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkstylecontext.h:90:10: note: declared here
#   90 | void     gtk_style_context_add_class    (GtkStyleContext *context,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
#  351|                       NULL);
#  352|     context = gtk_widget_get_style_context (w);
#  353|->   gtk_style_context_add_class (context, "restricts");
#  354|     gtk_style_context_add_provider (context,
#  355|                                     GTK_STYLE_PROVIDER (self->css_provider),

Error: COMPILER_WARNING (CWE-477): [#def3]
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/restrict-applications-selector.c:354:3: warning[-Wdeprecated-declarations]: ‘gtk_style_context_add_provider’ is deprecated
#  354 |   gtk_style_context_add_provider (context,
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkstylecontext.h:64:6: note: declared here
#   64 | void gtk_style_context_add_provider    (GtkStyleContext  *context,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  352|     context = gtk_widget_get_style_context (w);
#  353|     gtk_style_context_add_class (context, "restricts");
#  354|->   gtk_style_context_add_provider (context,
#  355|                                     GTK_STYLE_PROVIDER (self->css_provider),
#  356|                                     GTK_STYLE_PROVIDER_PRIORITY_APPLICATION - 1);

Error: COMPILER_WARNING (CWE-477): [#def4]
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/user-controls.c: scope_hint: In function ‘on_restrict_applications_dialog_close_request_cb’
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/user-controls.c:611:3: warning[-Wdeprecated-declarations]: ‘gtk_widget_hide’ is deprecated: Use 'gtk_widget_set_visible' instead
/usr/include/gtk-4.0/gtk/gtkapplication.h:26: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwindow.h:32: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkaboutdialog.h:29: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:33: included_from: Included from here.
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/restrict-applications-dialog.h:26: included_from: Included from here.
malcontent-0.11.1-build/malcontent-0.11.1/libmalcontent-ui/user-controls.c:33: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwidget.h:273:12: note: declared here
#  609|      * since it contains the app filter settings which we’ll want to reuse next
#  610|      * time the dialogue is shown or the app filter is saved. */
#  611|->   gtk_widget_hide (GTK_WIDGET (self->restrict_applications_dialog));
#  612|   
#  613|     /* Schedule an update to the saved state. */

Error: COMPILER_WARNING (CWE-477): [#def5]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c: scope_hint: In function ‘on_malcontent_help_shown_finished_cb’
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c:333:3: warning[-Wdeprecated-declarations]: ‘gtk_show_uri_full_finish’ is deprecated: Use 'gtk_uri_launcher_launch' instead
/usr/include/gtk-4.0/gtk/gtk.h:249: included_from: Included from here.
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c:29: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkshow.h:40:10: note: declared here
#  331|     g_autoptr(GError) local_error = NULL;
#  332|   
#  333|->   if (!gtk_show_uri_full_finish (mct_application_get_main_window (self),
#  334|                                    result,
#  335|                                    &local_error))

Error: COMPILER_WARNING (CWE-477): [#def6]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c:337:7: warning[-Wdeprecated-declarations]: ‘gtk_message_dialog_new’ is deprecated
/usr/include/gtk-4.0/gtk/gtk.h:192: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkmessagedialog.h:81:12: note: declared here
#  335|                                    &local_error))
#  336|       {
#  337|->       GtkWidget *dialog = gtk_message_dialog_new (mct_application_get_main_window (self),
#  338|                                                     GTK_DIALOG_MODAL,
#  339|                                                     GTK_MESSAGE_ERROR,

Error: COMPILER_WARNING (CWE-477): [#def7]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c:342:7: warning[-Wdeprecated-declarations]: ‘gtk_message_dialog_format_secondary_text’ is deprecated
/usr/include/gtk-4.0/gtk/deprecated/gtkmessagedialog.h:101:12: note: declared here
#  340|                                                     GTK_BUTTONS_OK,
#  341|                                                     _("The help contents could not be displayed"));
#  342|->       gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog), "%s", local_error->message);
#  343|         gtk_window_present (GTK_WINDOW (dialog));
#  344|       }

Error: COMPILER_WARNING (CWE-477): [#def8]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c: scope_hint: In function ‘help_action_cb’
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c:352:3: warning[-Wdeprecated-declarations]: ‘gtk_show_uri_full’ is deprecated: Use 'gtk_uri_launcher_launch' instead
/usr/include/gtk-4.0/gtk/deprecated/gtkshow.h:32:6: note: declared here
#  350|     MctApplication *self = MCT_APPLICATION (user_data);
#  351|   
#  352|->   gtk_show_uri_full (mct_application_get_main_window (self),
#  353|                        "help:malcontent",
#  354|                        GDK_CURRENT_TIME,

Error: COMPILER_WARNING (CWE-477): [#def9]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c: scope_hint: In function ‘update_main_stack’
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/application.c:402:7: warning[-Wdeprecated-declarations]: ‘gtk_lock_button_set_permission’ is deprecated
/usr/include/gtk-4.0/gtk/gtk.h:185: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtklockbutton.h:39:14: note: declared here
#  400|     else if (is_permission_loaded && !has_permission)
#  401|       {
#  402|->       gtk_lock_button_set_permission (self->lock_button, self->permission);
#  403|         mct_user_controls_set_permission (self->user_controls, self->permission);
#  404|   

Error: COMPILER_WARNING (CWE-477): [#def10]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c: scope_hint: In function ‘mct_carousel_item_get_x’
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:111:3: warning[-Wdeprecated-declarations]: ‘gtk_widget_get_allocated_width’ is deprecated: Use 'gtk_widget_get_width' instead
#  111 |   width = gtk_widget_get_allocated_width (widget);
#      |   ^~~~~
/usr/include/gtk-4.0/gtk/gtkapplication.h:26: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwindow.h:32: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkaboutdialog.h:29: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:33: included_from: Included from here.
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:26: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwidget.h:472:23: note: declared here
#  472 | int                   gtk_widget_get_allocated_width    (GtkWidget     *widget);
#      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  109|     widget = GTK_WIDGET (item);
#  110|   
#  111|->   width = gtk_widget_get_allocated_width (widget);
#  112|     if (!gtk_widget_translate_coordinates (widget,
#  113|                                            parent,

Error: COMPILER_WARNING (CWE-477): [#def11]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:112:3: warning[-Wdeprecated-declarations]: ‘gtk_widget_translate_coordinates’ is deprecated: Use 'gtk_widget_compute_point' instead
#  112 |   if (!gtk_widget_translate_coordinates (widget,
#      |   ^~
/usr/include/gtk-4.0/gtk/gtkwidget.h:611:14: note: declared here
#  611 | gboolean     gtk_widget_translate_coordinates (GtkWidget  *src_widget,
#      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  110|   
#  111|     width = gtk_widget_get_allocated_width (widget);
#  112|->   if (!gtk_widget_translate_coordinates (widget,
#  113|                                            parent,
#  114|                                            width / 2,

Error: COMPILER_WARNING (CWE-477): [#def12]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:120:3: warning[-Wdeprecated-declarations]: ‘gtk_widget_get_allocated_width’ is deprecated: Use 'gtk_widget_get_width' instead
#  120 |   return CLAMP (dest_x - ARROW_SIZE,
#      |   ^~~~~~
/usr/include/gtk-4.0/gtk/gtkwidget.h:472:23: note: declared here
#  472 | int                   gtk_widget_get_allocated_width    (GtkWidget     *widget);
#      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  118|       return 0;
#  119|   
#  120|->   return CLAMP (dest_x - ARROW_SIZE,
#  121|                   0,
#  122|                   gtk_widget_get_allocated_width (parent));

Error: COMPILER_WARNING (CWE-477): [#def13]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c: scope_hint: In function ‘mct_carousel_move_arrow’
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:137:3: warning[-Wdeprecated-declarations]: ‘gtk_widget_get_style_context’ is deprecated
#  137 |   context = gtk_widget_get_style_context (self->arrow);
#      |   ^~~~~~~
/usr/include/gtk-4.0/gtk/gtkwidget.h:710:19: note: declared here
#  710 | GtkStyleContext * gtk_widget_get_style_context (GtkWidget *widget);
#      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  135|     end_x = mct_carousel_item_get_x (self->selected_item, self);
#  136|   
#  137|->   context = gtk_widget_get_style_context (self->arrow);
#  138|     if (self->provider)
#  139|       gtk_style_context_remove_provider (context, self->provider);

Error: COMPILER_WARNING (CWE-477): [#def14]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:139:5: warning[-Wdeprecated-declarations]: ‘gtk_style_context_remove_provider’ is deprecated
#  139 |     gtk_style_context_remove_provider (context, self->provider);
#      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtk.h:267: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkstylecontext.h:69:6: note: declared here
#   69 | void gtk_style_context_remove_provider (GtkStyleContext  *context,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  137|     context = gtk_widget_get_style_context (self->arrow);
#  138|     if (self->provider)
#  139|->     gtk_style_context_remove_provider (context, self->provider);
#  140|     g_clear_object (&self->provider);
#  141|   

Error: COMPILER_WARNING (CWE-477): [#def15]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:144:3: warning[-Wdeprecated-declarations]: ‘gtk_css_provider_load_from_data’ is deprecated: Use 'gtk_css_provider_load_from_string' instead
#  144 |   gtk_css_provider_load_from_data (GTK_CSS_PROVIDER (self->provider), css, -1);
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtk.h:99: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkcssprovider.h:49:18: note: declared here
#   49 | void             gtk_css_provider_load_from_data (GtkCssProvider  *css_provider,
#      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  142|     css = g_strdup_printf ("* { margin-left: %dpx; }", end_x);
#  143|     self->provider = GTK_STYLE_PROVIDER (gtk_css_provider_new ());
#  144|->   gtk_css_provider_load_from_data (GTK_CSS_PROVIDER (self->provider), css, -1);
#  145|     gtk_style_context_add_provider (context, self->provider, GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
#  146|   

Error: COMPILER_WARNING (CWE-477): [#def16]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/carousel.c:145:3: warning[-Wdeprecated-declarations]: ‘gtk_style_context_add_provider’ is deprecated
#  145 |   gtk_style_context_add_provider (context, self->provider, GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/deprecated/gtkstylecontext.h:64:6: note: declared here
#   64 | void gtk_style_context_add_provider    (GtkStyleContext  *context,
#      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  143|     self->provider = GTK_STYLE_PROVIDER (gtk_css_provider_new ());
#  144|     gtk_css_provider_load_from_data (GTK_CSS_PROVIDER (self->provider), css, -1);
#  145|->   gtk_style_context_add_provider (context, self->provider, GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
#  146|   
#  147|     g_free (css);

Error: COMPILER_WARNING (CWE-477): [#def17]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/user-selector.c: scope_hint: In function ‘create_carousel_entry’
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/user-selector.c:435:3: warning[-Wdeprecated-declarations]: ‘gtk_style_context_add_class’ is deprecated
#  435 |   gtk_style_context_add_class (gtk_widget_get_style_context (widget),
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtk.h:267: included_from: Included from here.
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/user-selector.c:27: included_from: Included from here.
/usr/include/gtk-4.0/gtk/deprecated/gtkstylecontext.h:90:10: note: declared here
#   90 | void     gtk_style_context_add_class    (GtkStyleContext *context,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
#  433|   
#  434|     gtk_box_append (GTK_BOX (box), widget);
#  435|->   gtk_style_context_add_class (gtk_widget_get_style_context (widget),
#  436|                                  "dim-label");
#  437|   

Error: COMPILER_WARNING (CWE-477): [#def18]
malcontent-0.11.1-build/malcontent-0.11.1/malcontent-control/user-selector.c:435:3: warning[-Wdeprecated-declarations]: ‘gtk_widget_get_style_context’ is deprecated
#  435 |   gtk_style_context_add_class (gtk_widget_get_style_context (widget),
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gtk/gtkapplication.h:26: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwindow.h:32: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkaboutdialog.h:29: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtk.h:33: included_from: Included from here.
/usr/include/gtk-4.0/gtk/gtkwidget.h:710:19: note: declared here
#  710 | GtkStyleContext * gtk_widget_get_style_context (GtkWidget *widget);
#      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  433|   
#  434|     gtk_box_append (GTK_BOX (box), widget);
#  435|->   gtk_style_context_add_class (gtk_widget_get_style_context (widget),
#  436|                                  "dim-label");
#  437|   

Scan Properties