Fixed findings

List of Findings

Error: COMPILER_WARNING: [#def1]
openssh-9.8p1-build/openssh-9.8p1/cipher.c: scope_hint: In function ‘cipher_init’
openssh-9.8p1-build/openssh-9.8p1/cipher.c:239:32: warning[-Wcalloc-transposed-args]: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument
#  239 |         if ((cc = calloc(sizeof(*cc), 1)) == NULL)
#      |                                ^
openssh-9.8p1-build/openssh-9.8p1/cipher.c:239:32: note: earlier argument should specify number of elements, later size of each element
#  237|   
#  238|   	*ccp = NULL;
#  239|-> 	if ((cc = calloc(sizeof(*cc), 1)) == NULL)
#  240|   		return SSH_ERR_ALLOC_FAIL;
#  241|   

Error: COMPILER_WARNING: [#def2]
openssh-9.8p1-build/openssh-9.8p1/sshbuf.c: scope_hint: In function ‘sshbuf_new’
openssh-9.8p1-build/openssh-9.8p1/sshbuf.c:96:33: warning[-Wcalloc-transposed-args]: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument
#   96 |         if ((ret = calloc(sizeof(*ret), 1)) == NULL)
#      |                                 ^
openssh-9.8p1-build/openssh-9.8p1/sshbuf.c:96:33: note: earlier argument should specify number of elements, later size of each element
#   94|   	struct sshbuf *ret;
#   95|   
#   96|-> 	if ((ret = calloc(sizeof(*ret), 1)) == NULL)
#   97|   		return NULL;
#   98|   	ret->alloc = SSHBUF_SIZE_INIT;

Error: COMPILER_WARNING: [#def3]
openssh-9.8p1-build/openssh-9.8p1/sshbuf.c: scope_hint: In function ‘sshbuf_from’
openssh-9.8p1-build/openssh-9.8p1/sshbuf.c:116:33: warning[-Wcalloc-transposed-args]: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument
#  116 |             (ret = calloc(sizeof(*ret), 1)) == NULL)
#      |                                 ^
openssh-9.8p1-build/openssh-9.8p1/sshbuf.c:116:33: note: earlier argument should specify number of elements, later size of each element
#  114|   
#  115|   	if (blob == NULL || len > SSHBUF_SIZE_MAX ||
#  116|-> 	    (ret = calloc(sizeof(*ret), 1)) == NULL)
#  117|   		return NULL;
#  118|   	ret->alloc = ret->size = ret->max_size = len;

Scan Properties

analyzer-version-clippy1.82.0
analyzer-version-cppcheck2.16.0
analyzer-version-gcc14.2.1
analyzer-version-gcc-analyzer15.0.0
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.82.0
diffbase-analyzer-version-cppcheck2.16.0
diffbase-analyzer-version-gcc14.2.1
diffbase-analyzer-version-gcc-analyzer15.0.0
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-105.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-gcc-latest-x86_64
diffbase-project-nameopenssh-9.9p1-5.fc42
diffbase-store-results-to/tmp/tmp_5laaykv/openssh-9.9p1-5.fc42.tar.xz
diffbase-time-created2024-11-13 02:11:31
diffbase-time-finished2024-11-13 02:15:31
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmp_5laaykv/openssh-9.9p1-5.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmp_5laaykv/openssh-9.9p1-5.fc42.src.rpm'
diffbase-tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-105.us-west-2.compute.internal
mock-configfedora-rawhide-gcc-latest-x86_64
project-nameopenssh-9.8p1-3.fc41.1
store-results-to/tmp/tmpn0zwbzj6/openssh-9.8p1-3.fc41.1.tar.xz
time-created2024-11-13 02:06:43
time-finished2024-11-13 02:11:02
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpn0zwbzj6/openssh-9.8p1-3.fc41.1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpn0zwbzj6/openssh-9.8p1-3.fc41.1.src.rpm'
tool-versioncsmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9