Error: SHELLCHECK_WARNING (CWE-457): [#def1] /usr/lib/dracut/modules.d/98ostree/module-setup.sh:27:14: warning[SC2154]: systemdutildir is referenced but not assigned. # 25| # 26| check() { # 27|-> if [[ -x $systemdutildir/systemd ]] && [[ -x /usr/lib/ostree/ostree-prepare-root ]]; then # 28| return 255 # 29| fi Error: SHELLCHECK_WARNING (CWE-457): [#def2] /usr/lib/dracut/modules.d/98ostree/module-setup.sh:48:18: warning[SC2154]: systemdsystemunitdir is referenced but not assigned. # 46| inst_simple "/etc/ostree/initramfs-root-binding.key" # 47| fi # 48|-> inst_simple "${systemdsystemunitdir}/ostree-prepare-root.service" # 49| mkdir -p "${initdir}${systemdsystemconfdir}/initrd-root-fs.target.wants" # 50| ln_r "${systemdsystemunitdir}/ostree-prepare-root.service" \ Error: SHELLCHECK_WARNING (CWE-457): [#def3] /usr/lib/dracut/modules.d/98ostree/module-setup.sh:49:15: warning[SC2154]: initdir is referenced but not assigned. # 47| fi # 48| inst_simple "${systemdsystemunitdir}/ostree-prepare-root.service" # 49|-> mkdir -p "${initdir}${systemdsystemconfdir}/initrd-root-fs.target.wants" # 50| ln_r "${systemdsystemunitdir}/ostree-prepare-root.service" \ # 51| "${systemdsystemconfdir}/initrd-root-fs.target.wants/ostree-prepare-root.service" Error: SHELLCHECK_WARNING (CWE-457): [#def4] /usr/lib/dracut/modules.d/98ostree/module-setup.sh:49:25: warning[SC2154]: systemdsystemconfdir is referenced but not assigned. # 47| fi # 48| inst_simple "${systemdsystemunitdir}/ostree-prepare-root.service" # 49|-> mkdir -p "${initdir}${systemdsystemconfdir}/initrd-root-fs.target.wants" # 50| ln_r "${systemdsystemunitdir}/ostree-prepare-root.service" \ # 51| "${systemdsystemconfdir}/initrd-root-fs.target.wants/ostree-prepare-root.service" Error: SHELLCHECK_WARNING (CWE-758): [#def5] /usr/libexec/installed-tests/libostree/admin-test.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. # 1|-> # This file is to be sourced, not executed # 2| # 3| # Copyright (C) 2011,2014 Colin Walters <walters@verbum.org> Error: SHELLCHECK_WARNING (CWE-563): [#def6] /usr/libexec/installed-tests/libostree/admin-test.sh:24:1: warning[SC2034]: flag appears unused. Verify use (or export if used externally). # 22| echo "1..$((31 + ${extra_admin_tests:-0}))" # 23| # 24|-> for flag in --modern --epoch=1; do # 25| mkdir sysrootmin # 26| ${CMD_PREFIX} ostree admin init-fs --modern sysrootmin Error: SHELLCHECK_WARNING (CWE-457): [#def7] /usr/libexec/installed-tests/libostree/admin-test.sh:39:8: warning[SC2154]: test_tmpdir is referenced but not assigned. # 37| # 38| function validate_bootloader() { # 39|-> cd ${test_tmpdir}; # 40| bootloader="" # 41| if test -f sysroot/boot/syslinux/syslinux.cfg; then Error: SHELLCHECK_WARNING (CWE-156): [#def8] /usr/libexec/installed-tests/libostree/admin-test.sh:47:9: warning[SC2046]: Quote this to prevent word splitting. # 45| fi # 46| if test -n "${bootloader}"; then # 47|-> $(dirname $0)/bootloader-entries-crosscheck.py sysroot ${bootloader} # 48| fi # 49| cd - Error: SHELLCHECK_WARNING (CWE-156): [#def9] /usr/libexec/installed-tests/libostree/admin-test.sh:88:33: warning[SC2046]: Quote this to prevent word splitting. # 86| # 87| ${CMD_PREFIX} ostree admin --print-current-dir > curdir # 88|-> assert_file_has_content curdir ^`pwd`/sysroot/ostree/deploy/testos/deploy/${rev}\.0$ # 89| # 90| echo "ok --print-current-dir" Error: SHELLCHECK_WARNING (CWE-457): [#def10] /usr/libexec/installed-tests/libostree/admin-test.sh:106:52: warning[SC2154]: bootcsum is referenced but not assigned. # 104| assert_file_has_content sysroot/boot/loader/entries/ostree-1.conf 'options.* root=LABEL=MOO' # 105| assert_file_has_content sysroot/boot/loader/entries/ostree-1.conf 'options.* quiet' # 106|-> assert_file_has_content sysroot/boot/ostree/testos-${bootcsum}/vmlinuz-3.6.0 'a kernel' # 107| assert_file_has_content sysroot/ostree/deploy/testos/deploy/${rev}.0/etc/os-release 'NAME=TestOS' # 108| assert_file_has_content sysroot/ostree/boot.1/testos/${bootcsum}/0/etc/os-release 'NAME=TestOS' Error: SHELLCHECK_WARNING (CWE-563): [#def11] /usr/libexec/installed-tests/libostree/admin-test.sh:210:1: warning[SC2034]: i appears unused. Verify use (or export if used externally). # 208| # 209| # we now have 5 deployments, let's bring that back down to 1 # 210|-> for i in $(seq 4); do # 211| ${CMD_PREFIX} ostree admin undeploy 0 # 212| done Error: SHELLCHECK_WARNING (CWE-156): [#def12] /usr/libexec/installed-tests/libostree/admin-test.sh:271:97: warning[SC2046]: Quote this to prevent word splitting. # 269| echo "ok upgrade failed when staged" # 270| # 271|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos file://$(pwd)/testos-repo testos/buildmain/x86_64-runtime # 272| ${CMD_PREFIX} ostree admin upgrade --os=testos # 273| origrev=${rev} Error: SHELLCHECK_WARNING (CWE-457): [#def13] /usr/libexec/installed-tests/libostree/admin-test.sh:333:85: warning[SC2154]: version is referenced but not assigned. # 331| os_repository_new_commit # 332| ${CMD_PREFIX} ostree admin upgrade --os=testos # 333|-> assert_file_has_content sysroot/boot/loader/entries/ostree-4.conf "^title TestOS 42 ${version} (ostree:testos:0)$" # 334| os_repository_new_commit 0 0 testos/buildmain/x86_64-runtime 42 # 335| ${CMD_PREFIX} ostree admin upgrade --os=testos Error: SHELLCHECK_WARNING (CWE-563): [#def14] /usr/libexec/installed-tests/libostree/admin-test.sh:380:1: warning[SC2034]: curr_rev appears unused. Verify use (or export if used externally). # 378| os_repository_new_commit # 379| ${CMD_PREFIX} ostree pull --repo=sysroot/ostree/repo --commit-metadata-only --depth=-1 testos:testos/buildmain/x86_64-runtime # 380|-> curr_rev=$(${CMD_PREFIX} ostree rev-parse --repo=sysroot/ostree/repo testos/buildmain/x86_64-runtime) # 381| prev_rev=$(${CMD_PREFIX} ostree rev-parse --repo=sysroot/ostree/repo testos/buildmain/x86_64-runtime^) # 382| ${CMD_PREFIX} ostree admin upgrade --os=testos --override-commit=${prev_rev} Error: SHELLCHECK_WARNING (CWE-156): [#def15] /usr/libexec/installed-tests/libostree/admin-test.sh:394:102: warning[SC2046]: Quote this to prevent word splitting. # 392| # 393| deployment=$(${CMD_PREFIX} ostree admin --sysroot=sysroot --print-current-dir) # 394|-> ${CMD_PREFIX} ostree --sysroot=sysroot remote add --set=gpg-verify=false remote-test-physical file://$(pwd)/testos-repo # 395| assert_not_has_file ${deployment}/etc/ostree/remotes.d/remote-test-physical.conf testos-repo # 396| assert_file_has_content sysroot/ostree/repo/config remote-test-physical Error: SHELLCHECK_WARNING (CWE-156): [#def16] /usr/libexec/installed-tests/libostree/admin-test.sh:403:111: warning[SC2046]: Quote this to prevent word splitting. # 401| ln -sr sysroot ${deployment}/sysroot # 402| ln -s sysroot/ostree ${deployment}/ostree # 403|-> ${CMD_PREFIX} ostree --sysroot=${deployment} remote add --set=gpg-verify=false remote-test-nonphysical file://$(pwd)/testos-repo # 404| assert_not_file_has_content sysroot/ostree/repo/config remote-test-nonphysical # 405| assert_file_has_content ${deployment}/etc/ostree/remotes.d/remote-test-nonphysical.conf testos-repo Error: SHELLCHECK_WARNING (CWE-156): [#def17] /usr/libexec/installed-tests/libostree/admin-test.sh:412:110: warning[SC2046]: Quote this to prevent word splitting. # 410| # "system" repo. # 411| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo config set core.add-remotes-config-dir false # 412|-> ${CMD_PREFIX} ostree --sysroot=${deployment} remote add --set=gpg-verify=false remote-test-config-dir file://$(pwd)/testos-repo # 413| assert_not_has_file ${deployment}/etc/ostree/remotes.d/remote-test-config-dir.conf testos-repo # 414| assert_file_has_content sysroot/ostree/repo/config remote-test-config-dir Error: SHELLCHECK_WARNING (CWE-758): [#def18] /usr/libexec/installed-tests/libostree/archive-test.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. # 1|-> # This file is to be sourced, not executed # 2| # 3| # Copyright (C) 2011 Colin Walters <walters@verbum.org> Error: SHELLCHECK_WARNING (CWE-457): [#def19] /usr/libexec/installed-tests/libostree/archive-test.sh:32:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 30| echo "ok content" # 31| # 32|-> cd ${test_tmpdir} # 33| mkdir repo2 # 34| ostree_repo_init repo2 Error: SHELLCHECK_WARNING (CWE-758): [#def20] /usr/libexec/installed-tests/libostree/basic-test.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. # 1|-> # This file is to be sourced, not executed # 2| # 3| # Copyright (C) 2011 Colin Walters <walters@verbum.org> Error: SHELLCHECK_WARNING (CWE-156): [#def21] /usr/libexec/installed-tests/libostree/basic-test.sh:57:22: warning[SC2046]: Quote this to prevent word splitting. # 55| validate_checkout_basic checkout-test2 # 56| if grep -q 'mode=bare$' repo/config; then # 57|-> assert_not_streq $(stat -c '%h' checkout-test2/firstfile) 1 # 58| fi # 59| echo "ok checkout" Error: SHELLCHECK_WARNING (CWE-156): [#def22] /usr/libexec/installed-tests/libostree/basic-test.sh:90:18: warning[SC2046]: Quote this to prevent word splitting. # 88| $OSTREE checkout -C test2 checkout-test2 # 89| for file in firstfile baz/cow baz/alink; do # 90|-> assert_streq $(stat -c '%h' checkout-test2/$file) 1 # 91| done # 92| Error: SHELLCHECK_WARNING (CWE-156): [#def23] /usr/libexec/installed-tests/libostree/basic-test.sh:122:34: warning[SC2046]: Quote this to prevent word splitting. # 120| $OSTREE rev-parse test2 > checksum # 121| $OSTREE rev-parse $partial > partial-results # 122|-> assert_file_has_content checksum $(cat partial-results) # 123| echo "ok shortened checksum" # 124| Error: SHELLCHECK_WARNING (CWE-457): [#def24] /usr/libexec/installed-tests/libostree/basic-test.sh:152:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 150| $OSTREE commit ${COMMIT_ARGS} -b test2 -s delete # 151| # 152|-> cd $test_tmpdir # 153| $OSTREE checkout test2 $test_tmpdir/checkout-test2-2 # 154| cd $test_tmpdir/checkout-test2-2 Error: SHELLCHECK_WARNING: [#def25] /usr/libexec/installed-tests/libostree/basic-test.sh:166:11: warning[SC2210]: This is a file redirection. Was it supposed to be a comparison or fd operation? # 164| echo fivebaby > a/5 # 165| touch a/6 # 166|-> echo whee > 7 # 167| mkdir -p another/nested/tree # 168| echo anotherone > another/nested/tree/1 Error: SHELLCHECK_WARNING (CWE-156): [#def26] /usr/libexec/installed-tests/libostree/basic-test.sh:236:14: warning[SC2046]: Quote this to prevent word splitting. # 234| cd ${test_tmpdir} # 235| $OSTREE commit ${COMMIT_ARGS} -b test2-no-parent -s '' $test_tmpdir/checkout-test2-4 # 236|-> assert_streq $($OSTREE log test2-no-parent |grep '^commit' | wc -l) "1" # 237| $OSTREE commit ${COMMIT_ARGS} -b test2-no-parent -s '' --parent=none $test_tmpdir/checkout-test2-4 # 238| assert_streq $($OSTREE log test2-no-parent |grep '^commit' | wc -l) "1" Error: SHELLCHECK_WARNING (CWE-156): [#def27] /usr/libexec/installed-tests/libostree/basic-test.sh:238:14: warning[SC2046]: Quote this to prevent word splitting. # 236| assert_streq $($OSTREE log test2-no-parent |grep '^commit' | wc -l) "1" # 237| $OSTREE commit ${COMMIT_ARGS} -b test2-no-parent -s '' --parent=none $test_tmpdir/checkout-test2-4 # 238|-> assert_streq $($OSTREE log test2-no-parent |grep '^commit' | wc -l) "1" # 239| echo "ok commit no parent" # 240| Error: SHELLCHECK_WARNING (CWE-156): [#def28] /usr/libexec/installed-tests/libostree/basic-test.sh:276:14: warning[SC2046]: Quote this to prevent word splitting. # 274| $OSTREE commit ${COMMIT_ARGS} -b test2-custom-parent -s '' $test_tmpdir/checkout-test2-4 # 275| $OSTREE commit ${COMMIT_ARGS} -b test2-custom-parent -s '' $test_tmpdir/checkout-test2-4 # 276|-> assert_streq $($OSTREE log test2-custom-parent |grep '^commit' | wc -l) "3" # 277| prevparent=$($OSTREE rev-parse test2-custom-parent^) # 278| $OSTREE commit ${COMMIT_ARGS} -b test2-custom-parent -s '' --parent=${prevparent} $test_tmpdir/checkout-test2-4 Error: SHELLCHECK_WARNING (CWE-156): [#def29] /usr/libexec/installed-tests/libostree/basic-test.sh:279:14: warning[SC2046]: Quote this to prevent word splitting. # 277| prevparent=$($OSTREE rev-parse test2-custom-parent^) # 278| $OSTREE commit ${COMMIT_ARGS} -b test2-custom-parent -s '' --parent=${prevparent} $test_tmpdir/checkout-test2-4 # 279|-> assert_streq $($OSTREE log test2-custom-parent |grep '^commit' | wc -l) "3" # 280| echo "ok commit custom parent" # 281| Error: SHELLCHECK_WARNING (CWE-457): [#def30] /usr/libexec/installed-tests/libostree/basic-test.sh:387:32: warning[SC2154]: mode is referenced but not assigned. # 385| # 386| rm repo2 -rf # 387|-> ostree_repo_init repo2 --mode="$mode" # 388| $CMD_PREFIX ostree --repo=repo2 pull-local --untrusted repo test2 # 389| target_file_object=$(ostree_file_path_to_relative_object_path repo test2 baz/saucer) Error: SHELLCHECK_WARNING (CWE-156): [#def31] /usr/libexec/installed-tests/libostree/basic-test.sh:459:40: warning[SC2046]: Quote this to prevent word splitting. # 457| # 458| mkdir badutf8 # 459|-> echo "invalid utf8 filename" > badutf8/$(printf '\x80') # 460| if $OSTREE commit ${COMMIT_ARGS} -b badutf8 --tree=dir=badutf8 2>err.txt; then # 461| assert_not_reached "commit filename with invalid UTF-8" Error: SHELLCHECK_WARNING: [#def32] /usr/libexec/installed-tests/libostree/basic-test.sh:760:1: warning[SC2226]: This ln has no destination. Check the arguments, or specify '.' explicitly. # 758| $OSTREE commit -b union-identical-conflictpkg1bin --tree=dir=pkg-conflict1bin # 759| mkdir -p pkg-conflict1link/usr/{bin,share/licenses} # 760|-> ln -s somewhere-else > pkg-conflict1link/usr/bin/pkg1 # 761| echo 'this is the GPL' > pkg-conflict1link/usr/share/licenses/COPYING # 762| $OSTREE commit -b union-identical-conflictpkg1link --tree=dir=pkg-conflict1link Error: SHELLCHECK_WARNING (CWE-156): [#def33] /usr/libexec/installed-tests/libostree/basic-test.sh:831:64: warning[SC2046]: Quote this to prevent word splitting. # 829| mkdir shadow-repo # 830| ostree_repo_init shadow-repo # 831|-> ${CMD_PREFIX} ostree --repo=shadow-repo config set core.parent $(pwd)/repo # 832| rm -rf test2-checkout # 833| parent_rev_test2=$(${CMD_PREFIX} ostree --repo=repo rev-parse test2) Error: SHELLCHECK_WARNING (CWE-457): [#def34] /usr/libexec/installed-tests/libostree/basic-test.sh:993:10: warning[SC2154]: test_builddir is referenced but not assigned. # 991| # 992| $OSTREE show --print-metadata-key=SOMENUM test2 > test2-meta # 993|-> case "$("${test_builddir}/get-byte-order")" in # 994| (4321) # 995| assert_file_has_content test2-meta "uint64 42" Error: SHELLCHECK_WARNING (CWE-398): [#def35] /usr/libexec/installed-tests/libostree/basic-test.sh:1117:10: warning[SC2044]: For loops over find output are fragile. Use find -exec or a while read loop. # 1115| assert_file_has_content err.txt OSTREE_REPO_TEST_ERROR_PRE_COMMIT # 1116| found_staging=0 # 1117|-> for d in $(find repo/tmp/ -maxdepth 1 -type d); do # 1118| bn=$(basename $d) # 1119| if test ${bn##staging-} != ${bn}; then Error: SHELLCHECK_WARNING (CWE-758): [#def36] /usr/libexec/installed-tests/libostree/libtest-core.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. # 1|-> # Core source library for shell script tests; the # 2| # canonical version lives in: # 3| # Error: SHELLCHECK_WARNING (CWE-88): [#def37] /usr/libexec/installed-tests/libostree/libtest-core.sh:29:10: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 27| # 28| fatal() { # 29|-> echo $@ 1>&2; exit 1 # 30| } # 31| # fatal() is shorter to type, but retain this alias Error: SHELLCHECK_WARNING (CWE-571): [#def38] /usr/libexec/installed-tests/libostree/libtest-core.sh:54:12: warning[SC2155]: Declare and assign separately to avoid masking return values. # 52| # (e.g. musl based systems) # 53| if type -p locale >/dev/null; then # 54|-> export LC_ALL=$(locale -a | grep -iEe '^(C|en_US)\.(UTF-8|utf8)$' | head -n1 || true) # 55| if [ -z "${LC_ALL}" ]; then fatal "Can't find suitable UTF-8 locale"; fi # 56| else Error: SHELLCHECK_WARNING (CWE-156): [#def39] /usr/libexec/installed-tests/libostree/libtest-core.sh:144:19: warning[SC2046]: Quote this to prevent word splitting. # 142| shift # 143| for re in "$@"; do # 144|-> if ! test $(grep -e "$re" "$fpath" | wc -l) = "1"; then # 145| _fatal_print_file "$fpath" "File '$fpath' doesn't match regexp '$re' exactly once" # 146| fi Error: SHELLCHECK_WARNING (CWE-758): [#def40] /usr/libexec/installed-tests/libostree/libtest.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. # 1|-> # Source library for shell script tests # 2| # # 3| # Copyright (C) 2011 Colin Walters <walters@verbum.org> Error: SHELLCHECK_WARNING (CWE-563): [#def41] /usr/libexec/installed-tests/libostree/libtest.sh:20:1: warning[SC2034]: dn appears unused. Verify use (or export if used externally). # 18| # License along with this library. If not, see <https://www.gnu.org/licenses/>. # 19| # 20|-> dn=$(dirname $0) # 21| # 22| if [ -n "${G_TEST_SRCDIR:-}" ]; then Error: SHELLCHECK_WARNING (CWE-156): [#def42] /usr/libexec/installed-tests/libostree/libtest.sh:30:23: warning[SC2046]: Quote this to prevent word splitting. # 28| top_builddir="${G_TEST_BUILDDIR:-}" # 29| if test -z "${top_builddir}"; then # 30|-> top_builddir=$(cd $(dirname $0)/.. && pwd) # 31| fi # 32| Error: SHELLCHECK_WARNING (CWE-563): [#def43] /usr/libexec/installed-tests/libostree/libtest.sh:33:1: warning[SC2034]: test_builddir appears unused. Verify use (or export if used externally). # 31| fi # 32| # 33|-> test_builddir="${top_builddir}/tests" # 34| . ${test_srcdir}/libtest-core.sh # 35| Error: SHELLCHECK_WARNING (CWE-398): [#def44] /usr/libexec/installed-tests/libostree/libtest.sh:153:6: warning[SC1010]: Use semicolon or linefeed before 'done' (or quote to make it literal). # 151| export OSTREE_NO_XATTRS=1 # 152| fi # 153|-> echo done # 154| # 155| # whiteout char 0:0 devices can be created as regular users, but Error: SHELLCHECK_WARNING (CWE-398): [#def45] /usr/libexec/installed-tests/libostree/libtest.sh:167:6: warning[SC1010]: Use semicolon or linefeed before 'done' (or quote to make it literal). # 165| export OSTREE_NO_WHITEOUTS=1 # 166| fi # 167|-> echo done # 168| # 169| if test -n "${OT_TESTS_DEBUG:-}"; then Error: SHELLCHECK_WARNING (CWE-563): [#def46] /usr/libexec/installed-tests/libostree/libtest.sh:176:5: warning[SC2034]: BUILT_WITH_ASAN appears unused. Verify use (or export if used externally). # 174| BUILT_WITH_ASAN="" # 175| if test -n "${ASAN_OPTIONS:-}"; then # 176|-> BUILT_WITH_ASAN=1 # 177| fi # 178| Error: SHELLCHECK_WARNING (CWE-571): [#def47] /usr/libexec/installed-tests/libostree/libtest.sh:226:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 224| # 225| cd ${test_tmpdir} # 226|-> local oldumask="$(umask)" # 227| umask 022 # 228| rm -rf files Error: SHELLCHECK_WARNING (CWE-563): [#def48] /usr/libexec/installed-tests/libostree/libtest.sh:231:5: warning[SC2034]: ot_files appears unused. Verify use (or export if used externally). # 229| mkdir files # 230| cd files # 231|-> ot_files=`pwd` # 232| export ht_files # 233| ln -s nosuchfile somelink Error: SHELLCHECK_WARNING (CWE-156): [#def49] /usr/libexec/installed-tests/libostree/libtest.sh:317:43: warning[SC2046]: Quote this to prevent word splitting. # 315| cd httpd # 316| ln -s ${test_tmpdir}/ostree-srv ostree # 317|-> ${OSTREE_HTTPD} --autoexit --log-file $(pwd)/httpd.log --daemonize -p ${test_tmpdir}/httpd-port "$@" # 318| port=$(cat ${test_tmpdir}/httpd-port) # 319| echo "http://127.0.0.1:${port}" > ${test_tmpdir}/httpd-address Error: SHELLCHECK_WARNING (CWE-156): [#def50] /usr/libexec/installed-tests/libostree/libtest.sh:362:43: warning[SC2046]: Quote this to prevent word splitting. # 360| cd httpd # 361| ln -s ${test_tmpdir}/ostree-srv ostree # 362|-> ${OSTREE_HTTPD} --autoexit --log-file $(pwd)/httpd.log --daemonize -p ${test_tmpdir}/httpd-port $args # 363| port=$(cat ${test_tmpdir}/httpd-port) # 364| echo "http://127.0.0.1:${port}" > ${test_tmpdir}/httpd-address Error: SHELLCHECK_WARNING (CWE-156): [#def51] /usr/libexec/installed-tests/libostree/libtest.sh:646:14: warning[SC2046]: Quote this to prevent word splitting. # 644| have_systemd_and_libmount() { # 645| if test "${_have_systemd_and_libmount}" = ''; then # 646|-> if [ $(ostree --version | grep -c -e '- systemd' -e '- libmount') -eq 2 ]; then # 647| _have_systemd_and_libmount=yes # 648| else Error: SHELLCHECK_WARNING (CWE-569): [#def52] /usr/libexec/installed-tests/libostree/libtest.sh:741:16: warning[SC2048]: Use "${array[@]}" (with quotes) to prevent whitespace problems. # 739| # Make sure all the needed options are available # 740| gpg_options=$(${gpg} --dump-options) || return 0 # 741|-> for opt in ${needed_options[*]}; do # 742| grep -q -x -e "${opt}" <<< "${gpg_options}" || return 0 # 743| done Error: SHELLCHECK_WARNING (CWE-563): [#def53] /usr/libexec/installed-tests/libostree/libtest.sh:771:3: warning[SC2034]: ED25519SECRET appears unused. Verify use (or export if used externally). # 769| ED25519SEED="$(openssl pkey -outform DER -in ${pemfile} | tail -c 32 | base64)" # 770| # Secret key is concantination of SEED and PUBLIC # 771|-> ED25519SECRET="$(echo ${ED25519SEED}${ED25519PUBLIC} | base64 -d | base64 -w 0)" # 772| # 773| echo "Generated ed25519 keys:" Error: SHELLCHECK_WARNING (CWE-156): [#def54] /usr/libexec/installed-tests/libostree/libtest.sh:825:18: warning[SC2046]: Quote this to prevent word splitting. # 823| # Assert ref $2 in repo $1 has checksum $3. # 824| assert_ref () { # 825|-> assert_streq $(${CMD_PREFIX} ostree rev-parse --repo=$1 $2) $3 # 826| } # 827| Error: SHELLCHECK_WARNING (CWE-88): [#def55] /usr/libexec/installed-tests/libostree/libtest.sh:837:3: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 835| assert_fail () { # 836| set +e # 837|-> $@ # 838| if [ $? = 0 ] ; then # 839| echo 1>&2 "$@ did not fail"; exit 1 Error: SHELLCHECK_WARNING (CWE-138): [#def56] /usr/libexec/installed-tests/libostree/libtest.sh:839:16: error[SC2145]: Argument mixes string and array. Use * or separate argument. # 837| $@ # 838| if [ $? = 0 ] ; then # 839|-> echo 1>&2 "$@ did not fail"; exit 1 # 840| fi # 841| set -euo pipefail Error: SHELLCHECK_WARNING (CWE-156): [#def57] /usr/libexec/installed-tests/libostree/ostree-grub-generator:69:93: warning[SC2046]: Quote this to prevent word splitting. # 67| { # 68| # Default to /boot if OSTREE_BOOT_PARTITION is not set and /boot is on the same device as /ostree/repo # 69|-> if [ -z ${OSTREE_BOOT_PARTITION+x} ] && [ -d /boot/ostree ] && [ -d /ostree/repo ] && [ $(stat -c '%d' /boot/ostree) -eq $(stat -c '%d' /ostree/repo) ]; then # 70| boot_prefix="/boot" # 71| else Error: SHELLCHECK_WARNING (CWE-156): [#def58] /usr/libexec/installed-tests/libostree/ostree-grub-generator:69:126: warning[SC2046]: Quote this to prevent word splitting. # 67| { # 68| # Default to /boot if OSTREE_BOOT_PARTITION is not set and /boot is on the same device as /ostree/repo # 69|-> if [ -z ${OSTREE_BOOT_PARTITION+x} ] && [ -d /boot/ostree ] && [ -d /ostree/repo ] && [ $(stat -c '%d' /boot/ostree) -eq $(stat -c '%d' /ostree/repo) ]; then # 70| boot_prefix="/boot" # 71| else Error: SHELLCHECK_WARNING (CWE-398): [#def59] /usr/libexec/installed-tests/libostree/ostree-grub-generator:74:19: warning[SC2045]: Iterating over ls output is fragile. Use globs. # 72| boot_prefix="${OSTREE_BOOT_PARTITION}" # 73| fi # 74|-> for config in $(ls -v -r $entries_path/*.conf); do # 75| read_config ${config} # 76| menu="${menu}menuentry '${title}' {\n" Error: SHELLCHECK_WARNING (CWE-758): [#def60] /usr/libexec/installed-tests/libostree/pull-test.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. # 1|-> # This file is to be sourced, not executed # 2| # 3| # Copyright (C) 2011 Colin Walters <walters@verbum.org> Error: SHELLCHECK_WARNING (CWE-457): [#def61] /usr/libexec/installed-tests/libostree/pull-test.sh:23:8: warning[SC2154]: test_tmpdir is referenced but not assigned. # 21| # 22| function repo_init() { # 23|-> cd ${test_tmpdir} # 24| rm repo -rf # 25| mkdir repo Error: SHELLCHECK_WARNING (CWE-457): [#def62] /usr/libexec/installed-tests/libostree/pull-test.sh:26:34: warning[SC2154]: repo_mode is referenced but not assigned. # 24| rm repo -rf # 25| mkdir repo # 26|-> ostree_repo_init repo --mode=${repo_mode} # 27| ${CMD_PREFIX} ostree --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo "$@" # 28| } Error: SHELLCHECK_WARNING (CWE-156): [#def63] /usr/libexec/installed-tests/libostree/pull-test.sh:27:56: warning[SC2046]: Quote this to prevent word splitting. # 25| mkdir repo # 26| ostree_repo_init repo --mode=${repo_mode} # 27|-> ${CMD_PREFIX} ostree --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo "$@" # 28| } # 29| Error: SHELLCHECK_WARNING (CWE-156): [#def64] /usr/libexec/installed-tests/libostree/pull-test.sh:89:81: warning[SC2046]: Quote this to prevent word splitting. # 87| mkdir mirrorrepo # 88| ostree_repo_init mirrorrepo --mode=archive # 89|-> ${CMD_PREFIX} ostree --repo=mirrorrepo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 90| ${CMD_PREFIX} ostree --repo=mirrorrepo pull --mirror origin main # 91| ${CMD_PREFIX} ostree --repo=mirrorrepo fsck Error: SHELLCHECK_WARNING (CWE-156): [#def65] /usr/libexec/installed-tests/libostree/pull-test.sh:102:81: warning[SC2046]: Quote this to prevent word splitting. # 100| # All refs # 101| ostree_repo_init mirrorrepo --mode=archive # 102|-> ${CMD_PREFIX} ostree --repo=mirrorrepo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 103| ${CMD_PREFIX} ostree --repo=mirrorrepo pull --mirror origin # 104| ${CMD_PREFIX} ostree --repo=mirrorrepo fsck Error: SHELLCHECK_WARNING (CWE-156): [#def66] /usr/libexec/installed-tests/libostree/pull-test.sh:112:81: warning[SC2046]: Quote this to prevent word splitting. # 110| rm mirrorrepo -rf # 111| ostree_repo_init mirrorrepo --mode=archive # 112|-> ${CMD_PREFIX} ostree --repo=mirrorrepo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 113| # Generate a summary in the mirror # 114| ${CMD_PREFIX} ostree --repo=mirrorrepo summary -u Error: SHELLCHECK_WARNING: [#def67] /usr/libexec/installed-tests/libostree/pull-test.sh:197:18: error[SC1102]: Shells disambiguate $(( differently or not at all. For $(command substitution), add space after $( . For $((arithmetics)), fix parsing errors. # 195| rev=$(ostree --repo=cacherepo rev-parse main) # 196| ${CMD_PREFIX} ostree --repo=cacherepo ls -R -C main > ls.txt # 197|-> regfile_hash=$((grep -E -e '^-0' ls.txt || true) | head -1 | awk '{ print $5 }') # 198| ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false corruptrepo $(cat httpd-address)/ostree/corruptrepo # 199| # Make this a loop so in the future we can add more object types like commit etc. Error: SHELLCHECK_WARNING (CWE-156): [#def68] /usr/libexec/installed-tests/libostree/pull-test.sh:198:84: warning[SC2046]: Quote this to prevent word splitting. # 196| ${CMD_PREFIX} ostree --repo=cacherepo ls -R -C main > ls.txt # 197| regfile_hash=$((grep -E -e '^-0' ls.txt || true) | head -1 | awk '{ print $5 }') # 198|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false corruptrepo $(cat httpd-address)/ostree/corruptrepo # 199| # Make this a loop so in the future we can add more object types like commit etc. # 200| for object in ${regfile_hash}.file; do Error: SHELLCHECK_WARNING (CWE-156): [#def69] /usr/libexec/installed-tests/libostree/pull-test.sh:227:101: warning[SC2046]: Quote this to prevent word splitting. # 225| ostree_repo_init corruptmirrorrepo --mode=archive # 226| # Pulling via http-trusted should not verify the checksum # 227|-> ${CMD_PREFIX} ostree --repo=corruptmirrorrepo remote add --set=gpg-verify=false corruptrepo $(cat httpd-address)/ostree/corruptrepo # 228| ${CMD_PREFIX} ostree --repo=corruptmirrorrepo pull --mirror --http-trusted corruptrepo main # 229| # But it should fail to fsck Error: SHELLCHECK_WARNING (CWE-457): [#def70] /usr/libexec/installed-tests/libostree/pull-test.sh:246:8: warning[SC2154]: test_srcdir is referenced but not assigned. # 244| # 245| cd ${test_tmpdir}/ostree-srv # 246|-> tar xf ${test_srcdir}/ostree-path-traverse.tar.gz # 247| cd ${test_tmpdir} # 248| rm corruptrepo -rf Error: SHELLCHECK_WARNING (CWE-156): [#def71] /usr/libexec/installed-tests/libostree/pull-test.sh:250:88: warning[SC2046]: Quote this to prevent word splitting. # 248| rm corruptrepo -rf # 249| ostree_repo_init corruptrepo --mode=archive # 250|-> ${CMD_PREFIX} ostree --repo=corruptrepo remote add --set=gpg-verify=false pathtraverse $(cat httpd-address)/ostree/ostree-path-traverse/repo # 251| if ${CMD_PREFIX} ostree --repo=corruptrepo pull pathtraverse pathtraverse-test 2>err.txt; then # 252| fatal "Pulled a repo with path traversal in dirtree" Error: SHELLCHECK_WARNING (CWE-156): [#def72] /usr/libexec/installed-tests/libostree/pull-test.sh:280:94: warning[SC2046]: Quote this to prevent word splitting. # 278| mkdir mirrorrepo-local # 279| ostree_repo_init mirrorrepo-local --mode=archive # 280|-> ${CMD_PREFIX} ostree --repo=mirrorrepo-local remote add --set=gpg-verify=false origin file://$(pwd)/ostree-srv/gnomerepo # 281| ${CMD_PREFIX} ostree --repo=mirrorrepo-local pull --mirror origin main # 282| ${CMD_PREFIX} ostree --repo=mirrorrepo-local fsck Error: SHELLCHECK_WARNING (CWE-156): [#def73] /usr/libexec/installed-tests/libostree/pull-test.sh:293:87: warning[SC2046]: Quote this to prevent word splitting. # 291| ${CMD_PREFIX} ostree --repo=ostree-srv/gnomerepo checkout ${CHECKOUT_U_ARG} main checkout-origin-main # 292| ${CMD_PREFIX} ostree --repo=otherrepo commit ${COMMIT_ARGS} -b localbranch --tree=dir=checkout-origin-main # 293|-> ${CMD_PREFIX} ostree --repo=otherrepo remote add --set=gpg-verify=false origin file://$(pwd)/ostree-srv/gnomerepo # 294| ${CMD_PREFIX} ostree --repo=otherrepo pull origin main # 295| rm mirrorrepo-local -rf Error: SHELLCHECK_WARNING (CWE-156): [#def74] /usr/libexec/installed-tests/libostree/pull-test.sh:326:92: warning[SC2046]: Quote this to prevent word splitting. # 324| mkdir parentpullrepo # 325| ostree_repo_init parentpullrepo --mode=archive # 326|-> ${CMD_PREFIX} ostree --repo=parentpullrepo remote add --set=gpg-verify=false origin file://$(pwd)/ostree-srv/gnomerepo # 327| parent_rev=$(ostree --repo=ostree-srv/gnomerepo rev-parse main^) # 328| rev=$(ostree --repo=ostree-srv/gnomerepo rev-parse main) Error: SHELLCHECK_WARNING (CWE-156): [#def75] /usr/libexec/installed-tests/libostree/pull-test.sh:451:82: warning[SC2046]: Quote this to prevent word splitting. # 449| repo_init --no-sign-verify # 450| ${CMD_PREFIX} ostree --repo=repo remote delete origin # 451|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin file://$(pwd)/ostree-srv/gnomerepo # 452| ${CMD_PREFIX} ostree --repo=repo pull origin main@${prev_rev} # 453| ${CMD_PREFIX} ostree --repo=repo pull --dry-run --require-static-deltas origin ${delta_target} >dry-run-pull.txt Error: SHELLCHECK_WARNING (CWE-156): [#def76] /usr/libexec/installed-tests/libostree/pull-test.sh:592:172: warning[SC2046]: Quote this to prevent word splitting. # 590| # 591| cd ${test_tmpdir} # 592|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false --set=unconfigured-state="Access to ExampleOS requires ONE BILLION DOLLARS." origin-subscription file://$(pwd)/ostree-srv/gnomerepo # 593| if ${CMD_PREFIX} ostree --repo=repo pull origin-subscription main 2>err.txt; then # 594| assert_not_reached "pull unexpectedly succeeded?" Error: SHELLCHECK_WARNING (CWE-156): [#def77] /usr/libexec/installed-tests/libostree/pull-test.sh:629:56: warning[SC2046]: Quote this to prevent word splitting. # 627| cd ${test_tmpdir} # 628| repo_init # 629|-> ${CMD_PREFIX} ostree --repo=repo remote add origin-bad $(cat httpd-address)/ostree/noent # 630| if ${CMD_PREFIX} ostree --repo=repo --depth=0 pull origin-bad main 2>err.txt; then # 631| assert_not_reached "pull repo 404 succeeded?" Error: SHELLCHECK_WARNING (CWE-156): [#def78] /usr/libexec/installed-tests/libostree/pull-test.sh:653:85: warning[SC2046]: Quote this to prevent word splitting. # 651| fi # 652| assert_file_has_content err.txt "404" # 653|-> find ostree-srv/gnomerepo/objects -name '*.dirtree.orig' | while read f; do mv ${f} $(dirname $f)/$(basename ${f} .orig); done # 654| echo "ok pull repo 404 on dirtree object" # 655| Error: SHELLCHECK_WARNING (CWE-156): [#def79] /usr/libexec/installed-tests/libostree/pull-test.sh:653:99: warning[SC2046]: Quote this to prevent word splitting. # 651| fi # 652| assert_file_has_content err.txt "404" # 653|-> find ostree-srv/gnomerepo/objects -name '*.dirtree.orig' | while read f; do mv ${f} $(dirname $f)/$(basename ${f} .orig); done # 654| echo "ok pull repo 404 on dirtree object" # 655| Error: SHELLCHECK_WARNING (CWE-758): [#def80] /usr/libexec/installed-tests/libostree/pull-test2.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. # 1|-> # This file is to be sourced, not executed # 2| # 3| # Copyright (C) 2011 Colin Walters <walters@verbum.org> Error: SHELLCHECK_WARNING (CWE-457): [#def81] /usr/libexec/installed-tests/libostree/pull-test2.sh:23:8: warning[SC2154]: test_tmpdir is referenced but not assigned. # 21| # 22| function repo_init() { # 23|-> cd ${test_tmpdir} # 24| rm repo -rf # 25| mkdir repo Error: SHELLCHECK_WARNING (CWE-457): [#def82] /usr/libexec/installed-tests/libostree/pull-test2.sh:26:34: warning[SC2154]: repo_mode is referenced but not assigned. # 24| rm repo -rf # 25| mkdir repo # 26|-> ostree_repo_init repo --mode=${repo_mode} # 27| ${CMD_PREFIX} ostree --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo "$@" # 28| } Error: SHELLCHECK_WARNING (CWE-156): [#def83] /usr/libexec/installed-tests/libostree/pull-test2.sh:27:56: warning[SC2046]: Quote this to prevent word splitting. # 25| mkdir repo # 26| ostree_repo_init repo --mode=${repo_mode} # 27|-> ${CMD_PREFIX} ostree --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo "$@" # 28| } # 29| Error: SHELLCHECK_WARNING (CWE-563): [#def84] /usr/libexec/installed-tests/libostree/pull-test2.sh:37:5: warning[SC2034]: COMMIT_ARGS appears unused. Verify use (or export if used externally). # 35| CHECKOUT_H_ARGS="-H" # 36| if is_bare_user_only_repo repo; then # 37|-> COMMIT_ARGS="--canonical-permissions" # 38| # Also, since we can't check out uid=0 files we need to check out in user mode # 39| CHECKOUT_U_ARG="-U" Error: SHELLCHECK_WARNING (CWE-563): [#def85] /usr/libexec/installed-tests/libostree/pull-test2.sh:39:5: warning[SC2034]: CHECKOUT_U_ARG appears unused. Verify use (or export if used externally). # 37| COMMIT_ARGS="--canonical-permissions" # 38| # Also, since we can't check out uid=0 files we need to check out in user mode # 39|-> CHECKOUT_U_ARG="-U" # 40| CHECKOUT_H_ARGS="-U -H" # 41| else Error: SHELLCHECK_WARNING (CWE-563): [#def86] /usr/libexec/installed-tests/libostree/pull-test2.sh:43:9: warning[SC2034]: CHECKOUT_H_ARGS appears unused. Verify use (or export if used externally). # 41| else # 42| if grep -E -q '^mode=bare-user' repo/config; then # 43|-> CHECKOUT_H_ARGS="-U -H" # 44| fi # 45| fi Error: SHELLCHECK_WARNING (CWE-457): [#def87] /usr/libexec/installed-tests/libostree/pull-test2.sh:50:52: warning[SC2154]: remote_ref is referenced but not assigned. # 48| cd ${test_tmpdir} # 49| repo_init --no-sign-verify # 50|-> prev_rev=$(ostree --repo=ostree-srv/repo rev-parse ${remote_ref}^) # 51| rev=$(ostree --repo=ostree-srv/repo rev-parse ${remote_ref}) # 52| ${CMD_PREFIX} ostree --repo=ostree-srv/repo static-delta generate ${remote_ref} Error: SHELLCHECK_WARNING (CWE-156): [#def88] /usr/libexec/installed-tests/libostree/test-admin-deploy-2.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-457): [#def89] /usr/libexec/installed-tests/libostree/test-admin-deploy-2.sh:34:43: warning[SC2154]: bootcsum is referenced but not assigned (did you mean 'bootcsum1'?). # 32| # This initial deployment gets kicked off with some kernel arguments # 33| ${CMD_PREFIX} ostree admin deploy --karg=root=LABEL=MOO --karg=quiet --os=testos testos:testos/buildmain/x86_64-runtime # 34|-> assert_has_dir sysroot/boot/ostree/testos-${bootcsum} # 35| # 36| echo "ok deploy command" Error: SHELLCHECK_WARNING (CWE-156): [#def90] /usr/libexec/installed-tests/libostree/test-admin-deploy-2.sh:41:97: warning[SC2046]: Quote this to prevent word splitting. # 39| bootcsum1=${bootcsum} # 40| os_repository_new_commit # 41|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos file://$(pwd)/testos-repo testos/buildmain/x86_64-runtime # 42| ${CMD_PREFIX} ostree admin upgrade --os=testos # 43| bootcsum2=${bootcsum} Error: SHELLCHECK_WARNING (CWE-457): [#def91] /usr/libexec/installed-tests/libostree/test-admin-deploy-2.sh:68:12: warning[SC2154]: version is referenced but not assigned. # 66| os_repository_new_commit "1" # 67| ${CMD_PREFIX} ostree admin upgrade --os=testos # 68|-> oldversion=${version} # 69| # another commit with *same* bootcsum but *new* content # 70| os_repository_new_commit "1" "2" Error: SHELLCHECK_WARNING (CWE-571): [#def92] /usr/libexec/installed-tests/libostree/test-admin-deploy-2.sh:81:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 79| local n=$1 # 80| ${CMD_PREFIX} ostree admin status > status.txt # 81|-> local n_pinned="$(grep -F -c -e 'Pinned: yes' < status.txt)" # 82| if test "${n_pinned}" '!=' "${n}"; then # 83| cat status.txt Error: SHELLCHECK_WARNING (CWE-571): [#def93] /usr/libexec/installed-tests/libostree/test-admin-deploy-2.sh:90:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 88| local n=$1 # 89| ${CMD_PREFIX} ostree admin status > status.txt # 90|-> local n_deployments="$(grep -F -c -e 'Version: ' < status.txt)" # 91| if test "${n_deployments}" '!=' "${n}"; then # 92| cat status.txt Error: SHELLCHECK_WARNING (CWE-156): [#def94] /usr/libexec/installed-tests/libostree/test-admin-deploy-bootid-gc.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def95] /usr/libexec/installed-tests/libostree/test-admin-deploy-bootprefix.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def96] /usr/libexec/installed-tests/libostree/test-admin-deploy-clean.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def97] /usr/libexec/installed-tests/libostree/test-admin-deploy-composefs.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euox pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_ostree_feature composefs Error: SHELLCHECK_WARNING (CWE-457): [#def98] /usr/libexec/installed-tests/libostree/test-admin-deploy-composefs.sh:35:29: warning[SC2154]: test_tmpdir is referenced but not assigned. # 33| enabled=true # 34| EOF # 35|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/testos-repo commit --add-metadata-string version=1.composefs -b testos/buildmain/x86_64-runtime # 36| cd - # 37| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull-local --remote=testos testos-repo testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def99] /usr/libexec/installed-tests/libostree/test-admin-deploy-emptyetc.sh:20:3: warning[SC2046]: Quote this to prevent word splitting. # 18| set -euo pipefail # 19| # 20|-> . $(dirname $0)/libtest.sh # 21| # 22| setup_os_repository "archive" "syslinux" Error: SHELLCHECK_WARNING (CWE-457): [#def100] /usr/libexec/installed-tests/libostree/test-admin-deploy-emptyetc.sh:25:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 23| # 24| echo "1..1" # 25|-> cd ${test_tmpdir}/osdata # 26| mkdir etc # 27| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/testos-repo commit --add-metadata-string "version=42.etc" -b testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def101] /usr/libexec/installed-tests/libostree/test-admin-deploy-etcmerge-cornercases.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-457): [#def102] /usr/libexec/installed-tests/libostree/test-admin-deploy-etcmerge-cornercases.sh:33:43: warning[SC2154]: bootcsum is referenced but not assigned. # 31| # This initial deployment gets kicked off with some kernel arguments # 32| ${CMD_PREFIX} ostree admin deploy --karg=root=LABEL=MOO --karg=quiet --os=testos testos:testos/buildmain/x86_64-runtime # 33|-> assert_has_dir sysroot/boot/ostree/testos-${bootcsum} # 34| # 35| etc=sysroot/ostree/deploy/testos/deploy/${rev}.0/etc Error: SHELLCHECK_WARNING (CWE-156): [#def103] /usr/libexec/installed-tests/libostree/test-admin-deploy-etcmerge-cornercases.sh:60:97: warning[SC2046]: Quote this to prevent word splitting. # 58| # Now deploy a new commit # 59| os_repository_new_commit # 60|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos file://$(pwd)/testos-repo testos/buildmain/x86_64-runtime # 61| ${CMD_PREFIX} ostree admin upgrade --os=testos # 62| newrev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmain/x86_64-runtime) Error: SHELLCHECK_WARNING (CWE-457): [#def104] /usr/libexec/installed-tests/libostree/test-admin-deploy-etcmerge-cornercases.sh:98:5: warning[SC2154]: test_tmpdir is referenced but not assigned. # 96| # 97| # Add /etc/initially-empty # 98|-> cd "${test_tmpdir}/osdata" # 99| mkdir -p usr/etc/initially-empty # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/testos-repo commit -b testos/buildmain/x86_64-runtime -s "Add empty directory" Error: SHELLCHECK_WARNING (CWE-156): [#def105] /usr/libexec/installed-tests/libostree/test-admin-deploy-grub2.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-563): [#def106] /usr/libexec/installed-tests/libostree/test-admin-deploy-grub2.sh:27:1: warning[SC2034]: extra_admin_tests appears unused. Verify use (or export if used externally). # 25| setup_os_repository "archive" "grub2 ostree-grub-generator" # 26| # 27|-> extra_admin_tests=0 # 28| # 29| . $(dirname $0)/admin-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def107] /usr/libexec/installed-tests/libostree/test-admin-deploy-grub2.sh:29:3: warning[SC2046]: Quote this to prevent word splitting. # 27| extra_admin_tests=0 # 28| # 29|-> . $(dirname $0)/admin-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def108] /usr/libexec/installed-tests/libostree/test-admin-deploy-karg.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def109] /usr/libexec/installed-tests/libostree/test-admin-deploy-nomerge.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def110] /usr/libexec/installed-tests/libostree/test-admin-deploy-none.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-563): [#def111] /usr/libexec/installed-tests/libostree/test-admin-deploy-none.sh:27:1: warning[SC2034]: extra_admin_tests appears unused. Verify use (or export if used externally). # 25| setup_os_repository "archive" "sysroot.bootloader none" # 26| # 27|-> extra_admin_tests=1 # 28| # 29| . $(dirname $0)/admin-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def112] /usr/libexec/installed-tests/libostree/test-admin-deploy-none.sh:29:3: warning[SC2046]: Quote this to prevent word splitting. # 27| extra_admin_tests=1 # 28| # 29|-> . $(dirname $0)/admin-test.sh # 30| # 31| # Test that the bootloader configuration "none" generates BLS config snippets. Error: SHELLCHECK_WARNING (CWE-457): [#def113] /usr/libexec/installed-tests/libostree/test-admin-deploy-none.sh:32:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 30| # 31| # Test that the bootloader configuration "none" generates BLS config snippets. # 32|-> cd ${test_tmpdir} # 33| rm httpd osdata testos-repo sysroot -rf # 34| setup_os_repository "archive" "sysroot.bootloader none" Error: SHELLCHECK_WARNING (CWE-457): [#def114] /usr/libexec/installed-tests/libostree/test-admin-deploy-none.sh:43:52: warning[SC2154]: bootcsum is referenced but not assigned. # 41| assert_file_has_content out.txt "Bootloader updated.*" # 42| assert_file_has_content sysroot/boot/loader/entries/ostree-1.conf 'options.* root=LABEL=MOO' # 43|-> assert_file_has_content sysroot/boot/ostree/testos-${bootcsum}/vmlinuz-3.6.0 'a kernel' # 44| assert_file_has_content sysroot/boot/ostree/testos-${bootcsum}/.vmlinuz-3.6.0.hmac 'an hmac file' # 45| assert_file_has_content sysroot/boot/ostree/testos-${bootcsum}/initramfs-3.6.0.img 'an initramfs' Error: SHELLCHECK_WARNING (CWE-156): [#def115] /usr/libexec/installed-tests/libostree/test-admin-deploy-switch.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def116] /usr/libexec/installed-tests/libostree/test-admin-deploy-switch.sh:29:97: warning[SC2046]: Quote this to prevent word splitting. # 27| echo "1..4" # 28| # 29|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos file://$(pwd)/testos-repo # 30| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime # 31| ${CMD_PREFIX} ostree admin deploy --karg=root=LABEL=MOO --karg=quiet --os=testos testos:testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def117] /usr/libexec/installed-tests/libostree/test-admin-deploy-switch.sh:45:104: warning[SC2046]: Quote this to prevent word splitting. # 43| echo "ok switch" # 44| # 45|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false anothertestos file://$(pwd)/testos-repo # 46| ${CMD_PREFIX} ostree admin switch --os=testos anothertestos:testos/buildmain/x86_64-devel # 47| # Ok this is lame, need a better shell command to extract config, or switch to gjs Error: SHELLCHECK_WARNING (CWE-156): [#def118] /usr/libexec/installed-tests/libostree/test-admin-deploy-syslinux.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-563): [#def119] /usr/libexec/installed-tests/libostree/test-admin-deploy-syslinux.sh:27:1: warning[SC2034]: extra_admin_tests appears unused. Verify use (or export if used externally). # 25| setup_os_repository "archive" "syslinux" # 26| # 27|-> extra_admin_tests=3 # 28| # 29| . $(dirname $0)/admin-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def120] /usr/libexec/installed-tests/libostree/test-admin-deploy-syslinux.sh:29:3: warning[SC2046]: Quote this to prevent word splitting. # 27| extra_admin_tests=3 # 28| # 29|-> . $(dirname $0)/admin-test.sh # 30| # 31| # Test the legacy dirs Error: SHELLCHECK_WARNING (CWE-457): [#def121] /usr/libexec/installed-tests/libostree/test-admin-deploy-syslinux.sh:33:8: warning[SC2154]: test_tmpdir is referenced but not assigned. # 31| # Test the legacy dirs # 32| for test_bootdir in "boot" "usr/lib/ostree-boot"; do # 33|-> cd ${test_tmpdir} # 34| rm httpd osdata testos-repo sysroot -rf # 35| setup_os_repository "archive" "syslinux" $test_bootdir Error: SHELLCHECK_WARNING (CWE-457): [#def122] /usr/libexec/installed-tests/libostree/test-admin-deploy-syslinux.sh:41:56: warning[SC2154]: bootcsum is referenced but not assigned. # 39| assert_file_has_content sysroot/boot/loader/entries/ostree-1.conf 'options.* root=LABEL=MOO' # 40| assert_file_has_content sysroot/boot/loader/entries/ostree-1.conf 'options.* quiet' # 41|-> assert_file_has_content sysroot/boot/ostree/testos-${bootcsum}/vmlinuz-3.6.0 'a kernel' # 42| assert_file_has_content sysroot/boot/ostree/testos-${bootcsum}/initramfs-3.6.0.img 'an initramfs' # 43| # kernel/initrams should also be in the tree's /boot with the checksum Error: SHELLCHECK_WARNING (CWE-156): [#def123] /usr/libexec/installed-tests/libostree/test-admin-deploy-uboot.sh:23:3: warning[SC2046]: Quote this to prevent word splitting. # 21| set -euo pipefail # 22| # 23|-> . $(dirname $0)/libtest.sh # 24| # 25| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-563): [#def124] /usr/libexec/installed-tests/libostree/test-admin-deploy-uboot.sh:30:1: warning[SC2034]: extra_admin_tests appears unused. Verify use (or export if used externally). # 28| setup_os_repository "archive" "uboot" ${modulesdir} # 29| # 30|-> extra_admin_tests=2 # 31| # 32| . $(dirname $0)/admin-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def125] /usr/libexec/installed-tests/libostree/test-admin-deploy-uboot.sh:32:3: warning[SC2046]: Quote this to prevent word splitting. # 30| extra_admin_tests=2 # 31| # 32|-> . $(dirname $0)/admin-test.sh # 33| # 34| cd ${test_tmpdir} Error: SHELLCHECK_WARNING (CWE-457): [#def126] /usr/libexec/installed-tests/libostree/test-admin-deploy-uboot.sh:34:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 32| . $(dirname $0)/admin-test.sh # 33| # 34|-> cd ${test_tmpdir} # 35| # Note this test actually requires a checksum change to /boot, # 36| # because adding the uEnv.txt isn't currently covered by the Error: SHELLCHECK_WARNING (CWE-156): [#def127] /usr/libexec/installed-tests/libostree/test-admin-deploy-var.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euox pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| if ! has_ostree_feature initial-var; then Error: SHELLCHECK_WARNING (CWE-457): [#def128] /usr/libexec/installed-tests/libostree/test-admin-deploy-var.sh:37:29: warning[SC2154]: test_tmpdir is referenced but not assigned. # 35| mkdir -p var/lib/ # 36| echo somedata > var/lib/somefile # 37|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/testos-repo commit -b testos/buildmain/x86_64-runtime # 38| cd - # 39| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull-local --remote=testos testos-repo testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def129] /usr/libexec/installed-tests/libostree/test-admin-deploy-whiteouts.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euox pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_whiteouts_devices Error: SHELLCHECK_WARNING (CWE-156): [#def130] /usr/libexec/installed-tests/libostree/test-admin-gpg.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| if test -z "${OSTREE_HTTPD}"; then Error: SHELLCHECK_WARNING (CWE-457): [#def131] /usr/libexec/installed-tests/libostree/test-admin-gpg.sh:39:8: warning[SC2154]: test_tmpdir is referenced but not assigned. # 37| keyid="7FCA23D8472CDAFA" # 38| # 39|-> cd ${test_tmpdir} # 40| mkdir testos-repo # 41| if test -n "$mode"; then Error: SHELLCHECK_WARNING (CWE-156): [#def132] /usr/libexec/installed-tests/libostree/test-admin-gpg.sh:142:67: warning[SC2046]: Quote this to prevent word splitting. # 140| echo "1..2" # 141| # 142|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add testos $(cat httpd-address)/ostree/testos-repo # 143| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull-local --gpg-verify=true --remote=testos testos-repo testos/buildmain/x86_64-runtime # 144| # This initial deployment gets kicked off with some kernel arguments Error: SHELLCHECK_WARNING (CWE-156): [#def133] /usr/libexec/installed-tests/libostree/test-admin-instutil-set-kargs.sh:23:3: warning[SC2046]: Quote this to prevent word splitting. # 21| set -euo pipefail # 22| # 23|-> . $(dirname $0)/libtest.sh # 24| # 25| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def134] /usr/libexec/installed-tests/libostree/test-admin-kargs.sh:23:3: warning[SC2046]: Quote this to prevent word splitting. # 21| set -euo pipefail # 22| # 23|-> . $(dirname $0)/libtest.sh # 24| # 25| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def135] /usr/libexec/installed-tests/libostree/test-admin-locking.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-457): [#def136] /usr/libexec/installed-tests/libostree/test-admin-locking.sh:35:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 33| echo "1..1" # 34| # 35|-> cd ${test_tmpdir} # 36| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 37| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def137] /usr/libexec/installed-tests/libostree/test-admin-locking.sh:36:90: warning[SC2046]: Quote this to prevent word splitting. # 34| # 35| cd ${test_tmpdir} # 36|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 37| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime # 38| rev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmain/x86_64-runtime) Error: SHELLCHECK_WARNING (CWE-457): [#def138] /usr/libexec/installed-tests/libostree/test-admin-locking.sh:43:43: warning[SC2154]: bootcsum is referenced but not assigned. # 41| # This initial deployment gets kicked off with some kernel arguments # 42| ${CMD_PREFIX} ostree admin deploy --karg=root=LABEL=MOO --karg=quiet --os=testos testos:testos/buildmain/x86_64-runtime # 43|-> assert_has_dir sysroot/boot/ostree/testos-${bootcsum} # 44| # 45| parallel_cmd="parallel --gnu" Error: SHELLCHECK_WARNING (CWE-156): [#def139] /usr/libexec/installed-tests/libostree/test-admin-pull-deploy-commit.sh:24:3: warning[SC2046]: Quote this to prevent word splitting. # 22| set -euo pipefail # 23| # 24|-> . $(dirname $0)/libtest.sh # 25| # 26| echo "1..1" Error: SHELLCHECK_WARNING (CWE-457): [#def140] /usr/libexec/installed-tests/libostree/test-admin-pull-deploy-commit.sh:30:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| setup_os_repository "archive" "syslinux" # 29| # 30|-> cd ${test_tmpdir} # 31| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 32| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def141] /usr/libexec/installed-tests/libostree/test-admin-pull-deploy-commit.sh:31:90: warning[SC2046]: Quote this to prevent word splitting. # 29| # 30| cd ${test_tmpdir} # 31|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 32| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime # 33| rev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmain/x86_64-runtime) Error: SHELLCHECK_WARNING (CWE-156): [#def142] /usr/libexec/installed-tests/libostree/test-admin-pull-deploy-split.sh:24:3: warning[SC2046]: Quote this to prevent word splitting. # 22| set -euo pipefail # 23| # 24|-> . $(dirname $0)/libtest.sh # 25| # 26| echo "1..1" Error: SHELLCHECK_WARNING (CWE-457): [#def143] /usr/libexec/installed-tests/libostree/test-admin-pull-deploy-split.sh:30:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| setup_os_repository "archive" "syslinux" # 29| # 30|-> cd ${test_tmpdir} # 31| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 32| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def144] /usr/libexec/installed-tests/libostree/test-admin-pull-deploy-split.sh:31:90: warning[SC2046]: Quote this to prevent word splitting. # 29| # 30| cd ${test_tmpdir} # 31|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 32| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime # 33| rev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmain/x86_64-runtime) Error: SHELLCHECK_WARNING (CWE-156): [#def145] /usr/libexec/installed-tests/libostree/test-admin-pull-deploy-split.sh:48:23: warning[SC2046]: Quote this to prevent word splitting. # 46| assert_not_has_dir sysroot/ostree/deploy/testos/deploy/${rev}.0 # 47| assert_file_has_content sysroot/boot/loader/entries/ostree-1.conf 'TestOS 42 1\.0\.9' # 48|-> assert_streq "${rev}" $(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmain/x86_64-runtime) # 49| # Now, generate new content upstream; we shouldn't pull it # 50| os_repository_new_commit Error: SHELLCHECK_WARNING (CWE-156): [#def146] /usr/libexec/installed-tests/libostree/test-admin-stateroot.sh:23:3: warning[SC2046]: Quote this to prevent word splitting. # 21| set -euo pipefail # 22| # 23|-> . $(dirname $0)/libtest.sh # 24| # 25| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def147] /usr/libexec/installed-tests/libostree/test-admin-upgrade-endoflife.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-457): [#def148] /usr/libexec/installed-tests/libostree/test-admin-upgrade-endoflife.sh:35:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 33| echo "1..3" # 34| # 35|-> cd ${test_tmpdir} # 36| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 37| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def149] /usr/libexec/installed-tests/libostree/test-admin-upgrade-endoflife.sh:36:90: warning[SC2046]: Quote this to prevent word splitting. # 34| # 35| cd ${test_tmpdir} # 36|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 37| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime # 38| rev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmain/x86_64-runtime) Error: SHELLCHECK_WARNING (CWE-457): [#def150] /usr/libexec/installed-tests/libostree/test-admin-upgrade-endoflife.sh:46:43: warning[SC2154]: bootcsum is referenced but not assigned. # 44| # This initial deployment gets kicked off with some kernel arguments # 45| ${CMD_PREFIX} ostree admin deploy --karg=root=LABEL=MOO --karg=quiet --os=testos testos:testos/buildmain/x86_64-runtime # 46|-> assert_has_dir sysroot/boot/ostree/testos-${bootcsum} # 47| # 48| echo "ok deploy" Error: SHELLCHECK_WARNING (CWE-156): [#def151] /usr/libexec/installed-tests/libostree/test-admin-upgrade-endoflife.sh:57:74: warning[SC2046]: Quote this to prevent word splitting. # 55| # EOL, redirecting to the new one. # 56| mkdir empty # 57|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/testos-repo commit --tree=dir=$(pwd)/empty --add-metadata-string "ostree.endoflife=Product discontinued" --add-metadata-string "ostree.endoflife-rebase=testos/buildmain/newbranch" -b testos/buildmain/x86_64-runtime -s "EOL redirect to new branch" # 58| # 59| echo "ok new branch" Error: SHELLCHECK_WARNING (CWE-156): [#def152] /usr/libexec/installed-tests/libostree/test-admin-upgrade-not-backwards.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-457): [#def153] /usr/libexec/installed-tests/libostree/test-admin-upgrade-not-backwards.sh:30:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| # 29| ref=testos/buildmain/x86_64-runtime # 30|-> cd ${test_tmpdir} # 31| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 32| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos ${ref} Error: SHELLCHECK_WARNING (CWE-156): [#def154] /usr/libexec/installed-tests/libostree/test-admin-upgrade-not-backwards.sh:31:90: warning[SC2046]: Quote this to prevent word splitting. # 29| ref=testos/buildmain/x86_64-runtime # 30| cd ${test_tmpdir} # 31|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 32| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos ${ref} # 33| rev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse ${ref}) Error: SHELLCHECK_WARNING (CWE-457): [#def155] /usr/libexec/installed-tests/libostree/test-admin-upgrade-not-backwards.sh:38:43: warning[SC2154]: bootcsum is referenced but not assigned. # 36| # This initial deployment gets kicked off with some kernel arguments # 37| ${CMD_PREFIX} ostree admin deploy --karg=root=LABEL=MOO --karg=quiet --os=testos testos:${ref} # 38|-> assert_has_dir sysroot/boot/ostree/testos-${bootcsum} # 39| # 40| # This should be a no-op Error: SHELLCHECK_WARNING (CWE-156): [#def156] /usr/libexec/installed-tests/libostree/test-admin-upgrade-systemd-update.sh:20:3: warning[SC2046]: Quote this to prevent word splitting. # 18| set -euo pipefail # 19| # 20|-> . $(dirname $0)/libtest.sh # 21| # 22| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-457): [#def157] /usr/libexec/installed-tests/libostree/test-admin-upgrade-systemd-update.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| # 27| # Setup a deployment # 28|-> cd ${test_tmpdir} # 29| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 30| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def158] /usr/libexec/installed-tests/libostree/test-admin-upgrade-systemd-update.sh:29:90: warning[SC2046]: Quote this to prevent word splitting. # 27| # Setup a deployment # 28| cd ${test_tmpdir} # 29|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 30| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime # 31| rev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmain/x86_64-runtime) Error: SHELLCHECK_WARNING (CWE-156): [#def159] /usr/libexec/installed-tests/libostree/test-admin-upgrade-unconfigured.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Exports OSTREE_SYSROOT so --sysroot not needed. Error: SHELLCHECK_WARNING (CWE-156): [#def160] /usr/libexec/installed-tests/libostree/test-admin-upgrade-unconfigured.sh:37:97: warning[SC2046]: Quote this to prevent word splitting. # 35| echo "unconfigured-state=Use \"subscription-manager\" to enable online updates for example.com OS" >> sysroot/ostree/deploy/testos/deploy/${rev}.0.origin # 36| # 37|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos file://$(pwd)/testos-repo testos/buildmain/x86_64-runtime # 38| if ${CMD_PREFIX} ostree admin upgrade --os=testos 2>err.txt; then # 39| assert_not_reached "upgrade unexpectedly succeeded" Error: SHELLCHECK_WARNING (CWE-156): [#def161] /usr/libexec/installed-tests/libostree/test-admin-upgrade-unconfigured.sh:45:98: warning[SC2046]: Quote this to prevent word splitting. # 43| echo "ok error" # 44| # 45|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false otheros file://$(pwd)/testos-repo testos/buildmain/x86_64-runtime # 46| ${CMD_PREFIX} ostree admin switch --os=testos otheros:testos/buildmain/x86_64-runtime # 47| Error: SHELLCHECK_WARNING (CWE-156): [#def162] /usr/libexec/installed-tests/libostree/test-archivez.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..13' Error: SHELLCHECK_WARNING (CWE-457): [#def163] /usr/libexec/installed-tests/libostree/test-archivez.sh:28:3: warning[SC2154]: test_srcdir is referenced but not assigned. # 26| setup_test_repository "archive" # 27| # 28|-> . ${test_srcdir}/archive-test.sh # 29| # 30| ${CMD_PREFIX} ostree --repo=repo-archive-z2 init --mode=archive-z2 Error: SHELLCHECK_WARNING (CWE-457): [#def164] /usr/libexec/installed-tests/libostree/test-archivez.sh:33:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 31| echo "ok did an init with archive-z2 alias" # 32| # 33|-> cd ${test_tmpdir} # 34| mkdir repo2 # 35| ostree_repo_init repo2 Error: SHELLCHECK_WARNING (CWE-156): [#def165] /usr/libexec/installed-tests/libostree/test-archivez.sh:36:84: warning[SC2046]: Quote this to prevent word splitting. # 34| mkdir repo2 # 35| ostree_repo_init repo2 # 36|-> ${CMD_PREFIX} ostree --repo=repo2 remote add --set=gpg-verify=false aremote file://$(pwd)/repo test2 # 37| ${CMD_PREFIX} ostree --repo=repo2 pull aremote # 38| ${CMD_PREFIX} ostree --repo=repo2 rev-parse aremote/test2 Error: SHELLCHECK_WARNING (CWE-156): [#def166] /usr/libexec/installed-tests/libostree/test-auto-summary.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| echo "1..4" # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| setup_test_repository "bare" Error: SHELLCHECK_WARNING (CWE-156): [#def167] /usr/libexec/installed-tests/libostree/test-basic-bare-split-xattrs.sh:7:3: warning[SC2046]: Quote this to prevent word splitting. # 5| set -euo pipefail # 6| # 7|-> . $(dirname $0)/libtest.sh # 8| # 9| mode="bare-split-xattrs" Error: SHELLCHECK_WARNING (CWE-457): [#def168] /usr/libexec/installed-tests/libostree/test-basic-bare-split-xattrs.sh:10:37: warning[SC2154]: test_tmpdir is referenced but not assigned. # 8| # 9| mode="bare-split-xattrs" # 10|-> OSTREE="${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo" # 11| # 12| skip_without_sudo Error: SHELLCHECK_WARNING (CWE-156): [#def169] /usr/libexec/installed-tests/libostree/test-basic-bare-split-xattrs.sh:16:6: warning[SC2046]: Quote this to prevent word splitting. # 14| # 15| PRIVILEGED="false" # 16|-> if [ $(id -u) -eq 0 ]; then # 17| PRIVILEGED="true" # 18| SUDO="" Error: SHELLCHECK_WARNING (CWE-829): [#def170] /usr/libexec/installed-tests/libostree/test-basic-bare-split-xattrs.sh:19:6: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional). # 17| PRIVILEGED="true" # 18| SUDO="" # 19|-> elif $(${SUDO} -v); then # 20| PRIVILEGED="true" # 21| fi Error: SHELLCHECK_WARNING (CWE-457): [#def171] /usr/libexec/installed-tests/libostree/test-basic-bare-split-xattrs.sh:61:54: warning[SC2154]: test_srcdir is referenced but not assigned. # 59| COMMIT="d614c428015227259031b0f19b934dade908942fd71c49047e0daa70e7800a5d" # 60| cd ${test_tmpdir} # 61|-> ${SUDO} tar --same-permissions --same-owner -xaf ${test_srcdir}/bare-split-xattrs-basic.tar.xz # 62| ${SUDO} ${OSTREE} fsck --all # 63| ${OSTREE} log ${COMMIT} > out.txt Error: SHELLCHECK_WARNING (CWE-156): [#def172] /usr/libexec/installed-tests/libostree/test-basic-root.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| id=$(id -u) Error: SHELLCHECK_WARNING (CWE-1164): [#def173] /usr/libexec/installed-tests/libostree/test-basic-root.sh:45:12: warning[SC2043]: This loop will only ever run once. Bad quoting or missing glob/expansion? # 43| # Both hardlinks and copies should respect ownership, but we don't have -C yet; # 44| # add it when we do. # 45|-> for opt in -H; do # 46| rm test2-co -rf # 47| $OSTREE checkout ${opt} test2 test2-co Error: SHELLCHECK_WARNING (CWE-156): [#def174] /usr/libexec/installed-tests/libostree/test-basic-user-only.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| mode="bare-user-only" Error: SHELLCHECK_WARNING (CWE-563): [#def175] /usr/libexec/installed-tests/libostree/test-basic-user-only.sh:26:1: warning[SC2034]: extra_basic_tests appears unused. Verify use (or export if used externally). # 24| mode="bare-user-only" # 25| setup_test_repository "$mode" # 26|-> extra_basic_tests=7 # 27| . $(dirname $0)/basic-test.sh # 28| Error: SHELLCHECK_WARNING (CWE-156): [#def176] /usr/libexec/installed-tests/libostree/test-basic-user-only.sh:27:3: warning[SC2046]: Quote this to prevent word splitting. # 25| setup_test_repository "$mode" # 26| extra_basic_tests=7 # 27|-> . $(dirname $0)/basic-test.sh # 28| # 29| $CMD_PREFIX ostree --version > version.yaml Error: SHELLCHECK_WARNING (CWE-457): [#def177] /usr/libexec/installed-tests/libostree/test-basic-user-only.sh:34:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 32| # 33| # Reset things so we don't inherit a lot of state from earlier tests # 34|-> cd ${test_tmpdir} # 35| rm repo files -rf # 36| ostree_repo_init repo init --mode=bare-user-only Error: SHELLCHECK_WARNING (CWE-156): [#def178] /usr/libexec/installed-tests/libostree/test-basic-user.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-563): [#def179] /usr/libexec/installed-tests/libostree/test-basic-user.sh:29:1: warning[SC2034]: extra_basic_tests appears unused. Verify use (or export if used externally). # 27| setup_test_repository "$mode" # 28| # 29|-> extra_basic_tests=6 # 30| . $(dirname $0)/basic-test.sh # 31| Error: SHELLCHECK_WARNING (CWE-156): [#def180] /usr/libexec/installed-tests/libostree/test-basic-user.sh:30:3: warning[SC2046]: Quote this to prevent word splitting. # 28| # 29| extra_basic_tests=6 # 30|-> . $(dirname $0)/basic-test.sh # 31| # 32| # Reset things so we don't inherit a lot of state from earlier tests Error: SHELLCHECK_WARNING (CWE-457): [#def181] /usr/libexec/installed-tests/libostree/test-basic-user.sh:36:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 34| setup_test_repository "bare-user" # 35| # 36|-> cd ${test_tmpdir} # 37| objpath_nonexec=$(ostree_file_path_to_object_path repo test2 baz/cow) # 38| assert_file_has_mode ${objpath_nonexec} 644 Error: SHELLCHECK_WARNING (CWE-156): [#def182] /usr/libexec/installed-tests/libostree/test-basic-user.sh:77:14: warning[SC2046]: Quote this to prevent word splitting. # 75| assert_file_has_mode test2-checkout/unreadable 400 # 76| # Should not be hardlinked # 77|-> assert_streq $(stat -c "%h" test2-checkout/unreadable) 1 # 78| echo "ok bare-user handled unreadable file" # 79| Error: SHELLCHECK_WARNING (CWE-156): [#def183] /usr/libexec/installed-tests/libostree/test-basic.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_no_selinux_or_relabel Error: SHELLCHECK_WARNING (CWE-156): [#def184] /usr/libexec/installed-tests/libostree/test-basic.sh:28:3: warning[SC2046]: Quote this to prevent word splitting. # 26| mode="bare" # 27| setup_test_repository "$mode" # 28|-> . $(dirname $0)/basic-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def185] /usr/libexec/installed-tests/libostree/test-cli-extensions.sh:8:3: warning[SC2046]: Quote this to prevent word splitting. # 6| set -euo pipefail # 7| # 8|-> . $(dirname $0)/libtest.sh # 9| # 10| echo '1..2' Error: SHELLCHECK_WARNING (CWE-156): [#def186] /usr/libexec/installed-tests/libostree/test-commit-sign.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_ostree_feature gpgme Error: SHELLCHECK_WARNING (CWE-457): [#def187] /usr/libexec/installed-tests/libostree/test-commit-sign.sh:45:30: warning[SC2154]: test_tmpdir is referenced but not assigned. # 43| echo moo > baz/cow # 44| echo alien > baz/saucer # 45|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo commit -b main -s "A remote commit" -m "Some Commit body" --gpg-sign=$keyid --gpg-homedir=${test_tmpdir}/gpghome # 46| mkdir baz/deeper # 47| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo commit -b main -s "Add deeper" --gpg-sign=$keyid --gpg-homedir=${test_tmpdir}/gpghome Error: SHELLCHECK_WARNING (CWE-156): [#def188] /usr/libexec/installed-tests/libostree/test-commit-sign.sh:73:52: warning[SC2046]: Quote this to prevent word splitting. # 71| mkdir repo # 72| ostree_repo_init repo # 73|-> ${CMD_PREFIX} ostree --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo # 74| if env OSTREE_GPG_HOME=${test_tmpdir} ${CMD_PREFIX} ostree --repo=repo pull origin main; then # 75| assert_not_reached "pull with no trusted GPG keys unexpectedly succeeded!" Error: SHELLCHECK_WARNING (CWE-156): [#def189] /usr/libexec/installed-tests/libostree/test-commit-sign.sh:84:52: warning[SC2046]: Quote this to prevent word splitting. # 82| mkdir repo # 83| ostree_repo_init repo # 84|-> ${CMD_PREFIX} ostree --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo # 85| ${CMD_PREFIX} ostree --repo=repo pull origin main # 86| ${CMD_PREFIX} ostree --repo=repo show --gpg-verify-remote=origin main > show.txt Error: SHELLCHECK_WARNING (CWE-156): [#def190] /usr/libexec/installed-tests/libostree/test-commit-sign.sh:108:52: warning[SC2046]: Quote this to prevent word splitting. # 106| mkdir repo # 107| ostree_repo_init repo # 108|-> ${CMD_PREFIX} ostree --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo # 109| if ${CMD_PREFIX} ostree --repo=repo pull origin main; then # 110| assert_not_reached "pull with corrupted signature unexpectedly succeeded!" Error: SHELLCHECK_WARNING (CWE-156): [#def191] /usr/libexec/installed-tests/libostree/test-commit-sign.sh:120:75: warning[SC2046]: Quote this to prevent word splitting. # 118| mkdir repo # 119| ostree_repo_init repo # 120|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 121| ${CMD_PREFIX} ostree --repo=repo pull origin main # 122| rm repo -rf Error: SHELLCHECK_WARNING (CWE-156): [#def192] /usr/libexec/installed-tests/libostree/test-commit-sign.sh:134:75: warning[SC2046]: Quote this to prevent word splitting. # 132| mkdir repo # 133| ostree_repo_init repo # 134|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 135| ${CMD_PREFIX} ostree --repo=repo pull origin main # 136| ${CMD_PREFIX} ostree --repo=repo show main > show.txt Error: SHELLCHECK_WARNING (CWE-156): [#def193] /usr/libexec/installed-tests/libostree/test-commit-timestamp.sh:7:3: warning[SC2046]: Quote this to prevent word splitting. # 5| set -euo pipefail # 6| # 7|-> . $(dirname $0)/libtest.sh # 8| TZ='UTC' # 9| LANG='C' Error: SHELLCHECK_WARNING (CWE-156): [#def194] /usr/libexec/installed-tests/libostree/test-composefs.sh:20:3: warning[SC2046]: Quote this to prevent word splitting. # 18| set -euo pipefail # 19| # 20|-> . $(dirname $0)/libtest.sh # 21| # 22| skip_without_ostree_feature composefs Error: SHELLCHECK_WARNING (CWE-457): [#def195] /usr/libexec/installed-tests/libostree/test-composefs.sh:27:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 25| setup_test_repository "bare-user" # 26| # 27|-> cd ${test_tmpdir} # 28| $OSTREE checkout test2 test2-co # 29| rm test2-co/whiteouts -rf # This may or may not exist Error: SHELLCHECK_WARNING (CWE-156): [#def196] /usr/libexec/installed-tests/libostree/test-config.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..3' Error: SHELLCHECK_WARNING (CWE-156): [#def197] /usr/libexec/installed-tests/libostree/test-create-usb.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| set -euo pipefail # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| skip_without_ostree_feature gpgme Error: SHELLCHECK_WARNING (CWE-457): [#def198] /usr/libexec/installed-tests/libostree/test-create-usb.sh:31:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 29| echo "1..5" # 30| # 31|-> cd ${test_tmpdir} # 32| mkdir repo # 33| ostree_repo_init repo --collection-id org.example.Collection1 Error: SHELLCHECK_WARNING (CWE-156): [#def199] /usr/libexec/installed-tests/libostree/test-create-usb.sh:50:66: warning[SC2046]: Quote this to prevent word splitting. # 48| mkdir local-repo # 49| ${CMD_PREFIX} ostree --repo=local-repo init # 50|-> ${CMD_PREFIX} ostree --repo=local-repo remote add remote1 file://$(pwd)/repo --collection-id org.example.Collection1 --gpg-import="${test_tmpdir}/gpghome/key1.asc" # 51| ${CMD_PREFIX} ostree --repo=local-repo pull remote1 test-1 test-2 test-3 test-4 test-5 # 52| Error: SHELLCHECK_WARNING (CWE-156): [#def200] /usr/libexec/installed-tests/libostree/test-create-usb.sh:109:67: warning[SC2046]: Quote this to prevent word splitting. # 107| mkdir finder-repo # 108| ostree_repo_init finder-repo # 109|-> ${CMD_PREFIX} ostree --repo=finder-repo remote add remote1 file://$(pwd)/just-needed-for-the-keyring --collection-id org.example.Collection1 --gpg-import="${test_tmpdir}/gpghome/key1.asc" # 110| # 111| ${test_builddir}/repo-finder-mount finder-repo dest-mount1 org.example.Collection1 test-1 org.example.Collection1 test-2 &> out Error: SHELLCHECK_WARNING (CWE-457): [#def201] /usr/libexec/installed-tests/libostree/test-create-usb.sh:111:1: warning[SC2154]: test_builddir is referenced but not assigned. # 109| ${CMD_PREFIX} ostree --repo=finder-repo remote add remote1 file://$(pwd)/just-needed-for-the-keyring --collection-id org.example.Collection1 --gpg-import="${test_tmpdir}/gpghome/key1.asc" # 110| # 111|-> ${test_builddir}/repo-finder-mount finder-repo dest-mount1 org.example.Collection1 test-1 org.example.Collection1 test-2 &> out # 112| assert_file_has_content out "^0 .*_2Fdest-mount1_2F\.ostree_2Frepo_remote1\.trustedkeys\.gpg org\.example\.Collection1 test-1 $(ostree --repo=repo show test-1)$" # 113| assert_file_has_content out "^0 .*_2Fdest-mount1_2F\.ostree_2Frepo_remote1\.trustedkeys\.gpg org\.example\.Collection1 test-2 $(ostree --repo=repo show test-2)$" Error: SHELLCHECK_WARNING (CWE-156): [#def202] /usr/libexec/installed-tests/libostree/test-delta-ed25519.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-156): [#def203] /usr/libexec/installed-tests/libostree/test-delta-ed25519.sh:37:8: warning[SC2046]: Quote this to prevent word splitting. # 35| mkdir files # 36| for bin in ${bindatafiles}; do # 37|-> cp $(which ${bin}) files # 38| done # 39| Error: SHELLCHECK_WARNING (CWE-457): [#def204] /usr/libexec/installed-tests/libostree/test-delta-ed25519.sh:96:25: warning[SC2154]: test_tmpdir is referenced but not assigned. # 94| WRONG_PUBLIC="$(gen_ed25519_random_public)" # 95| # 96|-> SECRETKEYS="$(mktemp -p ${test_tmpdir} ed25519_XXXXXX.ed25519)" # 97| echo ${SECRET} > ${SECRETKEYS} # 98| Error: SHELLCHECK_WARNING (CWE-156): [#def205] /usr/libexec/installed-tests/libostree/test-delta-sign.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-156): [#def206] /usr/libexec/installed-tests/libostree/test-delta-sign.sh:38:8: warning[SC2046]: Quote this to prevent word splitting. # 36| mkdir files # 37| for bin in ${bindatafiles}; do # 38|-> cp $(which ${bin}) files # 39| done # 40| Error: SHELLCHECK_WARNING (CWE-156): [#def207] /usr/libexec/installed-tests/libostree/test-delta.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-563): [#def208] /usr/libexec/installed-tests/libostree/test-delta.sh:27:1: warning[SC2034]: morebindatafiles appears unused. Verify use (or export if used externally). # 25| # 26| bindatafiles="bash true ostree" # 27|-> morebindatafiles="false ls" # 28| # 29| echo '1..14' Error: SHELLCHECK_WARNING (CWE-156): [#def209] /usr/libexec/installed-tests/libostree/test-delta.sh:36:8: warning[SC2046]: Quote this to prevent word splitting. # 34| mkdir files # 35| for bin in ${bindatafiles}; do # 36|-> cp $(which ${bin}) files # 37| done # 38| Error: SHELLCHECK_WARNING (CWE-457): [#def210] /usr/libexec/installed-tests/libostree/test-delta.sh:162:8: warning[SC2154]: test_srcdir is referenced but not assigned. # 160| echo 'ok generate + show endian swapped' # 161| # 162|-> tar xf ${test_srcdir}/pre-endian-deltas-repo-big.tar.xz # 163| mv pre-endian-deltas-repo{,-big} # 164| tar xf ${test_srcdir}/pre-endian-deltas-repo-little.tar.xz Error: SHELLCHECK_WARNING (CWE-156): [#def211] /usr/libexec/installed-tests/libostree/test-demo-buildsystem.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_fuse Error: SHELLCHECK_WARNING (CWE-156): [#def212] /usr/libexec/installed-tests/libostree/test-demo-buildsystem.sh:34:30: warning[SC2046]: Quote this to prevent word splitting. # 32| shift # 33| mkdir -p ${root}/usr/lib # 34|-> echo updated ldconfig at $(date) > ${root}/usr/lib/ld.so.cache.new # 35| mv ${root}/usr/lib/ld.so.cache{.new,} # 36| } Error: SHELLCHECK_WARNING (CWE-156): [#def213] /usr/libexec/installed-tests/libostree/test-export.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_ostree_feature libarchive Error: SHELLCHECK_WARNING (CWE-457): [#def214] /usr/libexec/installed-tests/libostree/test-export.sh:33:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 31| rm test2-co -rf # 32| # 33|-> cd ${test_tmpdir} # 34| ${OSTREE} 'export' test2-noxattrs -o test2.tar # 35| mkdir t Error: SHELLCHECK_WARNING (CWE-156): [#def215] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_ostree_feature gpgme Error: SHELLCHECK_WARNING (CWE-457): [#def216] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:29:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 27| # 28| # Create two upstream collection repositories with some example commits # 29|-> cd ${test_tmpdir} # 30| # 31| mkdir apps-collection Error: SHELLCHECK_WARNING (CWE-156): [#def217] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:51:65: warning[SC2046]: Quote this to prevent word splitting. # 49| mkdir local # 50| ostree_repo_init local # 51|-> ${CMD_PREFIX} ostree --repo=local remote add apps-remote file://$(pwd)/apps-collection --collection-id org.example.AppsCollection --gpg-import=${test_tmpdir}/gpghome/key1.asc # 52| ${CMD_PREFIX} ostree --repo=local remote add os-remote file://$(pwd)/os-collection --collection-id org.example.OsCollection --gpg-import=${test_tmpdir}/gpghome/key2.asc # 53| Error: SHELLCHECK_WARNING (CWE-156): [#def218] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:52:63: warning[SC2046]: Quote this to prevent word splitting. # 50| ostree_repo_init local # 51| ${CMD_PREFIX} ostree --repo=local remote add apps-remote file://$(pwd)/apps-collection --collection-id org.example.AppsCollection --gpg-import=${test_tmpdir}/gpghome/key1.asc # 52|-> ${CMD_PREFIX} ostree --repo=local remote add os-remote file://$(pwd)/os-collection --collection-id org.example.OsCollection --gpg-import=${test_tmpdir}/gpghome/key2.asc # 53| # 54| ${CMD_PREFIX} ostree --repo=local pull apps-remote app1 Error: SHELLCHECK_WARNING (CWE-156): [#def219] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:71:72: warning[SC2046]: Quote this to prevent word splitting. # 69| mkdir local-mirror # 70| ostree_repo_init local-mirror # 71|-> ${CMD_PREFIX} ostree --repo=local-mirror remote add apps-remote file://$(pwd)/apps-collection --collection-id org.example.AppsCollection --gpg-import=${test_tmpdir}/gpghome/key1.asc # 72| ${CMD_PREFIX} ostree --repo=local-mirror remote add os-remote file://$(pwd)/os-collection --collection-id org.example.OsCollection --gpg-import=${test_tmpdir}/gpghome/key2.asc # 73| Error: SHELLCHECK_WARNING (CWE-156): [#def220] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:72:70: warning[SC2046]: Quote this to prevent word splitting. # 70| ostree_repo_init local-mirror # 71| ${CMD_PREFIX} ostree --repo=local-mirror remote add apps-remote file://$(pwd)/apps-collection --collection-id org.example.AppsCollection --gpg-import=${test_tmpdir}/gpghome/key1.asc # 72|-> ${CMD_PREFIX} ostree --repo=local-mirror remote add os-remote file://$(pwd)/os-collection --collection-id org.example.OsCollection --gpg-import=${test_tmpdir}/gpghome/key2.asc # 73| # 74| ${CMD_PREFIX} ostree --repo=local-mirror pull --mirror apps-remote app1 Error: SHELLCHECK_WARNING (CWE-398): [#def221] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:91:103: warning[SC2238]: Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)? # 89| for repo in local local-mirror; do # 90| # Try finding an update for an existing branch. # 91|-> ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.AppsCollection app1 > find # 92| assert_file_has_content find "^Result [0-9]\+: file://$(pwd)/apps-collection$" # 93| assert_file_has_content find "^ - Keyring: apps-remote\.trustedkeys\.gpg$" Error: SHELLCHECK_WARNING (CWE-398): [#def222] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:99:142: warning[SC2238]: Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)? # 97| # 98| # Find several updates for several existing branches. # 99|-> ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.AppsCollection app1 org.example.OsCollection os/amd64/main > find # 100| assert_file_has_content find "^Result [0-9]\+: file://$(pwd)/apps-collection$" # 101| assert_file_has_content find "^ - Keyring: apps-remote\.trustedkeys\.gpg$" Error: SHELLCHECK_WARNING (CWE-398): [#def223] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:110:174: warning[SC2238]: Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)? # 108| # 109| # Find some updates and a new branch. # 110|-> ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.AppsCollection app1 org.example.AppsCollection app2 org.example.OsCollection os/amd64/main > find # 111| assert_file_has_content find "^Result [0-9]\+: file://$(pwd)/apps-collection$" # 112| assert_file_has_content find "^ - Keyring: apps-remote\.trustedkeys\.gpg$" Error: SHELLCHECK_WARNING (CWE-398): [#def224] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:122:141: warning[SC2238]: Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)? # 120| # 121| # Find an update and a non-existent branch. # 122|-> ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.AppsCollection app1 org.example.AppsCollection not-an-app > find # 123| assert_file_has_content find "^Result [0-9]\+: file://$(pwd)/apps-collection$" # 124| assert_file_has_content find "^ - Keyring: apps-remote\.trustedkeys\.gpg$" Error: SHELLCHECK_WARNING (CWE-156): [#def225] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:137:27: warning[SC2046]: Quote this to prevent word splitting. # 135| assert_file_has_content pull "^Pulled 1/1 refs successfully\.$" # 136| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 137|-> assert_ref $repo app1 $(cat app1-checksum) # 138| # 139| ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config --pull org.example.AppsCollection app1 org.example.OsCollection os/amd64/main > pull Error: SHELLCHECK_WARNING (CWE-156): [#def226] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:143:27: warning[SC2046]: Quote this to prevent word splitting. # 141| assert_file_has_content pull "^Pulled 2/2 refs successfully\.$" # 142| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 143|-> assert_ref $repo app1 $(cat app1-checksum) # 144| assert_ref $repo os/amd64/main $(cat os-checksum) # 145| Error: SHELLCHECK_WARNING (CWE-156): [#def227] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:144:36: warning[SC2046]: Quote this to prevent word splitting. # 142| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 143| assert_ref $repo app1 $(cat app1-checksum) # 144|-> assert_ref $repo os/amd64/main $(cat os-checksum) # 145| # 146| ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config --pull org.example.AppsCollection app1 org.example.AppsCollection app2 org.example.OsCollection os/amd64/main > pull Error: SHELLCHECK_WARNING (CWE-156): [#def228] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:150:27: warning[SC2046]: Quote this to prevent word splitting. # 148| assert_file_has_content pull "^Pulled 3/3 refs successfully\.$" # 149| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 150|-> assert_ref $repo app1 $(cat app1-checksum) # 151| assert_ref $repo app2 $(cat app2-checksum) # 152| assert_ref $repo os/amd64/main $(cat os-checksum) Error: SHELLCHECK_WARNING (CWE-156): [#def229] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:151:27: warning[SC2046]: Quote this to prevent word splitting. # 149| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 150| assert_ref $repo app1 $(cat app1-checksum) # 151|-> assert_ref $repo app2 $(cat app2-checksum) # 152| assert_ref $repo os/amd64/main $(cat os-checksum) # 153| Error: SHELLCHECK_WARNING (CWE-156): [#def230] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:152:36: warning[SC2046]: Quote this to prevent word splitting. # 150| assert_ref $repo app1 $(cat app1-checksum) # 151| assert_ref $repo app2 $(cat app2-checksum) # 152|-> assert_ref $repo os/amd64/main $(cat os-checksum) # 153| # 154| ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config --pull org.example.AppsCollection app1 org.example.AppsCollection not-an-app > pull Error: SHELLCHECK_WARNING (CWE-156): [#def231] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:157:27: warning[SC2046]: Quote this to prevent word splitting. # 155| assert_file_has_content pull "^1/2 refs were found\.$" # 156| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 157|-> assert_ref $repo app1 $(cat app1-checksum) # 158| assert_not_ref $repo not-an-app # 159| done Error: SHELLCHECK_WARNING (CWE-1164): [#def232] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:167:13: warning[SC2043]: This loop will only ever run once. Bad quoting or missing glob/expansion? # 165| ${CMD_PREFIX} ostree --repo=os-collection summary --update --gpg-homedir=${TEST_GPG_KEYHOME} --gpg-sign=${TEST_GPG_KEYID_2} # 166| # 167|-> for repo in local-mirror; do # 168| # Try finding an update for that branch. # 169| ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.OsCollection os/amd64/main > find Error: SHELLCHECK_WARNING (CWE-398): [#def233] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:169:110: warning[SC2238]: Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)? # 167| for repo in local-mirror; do # 168| # Try finding an update for that branch. # 169|-> ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.OsCollection os/amd64/main > find # 170| assert_file_has_content find "^Result [0-9]\+: file://$(pwd)/os-collection$" # 171| assert_file_has_content find "^ - Keyring: os-remote\.trustedkeys\.gpg$" Error: SHELLCHECK_WARNING (CWE-156): [#def234] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:181:36: warning[SC2046]: Quote this to prevent word splitting. # 179| assert_file_has_content pull "^Pulled 1/1 refs successfully\.$" # 180| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 181|-> assert_ref $repo os/amd64/main $(cat os-checksum-2) # 182| # 183| # We need to manually update the refs afterwards, since the original pull Error: SHELLCHECK_WARNING (CWE-156): [#def235] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:192:76: warning[SC2046]: Quote this to prevent word splitting. # 190| # has two configured remotes for the os-collection. Ensure its summary is up to date first. # 191| ${CMD_PREFIX} ostree --repo=local-mirror summary --update # 192|-> ${CMD_PREFIX} ostree --repo=local remote add os-remote-local-mirror file://$(pwd)/local-mirror --collection-id org.example.OsCollection --gpg-import=${test_tmpdir}/gpghome/key2.asc # 193| # 194| for repo in local; do Error: SHELLCHECK_WARNING (CWE-1164): [#def236] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:194:13: warning[SC2043]: This loop will only ever run once. Bad quoting or missing glob/expansion? # 192| ${CMD_PREFIX} ostree --repo=local remote add os-remote-local-mirror file://$(pwd)/local-mirror --collection-id org.example.OsCollection --gpg-import=${test_tmpdir}/gpghome/key2.asc # 193| # 194|-> for repo in local; do # 195| # Try finding an update for that branch. # 196| ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.OsCollection os/amd64/main > find Error: SHELLCHECK_WARNING (CWE-398): [#def237] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:196:110: warning[SC2238]: Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)? # 194| for repo in local; do # 195| # Try finding an update for that branch. # 196|-> ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.OsCollection os/amd64/main > find # 197| assert_file_has_content find "^Result [0-9]\+: file://$(pwd)/os-collection$" # 198| assert_file_has_content find "^ - Keyring: os-remote\.trustedkeys\.gpg$" Error: SHELLCHECK_WARNING (CWE-156): [#def238] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:211:36: warning[SC2046]: Quote this to prevent word splitting. # 209| assert_file_has_content pull "^Pulled 1/1 refs successfully\.$" # 210| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 211|-> assert_ref $repo os/amd64/main $(cat os-checksum-2) # 212| done # 213| Error: SHELLCHECK_WARNING (CWE-1164): [#def239] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:221:13: warning[SC2043]: This loop will only ever run once. Bad quoting or missing glob/expansion? # 219| ${CMD_PREFIX} ostree --repo=os-collection summary --update --gpg-homedir=${TEST_GPG_KEYHOME} --gpg-sign=${TEST_GPG_KEYID_2} # 220| # 221|-> for repo in local; do # 222| # Try finding an update for that branch. # 223| ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.OsCollection os/amd64/main > find Error: SHELLCHECK_WARNING (CWE-398): [#def240] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:223:110: warning[SC2238]: Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)? # 221| for repo in local; do # 222| # Try finding an update for that branch. # 223|-> ${CMD_PREFIX} ostree --repo=$repo find-remotes --finders=config org.example.OsCollection os/amd64/main > find # 224| assert_file_has_content find "^Result [0-9]\+: file://$(pwd)/os-collection$" # 225| assert_file_has_content find "^ - Keyring: os-remote\.trustedkeys\.gpg$" Error: SHELLCHECK_WARNING (CWE-156): [#def241] /usr/libexec/installed-tests/libostree/test-find-remotes.sh:235:36: warning[SC2046]: Quote this to prevent word splitting. # 233| assert_file_has_content pull "^Pulled 1/1 refs successfully\.$" # 234| assert_not_file_has_content pull "Failed to pull some refs from the remotes" # 235|-> assert_ref $repo os/amd64/main $(cat os-checksum-3) # 236| done # 237| Error: SHELLCHECK_WARNING (CWE-156): [#def242] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..11' Error: SHELLCHECK_WARNING (CWE-457): [#def243] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:26:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 24| echo '1..11' # 25| # 26|-> cd ${test_tmpdir} # 27| # 28| # Create a new repository with one ref with the repository’s collection ID, and Error: SHELLCHECK_WARNING (CWE-156): [#def244] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:40:96: warning[SC2046]: Quote this to prevent word splitting. # 38| ${CMD_PREFIX} ostree --repo=../repo commit -s "Commit 1" -b ref1 > ../ref1-checksum # 39| ${CMD_PREFIX} ostree --repo=../repo commit -s "Commit 2" --orphan --bind-ref ref2 --add-metadata-string=ostree.collection-binding=org.example.Collection2 > ../ref2-checksum # 40|-> ${CMD_PREFIX} ostree --repo=../repo refs --collections --create=org.example.Collection2:ref2 $(cat ../ref2-checksum) # 41| popd # 42| } Error: SHELLCHECK_WARNING (CWE-156): [#def245] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:54:58: warning[SC2046]: Quote this to prevent word splitting. # 52| pushd files # 53| ${CMD_PREFIX} ostree --repo=../repo commit -s "Commit 3" -b ref3 --bind-ref ref4 > ../ref3-checksum # 54|-> ${CMD_PREFIX} ostree --repo=../repo refs --create=ref4 $(cat ../ref3-checksum) # 55| popd # 56| } Error: SHELLCHECK_WARNING (CWE-156): [#def246] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:93:56: warning[SC2046]: Quote this to prevent word splitting. # 91| # list those refs in their ref-bindings. # 92| set_up_repo_with_collection_id # 93|-> ${CMD_PREFIX} ostree --repo=repo refs --create=new-ref $(cat ref1-checksum) # 94| # 95| # For compatibility we don't check for this by default Error: SHELLCHECK_WARNING (CWE-156): [#def247] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:108:94: warning[SC2046]: Quote this to prevent word splitting. # 106| # And the same where the ref is a collection–ref. # 107| set_up_repo_with_collection_id # 108|-> ${CMD_PREFIX} ostree --repo=repo refs --collections --create=org.example.Collection2:new-ref $(cat ref1-checksum) # 109| # 110| # fsck should now fail Error: SHELLCHECK_WARNING (CWE-156): [#def248] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:122:91: warning[SC2046]: Quote this to prevent word splitting. # 120| # Check that a ref with a different collection ID but the same ref name is caught. # 121| set_up_repo_with_collection_id # 122|-> ${CMD_PREFIX} ostree --repo=repo refs --collections --create=org.example.Collection2:ref1 $(cat ref1-checksum) # 123| # 124| # fsck should now fail Error: SHELLCHECK_WARNING (CWE-156): [#def249] /usr/libexec/installed-tests/libostree/test-fsck-collections.sh:181:56: warning[SC2046]: Quote this to prevent word splitting. # 179| # list those refs in their ref-bindings. # 180| set_up_repo_without_collection_id # 181|-> ${CMD_PREFIX} ostree --repo=repo refs --create=new-ref $(cat ref3-checksum) # 182| # 183| # fsck should now fail Error: SHELLCHECK_WARNING (CWE-156): [#def250] /usr/libexec/installed-tests/libostree/test-fsck-delete.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..6' Error: SHELLCHECK_WARNING (CWE-457): [#def251] /usr/libexec/installed-tests/libostree/test-fsck-delete.sh:26:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 24| echo '1..6' # 25| # 26|-> cd ${test_tmpdir} # 27| # 28| rm -rf ./f1 Error: SHELLCHECK_WARNING (CWE-156): [#def252] /usr/libexec/installed-tests/libostree/test-gpg-signed-commit.sh:23:3: warning[SC2046]: Quote this to prevent word splitting. # 21| set -euo pipefail # 22| # 23|-> . $(dirname $0)/libtest.sh # 24| # 25| skip_without_ostree_feature gpgme Error: SHELLCHECK_WARNING (CWE-457): [#def253] /usr/libexec/installed-tests/libostree/test-gpg-signed-commit.sh:42:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 40| export OSTREE_GPG_SIGN="${OSTREE} gpg-sign --gpg-homedir=${TEST_GPG_KEYHOME}" # 41| # 42|-> cd ${test_tmpdir} # 43| ${OSTREE} commit -b test2 -s "A GPG signed commit" -m "Signed commit body" --gpg-sign=${TEST_GPG_KEYID_1} --gpg-homedir=${TEST_GPG_KEYHOME} --tree=dir=files # 44| ${OSTREE} show test2 | grep -o 'Found [[:digit:]] signature' > test2-show Error: SHELLCHECK_WARNING (CWE-563): [#def254] /usr/libexec/installed-tests/libostree/test-gpg-signed-commit.sh:288:1: warning[SC2034]: key2_sub2_fpr appears unused. Verify use (or export if used externally). # 286| gpg_seckey_listing=$(${GPG} --homedir=${tmpgpg_home} --list-secret-keys --with-colons) # 287| key2_sub2_id=$(awk -F: '{if ($1 == "ssb") print $5}' <<< "${gpg_seckey_listing}" | tail -n1) # 288|-> key2_sub2_fpr=$(awk -F: '{if ($1 == "fpr") print $10}' <<< "${gpg_seckey_listing}" | tail -n1) # 289| ${OSTREE} commit -b test2 -s "A GPG signed commit" -m "Signed commit body" \ # 290| --tree=dir=files --gpg-homedir=${tmpgpg_home} \ Error: SHELLCHECK_WARNING (CWE-156): [#def255] /usr/libexec/installed-tests/libostree/test-help.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo "1..1" Error: SHELLCHECK_WARNING (CWE-156): [#def256] /usr/libexec/installed-tests/libostree/test-init-collections.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..1' Error: SHELLCHECK_WARNING (CWE-457): [#def257] /usr/libexec/installed-tests/libostree/test-init-collections.sh:26:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 24| echo '1..1' # 25| # 26|-> cd ${test_tmpdir} # 27| # 28| # Check that initialising a repository with a collection ID results in the ID being in the config. Error: SHELLCHECK_WARNING (CWE-156): [#def258] /usr/libexec/installed-tests/libostree/test-libarchive.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_ostree_feature libarchive Error: SHELLCHECK_WARNING (CWE-457): [#def259] /usr/libexec/installed-tests/libostree/test-libarchive.sh:30:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| setup_test_repository "bare" # 29| # 30|-> cd ${test_tmpdir} # 31| mkdir foo # 32| cd foo Error: SHELLCHECK_WARNING (CWE-156): [#def260] /usr/libexec/installed-tests/libostree/test-local-pull-depth.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_test_repository "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def261] /usr/libexec/installed-tests/libostree/test-local-pull-depth.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo "1..3" # 27| # 28|-> cd ${test_tmpdir} # 29| mkdir repo2 # 30| ostree_repo_init repo2 --mode="archive" Error: SHELLCHECK_WARNING (CWE-156): [#def262] /usr/libexec/installed-tests/libostree/test-local-pull.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| unset OSTREE_GPG_HOME # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-457): [#def263] /usr/libexec/installed-tests/libostree/test-local-pull.sh:34:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 32| echo "ok setup" # 33| # 34|-> cd ${test_tmpdir} # 35| mkdir repo2 # 36| ostree_repo_init repo2 --mode="bare-user" Error: SHELLCHECK_WARNING (CWE-398): [#def264] /usr/libexec/installed-tests/libostree/test-local-pull.sh:111:19: warning[SC2044]: For loops over find output are fragile. Use find -exec or a while read loop. # 109| ${CMD_PREFIX} ostree --repo=repo7 pull-local repo # 110| ${CMD_PREFIX} ostree --repo=repo7 fsck # 111|-> for src_object in `find repo/objects -name '*.filez'`; do # 112| dst_object=${src_object/repo/repo7} # 113| assert_files_hardlinked "$src_object" "$dst_object" Error: SHELLCHECK_WARNING (CWE-156): [#def265] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:3:3: warning[SC2046]: Quote this to prevent word splitting. # 1| #!/usr/bin/bash # 2| # 3|-> . $(dirname $0)/libtest.sh # 4| # 5| echo "1..10" Error: SHELLCHECK_WARNING (CWE-252): [#def266] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:9:1: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 7| setup_os_repository "archive-z2" "uboot" # 8| # 9|-> cd ${test_tmpdir} # 10| # 11| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo Error: SHELLCHECK_WARNING (CWE-457): [#def267] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:9:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 7| setup_os_repository "archive-z2" "uboot" # 8| # 9|-> cd ${test_tmpdir} # 10| # 11| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo Error: SHELLCHECK_WARNING (CWE-156): [#def268] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:11:90: warning[SC2046]: Quote this to prevent word splitting. # 9| cd ${test_tmpdir} # 10| # 11|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos $(cat httpd-address)/ostree/testos-repo # 12| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull testos testos/buildmain/x86_64-runtime # 13| ${CMD_PREFIX} ostree admin deploy --karg=root=LABEL=rootfs --os=testos testos:testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-252): [#def269] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:33:9: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 31| if [ "$layout" = "/usr/lib/modules" ]; then # 32| # Fedora compatible layout # 33|-> cd ${test_tmpdir}/osdata/usr/lib/modules/3.6.0 # 34| echo -n "$kernel_contents" > vmlinuz # 35| [ -n "$initramfs_contents" ] && echo -n "$initramfs_contents" > initramfs.img Error: SHELLCHECK_WARNING (CWE-252): [#def270] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:40:9: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 38| # "Legacy" layout # 39| mkdir -p "${test_tmpdir}/osdata/$layout" # 40|-> cd "${test_tmpdir}/osdata/$layout" # 41| bootcsum=$(echo -n "$kernel_contents$initramfs_contents$devicetree_contents" \ # 42| | sha256sum | cut -f 1 -d ' ') Error: SHELLCHECK_WARNING (CWE-252): [#def271] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:49:5: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 47| exit 1 # 48| fi # 49|-> cd - # 50| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/testos-repo commit --tree=dir=osdata/ -b testos/buildmain/x86_64-runtime # 51| ${CMD_PREFIX} ostree pull testos:testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def272] /usr/libexec/installed-tests/libostree/test-no-initramfs.sh:75:42: warning[SC2046]: Quote this to prevent word splitting. # 73| ${CMD_PREFIX} ostree admin deploy --os=testos --karg-none --karg=root=LABEL=rootfs testos:testos/buildmain/x86_64-runtime # 74| assert_file_has_content sysroot/boot/loader/entries/ostree-2.conf 'initrd' # 75|-> assert_file_has_content sysroot/boot/$(get_key_from_bootloader_conf sysroot/boot/loader/entries/ostree-2.conf "initrd") "initramfs to assist the kernel" # 76| assert_file_has_content sysroot/boot/loader/entries/ostree-2.conf 'root=LABEL=rootfs' # 77| assert_not_file_has_content sysroot/boot/loader/entries/ostree-2.conf 'rootwait' Error: SHELLCHECK_WARNING (CWE-156): [#def273] /usr/libexec/installed-tests/libostree/test-oldstyle-partial.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def274] /usr/libexec/installed-tests/libostree/test-oldstyle-partial.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo '1..1' # 27| # 28|-> cd ${test_tmpdir} # 29| rm repo -rf # 30| mkdir repo Error: SHELLCHECK_WARNING (CWE-156): [#def275] /usr/libexec/installed-tests/libostree/test-oldstyle-partial.sh:32:75: warning[SC2046]: Quote this to prevent word splitting. # 30| mkdir repo # 31| ostree_repo_init repo # 32|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 33| # 34| ${CMD_PREFIX} ostree --repo=repo pull origin main --subpath /baz Error: SHELLCHECK_WARNING (CWE-156): [#def276] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo "1..1" Error: SHELLCHECK_WARNING (CWE-457): [#def277] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:31:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 29| setup_os_repository "archive" "syslinux" ${modulesdir} # 30| # 31|-> cd ${test_tmpdir} # 32| os_repository_new_commit "test" "test with device tree directory" # 33| Error: SHELLCHECK_WARNING (CWE-156): [#def278] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:44:97: warning[SC2046]: Quote this to prevent word splitting. # 42| ${CMD_PREFIX} ostree --repo=testos-repo commit --tree=dir=osdata/ -b testos/buildmain/x86_64-runtime # 43| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo pull-local --remote=testos testos-repo testos/buildmain/x86_64-runtime # 44|-> ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos file://$(pwd)/testos-repo testos/buildmain/x86_64-runtime # 45| ${CMD_PREFIX} env OSTREE_SYSROOT_DEBUG=${OSTREE_SYSROOT_DEBUG},no-dtb ostree admin deploy --os=testos testos:testos/buildmain/x86_64-runtime # 46| assert_has_file sysroot/boot/ostree/testos-${bootcsum}/vmlinuz-3.6.0 Error: SHELLCHECK_WARNING (CWE-457): [#def279] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:46:44: warning[SC2154]: bootcsum is referenced but not assigned. # 44| ${CMD_PREFIX} ostree --repo=sysroot/ostree/repo remote add --set=gpg-verify=false testos file://$(pwd)/testos-repo testos/buildmain/x86_64-runtime # 45| ${CMD_PREFIX} env OSTREE_SYSROOT_DEBUG=${OSTREE_SYSROOT_DEBUG},no-dtb ostree admin deploy --os=testos testos:testos/buildmain/x86_64-runtime # 46|-> assert_has_file sysroot/boot/ostree/testos-${bootcsum}/vmlinuz-3.6.0 # 47| assert_not_has_file sysroot/boot/ostree/testos-${bootcsum}/dtb/asoc-board.dtb 'a device tree' # 48| assert_streq $(ls sysroot/boot/ostree | wc -l) 1 Error: SHELLCHECK_WARNING (CWE-156): [#def280] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:48:14: warning[SC2046]: Quote this to prevent word splitting. # 46| assert_has_file sysroot/boot/ostree/testos-${bootcsum}/vmlinuz-3.6.0 # 47| assert_not_has_file sysroot/boot/ostree/testos-${bootcsum}/dtb/asoc-board.dtb 'a device tree' # 48|-> assert_streq $(ls sysroot/boot/ostree | wc -l) 1 # 49| assert_streq $(find sysroot/boot/ostree -name '*.dtb' | wc -l) 0 # 50| ${CMD_PREFIX} ostree --repo=testos-repo commit --tree=dir=osdata/ -b testos/buildmain/x86_64-runtime Error: SHELLCHECK_WARNING (CWE-156): [#def281] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:49:14: warning[SC2046]: Quote this to prevent word splitting. # 47| assert_not_has_file sysroot/boot/ostree/testos-${bootcsum}/dtb/asoc-board.dtb 'a device tree' # 48| assert_streq $(ls sysroot/boot/ostree | wc -l) 1 # 49|-> assert_streq $(find sysroot/boot/ostree -name '*.dtb' | wc -l) 0 # 50| ${CMD_PREFIX} ostree --repo=testos-repo commit --tree=dir=osdata/ -b testos/buildmain/x86_64-runtime # 51| env OSTREE_SYSROOT_DEBUG=${OSTREE_SYSROOT_DEBUG},no-dtb ${CMD_PREFIX} ostree admin upgrade --os=testos Error: SHELLCHECK_WARNING (CWE-156): [#def282] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:54:14: warning[SC2046]: Quote this to prevent word splitting. # 52| ${CMD_PREFIX} ostree --repo=testos-repo commit --tree=dir=osdata/ -b testos/buildmain/x86_64-runtime # 53| ${CMD_PREFIX} ostree admin upgrade --os=testos # 54|-> assert_streq $(ls sysroot/boot/ostree | wc -l) 2 # 55| # Note that the bootcsum computed by the test suite doesn't include devicetree # 56| # And currently we end up installing the dtb for the *previous* deployment Error: SHELLCHECK_WARNING (CWE-156): [#def283] /usr/libexec/installed-tests/libostree/test-osupdate-dtb.sh:58:14: warning[SC2046]: Quote this to prevent word splitting. # 56| # And currently we end up installing the dtb for the *previous* deployment # 57| # too which is a bug - in the future this should be fixed to assert 1. # 58|-> assert_streq $(find sysroot/boot/ostree -name '*.dtb' | wc -l) 2 # 59| # 60| echo "ok update with no dtb to dtb" Error: SHELLCHECK_WARNING (CWE-156): [#def284] /usr/libexec/installed-tests/libostree/test-parent.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-457): [#def285] /usr/libexec/installed-tests/libostree/test-parent.sh:34:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 32| export OSTREE_GPG_SIGN="${OSTREE} gpg-sign --gpg-homedir=${TEST_GPG_KEYHOME}" # 33| # 34|-> cd ${test_tmpdir} # 35| # 36| # Create a repo Error: SHELLCHECK_WARNING (CWE-156): [#def286] /usr/libexec/installed-tests/libostree/test-parent.sh:38:139: warning[SC2046]: Quote this to prevent word splitting. # 36| # Create a repo # 37| ostree_repo_init repo2 # 38|-> ${CMD_PREFIX} ostree --repo=repo2 remote add --gpg-import=${test_tmpdir}/gpghome/trusted/pubring.gpg --set=gpg-verify=true aremote file://$(pwd)/repo test2 # 39| # 40| # Create a repo with repo2 as parent Error: SHELLCHECK_WARNING (CWE-156): [#def287] /usr/libexec/installed-tests/libostree/test-parent.sh:42:58: warning[SC2046]: Quote this to prevent word splitting. # 40| # Create a repo with repo2 as parent # 41| ${CMD_PREFIX} ostree init --repo=repo3 --mode=bare-user # 42|-> ${CMD_PREFIX} ostree config --repo=repo3 set core.parent `pwd`/repo2 # 43| # 44| # Ensure the unsigned pull fails so we know we imported the gpg config correctly Error: SHELLCHECK_WARNING (CWE-156): [#def288] /usr/libexec/installed-tests/libostree/test-payload-link.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euox pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| touch foo Error: SHELLCHECK_WARNING (CWE-156): [#def289] /usr/libexec/installed-tests/libostree/test-pre-signed-pull.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo "1..1" Error: SHELLCHECK_WARNING (CWE-156): [#def290] /usr/libexec/installed-tests/libostree/test-pre-signed-pull.sh:33:9: warning[SC2046]: Quote this to prevent word splitting. # 31| mkdir upstream # 32| cd upstream # 33|-> tar xzf $(dirname $0)/pre-signed-pull-data.tar.gz # 34| cd .. # 35| Error: SHELLCHECK_WARNING (CWE-156): [#def291] /usr/libexec/installed-tests/libostree/test-pre-signed-pull.sh:39:109: warning[SC2046]: Quote this to prevent word splitting. # 37| # 38| ostree --repo=repo init --mode=archive # 39|-> ostree --repo=repo remote add upstream --set=gpg-verify=false --sign-verify=ed25519=inline:${pubkey} file://$(pwd)/upstream/repo # 40| ostree --repo=repo pull upstream:testref # 41| Error: SHELLCHECK_WARNING (CWE-156): [#def292] /usr/libexec/installed-tests/libostree/test-pre-signed-pull.sh:45:114: warning[SC2046]: Quote this to prevent word splitting. # 43| rm repo -rf # 44| ostree --repo=repo init --mode=archive # 45|-> ostree --repo=repo remote add badupstream --set=gpg-verify=false --sign-verify=ed25519=inline:${wrongkey} file://$(pwd)/upstream/repo # 46| if ostree --repo=repo pull badupstream:testref 2>err.txt; then # 47| fatal "pulled with wrong key" Error: SHELLCHECK_WARNING (CWE-156): [#def293] /usr/libexec/installed-tests/libostree/test-prune-collections.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..2' Error: SHELLCHECK_WARNING (CWE-457): [#def294] /usr/libexec/installed-tests/libostree/test-prune-collections.sh:26:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 24| echo '1..2' # 25| # 26|-> cd ${test_tmpdir} # 27| # 28| # Check that refs with collection IDs (i.e. refs in refs/mirrors) are taken into account Error: SHELLCHECK_WARNING (CWE-156): [#def295] /usr/libexec/installed-tests/libostree/test-prune-collections.sh:40:96: warning[SC2046]: Quote this to prevent word splitting. # 38| ${CMD_PREFIX} ostree --repo=../repo commit -s "Commit 1" -b original-ref > ../original-ref-checksum # 39| popd # 40|-> ${CMD_PREFIX} ostree --repo=repo refs --collections --create=org.example.Collection:some-ref $(cat original-ref-checksum) # 41| } # 42| Error: SHELLCHECK_WARNING (CWE-156): [#def296] /usr/libexec/installed-tests/libostree/test-prune-collections.sh:46:59: warning[SC2046]: Quote this to prevent word splitting. # 44| # 45| # Try deleting a specific commit which is still pointed to by both refs. # 46|-> if ${CMD_PREFIX} ostree --repo=repo prune --delete-commit=$(cat original-ref-checksum) 2>/dev/null; then # 47| assert_not_reached "prune unexpectedly succeeded in deleting a referenced commit!" # 48| fi Error: SHELLCHECK_WARNING (CWE-156): [#def297] /usr/libexec/installed-tests/libostree/test-prune.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-457): [#def298] /usr/libexec/installed-tests/libostree/test-prune.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| setup_fake_remote_repo1 "archive" # 27| # 28|-> cd ${test_tmpdir} # 29| mkdir repo # 30| ostree_repo_init repo Error: SHELLCHECK_WARNING (CWE-156): [#def299] /usr/libexec/installed-tests/libostree/test-prune.sh:31:75: warning[SC2046]: Quote this to prevent word splitting. # 29| mkdir repo # 30| ostree_repo_init repo # 31|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 32| # 33| mkdir -p tree/root Error: SHELLCHECK_WARNING (CWE-156): [#def300] /usr/libexec/installed-tests/libostree/test-prune.sh:155:75: warning[SC2046]: Quote this to prevent word splitting. # 153| rm repo -rf # 154| ostree_repo_init repo --mode=bare-user # 155|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 156| ${CMD_PREFIX} ostree --repo=repo pull --depth=-1 --commit-metadata-only origin test # 157| ${CMD_PREFIX} ostree --repo=repo prune Error: SHELLCHECK_WARNING (CWE-563): [#def301] /usr/libexec/installed-tests/libostree/test-prune.sh:368:1: warning[SC2034]: i appears unused. Verify use (or export if used externally). # 366| # 367| reinitialize_commit_only_test_repo # 368|-> for i in {1..10}; do # 369| ${CMD_PREFIX} ostree --repo=repo prune --commit-only --keep-younger-than="1 week ago" & # 370| commit=$(${CMD_PREFIX} ostree --repo=repo commit --branch foobar tree) Error: SHELLCHECK_WARNING (CWE-156): [#def302] /usr/libexec/installed-tests/libostree/test-pull-bare.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-563): [#def303] /usr/libexec/installed-tests/libostree/test-pull-bare.sh:26:1: warning[SC2034]: repo_mode appears unused. Verify use (or export if used externally). # 24| setup_fake_remote_repo1 "archive" # 25| # 26|-> repo_mode=bare # 27| . ${test_srcdir}/pull-test.sh Error: SHELLCHECK_WARNING (CWE-457): [#def304] /usr/libexec/installed-tests/libostree/test-pull-bare.sh:27:3: warning[SC2154]: test_srcdir is referenced but not assigned. # 25| # 26| repo_mode=bare # 27|-> . ${test_srcdir}/pull-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def305] /usr/libexec/installed-tests/libostree/test-pull-bareuser.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-563): [#def306] /usr/libexec/installed-tests/libostree/test-pull-bareuser.sh:27:1: warning[SC2034]: repo_mode appears unused. Verify use (or export if used externally). # 25| setup_fake_remote_repo1 "archive" # 26| # 27|-> repo_mode=bare-user # 28| . ${test_srcdir}/pull-test.sh Error: SHELLCHECK_WARNING (CWE-457): [#def307] /usr/libexec/installed-tests/libostree/test-pull-bareuser.sh:28:3: warning[SC2154]: test_srcdir is referenced but not assigned. # 26| # 27| repo_mode=bare-user # 28|-> . ${test_srcdir}/pull-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def308] /usr/libexec/installed-tests/libostree/test-pull-bareuseronly.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_user_xattrs Error: SHELLCHECK_WARNING (CWE-563): [#def309] /usr/libexec/installed-tests/libostree/test-pull-bareuseronly.sh:27:1: warning[SC2034]: repo_mode appears unused. Verify use (or export if used externally). # 25| setup_fake_remote_repo1 "archive" "--canonical-permissions" # 26| # 27|-> repo_mode=bare-user-only # 28| . ${test_srcdir}/pull-test.sh Error: SHELLCHECK_WARNING (CWE-457): [#def310] /usr/libexec/installed-tests/libostree/test-pull-bareuseronly.sh:28:3: warning[SC2154]: test_srcdir is referenced but not assigned. # 26| # 27| repo_mode=bare-user-only # 28|-> . ${test_srcdir}/pull-test.sh Error: SHELLCHECK_WARNING (CWE-156): [#def311] /usr/libexec/installed-tests/libostree/test-pull-basicauth.sh:20:3: warning[SC2046]: Quote this to prevent word splitting. # 18| set -euo pipefail # 19| # 20|-> . $(dirname $0)/libtest.sh # 21| # 22| setup_fake_remote_repo1 "archive" "" "--require-basic-auth" Error: SHELLCHECK_WARNING (CWE-457): [#def312] /usr/libexec/installed-tests/libostree/test-pull-basicauth.sh:26:10: warning[SC2154]: test_tmpdir is referenced but not assigned. # 24| echo '1..3' # 25| # 26|-> repopath=${test_tmpdir}/ostree-srv/gnomerepo # 27| cp -a ${repopath} ${repopath}.orig # 28| Error: SHELLCHECK_WARNING (CWE-156): [#def313] /usr/libexec/installed-tests/libostree/test-pull-collections.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..7' Error: SHELLCHECK_WARNING (CWE-457): [#def314] /usr/libexec/installed-tests/libostree/test-pull-collections.sh:26:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 24| echo '1..7' # 25| # 26|-> cd ${test_tmpdir} # 27| # 28| do_commit() { Error: SHELLCHECK_WARNING (CWE-156): [#def315] /usr/libexec/installed-tests/libostree/test-pull-collections.sh:60:98: warning[SC2046]: Quote this to prevent word splitting. # 58| # 59| echo -n "collection ID: " # 60|-> if ${CMD_PREFIX} ostree "--repo=${repo}" show --print-metadata-key=ostree.collection-binding $(cat "${branch}-checksum") # 61| then : # 62| else return 1 Error: SHELLCHECK_WARNING (CWE-156): [#def316] /usr/libexec/installed-tests/libostree/test-pull-collections.sh:65:91: warning[SC2046]: Quote this to prevent word splitting. # 63| fi # 64| echo -n "refs: " # 65|-> if ${CMD_PREFIX} ostree "--repo=${repo}" show --print-metadata-key=ostree.ref-binding $(cat "${branch}-checksum") # 66| then return 0 # 67| else return 1 Error: SHELLCHECK_WARNING (CWE-571): [#def317] /usr/libexec/installed-tests/libostree/test-pull-collections.sh:93:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 91| local collection_id=$3 # 92| shift 3 # 93|-> local refs=$(do_join "$@") # 94| # 95| do_collection_ref_show "${repo}" "${branch}" >"${branch}-meta" Error: SHELLCHECK_WARNING (CWE-156): [#def318] /usr/libexec/installed-tests/libostree/test-pull-collections.sh:161:68: warning[SC2046]: Quote this to prevent word splitting. # 159| do_commit collection-repo goodcref1 # 160| # create a badcref4 ref with a commit that has goodcref1 in its collection ref metadata # 161|-> ${CMD_PREFIX} ostree --repo=collection-repo refs --create=badcref4 $(cat goodcref1-checksum) # 162| do_summary collection-repo # 163| ensure_no_collection_ref \ Error: SHELLCHECK_WARNING (CWE-156): [#def319] /usr/libexec/installed-tests/libostree/test-pull-collections.sh:198:75: warning[SC2046]: Quote this to prevent word splitting. # 196| do_commit collection-local-repo goodclref1 # 197| # create a badclref4 ref with a commit that has goodclref1 in its collection ref metadata # 198|-> ${CMD_PREFIX} ostree --repo=collection-local-repo refs --create=badclref4 $(cat goodclref1-checksum) # 199| do_summary collection-local-repo # 200| ensure_no_collection_ref \ Error: SHELLCHECK_WARNING (CWE-156): [#def320] /usr/libexec/installed-tests/libostree/test-pull-commit-only.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def321] /usr/libexec/installed-tests/libostree/test-pull-commit-only.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo '1..1' # 27| # 28|-> cd ${test_tmpdir} # 29| mkdir repo # 30| ostree_repo_init repo Error: SHELLCHECK_WARNING (CWE-156): [#def322] /usr/libexec/installed-tests/libostree/test-pull-commit-only.sh:31:75: warning[SC2046]: Quote this to prevent word splitting. # 29| mkdir repo # 30| ostree_repo_init repo # 31|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 32| # 33| ${CMD_PREFIX} ostree --repo=repo pull --commit-metadata-only origin main Error: SHELLCHECK_WARNING (CWE-156): [#def323] /usr/libexec/installed-tests/libostree/test-pull-contenturl.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| if test -z "${OSTREE_HTTPD}"; then Error: SHELLCHECK_WARNING (CWE-457): [#def324] /usr/libexec/installed-tests/libostree/test-pull-contenturl.sh:39:29: warning[SC2154]: test_tmpdir is referenced but not assigned. # 37| # 38| # create a summary # 39|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo \ # 40| summary -u ${COMMIT_SIGN} # 41| Error: SHELLCHECK_WARNING (CWE-398): [#def325] /usr/libexec/installed-tests/libostree/test-pull-contenturl.sh:52:3: warning[SC2038]: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames. # 50| if has_ostree_feature gpgme; then # 51| rm ostree/gnomerepo/summary.sig # 52|-> find ostree/gnomerepo/objects -name '*.commitmeta' | xargs rm # 53| fi # 54| Error: SHELLCHECK_WARNING (CWE-398): [#def326] /usr/libexec/installed-tests/libostree/test-pull-contenturl.sh:56:1: warning[SC2038]: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames. # 54| # 55| # delete all the content stuff from there # 56|-> find ${test_tmpdir}/ostree-srv/gnomerepo/objects \ # 57| ! -name '*.commitmeta' -type f | xargs rm # 58| Error: SHELLCHECK_WARNING (CWE-156): [#def327] /usr/libexec/installed-tests/libostree/test-pull-contenturl.sh:69:16: warning[SC2046]: Quote this to prevent word splitting. # 67| ${CMD_PREFIX} ostree --repo=repo remote add origin \ # 68| --set=gpg-verify=$VERIFY --set=gpg-verify-summary=$VERIFY \ # 69|-> --contenturl=$(cat httpd-content-address)/ostree/gnomerepo \ # 70| $(cat httpd-address)/ostree/gnomerepo # 71| ${CMD_PREFIX} ostree --repo=repo pull origin:main Error: SHELLCHECK_WARNING (CWE-156): [#def328] /usr/libexec/installed-tests/libostree/test-pull-contenturl.sh:70:3: warning[SC2046]: Quote this to prevent word splitting. # 68| --set=gpg-verify=$VERIFY --set=gpg-verify-summary=$VERIFY \ # 69| --contenturl=$(cat httpd-content-address)/ostree/gnomerepo \ # 70|-> $(cat httpd-address)/ostree/gnomerepo # 71| ${CMD_PREFIX} ostree --repo=repo pull origin:main # 72| Error: SHELLCHECK_WARNING (CWE-156): [#def329] /usr/libexec/installed-tests/libostree/test-pull-depth.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def330] /usr/libexec/installed-tests/libostree/test-pull-depth.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo '1..3' # 27| # 28|-> cd ${test_tmpdir} # 29| mkdir repo # 30| ostree_repo_init repo Error: SHELLCHECK_WARNING (CWE-156): [#def331] /usr/libexec/installed-tests/libostree/test-pull-depth.sh:31:75: warning[SC2046]: Quote this to prevent word splitting. # 29| mkdir repo # 30| ostree_repo_init repo # 31|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 32| # 33| ${CMD_PREFIX} ostree --repo=repo pull --depth=0 origin main Error: SHELLCHECK_WARNING (CWE-156): [#def332] /usr/libexec/installed-tests/libostree/test-pull-large-metadata.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def333] /usr/libexec/installed-tests/libostree/test-pull-large-metadata.sh:30:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| # Overwrite the commit object with 121 M of zeroes. This is based on the # 29| # OSTREE_MAX_METADATA_SIZE constant in src/libostree/ostree-core.h # 30|-> cd ${test_tmpdir} # 31| rev=$(cd ostree-srv && ${CMD_PREFIX} ostree --repo=gnomerepo rev-parse main) # 32| dd if=/dev/zero bs=1M count=130 of=ostree-srv/gnomerepo/objects/$(echo $rev | cut -b 1-2)/$(echo $rev | cut -b 3-).commit Error: SHELLCHECK_WARNING (CWE-156): [#def334] /usr/libexec/installed-tests/libostree/test-pull-large-metadata.sh:32:65: warning[SC2046]: Quote this to prevent word splitting. # 30| cd ${test_tmpdir} # 31| rev=$(cd ostree-srv && ${CMD_PREFIX} ostree --repo=gnomerepo rev-parse main) # 32|-> dd if=/dev/zero bs=1M count=130 of=ostree-srv/gnomerepo/objects/$(echo $rev | cut -b 1-2)/$(echo $rev | cut -b 3-).commit # 33| # 34| cd ${test_tmpdir} Error: SHELLCHECK_WARNING (CWE-156): [#def335] /usr/libexec/installed-tests/libostree/test-pull-large-metadata.sh:32:91: warning[SC2046]: Quote this to prevent word splitting. # 30| cd ${test_tmpdir} # 31| rev=$(cd ostree-srv && ${CMD_PREFIX} ostree --repo=gnomerepo rev-parse main) # 32|-> dd if=/dev/zero bs=1M count=130 of=ostree-srv/gnomerepo/objects/$(echo $rev | cut -b 1-2)/$(echo $rev | cut -b 3-).commit # 33| # 34| cd ${test_tmpdir} Error: SHELLCHECK_WARNING (CWE-156): [#def336] /usr/libexec/installed-tests/libostree/test-pull-large-metadata.sh:37:75: warning[SC2046]: Quote this to prevent word splitting. # 35| mkdir repo # 36| ostree_repo_init repo # 37|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 38| # 39| if ${CMD_PREFIX} ostree --repo=repo pull origin main 2>pulllog.txt 1>&2; then Error: SHELLCHECK_WARNING (CWE-156): [#def337] /usr/libexec/installed-tests/libostree/test-pull-localcache.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def338] /usr/libexec/installed-tests/libostree/test-pull-localcache.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo '1..2' # 27| # 28|-> cd ${test_tmpdir} # 29| gnomerepo_url="$(cat httpd-address)/ostree/gnomerepo" # 30| Error: SHELLCHECK_WARNING (CWE-153): [#def339] /usr/libexec/installed-tests/libostree/test-pull-localcache.sh:60:15: warning[SC2053]: Quote the right-hand side of == in [[ ]] to prevent glob matching. # 58| ${CMD_PREFIX} ostree --repo=repo pull -L repo-local origin main # 59| commit2=$(${CMD_PREFIX} ostree --repo=repo rev-parse main) # 60|-> [[ $commit == $commit2 ]] # 61| # and check that it's not partial # 62| rm -rf files Error: SHELLCHECK_WARNING (CWE-156): [#def340] /usr/libexec/installed-tests/libostree/test-pull-metalink.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| if test -z "${OSTREE_HTTPD}"; then Error: SHELLCHECK_WARNING (CWE-457): [#def341] /usr/libexec/installed-tests/libostree/test-pull-metalink.sh:34:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 32| # 33| # And another web server acting as the metalink server # 34|-> cd ${test_tmpdir} # 35| mkdir metalink-data # 36| cd metalink-data Error: SHELLCHECK_WARNING (CWE-156): [#def342] /usr/libexec/installed-tests/libostree/test-pull-metalink.sh:77:84: warning[SC2046]: Quote this to prevent word splitting. # 75| mkdir repo # 76| ostree_repo_init repo # 77|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin metalink=$(cat metalink-httpd-address)/metalink.xml # 78| ${CMD_PREFIX} ostree --repo=repo pull origin:main # 79| ${CMD_PREFIX} ostree --repo=repo rev-parse origin:main Error: SHELLCHECK_WARNING (CWE-156): [#def343] /usr/libexec/installed-tests/libostree/test-pull-metalink.sh:96:88: warning[SC2046]: Quote this to prevent word splitting. # 94| mkdir repo # 95| ostree_repo_init repo # 96|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin metalink=$(cat metalink-httpd-address)/metalink.xml # 97| if ${CMD_PREFIX} ostree --repo=repo pull origin:main 2>err.txt; then # 98| assert_not_reached "pull unexpectedly succeeded" Error: SHELLCHECK_WARNING (CWE-156): [#def344] /usr/libexec/installed-tests/libostree/test-pull-metalink.sh:109:62: warning[SC2046]: Quote this to prevent word splitting. # 107| # 108| cd ${test_tmpdir} # 109|-> sed -e 's,<hash type="sha512">.*</hash>,<hash type="sha512">'$( (echo -n dummy; cat ${summary_path}) | sha512sum | cut -f 1 -d ' ')'</hash>,' < metalink-data/metalink.xml.orig > metalink-data/metalink.xml # 110| test_metalink_pull_error "Expected checksum is .* but actual is" # 111| echo "ok metalink err hash sha512" Error: SHELLCHECK_WARNING (CWE-156): [#def345] /usr/libexec/installed-tests/libostree/test-pull-metalink.sh:166:84: warning[SC2046]: Quote this to prevent word splitting. # 164| mkdir repo # 165| ostree_repo_init repo # 166|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin metalink=$(cat metalink-httpd-address)/metalink.xml # 167| ${CMD_PREFIX} ostree --repo=repo pull origin:main # 168| ${CMD_PREFIX} ostree --repo=repo rev-parse origin:main Error: SHELLCHECK_WARNING (CWE-156): [#def346] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| COMMIT_SIGN="" Error: SHELLCHECK_WARNING (CWE-457): [#def347] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:36:7: warning[SC2154]: test_tmpdir is referenced but not assigned. # 34| # 35| # Now, setup multiple branches # 36|-> mkdir ${test_tmpdir}/ostree-srv/other-files # 37| cd ${test_tmpdir}/ostree-srv/other-files # 38| echo 'hello world another object' > hello-world Error: SHELLCHECK_WARNING (CWE-156): [#def348] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:51:75: warning[SC2046]: Quote this to prevent word splitting. # 49| cd ${test_tmpdir} # 50| ostree_repo_init repo --mode=archive # 51|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 52| ${CMD_PREFIX} ostree --repo=repo pull --mirror origin # 53| assert_has_file repo/summary Error: SHELLCHECK_WARNING (CWE-563): [#def349] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:61:1: warning[SC2034]: rev appears unused. Verify use (or export if used externally). # 59| assert_file_has_content yet-another-copy/yet-another-hello-world "hello world yet another object" # 60| ${CMD_PREFIX} ostree --repo=repo fsck # 61|-> rev=$(ostree --repo=repo rev-parse main) # 62| find repo/objects -name '*.filez' | while read name; do # 63| mode=$(stat -c '%a' "${name}") Error: SHELLCHECK_WARNING (CWE-156): [#def350] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:79:41: warning[SC2046]: Quote this to prevent word splitting. # 77| rm -rf repo # 78| ostree_repo_init repo --mode=archive # 79|-> ${OSTREE} --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo # 80| echo "ok pull mirror without checking signed summary" # 81| Error: SHELLCHECK_WARNING (CWE-156): [#def351] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:85:71: warning[SC2046]: Quote this to prevent word splitting. # 83| rm -rf repo # 84| ostree_repo_init repo --mode=archive # 85|-> ${OSTREE} --repo=repo remote add --set=gpg-verify-summary=true origin $(cat httpd-address)/ostree/gnomerepo # 86| if ${OSTREE} --repo=repo pull --mirror origin 2>err.txt; then # 87| assert_not_reached "Mirroring unexpectedly succeeded" Error: SHELLCHECK_WARNING (CWE-156): [#def352] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:96:71: warning[SC2046]: Quote this to prevent word splitting. # 94| rm -rf repo # 95| ostree_repo_init repo --mode=archive # 96|-> ${OSTREE} --repo=repo remote add --set=gpg-verify-summary=true origin $(cat httpd-address)/ostree/gnomerepo # 97| ${OSTREE} --repo=repo pull --mirror origin # 98| assert_has_file repo/summary Error: SHELLCHECK_WARNING (CWE-156): [#def353] /usr/libexec/installed-tests/libostree/test-pull-mirror-summary.sh:109:41: warning[SC2046]: Quote this to prevent word splitting. # 107| mkdir repo # 108| ostree_repo_init repo --mode=archive # 109|-> ${OSTREE} --repo=repo remote add origin $(cat httpd-address)/ostree/gnomerepo # 110| ${OSTREE} --repo=repo pull --mirror origin # 111| assert_has_file repo/summary Error: SHELLCHECK_WARNING (CWE-156): [#def354] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| if test -z "${OSTREE_HTTPD}"; then Error: SHELLCHECK_WARNING (CWE-457): [#def355] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:36:6: warning[SC2154]: test_tmpdir is referenced but not assigned. # 34| name=$1; shift # 35| # 36|-> cd ${test_tmpdir} # 37| mkdir $name # 38| cd $name Error: SHELLCHECK_WARNING: [#def356] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:53:7: error[SC1102]: Shells disambiguate $(( differently or not at all. For $(command substitution), add space after $( . For $((arithmetics)), fix parsing errors. # 51| # Let's delete a file from 1 so that it falls back on 2 # 52| cd ${test_tmpdir}/content_mirror1/ostree/gnomerepo # 53|-> filez=$((find objects/ -name '*.filez' || true) | head -n 1) # 54| rm ${filez} # 55| Error: SHELLCHECK_WARNING: [#def357] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:58:7: error[SC1102]: Shells disambiguate $(( differently or not at all. For $(command substitution), add space after $( . For $((arithmetics)), fix parsing errors. # 56| # Let's delete a file from 1 and 2 so that it falls back on 3 # 57| cd ${test_tmpdir}/content_mirror1/ostree/gnomerepo # 58|-> filez=$((find objects/ -name '*.filez' || true) | head -n 1) # 59| rm ${filez} # 60| cd ${test_tmpdir}/content_mirror2/ostree/gnomerepo Error: SHELLCHECK_WARNING (CWE-156): [#def358] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:82:14: warning[SC2046]: Quote this to prevent word splitting. # 80| ostree_repo_init repo # 81| ${CMD_PREFIX} ostree --repo=repo remote add origin --no-sign-verify \ # 82|-> mirrorlist=$(cat httpd-address)/ostree/mirrorlist # 83| ${CMD_PREFIX} ostree --repo=repo pull origin:main # 84| Error: SHELLCHECK_WARNING (CWE-156): [#def359] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:94:27: warning[SC2046]: Quote this to prevent word splitting. # 92| ostree_repo_init repo # 93| ${CMD_PREFIX} ostree --repo=repo remote add origin --no-sign-verify \ # 94|-> --contenturl=mirrorlist=$(cat httpd-address)/ostree/mirrorlist \ # 95| $(cat httpd-address)/ostree/gnomerepo # 96| ${CMD_PREFIX} ostree --repo=repo pull origin:main Error: SHELLCHECK_WARNING (CWE-156): [#def360] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:95:3: warning[SC2046]: Quote this to prevent word splitting. # 93| ${CMD_PREFIX} ostree --repo=repo remote add origin --no-sign-verify \ # 94| --contenturl=mirrorlist=$(cat httpd-address)/ostree/mirrorlist \ # 95|-> $(cat httpd-address)/ostree/gnomerepo # 96| ${CMD_PREFIX} ostree --repo=repo pull origin:main # 97| Error: SHELLCHECK_WARNING (CWE-156): [#def361] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:107:27: warning[SC2046]: Quote this to prevent word splitting. # 105| ostree_repo_init repo # 106| ${CMD_PREFIX} ostree --repo=repo remote add origin --no-sign-verify \ # 107|-> --contenturl=mirrorlist=$(cat httpd-address)/ostree/mirrorlist \ # 108| mirrorlist=$(cat httpd-address)/ostree/mirrorlist # 109| ${CMD_PREFIX} ostree --repo=repo pull origin:main Error: SHELLCHECK_WARNING (CWE-156): [#def362] /usr/libexec/installed-tests/libostree/test-pull-mirrorlist.sh:108:14: warning[SC2046]: Quote this to prevent word splitting. # 106| ${CMD_PREFIX} ostree --repo=repo remote add origin --no-sign-verify \ # 107| --contenturl=mirrorlist=$(cat httpd-address)/ostree/mirrorlist \ # 108|-> mirrorlist=$(cat httpd-address)/ostree/mirrorlist # 109| ${CMD_PREFIX} ostree --repo=repo pull origin:main # 110| Error: SHELLCHECK_WARNING (CWE-156): [#def363] /usr/libexec/installed-tests/libostree/test-pull-override-url.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| if test -z "${OSTREE_HTTPD}"; then Error: SHELLCHECK_WARNING (CWE-457): [#def364] /usr/libexec/installed-tests/libostree/test-pull-override-url.sh:33:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 31| echo '1..1' # 32| # 33|-> cd ${test_tmpdir} # 34| # get a list of XX/XXXXXXX...XX.commit # 35| find ostree-srv/gnomerepo/objects -name '*.commit' | cut -d/ -f4- | sort >${test_tmpdir}/original_commits Error: SHELLCHECK_WARNING (CWE-156): [#def365] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| COMMIT_SIGN="" Error: SHELLCHECK_WARNING (CWE-457): [#def366] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:35:7: warning[SC2154]: test_tmpdir is referenced but not assigned. # 33| setup_fake_remote_repo1 "archive" "${COMMIT_SIGN}" --random-500s=99 # 34| # 35|-> pushd ${test_tmpdir} # 36| ostree_repo_init repo --mode=archive # 37| ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo Error: SHELLCHECK_WARNING (CWE-156): [#def367] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:37:75: warning[SC2046]: Quote this to prevent word splitting. # 35| pushd ${test_tmpdir} # 36| ostree_repo_init repo --mode=archive # 37|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 38| assert_fail ${CMD_PREFIX} ostree --repo=repo pull --mirror origin --network-retries=0 main 2>err.txt # 39| assert_file_has_content err.txt "\(500.*Internal Server Error\)\|\(HTTP 500\)" Error: SHELLCHECK_WARNING (CWE-156): [#def368] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:50:75: warning[SC2046]: Quote this to prevent word splitting. # 48| pushd ${test_tmpdir} # 49| ostree_repo_init repo --mode=archive # 50|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 51| for x in $(seq 40); do # 52| if ${CMD_PREFIX} ostree --repo=repo pull --mirror origin --network-retries=2 main 2>err.txt; then Error: SHELLCHECK_WARNING (CWE-156): [#def369] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:71:75: warning[SC2046]: Quote this to prevent word splitting. # 69| pushd ${test_tmpdir} # 70| ostree_repo_init repo --mode=archive # 71|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 72| # 73| # We limit 500s above to 100, so 100 retries should be enough always. Error: SHELLCHECK_WARNING (CWE-156): [#def370] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:89:75: warning[SC2046]: Quote this to prevent word splitting. # 87| pushd ${test_tmpdir} # 88| ostree_repo_init repo --mode=archive # 89|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 90| assert_fail ${CMD_PREFIX} ostree --repo=repo pull --mirror origin --network-retries=0 main 2>err.txt # 91| assert_file_has_content err.txt "\(408.*Request Timeout\)\|\(HTTP 408\)" Error: SHELLCHECK_WARNING (CWE-156): [#def371] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:102:75: warning[SC2046]: Quote this to prevent word splitting. # 100| pushd ${test_tmpdir} # 101| ostree_repo_init repo --mode=archive # 102|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 103| for x in $(seq 40); do # 104| if ${CMD_PREFIX} ostree --repo=repo pull --mirror origin --network-retries=2 main 2>err.txt; then Error: SHELLCHECK_WARNING (CWE-156): [#def372] /usr/libexec/installed-tests/libostree/test-pull-repeated.sh:123:75: warning[SC2046]: Quote this to prevent word splitting. # 121| pushd ${test_tmpdir} # 122| ostree_repo_init repo --mode=archive # 123|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 124| # 125| # We limit 408s above to 100, so 100 retries should be enough always. Error: SHELLCHECK_WARNING (CWE-156): [#def373] /usr/libexec/installed-tests/libostree/test-pull-resume.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" "" "--force-range-requests" Error: SHELLCHECK_WARNING (CWE-457): [#def374] /usr/libexec/installed-tests/libostree/test-pull-resume.sh:28:10: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo '1..1' # 27| # 28|-> repopath=${test_tmpdir}/ostree-srv/gnomerepo # 29| cp -a ${repopath} ${repopath}.orig # 30| Error: SHELLCHECK_WARNING (CWE-156): [#def375] /usr/libexec/installed-tests/libostree/test-pull-resume.sh:35:75: warning[SC2046]: Quote this to prevent word splitting. # 33| mkdir repo # 34| ostree_repo_init repo # 35|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 36| # 37| maxtries=`find ${repopath}/objects | wc -l` Error: SHELLCHECK_WARNING (CWE-156): [#def376] /usr/libexec/installed-tests/libostree/test-pull-sizes.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Committing SELinux attributes throws off the hardcoded sizes below Error: SHELLCHECK_WARNING (CWE-457): [#def377] /usr/libexec/installed-tests/libostree/test-pull-sizes.sh:30:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| echo '1..3' # 29| # 30|-> cd ${test_tmpdir} # 31| mkdir repo # 32| ostree_repo_init repo Error: SHELLCHECK_WARNING (CWE-156): [#def378] /usr/libexec/installed-tests/libostree/test-pull-sizes.sh:33:75: warning[SC2046]: Quote this to prevent word splitting. # 31| mkdir repo # 32| ostree_repo_init repo # 33|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 34| # 35| # Pull commit metadata only. All size and objects will be needed. Error: SHELLCHECK_WARNING (CWE-156): [#def379] /usr/libexec/installed-tests/libostree/test-pull-subpath.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def380] /usr/libexec/installed-tests/libostree/test-pull-subpath.sh:28:10: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo '1..4' # 27| # 28|-> repopath=${test_tmpdir}/ostree-srv/gnomerepo # 29| cp -a ${repopath} ${repopath}.orig # 30| Error: SHELLCHECK_WARNING (CWE-156): [#def381] /usr/libexec/installed-tests/libostree/test-pull-summary-caching.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| set -euo pipefail # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| skip_without_ostree_feature gpgme Error: SHELLCHECK_WARNING (CWE-457): [#def382] /usr/libexec/installed-tests/libostree/test-pull-summary-caching.sh:39:7: warning[SC2154]: test_tmpdir is referenced but not assigned. # 37| # 38| # Create a few branches and update the summary file (and sign it) # 39|-> mkdir ${test_tmpdir}/ostree-srv/other-files # 40| cd ${test_tmpdir}/ostree-srv/other-files # 41| echo 'hello world another object' > hello-world Error: SHELLCHECK_WARNING (CWE-156): [#def383] /usr/libexec/installed-tests/libostree/test-pull-summary-caching.sh:55:71: warning[SC2046]: Quote this to prevent word splitting. # 53| rm -rf repo # 54| ostree_repo_init repo --mode=archive # 55|-> ${OSTREE} --repo=repo remote add --set=gpg-verify-summary=true origin $(cat httpd-address)/ostree/gnomerepo # 56| ${OSTREE} --repo=repo pull origin other # 57| assert_has_file repo/tmp/cache/summaries/origin Error: SHELLCHECK_WARNING (CWE-156): [#def384] /usr/libexec/installed-tests/libostree/test-pull-summary-sigs.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # Ensure repo caching is in use. Error: SHELLCHECK_WARNING (CWE-457): [#def385] /usr/libexec/installed-tests/libostree/test-pull-summary-sigs.sh:39:7: warning[SC2154]: test_tmpdir is referenced but not assigned. # 37| # 38| # Now, setup multiple branches # 39|-> mkdir ${test_tmpdir}/ostree-srv/other-files # 40| cd ${test_tmpdir}/ostree-srv/other-files # 41| echo 'hello world another object' > hello-world Error: SHELLCHECK_WARNING (CWE-156): [#def386] /usr/libexec/installed-tests/libostree/test-pull-summary-sigs.sh:54:75: warning[SC2046]: Quote this to prevent word splitting. # 52| cd ${test_tmpdir} # 53| ostree_repo_init repo --mode=archive # 54|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 55| ${CMD_PREFIX} ostree --repo=repo pull --mirror origin # 56| assert_has_file repo/summary Error: SHELLCHECK_WARNING (CWE-156): [#def387] /usr/libexec/installed-tests/libostree/test-pull-summary-sigs.sh:79:73: warning[SC2046]: Quote this to prevent word splitting. # 77| mkdir repo # 78| ostree_repo_init repo --mode=archive # 79|-> ${OSTREE} --repo=repo remote add --set=gpg-verify-summary=true origin $(cat httpd-address)/ostree/gnomerepo # 80| } # 81| Error: SHELLCHECK_WARNING (CWE-156): [#def388] /usr/libexec/installed-tests/libostree/test-pull-summary-sigs.sh:159:3: warning[SC2046]: Quote this to prevent word splitting. # 157| grep static-deltas summary.txt > static-deltas.txt # 158| assert_file_has_content static-deltas.txt \ # 159|-> $(${OSTREE} --repo=repo rev-parse origin:main) # 160| ${OSTREE} --repo=repo remote summary origin --list-metadata-keys > metadata # 161| assert_file_has_content metadata "^ostree.static-deltas$" Error: SHELLCHECK_WARNING (CWE-156): [#def389] /usr/libexec/installed-tests/libostree/test-pull-untrusted.sh:24:3: warning[SC2046]: Quote this to prevent word splitting. # 22| set -euo pipefail # 23| # 24|-> . $(dirname $0)/libtest.sh # 25| # 26| echo '1..1' Error: SHELLCHECK_WARNING (CWE-457): [#def390] /usr/libexec/installed-tests/libostree/test-pull-untrusted.sh:30:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| setup_test_repository "bare" # 29| # 30|-> cd ${test_tmpdir} # 31| tar xf ${test_srcdir}/ostree-path-traverse.tar.gz # 32| rm -rf repo2 Error: SHELLCHECK_WARNING (CWE-457): [#def391] /usr/libexec/installed-tests/libostree/test-pull-untrusted.sh:31:8: warning[SC2154]: test_srcdir is referenced but not assigned. # 29| # 30| cd ${test_tmpdir} # 31|-> tar xf ${test_srcdir}/ostree-path-traverse.tar.gz # 32| rm -rf repo2 # 33| ostree_repo_init repo2 --mode=archive Error: SHELLCHECK_WARNING (CWE-156): [#def392] /usr/libexec/installed-tests/libostree/test-pull2-bareuseronly.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo2 "archive" "--canonical-permissions" Error: SHELLCHECK_WARNING (CWE-563): [#def393] /usr/libexec/installed-tests/libostree/test-pull2-bareuseronly.sh:26:1: warning[SC2034]: repo_mode appears unused. Verify use (or export if used externally). # 24| setup_fake_remote_repo2 "archive" "--canonical-permissions" # 25| # 26|-> repo_mode=bare-user-only # 27| . ${test_srcdir}/pull-test2.sh Error: SHELLCHECK_WARNING (CWE-457): [#def394] /usr/libexec/installed-tests/libostree/test-pull2-bareuseronly.sh:27:3: warning[SC2154]: test_srcdir is referenced but not assigned. # 25| # 26| repo_mode=bare-user-only # 27|-> . ${test_srcdir}/pull-test2.sh Error: SHELLCHECK_WARNING (CWE-156): [#def395] /usr/libexec/installed-tests/libostree/test-refs-collections.sh:23:3: warning[SC2046]: Quote this to prevent word splitting. # 21| set -euo pipefail # 22| # 23|-> . $(dirname $0)/libtest.sh # 24| # 25| echo '1..2' Error: SHELLCHECK_WARNING (CWE-457): [#def396] /usr/libexec/installed-tests/libostree/test-refs-collections.sh:27:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 25| echo '1..2' # 26| # 27|-> cd ${test_tmpdir} # 28| mkdir repo # 29| ostree_repo_init repo --collection-id org.example.Collection Error: SHELLCHECK_WARNING (CWE-156): [#def397] /usr/libexec/installed-tests/libostree/test-refs.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| setup_fake_remote_repo1 "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def398] /usr/libexec/installed-tests/libostree/test-refs.sh:28:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 26| echo '1..7' # 27| # 28|-> cd ${test_tmpdir} # 29| mkdir repo # 30| ostree_repo_init repo Error: SHELLCHECK_WARNING (CWE-398): [#def399] /usr/libexec/installed-tests/libostree/test-refs.sh:130:12: warning[SC2041]: This is a literal string. To run as a command, use $(..) instead of '..' . # 128| echo "ok invalid refs" # 129| # 130|-> for ref in 'org.foo.bar/x86_64/standard-blah'; do # 131| ostree --repo=repo refs ctest --create=${ref} # 132| ostree --repo=repo rev-parse ${ref} >/dev/null Error: SHELLCHECK_WARNING (CWE-156): [#def400] /usr/libexec/installed-tests/libostree/test-remote-add-collections.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..1' Error: SHELLCHECK_WARNING (CWE-457): [#def401] /usr/libexec/installed-tests/libostree/test-remote-add-collections.sh:26:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 24| echo '1..1' # 25| # 26|-> cd ${test_tmpdir} # 27| # 28| # Check that adding a remote with a collection ID results in the ID being in the config. Error: SHELLCHECK_WARNING (CWE-156): [#def402] /usr/libexec/installed-tests/libostree/test-remote-add.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo '1..16' Error: SHELLCHECK_WARNING (CWE-457): [#def403] /usr/libexec/installed-tests/libostree/test-remote-add.sh:66:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 64| echo "ok remote list with urls" # 65| # 66|-> cd ${test_tmpdir} # 67| rm -rf parent-repo # 68| ostree_repo_init parent-repo Error: SHELLCHECK_WARNING (CWE-156): [#def404] /usr/libexec/installed-tests/libostree/test-remote-cookies.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| echo '1..4' # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| setup_fake_remote_repo1 "archive" "" \ Error: SHELLCHECK_WARNING (CWE-88): [#def405] /usr/libexec/installed-tests/libostree/test-remote-cookies.sh:32:6: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 30| # 31| assert_fail (){ # 32|-> if $@; then # 33| (echo 1>&2 "$@ did not fail"; exit 1) # 34| fi Error: SHELLCHECK_WARNING (CWE-138): [#def406] /usr/libexec/installed-tests/libostree/test-remote-cookies.sh:33:17: error[SC2145]: Argument mixes string and array. Use * or separate argument. # 31| assert_fail (){ # 32| if $@; then # 33|-> (echo 1>&2 "$@ did not fail"; exit 1) # 34| fi # 35| } Error: SHELLCHECK_WARNING (CWE-457): [#def407] /usr/libexec/installed-tests/libostree/test-remote-cookies.sh:37:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 35| } # 36| # 37|-> cd ${test_tmpdir} # 38| rm repo -rf # 39| mkdir repo Error: SHELLCHECK_WARNING (CWE-156): [#def408] /usr/libexec/installed-tests/libostree/test-remote-cookies.sh:41:75: warning[SC2046]: Quote this to prevent word splitting. # 39| mkdir repo # 40| ostree_repo_init repo # 41|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 42| # 43| # Sanity check the setup, without cookies the pull should fail Error: SHELLCHECK_WARNING (CWE-156): [#def409] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # We don't want OSTREE_GPG_HOME used for these tests. Error: SHELLCHECK_WARNING (CWE-457): [#def410] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:36:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 34| echo "1..${num_tests}" # 35| # 36|-> cd ${test_tmpdir} # 37| mkdir repo # 38| ostree_repo_init repo Error: SHELLCHECK_WARNING (CWE-156): [#def411] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:46:25: warning[SC2046]: Quote this to prevent word splitting. # 44| assert_not_has_file repo/R1.trustedkeys.gpg # 45| # 46|-> ${OSTREE} remote add R1 $(cat httpd-address)/ostree/gnomerepo # 47| # 48| assert_not_has_file repo/R1.trustedkeys.gpg Error: SHELLCHECK_WARNING (CWE-156): [#def412] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:64:25: warning[SC2046]: Quote this to prevent word splitting. # 62| #--------------------------------------- # 63| # 64|-> ${OSTREE} remote add R1 $(cat httpd-address)/ostree/gnomerepo # 65| # 66| # Import one valid key ID Error: SHELLCHECK_WARNING (CWE-156): [#def413] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:80:25: warning[SC2046]: Quote this to prevent word splitting. # 78| ${OSTREE} remote delete R1 # 79| # 80|-> ${OSTREE} remote add R1 $(cat httpd-address)/ostree/gnomerepo # 81| # 82| # Import all keys from keyring Error: SHELLCHECK_WARNING (CWE-156): [#def414] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:92:25: warning[SC2046]: Quote this to prevent word splitting. # 90| #------------------------------------- # 91| # 92|-> ${OSTREE} remote add R1 $(cat httpd-address)/ostree/gnomerepo # 93| # 94| # Import ASCII-armored keys thru stdin Error: SHELLCHECK_WARNING (CWE-156): [#def415] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:106:70: warning[SC2046]: Quote this to prevent word splitting. # 104| #------------------------------------------------------------ # 105| # 106|-> ${OSTREE} remote add --gpg-import ${test_tmpdir}/gpghome/key1.asc R1 $(cat httpd-address)/ostree/gnomerepo | grep -o 'Imported [[:digit:]] GPG key' > result # 107| assert_file_has_content result 'Imported 1 GPG key' # 108| Error: SHELLCHECK_WARNING (CWE-156): [#def416] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:109:70: warning[SC2046]: Quote this to prevent word splitting. # 107| assert_file_has_content result 'Imported 1 GPG key' # 108| # 109|-> ${OSTREE} remote add --gpg-import ${test_tmpdir}/gpghome/key2.asc R2 $(cat httpd-address)/ostree/gnomerepo | grep -o 'Imported [[:digit:]] GPG key' > result # 110| assert_file_has_content result 'Imported 1 GPG key' # 111| Error: SHELLCHECK_WARNING (CWE-156): [#def417] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:112:70: warning[SC2046]: Quote this to prevent word splitting. # 110| assert_file_has_content result 'Imported 1 GPG key' # 111| # 112|-> ${OSTREE} remote add --gpg-import ${test_tmpdir}/gpghome/key3.asc R3 $(cat httpd-address)/ostree/gnomerepo | grep -o 'Imported [[:digit:]] GPG key' > result # 113| assert_file_has_content result 'Imported 1 GPG key' # 114| Error: SHELLCHECK_WARNING (CWE-156): [#def418] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:157:74: warning[SC2046]: Quote this to prevent word splitting. # 155| # 156| # Test the successful gpgkeypath option # 157|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/key3.asc R4 $(cat httpd-address)/ostree/gnomerepo # 158| ${OSTREE} pull R4:main >/dev/null # 159| Error: SHELLCHECK_WARNING (CWE-156): [#def419] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:161:138: warning[SC2046]: Quote this to prevent word splitting. # 159| # 160| # Test gpgkeypath success with multiple keys to try # 161|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/key1.asc,${test_tmpdir}/gpghome/key2.asc,${test_tmpdir}/gpghome/key3.asc R7 $(cat httpd-address)/ostree/gnomerepo # 162| ${OSTREE} pull R7:main >/dev/null # 163| Error: SHELLCHECK_WARNING (CWE-156): [#def420] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:165:106: warning[SC2046]: Quote this to prevent word splitting. # 163| # 164| # Test gpgkeypath failure with multiple keys but none in keyring # 165|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/key1.asc,${test_tmpdir}/gpghome/key2.asc R8 $(cat httpd-address)/ostree/gnomerepo # 166| if ${OSTREE} pull R8:main 2>err.txt; then # 167| assert_not_reached "Unexpectedly succeeded at pulling with different key" Error: SHELLCHECK_WARNING (CWE-156): [#def421] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:172:66: warning[SC2046]: Quote this to prevent word splitting. # 170| # 171| # Test gpgkeypath success with directory containing a valid key # 172|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/ R9 $(cat httpd-address)/ostree/gnomerepo # 173| ${OSTREE} pull R9:main >/dev/null # 174| Error: SHELLCHECK_WARNING (CWE-156): [#def422] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:176:85: warning[SC2046]: Quote this to prevent word splitting. # 174| # 175| # Test gpgkeypath failure with nonexistent directory # 176|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/INVALIDKEYDIRPATH/ R10 $(cat httpd-address)/ostree/gnomerepo # 177| if ${OSTREE} pull R10:main 2>err.txt; then # 178| assert_not_reached "Unexpectedly succeeded at pulling with nonexistent key directory" Error: SHELLCHECK_WARNING (CWE-156): [#def423] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:183:109: warning[SC2046]: Quote this to prevent word splitting. # 181| # 182| # Test gpgkeypath failure with a directory containing a valid key, and a nonexistent key # 183|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/,${test_tmpdir}/gpghome/INVALIDKEYPATH.asc R11 $(cat httpd-address)/ostree/gnomerepo # 184| if ${OSTREE} pull R11:main 2>err.txt; then # 185| assert_not_reached "Unexpectedly succeeded at pulling with nonexistent key" Error: SHELLCHECK_WARNING (CWE-156): [#def424] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:190:99: warning[SC2046]: Quote this to prevent word splitting. # 188| # 189| # Test gpgkeypath success with a directory containing a valid key, and a key not in keyring # 190|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/,${test_tmpdir}/gpghome/key1.asc R12 $(cat httpd-address)/ostree/gnomerepo # 191| ${OSTREE} pull R12:main >/dev/null # 192| Error: SHELLCHECK_WARNING (CWE-156): [#def425] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:194:117: warning[SC2046]: Quote this to prevent word splitting. # 192| # 193| # Test gpgkeypath failure with a nonexistent directory, and a valid key # 194|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/INVALIDKEYDIRPATH/,${test_tmpdir}/gpghome/key3.asc R13 $(cat httpd-address)/ostree/gnomerepo # 195| if ${OSTREE} pull R13:main 2>err.txt; then # 196| assert_not_reached "Unexpectedly succeeded at pulling with nonexistent key directory" Error: SHELLCHECK_WARNING (CWE-156): [#def426] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:201:127: warning[SC2046]: Quote this to prevent word splitting. # 199| # 200| # Test gpgkeypath failure with a nonexistent directory and a nonexistent key # 201|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/INVALIDKEYDIRPATH/,${test_tmpdir}/gpghome/INVALIDKEYPATH.asc R14 $(cat httpd-address)/ostree/gnomerepo # 202| if ${OSTREE} pull R14:main 2>err.txt; then # 203| assert_not_reached "Unexpectedly succeeded at pulling with nonexistent key" Error: SHELLCHECK_WARNING (CWE-156): [#def427] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:208:66: warning[SC2046]: Quote this to prevent word splitting. # 206| # 207| # Test gpgkeypath success for no trailing slash in directory path # 208|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome R15 $(cat httpd-address)/ostree/gnomerepo # 209| ${OSTREE} pull R15:main >/dev/null # 210| Error: SHELLCHECK_WARNING (CWE-156): [#def428] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:212:86: warning[SC2046]: Quote this to prevent word splitting. # 210| # 211| # Test gpgkeypath failure with prefixed separator giving an empty path, and a nonexistent key # 212|-> ${OSTREE} remote add --set=gpgkeypath=,${test_tmpdir}/gpghome/INVALIDKEYPATH.asc R16 $(cat httpd-address)/ostree/gnomerepo # 213| if ${OSTREE} pull R16:main 2>err.txt; then # 214| assert_not_reached "Unexpectedly succeeded at pulling with nonexistent key" Error: SHELLCHECK_WARNING (CWE-156): [#def429] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:219:76: warning[SC2046]: Quote this to prevent word splitting. # 217| # 218| # Test gpgkeypath success with suffixed separator # 219|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/key3.asc, R17 $(cat httpd-address)/ostree/gnomerepo # 220| ${OSTREE} pull R17:main >/dev/null # 221| Error: SHELLCHECK_WARNING (CWE-156): [#def430] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:223:141: warning[SC2046]: Quote this to prevent word splitting. # 221| # 222| # Test gpgkeypath success with multiple keys specified, with semicolons # 223|-> ${OSTREE} remote add --set=gpgkeypath="${test_tmpdir}/gpghome/key1.asc;${test_tmpdir}/gpghome/key2.asc;${test_tmpdir}/gpghome/key3.asc" R18 $(cat httpd-address)/ostree/gnomerepo # 224| ${OSTREE} pull R18:main >/dev/null # 225| Error: SHELLCHECK_WARNING (CWE-156): [#def431] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:227:141: warning[SC2046]: Quote this to prevent word splitting. # 225| # 226| # Test gpgkeypath failure multiple keys specified, with mix of commas and semicolons # 227|-> ${OSTREE} remote add --set=gpgkeypath="${test_tmpdir}/gpghome/key1.asc,${test_tmpdir}/gpghome/key2.asc;${test_tmpdir}/gpghome/key3.asc" R19 $(cat httpd-address)/ostree/gnomerepo # 228| if ${OSTREE} pull R19:main 2>err.txt; then # 229| assert_not_reached "Unexpectedly succeeded at pulling with invalid gpgkeypath value" Error: SHELLCHECK_WARNING (CWE-156): [#def432] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:236:84: warning[SC2046]: Quote this to prevent word splitting. # 234| ${OSTREE} prune --refs-only # 235| # 236|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/INVALIDKEYPATH.asc R5 $(cat httpd-address)/ostree/gnomerepo # 237| if ${OSTREE} pull R5:main 2>err.txt; then # 238| assert_not_reached "Unexpectedly succeeded at pulling with nonexistent key" Error: SHELLCHECK_WARNING (CWE-156): [#def433] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:245:74: warning[SC2046]: Quote this to prevent word splitting. # 243| ${OSTREE} prune --refs-only # 244| # 245|-> ${OSTREE} remote add --set=gpgkeypath=${test_tmpdir}/gpghome/key2.asc R6 $(cat httpd-address)/ostree/gnomerepo # 246| if ${OSTREE} pull R6:main 2>err.txt; then # 247| assert_not_reached "Unexpectedly succeeded at pulling with different key" Error: SHELLCHECK_WARNING (CWE-156): [#def434] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:258:6: warning[SC2046]: Quote this to prevent word splitting. # 256| rm repo/refs/remotes/* -rf # 257| ${OSTREE} prune --refs-only # 258|-> echo $(date) > workdir/testfile-for-deltas-1 # 259| # Sign with keyid 1 for first commit # 260| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo commit -b main --gpg-sign ${TEST_GPG_KEYID_1} --gpg-homedir ${test_tmpdir}/gpghome workdir Error: SHELLCHECK_WARNING (CWE-156): [#def435] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:264:14: warning[SC2046]: Quote this to prevent word splitting. # 262| # Pull the previous revision # 263| ${OSTREE} pull R1:main # 264|-> assert_streq $(${OSTREE} rev-parse R1:main) ${prevrev} # 265| # Sign with keyid 2, but use remote r1 # 266| echo $(date) > workdir/testfile-for-deltas-2 Error: SHELLCHECK_WARNING (CWE-156): [#def436] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:266:6: warning[SC2046]: Quote this to prevent word splitting. # 264| assert_streq $(${OSTREE} rev-parse R1:main) ${prevrev} # 265| # Sign with keyid 2, but use remote r1 # 266|-> echo $(date) > workdir/testfile-for-deltas-2 # 267| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo commit -b main --gpg-sign ${TEST_GPG_KEYID_2} --gpg-homedir ${test_tmpdir}/gpghome workdir # 268| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo static-delta generate main Error: SHELLCHECK_WARNING (CWE-563): [#def437] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:271:1: warning[SC2034]: newrev appears unused. Verify use (or export if used externally). # 269| # Summary is signed with key1 # 270| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo summary -u --gpg-sign ${TEST_GPG_KEYID_1} --gpg-homedir ${test_tmpdir}/gpghome # 271|-> newrev=$(${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo rev-parse main) # 272| if ${OSTREE} pull --require-static-deltas R1:main 2>err.txt; then # 273| assert_not_reached "Unexpectedly succeeded at pulling commit signed with untrusted key" Error: SHELLCHECK_WARNING (CWE-156): [#def438] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:296:8: warning[SC2046]: Quote this to prevent word splitting. # 294| else # 295| # Create a commit signed with keyid 1 # 296|-> echo $(date) > workdir/testfile-for-key-mangling # 297| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo commit -b main --gpg-sign ${TEST_GPG_KEYID_1} --gpg-homedir ${test_tmpdir}/gpghome workdir # 298| Error: SHELLCHECK_WARNING (CWE-156): [#def439] /usr/libexec/installed-tests/libostree/test-remote-gpg-import.sh:301:72: warning[SC2046]: Quote this to prevent word splitting. # 299| # Re-add the remote # 300| ${OSTREE} remote delete R1 # 301|-> ${OSTREE} remote add --gpg-import ${test_tmpdir}/gpghome/key1.asc R1 $(cat httpd-address)/ostree/gnomerepo | grep -o 'Imported [[:digit:]] GPG key' > result # 302| assert_file_has_content result 'Imported 1 GPG key' # 303| Error: SHELLCHECK_WARNING (CWE-156): [#def440] /usr/libexec/installed-tests/libostree/test-remote-gpg-list-keys.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| # We don't want OSTREE_GPG_HOME used for most of these tests. Error: SHELLCHECK_WARNING (CWE-457): [#def441] /usr/libexec/installed-tests/libostree/test-remote-gpg-list-keys.sh:25:10: warning[SC2154]: test_tmpdir is referenced but not assigned. # 23| # 24| # We don't want OSTREE_GPG_HOME used for most of these tests. # 25|-> emptydir=${test_tmpdir}/empty # 26| trusteddir=${OSTREE_GPG_HOME} # 27| mkdir ${emptydir} Error: SHELLCHECK_WARNING (CWE-156): [#def442] /usr/libexec/installed-tests/libostree/test-remote-headers.sh:24:3: warning[SC2046]: Quote this to prevent word splitting. # 22| echo '1..2' # 23| # 24|-> . $(dirname $0)/libtest.sh # 25| # 26| V=$($CMD_PREFIX ostree --version | \ Error: SHELLCHECK_WARNING (CWE-457): [#def443] /usr/libexec/installed-tests/libostree/test-remote-headers.sh:34:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 32| --expected-header "User-Agent=libostree/$V dodo/2.15" # 33| # 34|-> cd ${test_tmpdir} # 35| rm repo -rf # 36| mkdir repo Error: SHELLCHECK_WARNING (CWE-156): [#def444] /usr/libexec/installed-tests/libostree/test-remote-headers.sh:38:75: warning[SC2046]: Quote this to prevent word splitting. # 36| mkdir repo # 37| ostree_repo_init repo # 38|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 39| # 40| # Sanity check the setup, without headers the pull should fail Error: SHELLCHECK_WARNING (CWE-156): [#def445] /usr/libexec/installed-tests/libostree/test-remote-refs.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| set -euo pipefail # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| echo "1..2" Error: SHELLCHECK_WARNING (CWE-457): [#def446] /usr/libexec/installed-tests/libostree/test-remote-refs.sh:30:29: warning[SC2154]: test_tmpdir is referenced but not assigned. # 28| # 29| setup_fake_remote_repo2 "archive" # 30|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/repo summary -u # 31| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/repo refs > origin-refs # 32| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/repo refs --revision > origin-refs-revs Error: SHELLCHECK_WARNING (CWE-156): [#def447] /usr/libexec/installed-tests/libostree/test-remote-refs.sh:37:46: warning[SC2046]: Quote this to prevent word splitting. # 35| rm -rf repo # 36| ostree_repo_init repo --mode=archive # 37|-> ${OSTREE} remote add --no-sign-verify origin $(cat httpd-address)/ostree/repo # 38| # 39| ${OSTREE} remote refs origin > refs Error: SHELLCHECK_WARNING (CWE-156): [#def448] /usr/libexec/installed-tests/libostree/test-repo-finder-mount-integration.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| set -euo pipefail # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| skip_without_sudo Error: SHELLCHECK_WARNING (CWE-457): [#def449] /usr/libexec/installed-tests/libostree/test-repo-finder-mount-integration.sh:66:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 64| echo "1..3" # 65| # 66|-> cd ${test_tmpdir} # 67| mkdir repo # 68| ostree_repo_init repo --collection-id org.example.Collection1 Error: SHELLCHECK_WARNING (CWE-156): [#def450] /usr/libexec/installed-tests/libostree/test-repo-finder-mount-integration.sh:86:66: warning[SC2046]: Quote this to prevent word splitting. # 84| mkdir local-repo # 85| ostree_repo_init local-repo # 86|-> ${CMD_PREFIX} ostree --repo=local-repo remote add remote1 file://$(pwd)/repo --collection-id org.example.Collection1 --gpg-import="${test_tmpdir}/gpghome/key1.asc" # 87| ${CMD_PREFIX} ostree --repo=local-repo pull remote1 test-1 test-2 test-3 test-4 test-5 # 88| Error: SHELLCHECK_WARNING (CWE-156): [#def451] /usr/libexec/installed-tests/libostree/test-reset-nonlinear.sh:24:3: warning[SC2046]: Quote this to prevent word splitting. # 22| echo "1..1" # 23| # 24|-> . $(dirname $0)/libtest.sh # 25| # 26| setup_test_repository "archive" Error: SHELLCHECK_WARNING (CWE-457): [#def452] /usr/libexec/installed-tests/libostree/test-reset-nonlinear.sh:27:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 25| # 26| setup_test_repository "archive" # 27|-> cd ${test_tmpdir}/files # 28| $OSTREE commit -b testx -s "Another Commit" # 29| cd ${test_tmpdir} Error: SHELLCHECK_WARNING (CWE-156): [#def453] /usr/libexec/installed-tests/libostree/test-rofiles-fuse.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip_without_fuse Error: SHELLCHECK_WARNING (CWE-457): [#def454] /usr/libexec/installed-tests/libostree/test-rofiles-fuse.sh:31:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 29| echo "1..13" # 30| # 31|-> cd ${test_tmpdir} # 32| mkdir mnt # 33| # The default content set amazingly doesn't have a non-broken link Error: SHELLCHECK_WARNING (CWE-156): [#def455] /usr/libexec/installed-tests/libostree/test-rofiles-fuse.sh:64:17: warning[SC2046]: Quote this to prevent word splitting. # 62| # Test chown with regfiles and symlinks # 63| for path in firstfile baz/alink; do # 64|-> if chown -h $(id -u) mnt/${path} 2>err.txt; then # 65| assert_not_reached "chown inplace ${path}" # 66| fi Error: SHELLCHECK_WARNING (CWE-156): [#def456] /usr/libexec/installed-tests/libostree/test-rofiles-fuse.sh:70:10: warning[SC2046]: Quote this to prevent word splitting. # 68| done # 69| # And test via dereferencing a symlink # 70|-> if chown $(id -u) mnt/firstfile-link 2>err.txt; then # 71| assert_not_reached "chown inplace firstfile-link" # 72| fi Error: SHELLCHECK_WARNING (CWE-156): [#def457] /usr/libexec/installed-tests/libostree/test-rofiles-fuse.sh:90:7: warning[SC2046]: Quote this to prevent word splitting. # 88| assert_file_has_content mnt/${path} writevialink # 89| done # 90|-> chown $(id -u) mnt/anewfile-for-fuse-link # 91| # 92| mkdir mnt/newfusedir Error: SHELLCHECK_WARNING (CWE-156): [#def458] /usr/libexec/installed-tests/libostree/test-rofiles-fuse.sh:96:11: warning[SC2046]: Quote this to prevent word splitting. # 94| echo ${i}-morenewfuse-${i} > mnt/newfusedir/test-morenewfuse.${i} # 95| chmod 0600 mnt/newfusedir/test-morenewfuse.${i} # 96|-> chown $(id -u) mnt/newfusedir/test-morenewfuse.${i} # 97| done # 98| assert_file_has_content checkout-test2/newfusedir/test-morenewfuse.3 3-morenewfuse-3 Error: SHELLCHECK_WARNING (CWE-156): [#def459] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo "1..11" Error: SHELLCHECK_WARNING (CWE-457): [#def460] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:29:7: warning[SC2154]: test_tmpdir is referenced but not assigned. # 27| export OSTREE_DUMMY_SIGN_ENABLED=1 # 28| # 29|-> mkdir ${test_tmpdir}/repo # 30| ostree_repo_init repo --mode="archive" # 31| Error: SHELLCHECK_WARNING (CWE-156): [#def461] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:98:94: warning[SC2046]: Quote this to prevent word splitting. # 96| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} # 97| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} ${PUBLIC} # 98|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) ${PUBLIC} # 99| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) Error: SHELLCHECK_WARNING (CWE-156): [#def462] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:99:94: warning[SC2046]: Quote this to prevent word splitting. # 97| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} ${PUBLIC} # 98| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) ${PUBLIC} # 99|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) Error: SHELLCHECK_WARNING (CWE-156): [#def463] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:99:123: warning[SC2046]: Quote this to prevent word splitting. # 97| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} ${PUBLIC} # 98| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) ${PUBLIC} # 99|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) Error: SHELLCHECK_WARNING (CWE-156): [#def464] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:100:104: warning[SC2046]: Quote this to prevent word splitting. # 98| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) ${PUBLIC} # 99| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 102| echo "ok ed25519 signature verified" Error: SHELLCHECK_WARNING (CWE-156): [#def465] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:100:133: warning[SC2046]: Quote this to prevent word splitting. # 98| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) ${PUBLIC} # 99| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 102| echo "ok ed25519 signature verified" Error: SHELLCHECK_WARNING (CWE-156): [#def466] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:101:94: warning[SC2046]: Quote this to prevent word splitting. # 99| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 102| echo "ok ed25519 signature verified" # 103| Error: SHELLCHECK_WARNING (CWE-156): [#def467] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:101:123: warning[SC2046]: Quote this to prevent word splitting. # 99| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 102| echo "ok ed25519 signature verified" # 103| Error: SHELLCHECK_WARNING (CWE-156): [#def468] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:101:162: warning[SC2046]: Quote this to prevent word splitting. # 99| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 102| echo "ok ed25519 signature verified" # 103| Error: SHELLCHECK_WARNING (CWE-156): [#def469] /usr/libexec/installed-tests/libostree/test-signed-commit.sh:101:191: warning[SC2046]: Quote this to prevent word splitting. # 99| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} # 100| ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 101|-> ${CMD_PREFIX} ostree --repo=${test_tmpdir}/repo sign --verify --sign-type=ed25519 ${COMMIT} $(gen_ed25519_random_public) $(gen_ed25519_random_public) ${PUBLIC} $(gen_ed25519_random_public) $(gen_ed25519_random_public) # 102| echo "ok ed25519 signature verified" # 103| Error: SHELLCHECK_WARNING (CWE-156): [#def470] /usr/libexec/installed-tests/libostree/test-signed-pull-summary.sh:24:3: warning[SC2046]: Quote this to prevent word splitting. # 22| set -euo pipefail # 23| # 24|-> . $(dirname $0)/libtest.sh # 25| # 26| echo "1..14" Error: SHELLCHECK_WARNING (CWE-457): [#def471] /usr/libexec/installed-tests/libostree/test-signed-pull-summary.sh:36:8: warning[SC2154]: test_tmpdir is referenced but not assigned. # 34| repo_reinit () { # 35| ARGS="$*" # 36|-> cd ${test_tmpdir} # 37| rm -rf repo # 38| mkdir repo Error: SHELLCHECK_WARNING (CWE-156): [#def472] /usr/libexec/installed-tests/libostree/test-signed-pull-summary.sh:43:24: warning[SC2046]: Quote this to prevent word splitting. # 41| --set=gpg-verify=false --set=gpg-verify-summary=false \ # 42| --set=sign-verify=false --set=sign-verify-summary=true \ # 43|-> ${ARGS} origin $(cat httpd-address)/ostree/gnomerepo # 44| } # 45| Error: SHELLCHECK_WARNING (CWE-156): [#def473] /usr/libexec/installed-tests/libostree/test-signed-pull-summary.sh:101:16: warning[SC2046]: Quote this to prevent word splitting. # 99| --set=gpg-verify=false --set=gpg-verify-summary=false \ # 100| --set=sign-verify=false --set=sign-verify-summary=false \ # 101|-> origin $(cat httpd-address)/ostree/gnomerepo # 102| ${CMD_PREFIX} ostree --repo=repo pull --mirror origin # 103| assert_has_file repo/summary Error: SHELLCHECK_WARNING (CWE-156): [#def474] /usr/libexec/installed-tests/libostree/test-signed-pull-summary.sh:196:5: warning[SC2046]: Quote this to prevent word splitting. # 194| grep static-deltas summary.txt > static-deltas.txt # 195| assert_file_has_content static-deltas.txt \ # 196|-> $(${OSTREE} --repo=repo rev-parse origin:main) # 197| ${OSTREE} --repo=repo remote summary origin --list-metadata-keys > metadata # 198| assert_file_has_content metadata "^ostree.static-deltas$" Error: SHELLCHECK_WARNING (CWE-156): [#def475] /usr/libexec/installed-tests/libostree/test-signed-pull.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| echo "1..20" Error: SHELLCHECK_WARNING (CWE-457): [#def476] /usr/libexec/installed-tests/libostree/test-signed-pull.sh:33:8: warning[SC2154]: test_tmpdir is referenced but not assigned. # 31| # 32| function repo_init() { # 33|-> cd ${test_tmpdir} # 34| rm repo -rf # 35| mkdir repo Error: SHELLCHECK_WARNING (CWE-156): [#def477] /usr/libexec/installed-tests/libostree/test-signed-pull.sh:37:111: warning[SC2046]: Quote this to prevent word splitting. # 35| mkdir repo # 36| ostree_repo_init repo --mode=${repo_mode} # 37|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false --set=sign-verify-summary=false origin $(cat httpd-address)/ostree/gnomerepo "$@" # 38| } # 39| Error: SHELLCHECK_WARNING (CWE-563): [#def478] /usr/libexec/installed-tests/libostree/test-signed-pull.sh:158:1: warning[SC2034]: SECRET appears unused. Verify use (or export if used externally). # 156| gen_ed25519_keys # 157| PUBLIC=${ED25519PUBLIC} # 158|-> SECRET=${ED25519SECRET} # 159| # Other tests verify --sign, we will verify --sign-from-file here # 160| echo ${ED25519SECRET} > key Error: SHELLCHECK_WARNING (CWE-156): [#def479] /usr/libexec/installed-tests/libostree/test-summary-collections.sh:23:3: warning[SC2046]: Quote this to prevent word splitting. # 21| set -euo pipefail # 22| # 23|-> . $(dirname $0)/libtest.sh # 24| # 25| echo '1..1' Error: SHELLCHECK_WARNING (CWE-457): [#def480] /usr/libexec/installed-tests/libostree/test-summary-collections.sh:27:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 25| echo '1..1' # 26| # 27|-> cd ${test_tmpdir} # 28| mkdir repo # 29| ostree_repo_init repo --collection-id org.example.Collection Error: SHELLCHECK_WARNING (CWE-156): [#def481] /usr/libexec/installed-tests/libostree/test-summary-update.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| set -euo pipefail # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| echo "1..2" Error: SHELLCHECK_WARNING (CWE-457): [#def482] /usr/libexec/installed-tests/libostree/test-summary-update.sh:35:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 33| # 34| # 35|-> cd ${test_tmpdir} # 36| mkdir repo # 37| ostree_repo_init repo Error: SHELLCHECK_WARNING (CWE-156): [#def483] /usr/libexec/installed-tests/libostree/test-summary-view.sh:25:3: warning[SC2046]: Quote this to prevent word splitting. # 23| set -euo pipefail # 24| # 25|-> . $(dirname $0)/libtest.sh # 26| # 27| echo "1..2" Error: SHELLCHECK_WARNING (CWE-457): [#def484] /usr/libexec/installed-tests/libostree/test-summary-view.sh:37:7: warning[SC2154]: test_tmpdir is referenced but not assigned. # 35| # 36| # Set up a second branch. # 37|-> mkdir ${test_tmpdir}/ostree-srv/other-files # 38| cd ${test_tmpdir}/ostree-srv/other-files # 39| echo 'hello world some object' > hello-world Error: SHELLCHECK_WARNING (CWE-563): [#def485] /usr/libexec/installed-tests/libostree/test-summary-view.sh:46:1: warning[SC2034]: prev_dir appears unused. Verify use (or export if used externally). # 44| # 45| # Check out the repository. # 46|-> prev_dir=`pwd` # 47| cd ${test_tmpdir} # 48| ostree_repo_init repo --mode=archive Error: SHELLCHECK_WARNING (CWE-156): [#def486] /usr/libexec/installed-tests/libostree/test-summary-view.sh:49:75: warning[SC2046]: Quote this to prevent word splitting. # 47| cd ${test_tmpdir} # 48| ostree_repo_init repo --mode=archive # 49|-> ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo # 50| ${CMD_PREFIX} ostree --repo=repo pull --mirror origin # 51| Error: SHELLCHECK_WARNING (CWE-156): [#def487] /usr/libexec/installed-tests/libostree/test-switchroot.sh:141:4: warning[SC2046]: Quote this to prevent word splitting. # 139| # This script sources itself so we only want to run tests if we're the parent: # 140| if [ "${BASH_SOURCE[0]}" = "${0}" ]; then # 141|-> . $(dirname $0)/libtest.sh # 142| unshare -m true || \ # 143| skip "this test needs to set up mount namespaces, rerun as root" Error: SHELLCHECK_WARNING (CWE-156): [#def488] /usr/libexec/installed-tests/libostree/test-xattrs.sh:22:3: warning[SC2046]: Quote this to prevent word splitting. # 20| set -euo pipefail # 21| # 22|-> . $(dirname $0)/libtest.sh # 23| # 24| skip "We don't really have a use case for committing user. xattrs right now. See also https://github.com/ostreedev/ostree/issues/758" Error: SHELLCHECK_WARNING (CWE-457): [#def489] /usr/libexec/installed-tests/libostree/test-xattrs.sh:33:4: warning[SC2154]: test_tmpdir is referenced but not assigned. # 31| setup_test_repository "archive" # 32| # 33|-> cd ${test_tmpdir} # 34| ${CMD_PREFIX} ostree --repo=repo checkout test2 test2-checkout1 # 35| setfattr -n user.ostree-test -v testvalue test2-checkout1/firstfile Error: GCC_ANALYZER_WARNING (CWE-775): [#def490] ostree-2024.9-build/libostree-2024.9/libglnx/glnx-local-alloc.h: scope_hint: In function ‘glnx_close_fd’ ostree-2024.9-build/libostree-2024.9/libglnx/glnx-local-alloc.h:74:1: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘fd’ /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ ostree-2024.9-build/libostree-2024.9/libglnx/glnx-local-alloc.h:64:3: note: in expansion of macro ‘g_assert’ ostree-2024.9-build/libostree-2024.9/libglnx/glnx-local-alloc.h: scope_hint: In function ‘glnx_close_fd’ # 72| errno = errsv; # 73| } # 74|-> } # 75| # 76| /** Error: GCC_ANALYZER_WARNING (CWE-688): [#def491] ostree-2024.9-build/libostree-2024.9/libglnx/glnx-lockfile.c: scope_hint: In function 'glnx_make_lock_file' ostree-2024.9-build/libostree-2024.9/libglnx/glnx-lockfile.c:91:22: warning[-Wanalyzer-null-argument]: use of NULL 'p' where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/glnx-backport-autoptr.h:27: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/glnx-lockfile.h:26: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/glnx-lockfile.c:40: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/glnx-lockfile.c:80:13: note: in expansion of macro 'g_strdup' /usr/include/sys/file.h:24: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/glnx-lockfile.c:36: included_from: Included from here. /usr/include/fcntl.h:233:12: note: argument 2 of 'openat' must be non-null # 89| struct stat st; # 90| # 91|-> fd = openat(dfd, p, O_CREAT|O_RDWR|O_NOFOLLOW|O_CLOEXEC|O_NOCTTY, 0600); # 92| if (fd < 0) # 93| return glnx_throw_errno(error); Error: CPPCHECK_WARNING (CWE-457): [#def492] ostree-2024.9-build/libostree-2024.9/libglnx/glnx-xattrs.c:384: error[uninitvar]: Uninitialized variable: bytes_read # 382| return glnx_null_throw_errno_prefix (error, "lgetxattr(%s)", attribute); # 383| # 384|-> g_autofree guint8 *buf = g_malloc (bytes_read); # 385| if (TEMP_FAILURE_RETRY (real_size = lgetxattr (pathbuf, attribute, buf, bytes_read)) < 0) # 386| return glnx_null_throw_errno_prefix (error, "lgetxattr(%s)", attribute); Error: CPPCHECK_WARNING (CWE-457): [#def493] ostree-2024.9-build/libostree-2024.9/libglnx/glnx-xattrs.c:388: error[uninitvar]: Uninitialized variable: real_size # 386| return glnx_null_throw_errno_prefix (error, "lgetxattr(%s)", attribute); # 387| # 388|-> return g_bytes_new_take (g_steal_pointer (&buf), real_size); # 389| } # 390| Error: CPPCHECK_WARNING (CWE-457): [#def494] ostree-2024.9-build/libostree-2024.9/libglnx/glnx-xattrs.c:409: error[uninitvar]: Uninitialized variable: bytes_read # 407| return glnx_null_throw_errno_prefix (error, "fgetxattr(%s)", attribute); # 408| # 409|-> g_autofree guint8 *buf = g_malloc (bytes_read); # 410| if (TEMP_FAILURE_RETRY (real_size = fgetxattr (fd, attribute, buf, bytes_read)) < 0) # 411| return glnx_null_throw_errno_prefix (error, "fgetxattr(%s)", attribute); Error: CPPCHECK_WARNING (CWE-457): [#def495] ostree-2024.9-build/libostree-2024.9/libglnx/glnx-xattrs.c:413: error[uninitvar]: Uninitialized variable: real_size # 411| return glnx_null_throw_errno_prefix (error, "fgetxattr(%s)", attribute); # 412| # 413|-> return g_bytes_new_take (g_steal_pointer (&buf), real_size); # 414| } # 415| Error: GCC_ANALYZER_WARNING (CWE-688): [#def496] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c: scope_hint: In function 'diff_files' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:129:7: warning[-Wanalyzer-null-argument]: use of NULL 'checksum_a' where non-null expected /usr/include/glib-2.0/glib/glist.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/ghash.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:52: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/libglnx.h:24: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:24: included_from: Included from here. /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro 'g_clear_pointer' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:295:7: note: in expansion of macro 'g_clear_object' /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro 'g_clear_pointer' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:299:7: note: in expansion of macro 'g_clear_object' /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro 'g_clear_pointer' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:302:7: note: in expansion of macro 'g_clear_object' /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:45:22: note: in expansion of macro 'g_strdup' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-repo-private.h:26: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:25: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c: scope_hint: In function 'diff_files' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:73:3: note: in expansion of macro 'ot_transfer_out_value' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:73:3: note: in expansion of macro 'ot_transfer_out_value' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:73:3: note: in expansion of macro 'ot_transfer_out_value' /usr/include/glib-2.0/glib/galloca.h:35: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/string.h:156:12: note: argument 1 of 'strcmp' must be non-null # 127| # 128| g_autoptr (OstreeDiffItem) ret_item = NULL; # 129|-> if (strcmp (checksum_a, checksum_b) != 0) # 130| { # 131| ret_item = diff_item_new (a, a_info, b, b_info, checksum_a, checksum_b); Error: GCC_ANALYZER_WARNING (CWE-688): [#def497] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:129:7: warning[-Wanalyzer-null-argument]: use of NULL 'checksum_b' where non-null expected /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro 'g_clear_pointer' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:295:7: note: in expansion of macro 'g_clear_object' /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro 'g_clear_pointer' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:299:7: note: in expansion of macro 'g_clear_object' /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro 'g_clear_pointer' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:302:7: note: in expansion of macro 'g_clear_object' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:73:3: note: in expansion of macro 'ot_transfer_out_value' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-diff.c:73:3: note: in expansion of macro 'ot_transfer_out_value' /usr/include/string.h:156:12: note: argument 2 of 'strcmp' must be non-null # 127| # 128| g_autoptr (OstreeDiffItem) ret_item = NULL; # 129|-> if (strcmp (checksum_a, checksum_b) != 0) # 130| { # 131| ret_item = diff_item_new (a, a_info, b, b_info, checksum_a, checksum_b); Error: COMPILER_WARNING (CWE-477): [#def498] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-fetcher-curl.c: scope_hint: In function 'initiate_next_curl_request' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-fetcher-curl.c:935:3: warning[-Wdeprecated-declarations]: 'CURLOPT_PROTOCOLS' is deprecated: since 7.85.0. Use CURLOPT_PROTOCOLS_STR # 935 | rc = curl_easy_setopt (req->easy, CURLOPT_PROTOCOLS, # | ^~ ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-fetcher-curl.c:23: included_from: Included from here. /usr/include/curl/curl.h:1756:3: note: declared here # 1756 | CURLOPTDEPRECATED(CURLOPT_PROTOCOLS, CURLOPTTYPE_LONG, 181, # | ^~~~~~~~~~~~~~~~~ # 933| # 934| /* We should only speak HTTP; TODO: only enable file if specified */ # 935|-> rc = curl_easy_setopt (req->easy, CURLOPT_PROTOCOLS, # 936| (long)(CURLPROTO_HTTP | CURLPROTO_HTTPS | CURLPROTO_FILE)); # 937| g_assert_cmpint (rc, ==, CURLM_OK); Error: COMPILER_WARNING (CWE-477): [#def499] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-fetcher-curl.c:979:3: warning[-Wdeprecated-declarations]: 'CURLOPT_PROGRESSFUNCTION' is deprecated: since 7.32.0. Use CURLOPT_XFERINFOFUNCTION # 979 | rc = curl_easy_setopt (req->easy, CURLOPT_PROGRESSFUNCTION, prog_cb); # | ^~ /usr/include/curl/curl.h:1304:3: note: declared here # 1304 | CURLOPTDEPRECATED(CURLOPT_PROGRESSFUNCTION, CURLOPTTYPE_FUNCTIONPOINT, 56, # | ^~~~~~~~~~~~~~~~~ # 977| rc = curl_easy_setopt (req->easy, CURLOPT_NOPROGRESS, 1L); # 978| g_assert_cmpint (rc, ==, CURLM_OK); # 979|-> rc = curl_easy_setopt (req->easy, CURLOPT_PROGRESSFUNCTION, prog_cb); # 980| g_assert_cmpint (rc, ==, CURLM_OK); # 981| rc = curl_easy_setopt (req->easy, CURLOPT_FOLLOWLOCATION, 1L); Error: GCC_ANALYZER_WARNING (CWE-688): [#def500] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-impl-system-generator.c:47:12: warning[-Wanalyzer-null-argument]: use of NULL 'stateroot' where non-null expected ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-impl-system-generator.c: scope_hint: In function 'fstab_generator' /usr/include/glib-2.0/glib/gstrfuncs.h:324:38: note: in definition of macro 'g_strdup' <built-in>: scope_hint: In function 'fstab_generator' <built-in>: note: argument 1 of '__builtin_strchr' must be non-null # 45| is_path (const char *p) # 46| { # 47|-> return !!strchr (p, '/'); # 48| } # 49| Error: GCC_ANALYZER_WARNING (CWE-688): [#def501] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-impl-system-generator.c:47:12: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-impl-system-generator.c: scope_hint: In function 'fstab_generator' /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. /usr/include/gio-unix-2.0/gio/gunixoutputstream.h:26: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-impl-system-generator.c:23: included_from: Included from here. /usr/include/glib-2.0/glib/gstrfuncs.h:324:38: note: in definition of macro 'g_strdup' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-impl-system-generator.c:197:36: note: in expansion of macro 'g_strdup' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-impl-system-generator.c: scope_hint: In function 'fstab_generator' <built-in>: scope_hint: In function 'fstab_generator' <built-in>: note: argument 1 of '__builtin_strchr' must be non-null # 45| is_path (const char *p) # 46| { # 47|-> return !!strchr (p, '/'); # 48| } # 49| Error: GCC_ANALYZER_WARNING (CWE-688): [#def502] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c: scope_hint: In function 'split_keyeq' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:135:8: warning[-Wanalyzer-null-argument]: use of NULL 'arg' where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/libglnx.h:24: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:20: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:880:26: note: in expansion of macro 'g_strdup' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c: scope_hint: In function 'split_keyeq' <built-in>: note: argument 1 of '__builtin_strchr' must be non-null # 133| char *eq; # 134| # 135|-> eq = strchr (arg, '='); # 136| if (eq == NULL) # 137| return NULL; Error: GCC_ANALYZER_WARNING (CWE-688): [#def503] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c: scope_hint: In function ‘split_keyeq’ ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:135:8: warning[-Wanalyzer-null-argument]: use of NULL ‘arg’ where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/libglnx.h:24: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:20: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:880:26: note: in expansion of macro ‘g_strdup’ ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c: scope_hint: In function ‘split_keyeq’ <built-in>: note: argument 1 of ‘__builtin_strchr’ must be non-null # 133| char *eq; # 134| # 135|-> eq = strchr (arg, '='); # 136| if (eq == NULL) # 137| return NULL; Error: GCC_ANALYZER_WARNING (CWE-476): [#def504] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c: scope_hint: In function 'ostree_kernel_args_parse_append.part.0' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:709:21: warning[-Wanalyzer-null-dereference]: dereference of NULL 'iter' /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro 'G_LIKELY' ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:173:3: note: in expansion of macro 'g_return_val_if_fail' /usr/include/glib-2.0/glib.h:64: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:173:3: note: in expansion of macro 'g_return_val_if_fail' # 707| # 708| args = split_kernel_args (options); # 709|-> for (iter = args; *iter; iter++) # 710| { # 711| char *arg = *iter; Error: GCC_ANALYZER_WARNING (CWE-476): [#def505] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c: scope_hint: In function ‘ostree_kernel_args_parse_append.part.0’ ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:709:21: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘iter’ /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’ ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:173:3: note: in expansion of macro ‘g_return_val_if_fail’ /usr/include/glib-2.0/glib.h:64: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-kernel-args.c:173:3: note: in expansion of macro ‘g_return_val_if_fail’ # 707| # 708| args = split_kernel_args (options); # 709|-> for (iter = args; *iter; iter++) # 710| { # 711| char *arg = *iter; Error: CPPCHECK_WARNING (CWE-457): [#def506] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-sysroot-deploy.c:1594: error[uninitvar]: Uninitialized variable: wstatus # 1592| if (TEMP_FAILURE_RETRY (waitpid (pid, &wstatus, 0)) < 0) # 1593| return glnx_throw_errno_prefix (error, "waitpid(test-fifreeze)"); # 1594|-> if (!g_spawn_check_exit_status (wstatus, error)) # 1595| return glnx_prefix_error (error, "test-fifreeze: "); # 1596| return glnx_throw (error, "aborting due to test-fifreeze"); Error: CPPCHECK_WARNING (CWE-457): [#def507] ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-sysroot.c:2217: error[uninitvar]: Uninitialized variable: estatus # 2215| if (TEMP_FAILURE_RETRY (waitpid (mount_child, &estatus, 0)) < 0) # 2216| return glnx_throw_errno_prefix (error, "waitpid() on mount helper"); # 2217|-> if (!g_spawn_check_exit_status (estatus, error)) # 2218| return glnx_prefix_error (error, "Failed overlayfs mount"); # 2219| } Error: GCC_ANALYZER_WARNING (CWE-401): [#def508] ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c: scope_hint: In function 'otcore_get_ostree_target' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:57:52: warning[-Wanalyzer-malloc-leak]: leak of 'otcore_find_proc_cmdline_key(cmdline, "ostree")' /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro 'G_LIKELY' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:83:3: note: in expansion of macro 'g_assert' /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro 'G_LIKELY' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:84:3: note: in expansion of macro 'g_assert' /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro 'G_LIKELY' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:84:3: note: in expansion of macro 'g_assert' /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:35:11: note: in expansion of macro 'g_str_has_prefix' # 55| { # 56| const char *next = strchr (iter, ' '); # 57|-> if (strncmp (iter, key, key_len) == 0 && iter[key_len] == '=') # 58| { # 59| const char *start = iter + key_len + 1; Error: GCC_ANALYZER_WARNING (CWE-401): [#def509] ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c: scope_hint: In function 'otcore_load_composefs_config' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:57:52: warning[-Wanalyzer-malloc-leak]: leak of 'otcore_find_proc_cmdline_key(cmdline, "ostree.prepare-root.composefs")' /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotutil/otutil.h:24: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore.h:22: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:20: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro 'G_LIKELY' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:169:3: note: in expansion of macro 'g_assert' /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro 'G_LIKELY' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:170:3: note: in expansion of macro 'g_assert' /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro 'G_LIKELY' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:170:3: note: in expansion of macro 'g_assert' ostree-2024.9-build/libostree-2024.9/libglnx/libglnx.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotutil/otutil.h:25: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/glnx-macros.h:128:29: note: in definition of macro '_GLNX_CONCAT' ostree-2024.9-build/libostree-2024.9/libglnx/glnx-macros.h:130:33: note: in expansion of macro '_GLNX_CONCAT_INDIRECT' ostree-2024.9-build/libostree-2024.9/libglnx/glnx-errors.h:76:45: note: in expansion of macro '_GLNX_MAKE_ANONYMOUS' ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore-prepare-root.c:172:3: note: in expansion of macro 'GLNX_AUTO_PREFIX_ERROR' # 55| { # 56| const char *next = strchr (iter, ' '); # 57|-> if (strncmp (iter, key, key_len) == 0 && iter[key_len] == '=') # 58| { # 59| const char *start = iter + key_len + 1; Error: CPPCHECK_WARNING (CWE-457): [#def510] ostree-2024.9-build/libostree-2024.9/src/libotutil/ot-fs-utils.c:51: error[uninitvar]: Uninitialized variable: len # 49| if (TEMP_FAILURE_RETRY (len = readlinkat (dfd, path, targetbuf, sizeof (targetbuf) - 1)) < 0) # 50| return glnx_throw_errno_prefix (error, "readlinkat"); # 51|-> targetbuf[len] = '\0'; # 52| g_file_info_set_symlink_target (target_info, targetbuf); # 53| Error: GCC_ANALYZER_WARNING: [#def511] /usr/include/bits/sigstksz.h:24: included_from: Included from here. /usr/include/signal.h:328: included_from: Included from here. /usr/include/glib-2.0/glib/gbacktrace.h:38: included_from: Included from here. /usr/include/glib-2.0/glib.h:36: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:874:31: warning[-Wanalyzer-fd-use-without-check]: ‘write’ on possibly invalid file descriptor ‘-1’ # 872| guint8 buf = 0; # 873| g_debug ("Writing %u to parent", buf); # 874|-> if (TEMP_FAILURE_RETRY (write (pipefd[1], &buf, 1)) == -1) # 875| { # 876| glnx_set_error_from_errno (error); Error: GCC_ANALYZER_WARNING (CWE-775): [#def512] ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:953:1: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘pipefd[(int)ret]’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:733:11: note: in expansion of macro ‘glnx_set_error_from_errno’ /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro ‘g_clear_pointer’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:951:3: note: in expansion of macro ‘g_clear_object’ /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro ‘g_clear_pointer’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:951:3: note: in expansion of macro ‘g_clear_object’ /usr/include/glib-2.0/glib/gmacros.h:1365:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/gio/gio-autocleanups.h:76:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/gio/gio-autocleanups.h:76:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/gio/gio-autocleanups.h:76:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ /usr/include/glib-2.0/glib/gmacros.h:1365:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/glib/glib-autocleanups.h:72:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/glib/glib-autocleanups.h:72:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/glib/glib-autocleanups.h:72:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ # 951| g_clear_object (&app->log); # 952| return ret; # 953|-> } # 954| # 955| int Error: GCC_ANALYZER_WARNING (CWE-775): [#def513] ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:953:1: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘pipefd[1]’ ostree-2024.9-build/libostree-2024.9/libglnx/libglnx.h:35: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ot-main.h:24: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ot-builtins.h:26: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:27: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:733:11: note: in expansion of macro ‘glnx_set_error_from_errno’ /usr/include/glib-2.0/glib/glist.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/ghash.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:52: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. /usr/include/libsoup-3.0/libsoup/soup-types.h:9: included_from: Included from here. /usr/include/libsoup-3.0/libsoup/soup-auth.h:8: included_from: Included from here. /usr/include/libsoup-3.0/libsoup/soup.h:11: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:22: included_from: Included from here. /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro ‘g_clear_pointer’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:951:3: note: in expansion of macro ‘g_clear_object’ /usr/include/glib-2.0/gobject/gobject.h:695:36: note: in expansion of macro ‘g_clear_pointer’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c:951:3: note: in expansion of macro ‘g_clear_object’ /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1365:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/gio/gio-autocleanups.h:76:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/gio/gio-autocleanups.h:76:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/gio/gio-autocleanups.h:76:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ /usr/include/glib-2.0/glib/gmacros.h:1365:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/glib/glib-autocleanups.h:72:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/glib/glib-autocleanups.h:72:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ /usr/include/glib-2.0/glib/gmacros.h:1381:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’ /usr/include/glib-2.0/glib/glib-autocleanups.h:72:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’ ostree-2024.9-build/libostree-2024.9/src/ostree/ostree-trivial-httpd.c: scope_hint: In function ‘run’ # 951| g_clear_object (&app->log); # 952| return ret; # 953|-> } # 954| # 955| int Error: GCC_ANALYZER_WARNING (CWE-688): [#def514] ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c: scope_hint: In function ‘ot_admin_builtin_switch’ ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c:77:18: warning[-Wanalyzer-null-argument]: use of NULL ‘new_remote’ where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-types.h:24: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree-async-progress.h:22: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libostree/ostree.h:22: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c:22: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c:76:20: note: in expansion of macro ‘g_strdup’ ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c: scope_hint: In function ‘ot_admin_builtin_switch’ <built-in>: note: argument 1 of ‘__builtin_strlen’ must be non-null # 75| { # 76| new_remote = g_strdup (new_provided_refspec); # 77|-> new_remote[strlen (new_remote) - 1] = '\0'; # 78| new_ref = g_strdup (origin_ref); # 79| } Error: GCC_ANALYZER_WARNING (CWE-688): [#def515] ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c:93:7: warning[-Wanalyzer-null-argument]: use of NULL ‘new_refspec’ where non-null expected ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c:91:19: note: in expansion of macro ‘g_strdup’ ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c:91:19: note: in expansion of macro ‘g_strdup’ ostree-2024.9-build/libostree-2024.9/src/ostree/ot-admin-builtin-switch.c: scope_hint: In function ‘ot_admin_builtin_switch’ /usr/include/glib-2.0/glib/galloca.h:35: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/string.h:156:12: note: argument 2 of ‘strcmp’ must be non-null # 91| new_refspec = g_strdup (new_ref); # 92| # 93|-> if (strcmp (origin_refspec, new_refspec) == 0) # 94| { # 95| g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, "Old and new refs are equal: %s", Error: GCC_ANALYZER_WARNING (CWE-775): [#def516] ostree-2024.9-build/libostree-2024.9/src/switchroot/ostree-remount.c: scope_hint: In function ‘main’ ostree-2024.9-build/libostree-2024.9/src/switchroot/ostree-remount.c:142:26: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open("/run/ostree-booted", 524288)’ # 140| g_autoptr (GVariant) ostree_run_metadata_v = NULL; # 141| { # 142|-> glnx_autofd int fd = open (OTCORE_RUN_BOOTED, O_RDONLY | O_CLOEXEC); # 143| if (fd < 0) # 144| { Error: GCC_ANALYZER_WARNING (CWE-775): [#def517] ostree-2024.9-build/libostree-2024.9/src/switchroot/ostree-remount.c:194:27: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open("/proc/self/ns/mnt", 524544)’ ostree-2024.9-build/libostree-2024.9/src/switchroot/ostree-remount.c:25: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/libglnx/libglnx.h:30: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotutil/otutil.h:25: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotcore/otcore.h:22: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/switchroot/ostree-remount.c:43: included_from: Included from here. /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. ostree-2024.9-build/libostree-2024.9/src/libotutil/otutil.h:24: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1249:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1250:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ ostree-2024.9-build/libostree-2024.9/libglnx/glnx-local-alloc.h:64:3: note: in expansion of macro ‘g_assert’ ostree-2024.9-build/libostree-2024.9/libglnx/glnx-local-alloc.h: scope_hint: In function ‘main’ # 192| && g_file_test ("/etc/machine-id", G_FILE_TEST_EXISTS)) # 193| { # 194|-> initial_ns_fd = open ("/proc/self/ns/mnt", O_RDONLY | O_NOCTTY | O_CLOEXEC); # 195| if (initial_ns_fd < 0) # 196| err (EXIT_FAILURE, "Failed to open initial namespace");
| analyzer-version-clippy | 1.82.0 |
| analyzer-version-cppcheck | 2.16.0 |
| analyzer-version-gcc | 14.2.1 |
| analyzer-version-gcc-analyzer | 15.0.0 |
| analyzer-version-shellcheck | 0.10.0 |
| analyzer-version-unicontrol | 0.0.2 |
| enabled-plugins | clippy, cppcheck, gcc, shellcheck, unicontrol |
| exit-code | 0 |
| host | ip-172-16-1-36.us-west-2.compute.internal |
| mock-config | fedora-rawhide-gcc-latest-x86_64 |
| project-name | ostree-2024.9-1.fc42 |
| store-results-to | /tmp/tmp8uf7bojf/ostree-2024.9-1.fc42.tar.xz |
| time-created | 2024-11-13 02:13:18 |
| time-finished | 2024-11-13 02:17:12 |
| tool | csmock |
| tool-args | '/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmp8uf7bojf/ostree-2024.9-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmp8uf7bojf/ostree-2024.9-1.fc42.src.rpm' |
| tool-version | csmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9 |