Error: SHELLCHECK_WARNING (CWE-571): [#def1] /usr/share/podman/test/system/005-info.bats:161:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 159| test -e $osrelease || skip "Not a RHEL system (no $osrelease)" # 160| # 161|-> local osname=$(source $osrelease; echo $NAME) # 162| if [[ $osname =~ Red.Hat || $osname =~ CentOS ]]; then # 163| # Version can include minor; strip off first dot an all beyond it Error: SHELLCHECK_WARNING (CWE-571): [#def2] /usr/share/podman/test/system/012-manifest.bats:125:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 123| # 124| # Build two images, different arches, and add each to one manifest list # 125|-> local img="i-$(safename)" # 126| local manifestlocal="m-$(safename):1.0" # 127| run_podman manifest create $manifestlocal Error: SHELLCHECK_WARNING (CWE-571): [#def3] /usr/share/podman/test/system/012-manifest.bats:126:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 124| # Build two images, different arches, and add each to one manifest list # 125| local img="i-$(safename)" # 126|-> local manifestlocal="m-$(safename):1.0" # 127| run_podman manifest create $manifestlocal # 128| for arch in amd arm;do Error: SHELLCHECK_WARNING (CWE-156): [#def4] /usr/share/podman/test/system/012-manifest.bats:206:16: warning[SC2046]: Quote this to prevent word splitting. # 204| # 205| if [[ -n "$listFlags" ]] ; then # 206|-> assert $(jq -r '.annotations["global"]' <<<"$index") == local \ # 207| "listFlags=$listFlags, .annotations[global]" # 208| fi Error: SHELLCHECK_WARNING (CWE-156): [#def5] /usr/share/podman/test/system/012-manifest.bats:210:16: warning[SC2046]: Quote this to prevent word splitting. # 208| fi # 209| if [[ -n "$platformFlags" ]] ; then # 210|-> assert $(jq -r '.manifests[1].platform.os' <<<"$index") == linux \ # 211| "platformFlags=$platformFlags, .platform.os" # 212| assert $(jq -r '.manifests[1].platform.architecture' <<<"$index") == amd64 \ Error: SHELLCHECK_WARNING (CWE-156): [#def6] /usr/share/podman/test/system/012-manifest.bats:212:16: warning[SC2046]: Quote this to prevent word splitting. # 210| assert $(jq -r '.manifests[1].platform.os' <<<"$index") == linux \ # 211| "platformFlags=$platformFlags, .platform.os" # 212|-> assert $(jq -r '.manifests[1].platform.architecture' <<<"$index") == amd64 \ # 213| "platformFlags=$platformFlags, .platform.architecture" # 214| fi Error: SHELLCHECK_WARNING (CWE-571): [#def7] /usr/share/podman/test/system/012-manifest.bats:297:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 295| # every flag available. # 296| skip_if_remote "running a local registry doesn't work with podman-remote" # 297|-> local list="m-$(safename):1.0" # 298| truncate -s 20M ${PODMAN_TMPDIR}/zeroes # 299| echo oh yeah > ${PODMAN_TMPDIR}/listed.txt Error: SHELLCHECK_WARNING (CWE-563): [#def8] /usr/share/podman/test/system/030-run.bats:226:5: warning[SC2034]: i appears unused. Verify use (or export if used externally). # 224| run_podman run -d --name $cname --rmi $NONLOCAL_IMAGE /bin/true # 225| # 10 chances for the image to disappear # 226|-> for i in `seq 1 10`; do # 227| sleep 0.5 # 228| run_podman '?' image exists $NONLOCAL_IMAGE Error: SHELLCHECK_WARNING (CWE-140): [#def9] /usr/share/podman/test/system/030-run.bats:684:33: warning[SC2207]: Prefer mapfile or read -a to split command output (or quote to avoid splitting). # 682| run_podman inspect $IMAGE --format "{{json .RepoDigests}}" # 683| # ...so, strip off the prefix and get an array of sha strings # 684|-> declare -a expectedDigests=($(jq -r '.[]' <<<"$output" |\ # 685| sed -e "s;^${PODMAN_TEST_IMAGE_REGISTRY}/${PODMAN_TEST_IMAGE_USER}/${PODMAN_TEST_IMAGE_NAME}@;;")) # 686| Error: SHELLCHECK_WARNING (CWE-571): [#def10] /usr/share/podman/test/system/030-run.bats:878:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 876| # 877| # --layers=false needed to work around buildah#5674 parallel flake # 878|-> local iname=nomtab-$(safename) # 879| run_podman build -t $iname --layers=false $tmpdir # 880| run_podman run --rm $iname stat -c %N /etc/mtab Error: SHELLCHECK_WARNING (CWE-571): [#def11] /usr/share/podman/test/system/035-logs.bats:98:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 96| # 97| # Simple helper to make the container starts, below, easier to read # 98|-> local cname1="c-ltm-1-$(safename)" # 99| local cname2="c-ltm-2-$(safename)" # 100| local -a cid Error: SHELLCHECK_WARNING (CWE-571): [#def12] /usr/share/podman/test/system/035-logs.bats:99:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 97| # Simple helper to make the container starts, below, easier to read # 98| local cname1="c-ltm-1-$(safename)" # 99|-> local cname2="c-ltm-2-$(safename)" # 100| local -a cid # 101| doit() { Error: SHELLCHECK_WARNING (CWE-156): [#def13] /usr/share/podman/test/system/055-rm.bats:113:37: warning[SC2046]: Quote this to prevent word splitting. # 111| # bats test_tags=ci:parallel # 112| @test "podman container rm --force bogus" { # 113|-> run_podman 1 container rm bogus-$(safename) # 114| is "$output" "Error: no container with ID or name \"bogus-$(safename)\" found: no such container" "Should print error" # 115| run_podman container rm --force bogus-$(safename) Error: SHELLCHECK_WARNING (CWE-156): [#def14] /usr/share/podman/test/system/055-rm.bats:115:43: warning[SC2046]: Quote this to prevent word splitting. # 113| run_podman 1 container rm bogus-$(safename) # 114| is "$output" "Error: no container with ID or name \"bogus-$(safename)\" found: no such container" "Should print error" # 115|-> run_podman container rm --force bogus-$(safename) # 116| is "$output" "" "Should print no output" # 117| Error: SHELLCHECK_WARNING (CWE-156): [#def15] /usr/share/podman/test/system/055-rm.bats:118:38: warning[SC2046]: Quote this to prevent word splitting. # 116| is "$output" "" "Should print no output" # 117| # 118|-> run_podman create --name testctr-$(safename) $IMAGE # 119| run_podman container rm --force bogus-$(safename) testctr-$(safename) # 120| assert "$output" = "testctr-$(safename)" "should delete test" Error: SHELLCHECK_WARNING (CWE-156): [#def16] /usr/share/podman/test/system/055-rm.bats:119:43: warning[SC2046]: Quote this to prevent word splitting. # 117| # 118| run_podman create --name testctr-$(safename) $IMAGE # 119|-> run_podman container rm --force bogus-$(safename) testctr-$(safename) # 120| assert "$output" = "testctr-$(safename)" "should delete test" # 121| Error: SHELLCHECK_WARNING (CWE-156): [#def17] /usr/share/podman/test/system/055-rm.bats:119:63: warning[SC2046]: Quote this to prevent word splitting. # 117| # 118| run_podman create --name testctr-$(safename) $IMAGE # 119|-> run_podman container rm --force bogus-$(safename) testctr-$(safename) # 120| assert "$output" = "testctr-$(safename)" "should delete test" # 121| Error: SHELLCHECK_WARNING (CWE-571): [#def18] /usr/share/podman/test/system/055-rm.bats:143:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 141| # bats test_tags=ci:parallel # 142| @test "podman container rm doesn't affect stopping containers" { # 143|-> local cname=c-$(safename) # 144| __run_healthcheck_container $cname # 145| local cid=$output Error: SHELLCHECK_WARNING (CWE-571): [#def19] /usr/share/podman/test/system/055-rm.bats:181:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 179| # bats test_tags=ci:parallel # 180| @test "podman container rm --force doesn't leave running processes" { # 181|-> local cname=c-$(safename) # 182| __run_healthcheck_container $cname # 183| local cid=$output Error: SHELLCHECK_WARNING (CWE-571): [#def20] /usr/share/podman/test/system/060-mount.bats:125:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 123| # 124| # For parallel safety: create a temporary image to use for mounts # 125|-> local tmpctr="c-$(safename)" # 126| local iname="i-$(safename)" # 127| run_podman run --name $tmpctr $IMAGE true Error: SHELLCHECK_WARNING (CWE-571): [#def21] /usr/share/podman/test/system/060-mount.bats:126:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 124| # For parallel safety: create a temporary image to use for mounts # 125| local tmpctr="c-$(safename)" # 126|-> local iname="i-$(safename)" # 127| run_podman run --name $tmpctr $IMAGE true # 128| run_podman commit -q $tmpctr $iname Error: SHELLCHECK_WARNING (CWE-156): [#def22] /usr/share/podman/test/system/060-mount.bats:280:44: warning[SC2046]: Quote this to prevent word splitting. # 278| # 279| # Create a container that podman does not know about # 280|-> external_cname=$(buildah from --name b-$(safename) $IMAGE) # 281| # 282| run_podman mount $external_cname Error: SHELLCHECK_WARNING (CWE-571): [#def23] /usr/share/podman/test/system/065-cp.bats:28:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 26| echo "${randomcontent[2]}" > $srcdir/subdir/dotfile. # 27| # 28|-> local destrunning="c-destrun-$(safename)" # 29| run_podman run -d --name $destrunning --workdir=/srv $IMAGE sh -c "mkdir /srv/subdir; echo READY; sleep infinity" # 30| wait_for_ready $destrunning Error: SHELLCHECK_WARNING (CWE-571): [#def24] /usr/share/podman/test/system/065-cp.bats:83:15: warning[SC2155]: Declare and assign separately to avoid masking return values. # 81| # CREATED container # 82| while read id dest dest_fullname description; do # 83|-> local destcreated="c-destcreated-$(safename)" # 84| run_podman create --name $destcreated --workdir=/srv $cpimage sleep infinity # 85| run_podman cp $srcdir/hostfile$id $destcreated:$dest Error: SHELLCHECK_WARNING (CWE-571): [#def25] /usr/share/podman/test/system/065-cp.bats:103:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 101| # 102| # RUNNING container # 103|-> local destrunning="c-destrun-$(safename)" # 104| run_podman run -d --mount type=tmpfs,dst=/tmp --name $destrunning $IMAGE sleep infinity # 105| run_podman cp $srcdir/file $destrunning:/tmp Error: SHELLCHECK_WARNING (CWE-571): [#def26] /usr/share/podman/test/system/065-cp.bats:111:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 109| # 110| # CREATED container (with copy up) # 111|-> local destcreated=cdestcreated$(safename) # 112| run_podman create --mount type=tmpfs,dst=/tmp --name $destcreated $IMAGE sleep infinity # 113| run_podman cp $srcdir/file $destcreated:/tmp Error: SHELLCHECK_WARNING (CWE-571): [#def27] /usr/share/podman/test/system/065-cp.bats:130:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 128| keepid="--userns=keep-id" # 129| is_rootless || keepid="" # 130|-> local destrunning="c-destrun-$(safename)" # 131| run_podman run --user=$userid ${keepid} -d --name $destrunning $IMAGE sleep infinity # 132| run_podman cp $srcdir/hostfile $destrunning:/tmp/hostfile Error: SHELLCHECK_WARNING (CWE-571): [#def28] /usr/share/podman/test/system/065-cp.bats:151:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 149| keepid="--userns=keep-id" # 150| is_rootless || keepid="" # 151|-> local destrunning="c-destrun-$(safename)" # 152| run_podman run --user=$userid ${keepid} -d --name $destrunning $IMAGE sleep infinity # 153| run_podman cp -a=false - $destrunning:/tmp/ < "${tmpdir}/a.tar" Error: SHELLCHECK_WARNING (CWE-571): [#def29] /usr/share/podman/test/system/065-cp.bats:168:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 166| touch $srcdir/hostfile # 167| # 168|-> local cpcontainer="cpctr-$(safename)" # 169| run_podman run --pid=host -d --name $cpcontainer $IMAGE sleep infinity # 170| run_podman cp $srcdir/hostfile $cpcontainer:/tmp/hostfile Error: SHELLCHECK_WARNING (CWE-571): [#def30] /usr/share/podman/test/system/065-cp.bats:185:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 183| random-2-$(random_string 20) # 184| ) # 185|-> local srcrunning="c-srcrun-$(safename)" # 186| run_podman run -d --name $srcrunning --workdir=/srv $IMAGE sh -c "mkdir /srv/subdir; # 187| echo ${randomcontent[0]} > /tmp/containerfile; Error: SHELLCHECK_WARNING (CWE-571): [#def31] /usr/share/podman/test/system/065-cp.bats:225:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 223| # 224| # Created container # 225|-> local srccreated="c-src-crt-$(safename)" # 226| run_podman create --name $srccreated --workdir=/srv $cpimage # 227| while read id src dest dest_fullname description; do Error: SHELLCHECK_WARNING (CWE-571): [#def32] /usr/share/podman/test/system/065-cp.bats:249:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 247| ) # 248| # 249|-> local srcrunning="c-src-run-$(safename)" # 250| run_podman run -d --name $srcrunning --workdir=/srv $IMAGE sh -c "mkdir /srv/subdir; # 251| echo ${randomcontent[0]} > /tmp/containerfile; Error: SHELLCHECK_WARNING (CWE-88): [#def33] /usr/share/podman/test/system/065-cp.bats:301:39: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 299| is "$output" "${randomcontent[$id]}" "$description (cp ctr:$src to $dest - CREATED)" # 300| done < <(parse_table "$tests") # 301|-> run_podman rm -t 0 -f $srcrunning ${destcontainers[@]} # 302| # 303| # From CREATED container Error: SHELLCHECK_WARNING (CWE-571): [#def34] /usr/share/podman/test/system/065-cp.bats:305:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 303| # From CREATED container # 304| destcontainers=() # 305|-> local srccreated="c-src-crt-$(safename)" # 306| run_podman create --name $srccreated --workdir=/srv $cpimage # 307| while read id src dest dest_fullname description; do Error: SHELLCHECK_WARNING (CWE-88): [#def35] /usr/share/podman/test/system/065-cp.bats:329:39: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 327| is "$output" "${randomcontent[$id]}" "$description (cp ctr:$src to $dest)" # 328| done < <(parse_table "$tests") # 329|-> run_podman rm -t 0 -f $srccreated ${destcontainers[@]} # 330| run_podman rmi -f $cpimage # 331| } Error: SHELLCHECK_WARNING (CWE-571): [#def36] /usr/share/podman/test/system/065-cp.bats:348:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 346| cp -r $srcdir/dir/* $srcdir/dir. # 347| # 348|-> local destrunning="c-destrun-$(safename)" # 349| run_podman run -d --name $destrunning --workdir=/srv $IMAGE sh -c "mkdir /srv/subdir; echo READY;sleep infinity" # 350| wait_for_ready $destrunning Error: SHELLCHECK_WARNING (CWE-571): [#def37] /usr/share/podman/test/system/065-cp.bats:380:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 378| # 379| # CREATED container # 380|-> local destcreated="c-dest-created-$(safename)" # 381| run_podman create --name $destcreated --workdir=/srv $cpimage sleep infinity # 382| while read src dest dest_fullname description; do Error: SHELLCHECK_WARNING (CWE-571): [#def38] /usr/share/podman/test/system/065-cp.bats:396:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 394| run_podman rm -t 0 -f $destcreated # 395| # 396|-> local destnotdir="c-destnotdir-$(safename)" # 397| run_podman create --name $destnotdir --workdir=/srv $cpimage sleep infinity # 398| run_podman 125 cp $srcdir $destnotdir:/etc/os-release Error: SHELLCHECK_WARNING (CWE-571): [#def39] /usr/share/podman/test/system/065-cp.bats:415:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 413| ) # 414| # 415|-> local srcrunning="c-src-run-$(safename)" # 416| run_podman run -d --name $srcrunning --workdir=/srv $IMAGE sh -c "mkdir /srv/subdir; # 417| echo ${randomcontent[0]} > /srv/subdir/containerfile0; \ Error: SHELLCHECK_WARNING (CWE-571): [#def40] /usr/share/podman/test/system/065-cp.bats:457:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 455| # 456| # CREATED container # 457|-> local srccreated="c-src-crt-$(safename)" # 458| run_podman create --name $srccreated --workdir=/srv $cpimage # 459| while read src dest dest_fullname description; do Error: SHELLCHECK_WARNING (CWE-571): [#def41] /usr/share/podman/test/system/065-cp.bats:487:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 485| ) # 486| # 487|-> local srcrunning="c-src-run-$(safename)" # 488| run_podman run -d --name $srcrunning --workdir=/srv $IMAGE sh -c "mkdir /srv/subdir; # 489| echo ${randomcontent[0]} > /srv/subdir/containerfile0; \ Error: SHELLCHECK_WARNING (CWE-88): [#def42] /usr/share/podman/test/system/065-cp.bats:537:39: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 535| is "$(echo $output)" "${randomcontent[*]}" "$description - from RUNNING to CREATED/STARTED" # 536| done < <(parse_table "$tests") # 537|-> run_podman rm -t 0 -f $srcrunning ${destcontainers[@]} # 538| # 539| # From CREATED container Error: SHELLCHECK_WARNING (CWE-571): [#def43] /usr/share/podman/test/system/065-cp.bats:541:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 539| # From CREATED container # 540| destcontainers=() # 541|-> local srccreated="c-src-crt-$(safename)" # 542| run_podman create --name $srccreated --workdir=/srv $cpimage # 543| while read src dest dest_fullname description; do Error: SHELLCHECK_WARNING (CWE-88): [#def44] /usr/share/podman/test/system/065-cp.bats:566:39: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 564| done < <(parse_table "$tests") # 565| # 566|-> run_podman rm -t 0 -f $srccreated ${destcontainers[@]} # 567| run_podman rmi -f $cpimage # 568| } Error: SHELLCHECK_WARNING (CWE-571): [#def45] /usr/share/podman/test/system/065-cp.bats:580:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 578| ) # 579| # 580|-> local srcrunning="c-src-run-$(safename)" # 581| run_podman run -d --name $srcrunning $IMAGE sh -c "echo ${randomcontent[0]} > /tmp/containerfile0; \ # 582| echo ${randomcontent[1]} > /tmp/containerfile1; \ Error: SHELLCHECK_WARNING (CWE-571): [#def46] /usr/share/podman/test/system/065-cp.bats:604:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 602| # 603| # CREATED container # 604|-> local srccreated="c-src-crt-$(safename)" # 605| run_podman create --name $srccreated $cpimage # 606| run_podman cp $srccreated:/tmp/sub/weirdlink $destdir/dest Error: SHELLCHECK_WARNING (CWE-571): [#def47] /usr/share/podman/test/system/065-cp.bats:635:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 633| # This test is extra tricky, as volume2 is mounted into a sub-directory of # 634| # volume1. Podman must copy the file into volume2 and not volume1. # 635|-> local cpcontainer="c-cp_$(safename)" # 636| run_podman create --name $cpcontainer -v $volume1:/tmp/volume -v $volume2:/tmp/volume/sub-volume $IMAGE # 637| Error: SHELLCHECK_WARNING (CWE-571): [#def48] /usr/share/podman/test/system/065-cp.bats:660:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 658| # 659| # Make it a bit more complex and put the mount on a volume. # 660|-> local cpcontainer="c-cp-$(safename)" # 661| run_podman create --name $cpcontainer -v $volume:/tmp/volume -v $mountdir:/tmp/volume/mount $IMAGE # 662| Error: SHELLCHECK_WARNING (CWE-571): [#def49] /usr/share/podman/test/system/065-cp.bats:685:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 683| rand_content2=$(random_string 50) # 684| # 685|-> local cpcontainer="c-cp-$(safename)" # 686| run_podman run --name $cpcontainer $IMAGE sh -c \ # 687| "echo $rand_content1 >/tmp/$rand_filename1; Error: SHELLCHECK_WARNING (CWE-571): [#def50] /usr/share/podman/test/system/065-cp.bats:705:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 703| echo "this file is on the host" >$srcdir/hostfile # 704| # 705|-> local cpcontainer="c-cp-$(safename)" # 706| run_podman run --name $cpcontainer $IMAGE \ # 707| sh -c "ln -s $srcdir/hostfile /tmp/badlink" Error: SHELLCHECK_WARNING (CWE-571): [#def51] /usr/share/podman/test/system/065-cp.bats:733:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 731| echo "This file is on the host" > $srcdir/hostfile # 732| # 733|-> local cpcontainer="c-cp-$(safename)" # 734| run_podman run --name $cpcontainer $IMAGE \ # 735| sh -c "ln -s $srcdir/hostfile file1;ln -s file\* copyme" Error: SHELLCHECK_WARNING (CWE-571): [#def52] /usr/share/podman/test/system/065-cp.bats:754:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 752| echo "This file lives on the host" > $srcdir/hostfile # 753| # 754|-> local cpcontainer="c-cp-$(safename)" # 755| run_podman run --name $cpcontainer $IMAGE \ # 756| sh -c "ln -s $srcdir/hostfile /tmp/\*" Error: SHELLCHECK_WARNING (CWE-571): [#def53] /usr/share/podman/test/system/065-cp.bats:788:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 786| # Create tmp subdirectories in container, most with an invalid 'x' symlink # 787| # Keep container running so we can exec into it. # 788|-> local cpcontainer="c-cp-$(safename)" # 789| run_podman run -d --name $cpcontainer $IMAGE \ # 790| sh -c "mkdir /tmp/d1;ln -s /tmp/nonesuch1 /tmp/d1/x; Error: SHELLCHECK_WARNING (CWE-571): [#def54] /usr/share/podman/test/system/065-cp.bats:843:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 841| # 842| # Create that directory in the container, and keep container running # 843|-> local cpcontainer="c-cp-$(safename)" # 844| run_podman run -d --name $cpcontainer $IMAGE sh -c \ # 845| "mkdir -p $graphroot; echo READY; top" Error: SHELLCHECK_WARNING (CWE-571): [#def55] /usr/share/podman/test/system/065-cp.bats:876:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 874| tar -zvcf $tar_file $srcdir # 875| # 876|-> local cpcontainer="c-cp-$(safename)" # 877| run_podman run -d --name $cpcontainer $IMAGE sleep infinity # 878| Error: SHELLCHECK_WARNING (CWE-571): [#def56] /usr/share/podman/test/system/065-cp.bats:917:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 915| rand_content=$(random_string 50) # 916| # 917|-> local cpcontainer="c-cp-$(safename)" # 918| run_podman run -d --name $cpcontainer $IMAGE sleep infinity # 919| Error: SHELLCHECK_WARNING (CWE-571): [#def57] /usr/share/podman/test/system/065-cp.bats:959:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 957| rand_content_dir=$(random_string 50) # 958| # 959|-> local ctrfile="c-f-$(safename)" # 960| local ctrdir="c-d-$(safename)" # 961| run_podman run -d --name $ctrfile $IMAGE sh -c "echo '$rand_content_file' > /tmp/foo; echo READY; sleep infinity" Error: SHELLCHECK_WARNING (CWE-571): [#def58] /usr/share/podman/test/system/065-cp.bats:960:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 958| # 959| local ctrfile="c-f-$(safename)" # 960|-> local ctrdir="c-d-$(safename)" # 961| run_podman run -d --name $ctrfile $IMAGE sh -c "echo '$rand_content_file' > /tmp/foo; echo READY; sleep infinity" # 962| run_podman run -d --name $ctrdir $IMAGE sh -c "mkdir /tmp/foo; echo '$rand_content_dir' > /tmp/foo/file.txt; echo READY; sleep infinity" Error: SHELLCHECK_WARNING (CWE-571): [#def59] /usr/share/podman/test/system/065-cp.bats:997:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 995| rand_content_dir=$(random_string 50) # 996| # 997|-> local ctrfile="c-f-$(safename)" # 998| local ctrdir="c-d-$(safename)" # 999| run_podman run -d --name $ctrfile $IMAGE sh -c "echo '$rand_content_file' > /tmp/foo; echo READY; sleep infinity" Error: SHELLCHECK_WARNING (CWE-571): [#def60] /usr/share/podman/test/system/065-cp.bats:998:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 996| # 997| local ctrfile="c-f-$(safename)" # 998|-> local ctrdir="c-d-$(safename)" # 999| run_podman run -d --name $ctrfile $IMAGE sh -c "echo '$rand_content_file' > /tmp/foo; echo READY; sleep infinity" # 1000| run_podman run -d --name $ctrdir $IMAGE sh -c "mkdir /tmp/foo; echo '$rand_content_dir' > /tmp/foo/file.txt; echo READY; sleep infinity" Error: SHELLCHECK_WARNING (CWE-571): [#def61] /usr/share/podman/test/system/065-cp.bats:1033:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1031| rand_content_dir=$(random_string 50) # 1032| # 1033|-> local ctrfile="c-f-$(safename)" # 1034| local ctrdir="c-d-$(safename)" # 1035| run_podman run -d --name $ctrdir $IMAGE sh -c "mkdir /tmp/foo; echo READY; sleep infinity" Error: SHELLCHECK_WARNING (CWE-571): [#def62] /usr/share/podman/test/system/065-cp.bats:1034:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1032| # 1033| local ctrfile="c-f-$(safename)" # 1034|-> local ctrdir="c-d-$(safename)" # 1035| run_podman run -d --name $ctrdir $IMAGE sh -c "mkdir /tmp/foo; echo READY; sleep infinity" # 1036| run_podman run -d --name $ctrfile $IMAGE sh -c "touch /tmp/foo; echo READY; sleep infinity" Error: SHELLCHECK_WARNING (CWE-571): [#def63] /usr/share/podman/test/system/065-cp.bats:1072:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1070| touch $srcdir/test1./file1 $srcdir/test2/file2 # 1071| # 1072|-> local cname="c-$(safename)" # 1073| run_podman run -d --name=$cname --rm $IMAGE sleep infinity # 1074| run_podman cp $srcdir/test1. $cname:/tmp/foo Error: SHELLCHECK_WARNING (CWE-571): [#def64] /usr/share/podman/test/system/065-cp.bats:1085:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1083| mkdir -p $dstdir # 1084| # 1085|-> local cname="c-$(safename)" # 1086| run_podman run -d --name=$cname --rm $IMAGE sh -c "mkdir -p /foo/test1. /foo/test2; touch /foo/test1./file1 /foo/test2/file2; echo READY;sleep infinity" # 1087| wait_for_ready $cname Error: SHELLCHECK_WARNING (CWE-571): [#def65] /usr/share/podman/test/system/065-cp.bats:1097:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1095| # 1096| @test "podman cp - dot notation - container to container" { # 1097|-> local ctrsrc="c-src-$(safename)" # 1098| run_podman run -d --name=$ctrsrc --rm $IMAGE sh -c "mkdir -p /foo/test1. /foo/test2; touch /foo/test1./file1 /foo/test2/file2; echo READY;sleep infinity" # 1099| wait_for_ready $ctrsrc Error: SHELLCHECK_WARNING (CWE-571): [#def66] /usr/share/podman/test/system/065-cp.bats:1101:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1099| wait_for_ready $ctrsrc # 1100| # 1101|-> local ctrdest="c-test-$(safename)" # 1102| run_podman run -d --name=$ctrdest --rm $IMAGE sleep infinity # 1103| run_podman cp $ctrsrc:/foo/test1. $ctrdest:/foo Error: SHELLCHECK_WARNING (CWE-571): [#def67] /usr/share/podman/test/system/070-build.bats:255:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 253| EOF # 254| # 255|-> local imgbase="b-$(safename)" # 256| local count=10 # 257| for i in $(seq --format '%02g' 1 $count); do Error: SHELLCHECK_WARNING (CWE-156): [#def68] /usr/share/podman/test/system/070-build.bats:1204:29: warning[SC2046]: Quote this to prevent word splitting. # 1202| # test failures. Try a last-ditch force-rm in cleanup, ignoring errors. # 1203| run_podman '?' rm -t 0 -a -f # 1204|-> run_podman '?' rmi -f b-$(safename) # 1205| # 1206| # Many of the tests above leave interim layers behind. Clean them up. Error: SHELLCHECK_WARNING (CWE-571): [#def69] /usr/share/podman/test/system/090-events.bats:321:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 319| @test "events - labels included in container die" { # 320| skip_if_remote "remote does not support --events-backend" # 321|-> local cname=c-$(safename) # 322| local lname=label$(safename | tr -d -) # 323| local lvalue="labelvalue-$(safename) $(random_string 5)" Error: SHELLCHECK_WARNING (CWE-571): [#def70] /usr/share/podman/test/system/090-events.bats:322:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 320| skip_if_remote "remote does not support --events-backend" # 321| local cname=c-$(safename) # 322|-> local lname=label$(safename | tr -d -) # 323| local lvalue="labelvalue-$(safename) $(random_string 5)" # 324| Error: SHELLCHECK_WARNING (CWE-571): [#def71] /usr/share/podman/test/system/090-events.bats:323:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 321| local cname=c-$(safename) # 322| local lname=label$(safename | tr -d -) # 323|-> local lvalue="labelvalue-$(safename) $(random_string 5)" # 324| # 325| run_podman 17 --events-backend=file run --rm \ Error: SHELLCHECK_WARNING (CWE-571): [#def72] /usr/share/podman/test/system/090-events.bats:355:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 353| EOF # 354| # 355|-> local cname=c-$1-$(safename) # 356| t0=$(date --iso-8601=seconds) # 357| Error: SHELLCHECK_WARNING (CWE-571): [#def73] /usr/share/podman/test/system/090-events.bats:410:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 408| # bats test_tags=ci:parallel # 409| @test "events - docker compat" { # 410|-> local cname=c-$(safename) # 411| t0=$(date --iso-8601=ns) # 412| run_podman run --name=$cname --rm $IMAGE true Error: SHELLCHECK_WARNING (CWE-571): [#def74] /usr/share/podman/test/system/090-events.bats:423:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 421| # bats test_tags=ci:parallel # 422| @test "events - volume events" { # 423|-> local vname=v-$(safename) # 424| run_podman volume create $vname # 425| run_podman volume rm $vname Error: SHELLCHECK_WARNING (CWE-571): [#def75] /usr/share/podman/test/system/120-load.bats:246:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 244| run_podman rm -f -t0 myweb # 245| run_podman images -a --format '{{.ID}} {{.Repository}}:{{.Tag}}' # 246|-> local myweb_iid=$(echo "$output" | sed -n '/<none>:<none>/s/ .*$//p') # 247| if [[ -n "$myweb_iid" ]]; then # 248| run_podman rmi $myweb_iid Error: SHELLCHECK_WARNING (CWE-571): [#def76] /usr/share/podman/test/system/130-kill.bats:10:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 8| # bats test_tags=distro-integration, ci:parallel # 9| @test "podman kill - test signal handling in containers" { # 10|-> local cname=c-$(safename) # 11| local fifo=${PODMAN_TMPDIR}/podman-kill-fifo.$(random_string 10) # 12| mkfifo $fifo Error: SHELLCHECK_WARNING (CWE-571): [#def77] /usr/share/podman/test/system/150-login.bats:347:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 345| run_podman rmi $image1 # 346| # 347|-> local podman_image_config_digest=$(image_config_digest $IMAGE) # 348| # 349| run_podman pull -q --retry 4 --retry-delay "0s" --authfile=$authfile \ Error: SHELLCHECK_WARNING (CWE-156): [#def78] /usr/share/podman/test/system/170-run-userns.bats:155:36: warning[SC2046]: Quote this to prevent word splitting. # 153| @test "podman userns=keep-id in a pod" { # 154| user=$(id -u) # 155|-> run_podman pod create --name p_$(safename) --userns keep-id # 156| pid=$output # 157| run_podman run --rm --pod $pid $IMAGE id -u Error: SHELLCHECK_WARNING (CWE-571): [#def79] /usr/share/podman/test/system/195-run-namespaces.bats:21:19: warning[SC2155]: Declare and assign separately to avoid masking return values. # 19| for nstype in private host; do # 20| while read name option; do # 21|-> local cname="c-${name}-$(safename)" # 22| # ipc is special, private does not allow joining from another container. # 23| # Instead we must use "shareable". Error: SHELLCHECK_WARNING (CWE-571): [#def80] /usr/share/podman/test/system/200-pod.bats:241:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 239| # existing 'pause' script in our testimage. We assign a bogus # 240| # entrypoint to confirm that --infra-command will override. # 241|-> local infra_image="infra_image_$(safename)" # 242| local infra_command="/pause_$(safename)" # 243| local infra_name="infra_container_$(safename)" Error: SHELLCHECK_WARNING (CWE-571): [#def81] /usr/share/podman/test/system/200-pod.bats:242:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 240| # entrypoint to confirm that --infra-command will override. # 241| local infra_image="infra_image_$(safename)" # 242|-> local infra_command="/pause_$(safename)" # 243| local infra_name="infra_container_$(safename)" # 244| # --layers=false needed to work around buildah#5674 parallel flake Error: SHELLCHECK_WARNING (CWE-571): [#def82] /usr/share/podman/test/system/200-pod.bats:243:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 241| local infra_image="infra_image_$(safename)" # 242| local infra_command="/pause_$(safename)" # 243|-> local infra_name="infra_container_$(safename)" # 244| # --layers=false needed to work around buildah#5674 parallel flake # 245| run_podman build -t $infra_image --layers=false - << EOF Error: SHELLCHECK_WARNING (CWE-571): [#def83] /usr/share/podman/test/system/200-pod.bats:251:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 249| EOF # 250| # 251|-> local podname="pod-$(safename)" # 252| if is_rootless; then # 253| mac_option= Error: SHELLCHECK_WARNING (CWE-571): [#def84] /usr/share/podman/test/system/200-pod.bats:365:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 363| # bats test_tags=ci:parallel # 364| @test "podman pod create should fail when infra-name is already in use" { # 365|-> local infra_name="infra_container_$(safename)" # 366| local infra_image="quay.io/libpod/k8s-pause:3.5" # 367| local pod_name="p-$(safename)" Error: SHELLCHECK_WARNING (CWE-571): [#def85] /usr/share/podman/test/system/200-pod.bats:367:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 365| local infra_name="infra_container_$(safename)" # 366| local infra_image="quay.io/libpod/k8s-pause:3.5" # 367|-> local pod_name="p-$(safename)" # 368| # 369| run_podman --noout pod create --name $pod_name --infra-name "$infra_name" --infra-image "$infra_image" Error: SHELLCHECK_WARNING (CWE-571): [#def86] /usr/share/podman/test/system/200-pod.bats:382:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 380| # bats test_tags=ci:parallel # 381| @test "podman pod create --share" { # 382|-> local pod_name="p-$(safename)" # 383| run_podman 125 pod create --share bogus --name $pod_name # 384| is "$output" ".*invalid kernel namespace to share: bogus. Options are: cgroup, ipc, net, pid, uts or none" \ Error: SHELLCHECK_WARNING (CWE-571): [#def87] /usr/share/podman/test/system/200-pod.bats:402:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 400| # bats test_tags=ci:parallel # 401| @test "podman pod create --pod new:$POD --hostname" { # 402|-> local pod_name="p-$(safename)" # 403| run_podman run --rm --pod "new:$pod_name" --hostname foobar $IMAGE hostname # 404| is "$output" "foobar" "--hostname should work when creating a new:pod" Error: SHELLCHECK_WARNING (CWE-571): [#def88] /usr/share/podman/test/system/200-pod.bats:413:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 411| # bats test_tags=ci:parallel # 412| @test "podman rm --force to remove infra container" { # 413|-> local pod_name="p-$(safename)" # 414| run_podman create --pod "new:$pod_name" $IMAGE # 415| container_ID="$output" Error: SHELLCHECK_WARNING (CWE-569): [#def89] /usr/share/podman/test/system/200-pod.bats:451:46: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 449| podname="p-$(safename)" # 450| run_podman pod create --name $podname # 451|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "false" "Default network sharing should be false" # 453| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def90] /usr/share/podman/test/system/200-pod.bats:451:47: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 449| podname="p-$(safename)" # 450| run_podman pod create --name $podname # 451|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "false" "Default network sharing should be false" # 453| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def91] /usr/share/podman/test/system/200-pod.bats:451:72: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 449| podname="p-$(safename)" # 450| run_podman pod create --name $podname # 451|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "false" "Default network sharing should be false" # 453| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def92] /usr/share/podman/test/system/200-pod.bats:451:73: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 449| podname="p-$(safename)" # 450| run_podman pod create --name $podname # 451|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "false" "Default network sharing should be false" # 453| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def93] /usr/share/podman/test/system/200-pod.bats:456:46: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 454| # 455| run_podman pod create --share ipc --network private $podname # 456|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 457| is "$output" "false" "Private network sharing with only ipc should be false" # 458| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def94] /usr/share/podman/test/system/200-pod.bats:456:47: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 454| # 455| run_podman pod create --share ipc --network private $podname # 456|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 457| is "$output" "false" "Private network sharing with only ipc should be false" # 458| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def95] /usr/share/podman/test/system/200-pod.bats:456:72: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 454| # 455| run_podman pod create --share ipc --network private $podname # 456|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 457| is "$output" "false" "Private network sharing with only ipc should be false" # 458| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def96] /usr/share/podman/test/system/200-pod.bats:456:73: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 454| # 455| run_podman pod create --share ipc --network private $podname # 456|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 457| is "$output" "false" "Private network sharing with only ipc should be false" # 458| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def97] /usr/share/podman/test/system/200-pod.bats:461:46: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 459| # 460| run_podman pod create --name $podname --share net --network private # 461|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 462| is "$output" "false" "Private network sharing with only net should be false" # 463| Error: SHELLCHECK_WARNING (CWE-569): [#def98] /usr/share/podman/test/system/200-pod.bats:461:47: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 459| # 460| run_podman pod create --name $podname --share net --network private # 461|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 462| is "$output" "false" "Private network sharing with only net should be false" # 463| Error: SHELLCHECK_WARNING (CWE-569): [#def99] /usr/share/podman/test/system/200-pod.bats:461:72: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 459| # 460| run_podman pod create --name $podname --share net --network private # 461|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 462| is "$output" "false" "Private network sharing with only net should be false" # 463| Error: SHELLCHECK_WARNING (CWE-569): [#def100] /usr/share/podman/test/system/200-pod.bats:461:73: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 459| # 460| run_podman pod create --name $podname --share net --network private # 461|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 462| is "$output" "false" "Private network sharing with only net should be false" # 463| Error: SHELLCHECK_WARNING (CWE-569): [#def101] /usr/share/podman/test/system/200-pod.bats:465:46: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 463| # 464| run_podman pod create --share net --network host --replace $podname # 465|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 466| is "$output" "true" "Host network sharing with only net should be true" # 467| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def102] /usr/share/podman/test/system/200-pod.bats:465:47: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 463| # 464| run_podman pod create --share net --network host --replace $podname # 465|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 466| is "$output" "true" "Host network sharing with only net should be true" # 467| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def103] /usr/share/podman/test/system/200-pod.bats:465:72: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 463| # 464| run_podman pod create --share net --network host --replace $podname # 465|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 466| is "$output" "true" "Host network sharing with only net should be true" # 467| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def104] /usr/share/podman/test/system/200-pod.bats:465:73: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 463| # 464| run_podman pod create --share net --network host --replace $podname # 465|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 466| is "$output" "true" "Host network sharing with only net should be true" # 467| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def105] /usr/share/podman/test/system/200-pod.bats:470:46: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 468| # 469| run_podman pod create --name $podname --share ipc --network host # 470|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 471| is "$output" "true" "Host network sharing with only ipc should be true" # 472| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def106] /usr/share/podman/test/system/200-pod.bats:470:47: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 468| # 469| run_podman pod create --name $podname --share ipc --network host # 470|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 471| is "$output" "true" "Host network sharing with only ipc should be true" # 472| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def107] /usr/share/podman/test/system/200-pod.bats:470:72: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 468| # 469| run_podman pod create --name $podname --share ipc --network host # 470|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 471| is "$output" "true" "Host network sharing with only ipc should be true" # 472| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-569): [#def108] /usr/share/podman/test/system/200-pod.bats:470:73: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 468| # 469| run_podman pod create --name $podname --share ipc --network host # 470|-> run_podman pod inspect $podname --format {{.InfraConfig.HostNetwork}} # 471| is "$output" "true" "Host network sharing with only ipc should be true" # 472| run_podman pod rm $podname Error: SHELLCHECK_WARNING (CWE-571): [#def109] /usr/share/podman/test/system/200-pod.bats:512:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 510| @test "pod exit policies - play kube" { # 511| # play-kube sets the exit policy to "stop" # 512|-> local name="p-$(safename)" # 513| # 514| kubeFile="apiVersion: v1 Error: SHELLCHECK_WARNING (CWE-571): [#def110] /usr/share/podman/test/system/200-pod.bats:566:15: warning[SC2155]: Declare and assign separately to avoid masking return values. # 564| defer-assertion-failures # 565| for cgm in systemd cgroupfs; do # 566|-> local name="p-resources-$cgm-$(safename)" # 567| run_podman --cgroup-manager=$cgm pod create --name=$name --cpus=5 --memory=5m --memory-swap=1g --cpu-shares=1000 --cpuset-cpus=0 --cpuset-mems=0 --device-read-bps=${LOOPDEVICE}:1mb --device-write-bps=${LOOPDEVICE}:1mb --blkio-weight=50 # 568| run_podman --cgroup-manager=$cgm pod start $name Error: SHELLCHECK_WARNING (CWE-571): [#def111] /usr/share/podman/test/system/200-pod.bats:716:15: warning[SC2155]: Declare and assign separately to avoid masking return values. # 714| for p in 1 2 3; do # 715| local pid=${podid[$p]} # 716|-> local podname="p-$p-$(safename)" # 717| # 718| # Search by short pod ID, longer pod ID, pod ID regex, and pod name Error: SHELLCHECK_WARNING (CWE-571): [#def112] /usr/share/podman/test/system/200-pod.bats:740:19: warning[SC2155]: Declare and assign separately to avoid masking return values. # 738| for c in 1 2 3;do # 739| local cid=${ctrid[$p$c]} # 740|-> local podname="p-$p-$(safename)" # 741| for filter in "ctr-ids=${cid:0:2}" "ctr-ids=^${cid:0:2}.*"; do # 742| run_podman pod ps --filter=$filter --format '{{.Name}}:{{.Id}}' Error: SHELLCHECK_WARNING (CWE-569): [#def113] /usr/share/podman/test/system/200-pod.bats:758:26: warning[SC2048]: Use "${array[@]}" (with quotes) to prevent whitespace problems. # 756| # 757| # Clean up # 758|-> run_podman pod rm -f ${podid[*]} # 759| } # 760| Error: SHELLCHECK_WARNING (CWE-571): [#def114] /usr/share/podman/test/system/220-healthcheck.bats:56:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 54| # 55| @test "podman healthcheck" { # 56|-> local ctrname="c-h-$(safename)" # 57| run_podman run -d --name $ctrname \ # 58| --health-cmd /home/podman/healthcheck \ Error: SHELLCHECK_WARNING (CWE-571): [#def115] /usr/share/podman/test/system/220-healthcheck.bats:320:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 318| # 319| @test "podman healthcheck --health-max-log-count default value (5)" { # 320|-> local msg="healthmsg-$(random_string)" # 321| local ctrname="c-h-$(safename)" # 322| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogCount}}" "" "5" "HealthMaxLogCount is the expected default" Error: SHELLCHECK_WARNING (CWE-571): [#def116] /usr/share/podman/test/system/220-healthcheck.bats:321:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 319| @test "podman healthcheck --health-max-log-count default value (5)" { # 320| local msg="healthmsg-$(random_string)" # 321|-> local ctrname="c-h-$(safename)" # 322| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogCount}}" "" "5" "HealthMaxLogCount is the expected default" # 323| Error: SHELLCHECK_WARNING (CWE-571): [#def117] /usr/share/podman/test/system/220-healthcheck.bats:337:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 335| @test "podman healthcheck --health-max-log-count infinite value (0)" { # 336| local repeat_count=10 # 337|-> local msg="healthmsg-$(random_string)" # 338| local ctrname="c-h-$(safename)" # 339| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogCount}}" "--health-max-log-count 0" "0" "HealthMaxLogCount" Error: SHELLCHECK_WARNING (CWE-571): [#def118] /usr/share/podman/test/system/220-healthcheck.bats:338:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 336| local repeat_count=10 # 337| local msg="healthmsg-$(random_string)" # 338|-> local ctrname="c-h-$(safename)" # 339| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogCount}}" "--health-max-log-count 0" "0" "HealthMaxLogCount" # 340| Error: SHELLCHECK_WARNING (CWE-571): [#def119] /usr/share/podman/test/system/220-healthcheck.bats:358:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 356| @test "podman healthcheck --health-max-log-count 10" { # 357| local repeat_count=10 # 358|-> local msg="healthmsg-$(random_string)" # 359| local ctrname="c-h-$(safename)" # 360| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogCount}}" "--health-max-log-count $repeat_count" "$repeat_count" "HealthMaxLogCount" Error: SHELLCHECK_WARNING (CWE-571): [#def120] /usr/share/podman/test/system/220-healthcheck.bats:359:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 357| local repeat_count=10 # 358| local msg="healthmsg-$(random_string)" # 359|-> local ctrname="c-h-$(safename)" # 360| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogCount}}" "--health-max-log-count $repeat_count" "$repeat_count" "HealthMaxLogCount" # 361| Error: SHELLCHECK_WARNING (CWE-571): [#def121] /usr/share/podman/test/system/220-healthcheck.bats:375:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 373| # 374| @test "podman healthcheck --health-max-log-size 10" { # 375|-> local msg="healthmsg-$(random_string)" # 376| local ctrname="c-h-$(safename)" # 377| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogSize}}" "--health-max-log-size 10" "10" "HealthMaxLogSize" Error: SHELLCHECK_WARNING (CWE-571): [#def122] /usr/share/podman/test/system/220-healthcheck.bats:376:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 374| @test "podman healthcheck --health-max-log-size 10" { # 375| local msg="healthmsg-$(random_string)" # 376|-> local ctrname="c-h-$(safename)" # 377| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogSize}}" "--health-max-log-size 10" "10" "HealthMaxLogSize" # 378| Error: SHELLCHECK_WARNING (CWE-571): [#def123] /usr/share/podman/test/system/220-healthcheck.bats:389:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 387| # 388| @test "podman healthcheck --health-max-log-size infinite value (0)" { # 389|-> local s=$(printf "healthmsg-%1000s") # 390| local long_msg=${s// /$(random_string)} # 391| local ctrname="c-h-$(safename)" Error: SHELLCHECK_WARNING (CWE-398): [#def124] /usr/share/podman/test/system/220-healthcheck.bats:389:22: warning[SC2183]: This format string has 1 variable, but is passed 0 argument. # 387| # 388| @test "podman healthcheck --health-max-log-size infinite value (0)" { # 389|-> local s=$(printf "healthmsg-%1000s") # 390| local long_msg=${s// /$(random_string)} # 391| local ctrname="c-h-$(safename)" Error: SHELLCHECK_WARNING (CWE-571): [#def125] /usr/share/podman/test/system/220-healthcheck.bats:391:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 389| local s=$(printf "healthmsg-%1000s") # 390| local long_msg=${s// /$(random_string)} # 391|-> local ctrname="c-h-$(safename)" # 392| _create_container_with_health_log_settings $ctrname $long_msg "{{.Config.HealthMaxLogSize}}" "--health-max-log-size 0" "0" "HealthMaxLogSize" # 393| Error: SHELLCHECK_WARNING (CWE-571): [#def126] /usr/share/podman/test/system/220-healthcheck.bats:405:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 403| # 404| @test "podman healthcheck --health-max-log-size default value (500)" { # 405|-> local s=$(printf "healthmsg-%1000s") # 406| local long_msg=${s// /$(random_string)} # 407| local ctrname="c-h-$(safename)" Error: SHELLCHECK_WARNING (CWE-398): [#def127] /usr/share/podman/test/system/220-healthcheck.bats:405:22: warning[SC2183]: This format string has 1 variable, but is passed 0 argument. # 403| # 404| @test "podman healthcheck --health-max-log-size default value (500)" { # 405|-> local s=$(printf "healthmsg-%1000s") # 406| local long_msg=${s// /$(random_string)} # 407| local ctrname="c-h-$(safename)" Error: SHELLCHECK_WARNING (CWE-571): [#def128] /usr/share/podman/test/system/220-healthcheck.bats:407:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 405| local s=$(printf "healthmsg-%1000s") # 406| local long_msg=${s// /$(random_string)} # 407|-> local ctrname="c-h-$(safename)" # 408| _create_container_with_health_log_settings $ctrname $long_msg "{{.Config.HealthMaxLogSize}}" "" "500" "HealthMaxLogSize is the expected default" # 409| Error: SHELLCHECK_WARNING (CWE-571): [#def129] /usr/share/podman/test/system/220-healthcheck.bats:423:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 421| local TMP_DIR_HEALTHCHECK="$PODMAN_TMPDIR/healthcheck" # 422| mkdir $TMP_DIR_HEALTHCHECK # 423|-> local ctrname="c-h-$(safename)" # 424| local msg="healthmsg-$(random_string)" # 425| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination $TMP_DIR_HEALTHCHECK" "$TMP_DIR_HEALTHCHECK" "HealthLogDestination" Error: SHELLCHECK_WARNING (CWE-571): [#def130] /usr/share/podman/test/system/220-healthcheck.bats:424:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 422| mkdir $TMP_DIR_HEALTHCHECK # 423| local ctrname="c-h-$(safename)" # 424|-> local msg="healthmsg-$(random_string)" # 425| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination $TMP_DIR_HEALTHCHECK" "$TMP_DIR_HEALTHCHECK" "HealthLogDestination" # 426| cid="$output" Error: SHELLCHECK_WARNING (CWE-571): [#def131] /usr/share/podman/test/system/220-healthcheck.bats:447:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 445| skip_if_journald_unavailable # 446| # 447|-> local ctrname="c-h-$(safename)" # 448| local msg="healthmsg-$(random_string)" # 449| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination events_logger" "events_logger" "HealthLogDestination" Error: SHELLCHECK_WARNING (CWE-571): [#def132] /usr/share/podman/test/system/220-healthcheck.bats:448:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 446| # 447| local ctrname="c-h-$(safename)" # 448|-> local msg="healthmsg-$(random_string)" # 449| _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination events_logger" "events_logger" "HealthLogDestination" # 450| cid="$output" Error: SHELLCHECK_WARNING (CWE-252): [#def133] /usr/share/podman/test/system/250-systemd.bats:64:9: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 62| # is forgiving about that, but RHEL8 systemd chokes with EINVAL) # 63| ( # 64|-> cd $PODMAN_TMPDIR # 65| run_podman generate systemd --files --name \ # 66| -e http_proxy -e https_proxy -e no_proxy \ Error: SHELLCHECK_WARNING (CWE-571): [#def134] /usr/share/podman/test/system/250-systemd.bats:331:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 329| # 330| cname=c-$(safename) # 331|-> local netname=testnet-$(safename) # 332| # 333| # create network and container with network Error: SHELLCHECK_WARNING (CWE-571): [#def135] /usr/share/podman/test/system/252-quadlet.bats:192:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 190| # Network=none is to work around a Pasta bug, can be removed once a patched Pasta is available. # 191| # Ref https://github.com/containers/podman/pull/21563#issuecomment-1965145324 # 192|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 193| cat > $quadlet_file <<EOF # 194| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def136] /usr/share/podman/test/system/252-quadlet.bats:240:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 238| dir1=$PODMAN_TMPDIR/$(random_string) # 239| dir2=$PODMAN_TMPDIR/$(random_string) # 240|-> local quadlet_file=basic_$(safename).container # 241| mkdir -p $dir1 $dir2 # 242| Error: SHELLCHECK_WARNING (CWE-571): [#def137] /usr/share/podman/test/system/252-quadlet.bats:262:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 260| # 261| @test "quadlet - envvar" { # 262|-> local quadlet_file=$PODMAN_TMPDIR/envvar_$(safename).container # 263| cat > $quadlet_file <<EOF # 264| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def138] /usr/share/podman/test/system/252-quadlet.bats:286:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 284| # 285| @test "quadlet - ContainerName and journal output check" { # 286|-> local quadlet_file=$PODMAN_TMPDIR/containername_$(safename).container # 287| local token_out="STDOUT$(random_string 10)" # 288| local token_err="STDERR$(random_string 10)" Error: SHELLCHECK_WARNING (CWE-571): [#def139] /usr/share/podman/test/system/252-quadlet.bats:319:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 317| # 318| @test "quadlet - labels" { # 319|-> local quadlet_file=$PODMAN_TMPDIR/labels_$(safename).container # 320| cat > $quadlet_file <<EOF # 321| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def140] /usr/share/podman/test/system/252-quadlet.bats:345:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 343| # 344| @test "quadlet - oneshot" { # 345|-> local quadlet_file=$PODMAN_TMPDIR/oneshot_$(safename).container # 346| cat > $quadlet_file <<EOF # 347| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def141] /usr/share/podman/test/system/252-quadlet.bats:368:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 366| # 367| @test "quadlet - volume" { # 368|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).volume # 369| cat > $quadlet_file <<EOF # 370| [Volume] Error: SHELLCHECK_WARNING (CWE-571): [#def142] /usr/share/podman/test/system/252-quadlet.bats:394:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 392| @test "quadlet - volume dependency" { # 393| # Save the unit name to use as the volume for the container # 394|-> local quadlet_vol_unit=dep_$(safename).volume # 395| local quadlet_vol_file=$PODMAN_TMPDIR/${quadlet_vol_unit} # 396| cat > $quadlet_vol_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def143] /usr/share/podman/test/system/252-quadlet.bats:408:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 406| local volume_name=systemd-$(basename $quadlet_vol_file .volume) # 407| # 408|-> local quadlet_file=$PODMAN_TMPDIR/user_$(safename).container # 409| cat > $quadlet_file <<EOF # 410| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def144] /usr/share/podman/test/system/252-quadlet.bats:443:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 441| # A quadlet container depends on a named quadlet volume # 442| @test "quadlet - named volume dependency" { # 443|-> local volume_name="v-$(safename)" # 444| # 445| # Save the unit name to use as the volume for the container Error: SHELLCHECK_WARNING (CWE-571): [#def145] /usr/share/podman/test/system/252-quadlet.bats:446:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 444| # 445| # Save the unit name to use as the volume for the container # 446|-> local quadlet_vol_unit=dep_$(safename).volume # 447| local quadlet_vol_file=$PODMAN_TMPDIR/${quadlet_vol_unit} # 448| cat > $quadlet_vol_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def146] /usr/share/podman/test/system/252-quadlet.bats:460:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 458| local vol_service=$QUADLET_SERVICE_NAME # 459| # 460|-> local quadlet_file=$PODMAN_TMPDIR/user_$(safename).container # 461| cat > $quadlet_file <<EOF # 462| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def147] /usr/share/podman/test/system/252-quadlet.bats:498:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 496| # 497| @test "quadlet - network" { # 498|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).network # 499| cat > $quadlet_file <<EOF # 500| [Network] Error: SHELLCHECK_WARNING (CWE-571): [#def148] /usr/share/podman/test/system/252-quadlet.bats:523:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 521| @test "quadlet - network dependency" { # 522| # Save the unit name to use as the network for the container # 523|-> local quadlet_network_unit=dep_$(safename).network # 524| local quadlet_network_file=$PODMAN_TMPDIR/${quadlet_network_unit} # 525| cat > $quadlet_network_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def149] /usr/share/podman/test/system/252-quadlet.bats:537:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 535| local network_name=systemd-$(basename $quadlet_network_file .network) # 536| # 537|-> local quadlet_file=$PODMAN_TMPDIR/user_$(safename).container # 538| cat > $quadlet_file <<EOF # 539| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def150] /usr/share/podman/test/system/252-quadlet.bats:570:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 568| @test "quadlet - named network dependency" { # 569| # Save the unit name to use as the network for the container # 570|-> local quadlet_network_unit=dep_$(safename).network # 571| local quadlet_network_file=$PODMAN_TMPDIR/${quadlet_network_unit} # 572| cat > $quadlet_network_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def151] /usr/share/podman/test/system/252-quadlet.bats:578:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 576| # 577| # Have quadlet create the systemd unit file for the network unit # 578|-> local quadlet_tmpdir=$(mktemp -d --tmpdir=$PODMAN_TMPDIR quadlet.XXXXXX) # 579| run_quadlet "$quadlet_network_file" "$quadlet_tmpdir" # 580| Error: SHELLCHECK_WARNING (CWE-571): [#def152] /usr/share/podman/test/system/252-quadlet.bats:585:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 583| local network_name="foo" # 584| # 585|-> local quadlet_file=$PODMAN_TMPDIR/user_$(safename).container # 586| cat > $quadlet_file <<EOF # 587| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def153] /usr/share/podman/test/system/252-quadlet.bats:643:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 641| # 642| # Create the Quadlet file # 643|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).kube # 644| cat > $quadlet_file <<EOF # 645| [Kube] Error: SHELLCHECK_WARNING (CWE-571): [#def154] /usr/share/podman/test/system/252-quadlet.bats:663:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 661| @test "quadlet kube - named network dependency" { # 662| # Save the unit name to use as the network for the container # 663|-> local quadlet_network_unit=dep_$(safename).network # 664| local quadlet_network_file=$PODMAN_TMPDIR/${quadlet_network_unit} # 665| local network_name="n-$(safename)" Error: SHELLCHECK_WARNING (CWE-571): [#def155] /usr/share/podman/test/system/252-quadlet.bats:665:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 663| local quadlet_network_unit=dep_$(safename).network # 664| local quadlet_network_file=$PODMAN_TMPDIR/${quadlet_network_unit} # 665|-> local network_name="n-$(safename)" # 666| cat > $quadlet_network_file <<EOF # 667| [Network] Error: SHELLCHECK_WARNING (CWE-571): [#def156] /usr/share/podman/test/system/252-quadlet.bats:672:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 670| # 671| # Have quadlet create the systemd unit file for the network unit # 672|-> local quadlet_tmpdir=$(mktemp -d --tmpdir=$PODMAN_TMPDIR quadlet.XXXXXX) # 673| run_quadlet "$quadlet_network_file" "$quadlet_tmpdir" # 674| Error: SHELLCHECK_WARNING (CWE-571): [#def157] /usr/share/podman/test/system/252-quadlet.bats:701:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 699| # 700| # Create the Quadlet file # 701|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).kube # 702| cat > $quadlet_file <<EOF # 703| [Kube] Error: SHELLCHECK_WARNING (CWE-571): [#def158] /usr/share/podman/test/system/252-quadlet.bats:746:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 744| mountpoint="$output" # 745| # 746|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 747| cat > $quadlet_file <<EOF # 748| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def159] /usr/share/podman/test/system/252-quadlet.bats:767:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 765| @test "quadlet - selinux disable" { # 766| skip_if_no_selinux # 767|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 768| cat > $quadlet_file <<EOF # 769| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def160] /usr/share/podman/test/system/252-quadlet.bats:790:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 788| skip_if_no_selinux # 789| NAME=name$(safename) # 790|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 791| cat > $quadlet_file <<EOF # 792| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def161] /usr/share/podman/test/system/252-quadlet.bats:819:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 817| create_secret # 818| # 819|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 820| cat > $quadlet_file <<EOF # 821| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def162] /usr/share/podman/test/system/252-quadlet.bats:845:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 843| create_secret # 844| # 845|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 846| cat > $quadlet_file <<EOF # 847| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def163] /usr/share/podman/test/system/252-quadlet.bats:874:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 872| # seem to be any systemctly way to find this. # 873| percent_t_file="${PODMAN_TMPDIR}/foo" # 874|-> local service=get-percent-t.$(safename).service # 875| local unitfile=${UNIT_DIR}/$service # 876| cat >$unitfile <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def164] /usr/share/podman/test/system/252-quadlet.bats:900:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 898| echo $file_content > $tmp_path/$file_name # 899| # 900|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 901| cat > $quadlet_file <<EOF # 902| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def165] /usr/share/podman/test/system/252-quadlet.bats:921:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 919| # 920| @test "quadlet - tmpfs" { # 921|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 922| cat > $quadlet_file <<EOF # 923| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def166] /usr/share/podman/test/system/252-quadlet.bats:946:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 944| # 945| @test "quadlet - userns" { # 946|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).container # 947| cat > $quadlet_file <<EOF # 948| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def167] /usr/share/podman/test/system/252-quadlet.bats:972:13: warning[SC2155]: Declare and assign separately to avoid masking return values. # 970| " # 971| while read exit_code_prop cmd exit_code service_state; do # 972|-> local basename=propagate-${exit_code_prop}-${cmd}_$(safename) # 973| local quadlet_file=$PODMAN_TMPDIR/$basename.kube # 974| local yaml_file=$PODMAN_TMPDIR/$basename.yaml Error: SHELLCHECK_WARNING: [#def168] /usr/share/podman/test/system/252-quadlet.bats:1011:30: warning[SC2076]: Remove quotes from right-hand side of =~ to match as a regex rather than literally. # 1009| for tries in $(seq 1 5); do # 1010| run journalctl "--since=$STARTED_TIME" --unit="$QUADLET_SERVICE_NAME" # 1011|-> if [[ "$output" =~ "Started.*\.service" ]]; then # 1012| break # 1013| fi Error: SHELLCHECK_WARNING (CWE-571): [#def169] /usr/share/podman/test/system/252-quadlet.bats:1086:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1084| # 1085| # Create the Quadlet file # 1086|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(safename).kube # 1087| cat > $quadlet_file <<EOF # 1088| [Kube] Error: SHELLCHECK_WARNING (CWE-571): [#def170] /usr/share/podman/test/system/252-quadlet.bats:1114:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1112| # 1113| local registry=localhost:${PODMAN_LOGIN_REGISTRY_PORT} # 1114|-> local image_for_test=$registry/i-$(safename):$(random_string) # 1115| local authfile=$PODMAN_TMPDIR/authfile.json # 1116| Error: SHELLCHECK_WARNING (CWE-571): [#def171] /usr/share/podman/test/system/252-quadlet.bats:1117:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1115| local authfile=$PODMAN_TMPDIR/authfile.json # 1116| # 1117|-> local quadlet_image_unit=image_test_$(safename).image # 1118| local quadlet_image_file=$PODMAN_TMPDIR/$quadlet_image_unit # 1119| cat > $quadlet_image_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def172] /usr/share/podman/test/system/252-quadlet.bats:1126:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1124| EOF # 1125| # 1126|-> local quadlet_volume_unit=image_test_$(safename).volume # 1127| local quadlet_volume_file=$PODMAN_TMPDIR/$quadlet_volume_unit # 1128| local volume_name=systemd-$(basename $quadlet_volume_file .volume) Error: SHELLCHECK_WARNING (CWE-571): [#def173] /usr/share/podman/test/system/252-quadlet.bats:1135:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1133| EOF # 1134| # 1135|-> local quadlet_container_unit=image_test_$(safename).container # 1136| local quadlet_container_file=$PODMAN_TMPDIR/$quadlet_container_unit # 1137| cat > $quadlet_container_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def174] /usr/share/podman/test/system/252-quadlet.bats:1241:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1239| @test "quadlet - kube oneshot" { # 1240| local quadlet_tmpdir=$PODMAN_TMPDIR/quadlets # 1241|-> local test_random_string=r_$(safename) # 1242| # 1243| local quadlet_kube_volume_name=test-volume_$test_random_string Error: SHELLCHECK_WARNING (CWE-571): [#def175] /usr/share/podman/test/system/252-quadlet.bats:1269:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1267| EOF # 1268| # 1269|-> local pod_name="p-$(safename)" # 1270| local container_name="c-$(safename)" # 1271| local quadlet_kube_pod_yaml_file=$PODMAN_TMPDIR/pod_$test_random_string.yaml Error: SHELLCHECK_WARNING (CWE-571): [#def176] /usr/share/podman/test/system/252-quadlet.bats:1270:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1268| # 1269| local pod_name="p-$(safename)" # 1270|-> local container_name="c-$(safename)" # 1271| local quadlet_kube_pod_yaml_file=$PODMAN_TMPDIR/pod_$test_random_string.yaml # 1272| cat > $quadlet_kube_pod_yaml_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def177] /usr/share/podman/test/system/252-quadlet.bats:1349:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1347| # 1348| local quadlet_kube_volume_name=test-volume_$test_random_string # 1349|-> local pod_name="p-$(safename)" # 1350| local container_name="c-$(safename)" # 1351| local quadlet_kube_pod_yaml_file=$PODMAN_TMPDIR/pod_$test_random_string.yaml Error: SHELLCHECK_WARNING (CWE-571): [#def178] /usr/share/podman/test/system/252-quadlet.bats:1350:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1348| local quadlet_kube_volume_name=test-volume_$test_random_string # 1349| local pod_name="p-$(safename)" # 1350|-> local container_name="c-$(safename)" # 1351| local quadlet_kube_pod_yaml_file=$PODMAN_TMPDIR/pod_$test_random_string.yaml # 1352| cat > $quadlet_kube_pod_yaml_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def179] /usr/share/podman/test/system/252-quadlet.bats:1426:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1424| local quadlet_tmpdir=$PODMAN_TMPDIR/quadlets # 1425| local archive_file=$PODMAN_TMPDIR/archive-file.tar # 1426|-> local image_for_test=localhost/i-$(safename):$(random_string) # 1427| # 1428| local quadlet_image_unit=image_test_$(safename).image Error: SHELLCHECK_WARNING (CWE-571): [#def180] /usr/share/podman/test/system/252-quadlet.bats:1428:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1426| local image_for_test=localhost/i-$(safename):$(random_string) # 1427| # 1428|-> local quadlet_image_unit=image_test_$(safename).image # 1429| local quadlet_image_file=$PODMAN_TMPDIR/$quadlet_image_unit # 1430| cat > $quadlet_image_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def181] /usr/share/podman/test/system/252-quadlet.bats:1436:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1434| EOF # 1435| # 1436|-> local quadlet_volume_unit=image_test_$(safename).volume # 1437| local quadlet_volume_file=$PODMAN_TMPDIR/$quadlet_volume_unit # 1438| local volume_name=systemd-$(basename $quadlet_volume_file .volume) Error: SHELLCHECK_WARNING (CWE-571): [#def182] /usr/share/podman/test/system/252-quadlet.bats:1445:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1443| EOF # 1444| # 1445|-> local quadlet_container_unit=image_test_$(safename).container # 1446| local quadlet_container_file=$PODMAN_TMPDIR/$quadlet_container_unit # 1447| cat > $quadlet_container_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def183] /usr/share/podman/test/system/252-quadlet.bats:1518:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1516| local quadlet_tmpdir=$PODMAN_TMPDIR/quadlets # 1517| # 1518|-> local test_pod_name=pod_test_$(safename) # 1519| local quadlet_pod_unit=$test_pod_name.pod # 1520| local quadlet_pod_file=$PODMAN_TMPDIR/$quadlet_pod_unit Error: SHELLCHECK_WARNING (CWE-571): [#def184] /usr/share/podman/test/system/252-quadlet.bats:1526:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1524| EOF # 1525| # 1526|-> local quadlet_container_unit=pod_test_$(safename).container # 1527| local quadlet_container_file=$PODMAN_TMPDIR/$quadlet_container_unit # 1528| cat > $quadlet_container_file <<EOF Error: SHELLCHECK_WARNING (CWE-563): [#def185] /usr/share/podman/test/system/252-quadlet.bats:1567:5: warning[SC2034]: tries appears unused. Verify use (or export if used externally). # 1565| # 1566| # It might take a few seconds to go inactive, esp. under heavy load # 1567|-> for tries in $(seq 1 5); do # 1568| run systemctl show --property=ActiveState "$container_service" # 1569| if [[ "$output" = "ActiveState=inactive" ]]; then Error: SHELLCHECK_WARNING (CWE-571): [#def186] /usr/share/podman/test/system/252-quadlet.bats:1590:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1588| # FIXME: how to make this parallel-safe? Can we? # 1589| local untagged_image=quay.io/libpod/busybox # 1590|-> local built_image="built-$(safename)" # 1591| local yaml_dir=$quadlet_tmpdir/$built_image # 1592| local build_dir=$yaml_dir/$built_image Error: SHELLCHECK_WARNING (CWE-571): [#def187] /usr/share/podman/test/system/252-quadlet.bats:1625:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1623| # 1624| # Create the Quadlet file # 1625|-> local quadlet_file=$quadlet_tmpdir/build_$(safename).kube # 1626| cat > $quadlet_file <<EOF # 1627| [Kube] Error: SHELLCHECK_WARNING (CWE-571): [#def188] /usr/share/podman/test/system/252-quadlet.bats:1652:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1650| local quadlet_tmpdir="${PODMAN_TMPDIR}/dropins" # 1651| # 1652|-> local quadlet_file="truncated-$(safename).container" # 1653| # 1654| local -A dropin_dirs=( Error: SHELLCHECK_WARNING (CWE-563): [#def189] /usr/share/podman/test/system/260-sdnotify.bats:58:5: warning[SC2034]: try appears unused. Verify use (or export if used externally). # 56| # Wait for socat to create the socket file. This _should_ be # 57| # instantaneous, but can take a few seconds under high load # 58|-> for try in $(seq 1 10); do # 59| if [[ -e "$NOTIFY_SOCKET" ]]; then # 60| return Error: SHELLCHECK_WARNING (CWE-571): [#def190] /usr/share/podman/test/system/260-sdnotify.bats:458:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 456| local cmd2=$3 # 457| local sdnotify_policy=$4 # 458|-> local podname=p-$(safename) # 459| echo " # 460| apiVersion: v1 Error: SHELLCHECK_WARNING (CWE-571): [#def191] /usr/share/podman/test/system/260-sdnotify.bats:553:12: warning[SC2155]: Declare and assign separately to avoid masking return values. # 551| start_registry # 552| # 553|-> export NOTIFY_SOCKET=$PODMAN_TMPDIR/notify-$(safename).sock # 554| _start_socat # 555| Error: SHELLCHECK_WARNING (CWE-571): [#def192] /usr/share/podman/test/system/410-selinux.bats:201:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 199| # 200| # unique pod name helps when tracking down failure in journal # 201|-> local podname=p-$(safename) # 202| # 203| # We don't need a fullblown pause container; avoid pulling the k8s one Error: SHELLCHECK_WARNING (CWE-571): [#def193] /usr/share/podman/test/system/410-selinux.bats:229:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 227| # 228| # unique pod name helps when tracking down failure in journal # 229|-> local podname=p-$(safename) # 230| # 231| # We don't need a fullblown pause container; avoid pulling the k8s one Error: SHELLCHECK_WARNING (CWE-571): [#def194] /usr/share/podman/test/system/500-networking.bats:24:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 22| # 23| # check deterministic list order # 24|-> local net1=net-a-$(safename) # 25| local net2=net-b-$(safename) # 26| local net3=net-c-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def195] /usr/share/podman/test/system/500-networking.bats:25:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 23| # check deterministic list order # 24| local net1=net-a-$(safename) # 25|-> local net2=net-b-$(safename) # 26| local net3=net-c-$(safename) # 27| run_podman network create $net1 Error: SHELLCHECK_WARNING (CWE-571): [#def196] /usr/share/podman/test/system/500-networking.bats:26:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 24| local net1=net-a-$(safename) # 25| local net2=net-b-$(safename) # 26|-> local net3=net-c-$(safename) # 27| run_podman network create $net1 # 28| run_podman network create $net2 Error: SHELLCHECK_WARNING (CWE-571): [#def197] /usr/share/podman/test/system/500-networking.bats:166:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 164| # bats test_tags=ci:parallel # 165| @test "podman pod manages /etc/hosts correctly" { # 166|-> local pod_name=pod-$(safename) # 167| local infra_name=infra-$(safename) # 168| local con1_name=con1-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def198] /usr/share/podman/test/system/500-networking.bats:167:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 165| @test "podman pod manages /etc/hosts correctly" { # 166| local pod_name=pod-$(safename) # 167|-> local infra_name=infra-$(safename) # 168| local con1_name=con1-$(safename) # 169| local con2_name=con2-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def199] /usr/share/podman/test/system/500-networking.bats:168:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 166| local pod_name=pod-$(safename) # 167| local infra_name=infra-$(safename) # 168|-> local con1_name=con1-$(safename) # 169| local con2_name=con2-$(safename) # 170| run_podman pod create --name $pod_name --infra-name $infra_name Error: SHELLCHECK_WARNING (CWE-571): [#def200] /usr/share/podman/test/system/500-networking.bats:169:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 167| local infra_name=infra-$(safename) # 168| local con1_name=con1-$(safename) # 169|-> local con2_name=con2-$(safename) # 170| run_podman pod create --name $pod_name --infra-name $infra_name # 171| pid="$output" Error: SHELLCHECK_WARNING (CWE-571): [#def201] /usr/share/podman/test/system/500-networking.bats:206:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 204| CIDR="$(random_rfc1918_subnet)" # 205| IP=$(hostname -I | cut -f 1 -d " ") # 206|-> local conname=con-$(safename) # 207| run_podman run --rm --network slirp4netns:cidr="${CIDR}.0/24" \ # 208| --name $conname --hostname $conname $IMAGE cat /etc/hosts Error: SHELLCHECK_WARNING (CWE-571): [#def202] /usr/share/podman/test/system/500-networking.bats:256:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 254| myport=$(random_free_port) # 255| # 256|-> local mynetname=testnet-$(safename) # 257| local mysubnet=$(random_rfc1918_subnet) # 258| Error: SHELLCHECK_WARNING (CWE-571): [#def203] /usr/share/podman/test/system/500-networking.bats:270:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 268| "sdfsdf" # 269| # 270|-> local cname="c-$(safename)" # 271| run_podman run -d --network $mynetname --name $cname -p 127.0.0.1:$myport:$myport \ # 272| $IMAGE nc -l -n -v -p $myport Error: SHELLCHECK_WARNING (CWE-571): [#def204] /usr/share/podman/test/system/500-networking.bats:329:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 327| # 328| # Bind-mount this file with a different name to a container running httpd # 329|-> local cname=c-$(safename) # 330| run_podman run -d --name $cname -p "$HOST_PORT:80" \ # 331| --network $netname \ Error: SHELLCHECK_WARNING (CWE-571): [#def205] /usr/share/podman/test/system/500-networking.bats:429:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 427| is_rootless || skip "only meaningful for rootless" # 428| # 429|-> local mynetname=testnet-$(safename) # 430| run_podman --noout network create $mynetname # 431| is "$output" "" "output should be empty" Error: SHELLCHECK_WARNING (CWE-571): [#def206] /usr/share/podman/test/system/500-networking.bats:471:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 469| # ipv4 cni # 470| local mysubnet=$(random_rfc1918_subnet) # 471|-> local netname=testnet1-$(safename) # 472| # 473| run_podman network create --subnet $mysubnet.0/24 $netname Error: SHELLCHECK_WARNING (CWE-571): [#def207] /usr/share/podman/test/system/500-networking.bats:505:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 503| echo $random_1 > $INDEX1 # 504| # 505|-> local netname=testnet1-$(safename) # 506| run_podman network create $netname # 507| is "$output" "$netname" "output of 'network create'" Error: SHELLCHECK_WARNING (CWE-571): [#def208] /usr/share/podman/test/system/500-networking.bats:509:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 507| is "$output" "$netname" "output of 'network create'" # 508| # 509|-> local netname2=testnet2-$(safename) # 510| run_podman network create $netname2 # 511| is "$output" "$netname2" "output of 'network create'" Error: SHELLCHECK_WARNING (CWE-571): [#def209] /usr/share/podman/test/system/500-networking.bats:518:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 516| background_cid=$output # 517| # 518|-> local hostname=host-$(safename) # 519| # Run a httpd container on first network with exposed port # 520| run_podman run -d -p "$HOST_PORT:80" \ Error: SHELLCHECK_WARNING (CWE-571): [#def210] /usr/share/podman/test/system/500-networking.bats:621:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 619| echo $random_1 > $INDEX1 # 620| # 621|-> local netname=testnet-$(safename) # 622| run_podman network create $netname # 623| is "$output" "$netname" "output of 'network create'" Error: SHELLCHECK_WARNING (CWE-571): [#def211] /usr/share/podman/test/system/500-networking.bats:631:15: warning[SC2155]: Declare and assign separately to avoid masking return values. # 629| for network in "${networks[@]}"; do # 630| # Start container with the restart always policy # 631|-> local cname=c-$(safename) # 632| run_podman run -d --name $cname -p "$HOST_PORT:80" \ # 633| --restart always \ Error: SHELLCHECK_WARNING (CWE-571): [#def212] /usr/share/podman/test/system/500-networking.bats:726:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 724| # 725| # create network with dns # 726|-> local netname=testnet-$(safename) # 727| local subnet=$(random_rfc1918_subnet) # 728| run_podman network create --subnet "$subnet.0/24" $netname Error: SHELLCHECK_WARNING (CWE-563): [#def213] /usr/share/podman/test/system/500-networking.bats:973:11: warning[SC2034]: count appears unused. Verify use (or export if used externally). # 971| function wait_for_restart_count() { # 972| local cname="$1" # 973|-> local count="$2" # 974| local tname="$3" # 975| Error: SHELLCHECK_WARNING (CWE-571): [#def214] /usr/share/podman/test/system/500-networking.bats:997:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 995| skip_if_cgroupsv1 "run --uidmap fails on cgroups v1 (issue 15025, wontfix)" # 996| # 997|-> local net1=net-a-$(safename) # 998| # use /29 subnet to limit available ip space, a 29 gives 5 usable addresses (6 - 1 for the gw) # 999| local subnet="$(random_rfc1918_subnet).0/29" Error: SHELLCHECK_WARNING (CWE-571): [#def215] /usr/share/podman/test/system/500-networking.bats:1001:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 999| local subnet="$(random_rfc1918_subnet).0/29" # 1000| run_podman network create --subnet $subnet $net1 # 1001|-> local cname=con1-$(safename) # 1002| local cname2= # 1003| local cname3= Error: SHELLCHECK_WARNING (CWE-571): [#def216] /usr/share/podman/test/system/500-networking.bats:1059:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1057| # FIXME: random_rfc1918_subnet is not parallel-safe # 1058| @test "podman network inspect running containers" { # 1059|-> local cname1=c1-$(safename) # 1060| local cname2=c2-$(safename) # 1061| local cname3=c3-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def217] /usr/share/podman/test/system/500-networking.bats:1060:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1058| @test "podman network inspect running containers" { # 1059| local cname1=c1-$(safename) # 1060|-> local cname2=c2-$(safename) # 1061| local cname3=c3-$(safename) # 1062| Error: SHELLCHECK_WARNING (CWE-571): [#def218] /usr/share/podman/test/system/500-networking.bats:1061:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1059| local cname1=c1-$(safename) # 1060| local cname2=c2-$(safename) # 1061|-> local cname3=c3-$(safename) # 1062| # 1063| local netname=net-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def219] /usr/share/podman/test/system/500-networking.bats:1063:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1061| local cname3=c3-$(safename) # 1062| # 1063|-> local netname=net-$(safename) # 1064| local subnet=$(random_rfc1918_subnet) # 1065| Error: SHELLCHECK_WARNING (CWE-571): [#def220] /usr/share/podman/test/system/505-networking-pasta.bats:162:15: warning[SC2155]: Declare and assign separately to avoid masking return values. # 160| local xseq="$(echo ${xport} | tr '-' ' ')" # 161| else # 162|-> local port=$(random_free_port "" ${addr} ${proto}) # 163| local xport="$((port + delta))" # 164| local seq="${port} ${port}" Error: SHELLCHECK_WARNING (CWE-571): [#def221] /usr/share/podman/test/system/505-networking-pasta.bats:217:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 215| # 216| # Start server # 217|-> local cname="c-socat-$(safename)" # 218| run_podman run -d --name="$cname" --net=pasta"${pasta_spec}" -p "${podman_spec}" "${IMAGE}" \ # 219| sh -c 'for port in $(seq '"${xseq}"'); do '\ Error: SHELLCHECK_WARNING: [#def222] /usr/share/podman/test/system/505-networking-pasta.bats:228:32: warning[SC2076]: Remove quotes from right-hand side of =~ to match as a regex rather than literally. # 226| while [[ $retries -gt 0 ]]; do # 227| run_podman exec $cname ss -Hln -$ip_ver --$proto sport = "$cport" # 228|-> if [[ "$output" =~ "$cport" ]]; then # 229| break # 230| fi Error: SHELLCHECK_WARNING (CWE-571): [#def223] /usr/share/podman/test/system/505-networking-pasta.bats:783:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 781| # 782| # Allow time for process to vanish, in case there's high load # 783|-> local pid=$(< $pidfile) # 784| local timeout=5 # 785| while [[ $timeout -gt 0 ]]; do Error: SHELLCHECK_WARNING (CWE-571): [#def224] /usr/share/podman/test/system/520-checkpoint.bats:145:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 143| volname=v-$(safename) # 144| run_podman $p_opts volume create $volname # 145|-> local cname=c-$(safename) # 146| local host_port=$(random_free_port) # 147| local server=http://127.0.0.1:$host_port Error: SHELLCHECK_WARNING (CWE-571): [#def225] /usr/share/podman/test/system/520-checkpoint.bats:238:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 236| # Refer to https://github.com/containers/podman/issues/16666#issuecomment-1337860545 # 237| # for the correct behavior, this should cover all cases listed there. # 238|-> local netname="net-$(safename)" # 239| local subnet="$(random_rfc1918_subnet)" # 240| run_podman network create --subnet "$subnet.0/24" $netname Error: SHELLCHECK_WARNING: [#def226] /usr/share/podman/test/system/700-play.bats:920:32: warning[SC2076]: Remove quotes from right-hand side of =~ to match as a regex rather than literally. # 918| run_podman inspect $ctrName --format "$i-{{.State.Health.Status}}" # 919| full_log+=" $output" # 920|-> if [[ "$output" =~ "-$want" ]]; then # 921| break # 922| fi Error: SHELLCHECK_WARNING (CWE-569): [#def227] /usr/share/podman/test/system/700-play.bats:1245:37: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 1243| run_podman create --pod $podname $IMAGE true # 1244| # 1245|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1246| infraID="$output" # 1247| Error: SHELLCHECK_WARNING (CWE-569): [#def228] /usr/share/podman/test/system/700-play.bats:1245:38: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 1243| run_podman create --pod $podname $IMAGE true # 1244| # 1245|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1246| infraID="$output" # 1247| Error: SHELLCHECK_WARNING (CWE-569): [#def229] /usr/share/podman/test/system/700-play.bats:1245:56: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 1243| run_podman create --pod $podname $IMAGE true # 1244| # 1245|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1246| infraID="$output" # 1247| Error: SHELLCHECK_WARNING (CWE-569): [#def230] /usr/share/podman/test/system/700-play.bats:1245:57: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 1243| run_podman create --pod $podname $IMAGE true # 1244| # 1245|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1246| infraID="$output" # 1247| Error: SHELLCHECK_WARNING (CWE-569): [#def231] /usr/share/podman/test/system/700-play.bats:1258:37: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 1256| run_podman kube play --replace $YAML # 1257| # 1258|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1259| infraID="$output" # 1260| Error: SHELLCHECK_WARNING (CWE-569): [#def232] /usr/share/podman/test/system/700-play.bats:1258:38: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 1256| run_podman kube play --replace $YAML # 1257| # 1258|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1259| infraID="$output" # 1260| Error: SHELLCHECK_WARNING (CWE-569): [#def233] /usr/share/podman/test/system/700-play.bats:1258:56: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 1256| run_podman kube play --replace $YAML # 1257| # 1258|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1259| infraID="$output" # 1260| Error: SHELLCHECK_WARNING (CWE-569): [#def234] /usr/share/podman/test/system/700-play.bats:1258:57: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 1256| run_podman kube play --replace $YAML # 1257| # 1258|-> run_podman pod inspect --format {{.InfraContainerID}} $podname # 1259| infraID="$output" # 1260| Error: SHELLCHECK_WARNING (CWE-571): [#def235] /usr/share/podman/test/system/710-kube.bats:98:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 96| # 97| @test "podman kube generate - pod" { # 98|-> local pname=p-$(safename) # 99| local cname1=c1-$(safename) # 100| local cname2=c2-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def236] /usr/share/podman/test/system/710-kube.bats:99:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 97| @test "podman kube generate - pod" { # 98| local pname=p-$(safename) # 99|-> local cname1=c1-$(safename) # 100| local cname2=c2-$(safename) # 101| Error: SHELLCHECK_WARNING (CWE-571): [#def237] /usr/share/podman/test/system/710-kube.bats:100:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 98| local pname=p-$(safename) # 99| local cname1=c1-$(safename) # 100|-> local cname2=c2-$(safename) # 101| # 102| port=$(random_free_port) Error: SHELLCHECK_WARNING (CWE-571): [#def238] /usr/share/podman/test/system/710-kube.bats:159:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 157| @test "podman kube generate - deployment" { # 158| skip_if_remote "containersconf needs to be set on server side" # 159|-> local pname=p-$(safename) # 160| local cname1=c1-$(safename) # 161| local cname2=c2-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def239] /usr/share/podman/test/system/710-kube.bats:160:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 158| skip_if_remote "containersconf needs to be set on server side" # 159| local pname=p-$(safename) # 160|-> local cname1=c1-$(safename) # 161| local cname2=c2-$(safename) # 162| Error: SHELLCHECK_WARNING (CWE-571): [#def240] /usr/share/podman/test/system/710-kube.bats:161:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 159| local pname=p-$(safename) # 160| local cname1=c1-$(safename) # 161|-> local cname2=c2-$(safename) # 162| # 163| run_podman pod create --name $pname Error: SHELLCHECK_WARNING (CWE-571): [#def241] /usr/share/podman/test/system/710-kube.bats:199:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 197| @test "podman kube generate - job" { # 198| skip_if_remote "containersconf needs to be set on server side" # 199|-> local pname=p-$(safename) # 200| local cname1=c1-$(safename) # 201| local cname2=c2-$(safename) Error: SHELLCHECK_WARNING (CWE-571): [#def242] /usr/share/podman/test/system/710-kube.bats:200:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 198| skip_if_remote "containersconf needs to be set on server side" # 199| local pname=p-$(safename) # 200|-> local cname1=c1-$(safename) # 201| local cname2=c2-$(safename) # 202| Error: SHELLCHECK_WARNING (CWE-571): [#def243] /usr/share/podman/test/system/710-kube.bats:201:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 199| local pname=p-$(safename) # 200| local cname1=c1-$(safename) # 201|-> local cname2=c2-$(safename) # 202| # 203| run_podman pod create --name $pname Error: SHELLCHECK_WARNING (CWE-571): [#def244] /usr/share/podman/test/system/helpers.bash:51:12: warning[SC2155]: Declare and assign separately to avoid masking return values. # 49| # tools. # 50| if [[ -z "$XDG_RUNTIME_DIR" ]] && [[ "$(id -u)" -ne 0 ]]; then # 51|-> export XDG_RUNTIME_DIR=/run/user/$(id -u) # 52| fi # 53| Error: SHELLCHECK_WARNING: [#def245] /usr/share/podman/test/system/helpers.network.bash:299:5: warning[SC2215]: This flag is used as a command name. Bad line break or missing [ .. ]? # 297| # 298| local lockfile=$PORT_LOCK_DIR/$port # 299|-> -e $lockfile || die "Cannot unreserve non-reserved port $port" # 300| assert "$(< $lockfile)" = "$BATS_SUITE_TEST_NUMBER" \ # 301| "Port $port is not reserved by this test" Error: SHELLCHECK_WARNING (CWE-563): [#def246] /usr/share/podman/test/system/helpers.registry.bash:85:5: warning[SC2034]: cid appears unused. Verify use (or export if used externally). # 83| -e REGISTRY_HTTP_TLS_KEY="/auth/domain.key" \ # 84| $REGISTRY_IMAGE # 85|-> cid="$output" # 86| # 87| wait_for_port 127.0.0.1 ${PODMAN_LOGIN_REGISTRY_PORT} Error: SHELLCHECK_WARNING (CWE-398): [#def247] /usr/share/podman/test/system/helpers.registry.bash:115:20: warning[SC2115]: Use "${var:?}" to ensure this never expands to /* . # 113| # 114| if [[ $(id -u) -eq 0 ]]; then # 115|-> rm -rf ${PODMAN_LOGIN_WORKDIR}/* # 116| else # 117| # rootless image data is owned by a subuid Error: SHELLCHECK_WARNING (CWE-563): [#def248] /usr/share/podman/test/system/helpers.t:26:1: warning[SC2034]: PORT_LOCK_DIR appears unused. Verify use (or export if used externally). # 24| # 25| # Used by random_free_port. # 26|-> PORT_LOCK_DIR=$PODMAN_TMPDIR/reserved-ports # 27| # 28| ############################################################################### Error: SHELLCHECK_WARNING (CWE-571): [#def249] /usr/share/podman/test/system/setup_suite.bash:28:12: warning[SC2155]: Declare and assign separately to avoid masking return values. # 26| # FIXME: racy! It could be many minutes between now and when we start it. # 27| # To mitigate, we use a range not used anywhere else in system tests. # 28|-> export PODMAN_LOGIN_REGISTRY_PORT=$(random_free_port 27000-27999) # 29| # 30| # The above does not handle errors. Do a final confirmation.
| analyzer-version-clippy | 1.82.0 |
| analyzer-version-cppcheck | 2.16.0 |
| analyzer-version-gcc | 14.2.1 |
| analyzer-version-gcc-analyzer | 15.0.0 |
| analyzer-version-shellcheck | 0.10.0 |
| analyzer-version-unicontrol | 0.0.2 |
| diffbase-analyzer-version-clippy | 1.82.0 |
| diffbase-analyzer-version-cppcheck | 2.16.0 |
| diffbase-analyzer-version-gcc | 14.2.1 |
| diffbase-analyzer-version-gcc-analyzer | 15.0.0 |
| diffbase-analyzer-version-shellcheck | 0.10.0 |
| diffbase-analyzer-version-unicontrol | 0.0.2 |
| diffbase-enabled-plugins | clippy, cppcheck, gcc, shellcheck, unicontrol |
| diffbase-exit-code | 0 |
| diffbase-host | ip-172-16-1-29.us-west-2.compute.internal |
| diffbase-mock-config | fedora-rawhide-gcc-latest-x86_64 |
| diffbase-project-name | podman-5.2.5-1.fc41 |
| diffbase-store-results-to | /tmp/tmpx7lruobi/podman-5.2.5-1.fc41.tar.xz |
| diffbase-time-created | 2024-11-13 02:27:08 |
| diffbase-time-finished | 2024-11-13 02:38:43 |
| diffbase-tool | csmock |
| diffbase-tool-args | '/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpx7lruobi/podman-5.2.5-1.fc41.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpx7lruobi/podman-5.2.5-1.fc41.src.rpm' |
| diffbase-tool-version | csmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9 |
| enabled-plugins | clippy, cppcheck, gcc, shellcheck, unicontrol |
| exit-code | 0 |
| host | ip-172-16-1-29.us-west-2.compute.internal |
| mock-config | fedora-rawhide-gcc-latest-x86_64 |
| project-name | podman-5.3.0~rc3-1.fc42 |
| store-results-to | /tmp/tmpmfh71xmu/podman-5.3.0~rc3-1.fc42.tar.xz |
| time-created | 2024-11-13 02:39:08 |
| time-finished | 2024-11-13 02:50:18 |
| title | Newly introduced findings |
| tool | csmock |
| tool-args | '/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpmfh71xmu/podman-5.3.0~rc3-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpmfh71xmu/podman-5.3.0~rc3-1.fc42.src.rpm' |
| tool-version | csmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9 |