Error: SHELLCHECK_WARNING (CWE-156): [#def1] /usr/share/podman/test/system/012-manifest.bats:173:16: warning[SC2046]: Quote this to prevent word splitting. # 171| index="$output" # 172| if [[ -n "$listFlags" ]] ; then # 173|-> assert $(jq -r '.annotations["global"]' <<<"$index") == local # 174| fi # 175| if [[ -n "$platformFlags" ]] ; then Error: SHELLCHECK_WARNING (CWE-156): [#def2] /usr/share/podman/test/system/012-manifest.bats:176:16: warning[SC2046]: Quote this to prevent word splitting. # 174| fi # 175| if [[ -n "$platformFlags" ]] ; then # 176|-> assert $(jq -r '.manifests[1].platform.os' <<<"$index") == linux # 177| assert $(jq -r '.manifests[1].platform.architecture' <<<"$index") == amd64 # 178| fi Error: SHELLCHECK_WARNING (CWE-156): [#def3] /usr/share/podman/test/system/012-manifest.bats:177:16: warning[SC2046]: Quote this to prevent word splitting. # 175| if [[ -n "$platformFlags" ]] ; then # 176| assert $(jq -r '.manifests[1].platform.os' <<<"$index") == linux # 177|-> assert $(jq -r '.manifests[1].platform.architecture' <<<"$index") == amd64 # 178| fi # 179| if [[ -n "$typeFlag" ]] ; then Error: SHELLCHECK_WARNING (CWE-156): [#def4] /usr/share/podman/test/system/012-manifest.bats:238:20: warning[SC2046]: Quote this to prevent word splitting. # 236| fi # 237| if test -n "$titleFlag" ; then # 238|-> assert $(jq -r '.layers[0].annotations["org.opencontainers.image.title"]' <<<"$artifact") == null # 239| else # 240| assert $(jq -r '.layers[0].annotations["org.opencontainers.image.title"]' <<<"$artifact") == $filetitle Error: SHELLCHECK_WARNING (CWE-156): [#def5] /usr/share/podman/test/system/012-manifest.bats:240:20: warning[SC2046]: Quote this to prevent word splitting. # 238| assert $(jq -r '.layers[0].annotations["org.opencontainers.image.title"]' <<<"$artifact") == null # 239| else # 240|-> assert $(jq -r '.layers[0].annotations["org.opencontainers.image.title"]' <<<"$artifact") == $filetitle # 241| fi # 242| done Error: SHELLCHECK_WARNING (CWE-156): [#def6] /usr/share/podman/test/system/030-run.bats:1475:20: warning[SC2046]: Quote this to prevent word splitting. # 1473| # 1474| run_podman rm $cid # 1475|-> run_podman rmi $(pause_image) # 1476| } # 1477| Error: SHELLCHECK_WARNING (CWE-569): [#def7] /usr/share/podman/test/system/055-rm.bats:27:9: error[SC1035]: You are missing a required space after the !. # 25| is "$output" "-1" "wait --ignore will mark missing containers with -1" # 26| # 27|-> if !is_remote; then # 28| # remote does not support the --latest flag # 29| run_podman wait --ignore --latest Error: SHELLCHECK_WARNING (CWE-571): [#def8] /usr/share/podman/test/system/055-rm.bats:137:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 135| # 136| @test "podman container rm doesn't affect stopping containers" { # 137|-> local cname=c$(random_string 30) # 138| __run_healthcheck_container $cname # 139| local cid=$output Error: SHELLCHECK_WARNING (CWE-571): [#def9] /usr/share/podman/test/system/055-rm.bats:174:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 172| # 173| @test "podman container rm --force doesn't leave running processes" { # 174|-> local cname=c$(random_string 30) # 175| __run_healthcheck_container $cname # 176| local cid=$output Error: SHELLCHECK_WARNING (CWE-88): [#def10] /usr/share/podman/test/system/065-cp.bats:290:38: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 288| is "$output" "${randomcontent[$id]}" "$description (cp ctr:$src to $dest - CREATED)" # 289| done < <(parse_table "$tests") # 290|-> run_podman rm -t 0 -f srcrunning ${destcontainers[@]} # 291| # 292| # From CREATED container Error: SHELLCHECK_WARNING (CWE-88): [#def11] /usr/share/podman/test/system/065-cp.bats:317:38: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 315| is "$output" "${randomcontent[$id]}" "$description (cp ctr:$src to $dest)" # 316| done < <(parse_table "$tests") # 317|-> run_podman rm -t 0 -f srccreated ${destcontainers[@]} # 318| run_podman rmi -f $cpimage # 319| } Error: SHELLCHECK_WARNING (CWE-88): [#def12] /usr/share/podman/test/system/065-cp.bats:522:38: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 520| is "$(echo $output)" "${randomcontent[*]}" "$description - from RUNNING to CREATED/STARTED" # 521| done < <(parse_table "$tests") # 522|-> run_podman rm -t 0 -f srcrunning ${destcontainers[@]} # 523| # 524| # From CREATED container Error: SHELLCHECK_WARNING (CWE-88): [#def13] /usr/share/podman/test/system/065-cp.bats:550:38: error[SC2068]: Double quote array expansions to avoid re-splitting elements. # 548| done < <(parse_table "$tests") # 549| # 550|-> run_podman rm -t 0 -f srccreated ${destcontainers[@]} # 551| run_podman rmi -f $cpimage # 552| } Error: SHELLCHECK_WARNING (CWE-156): [#def14] /usr/share/podman/test/system/070-build.bats:661:20: warning[SC2046]: Quote this to prevent word splitting. # 659| run_podman pod create # 660| run_podman pod rm $output # 661|-> run_podman rmi $(pause_image) # 662| popd # 663| Error: SHELLCHECK_WARNING (CWE-571): [#def15] /usr/share/podman/test/system/090-events.bats:303:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 301| @test "events - labels included in container die" { # 302| skip_if_remote "remote does not support --events-backend" # 303|-> local cname=c$(random_string 15) # 304| local lname=l$(random_string 10) # 305| local lvalue="v$(random_string 10) $(random_string 5)" Error: SHELLCHECK_WARNING (CWE-571): [#def16] /usr/share/podman/test/system/090-events.bats:304:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 302| skip_if_remote "remote does not support --events-backend" # 303| local cname=c$(random_string 15) # 304|-> local lname=l$(random_string 10) # 305| local lvalue="v$(random_string 10) $(random_string 5)" # 306| Error: SHELLCHECK_WARNING (CWE-571): [#def17] /usr/share/podman/test/system/090-events.bats:305:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 303| local cname=c$(random_string 15) # 304| local lname=l$(random_string 10) # 305|-> local lvalue="v$(random_string 10) $(random_string 5)" # 306| # 307| run_podman 17 --events-backend=file run --rm \ Error: SHELLCHECK_WARNING (CWE-571): [#def18] /usr/share/podman/test/system/090-events.bats:336:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 334| EOF # 335| # 336|-> local cname=c$(random_string 15) # 337| t0=$(date --iso-8601=seconds) # 338| Error: SHELLCHECK_WARNING (CWE-571): [#def19] /usr/share/podman/test/system/090-events.bats:379:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 377| # 378| @test "events - docker compat" { # 379|-> local cname=c$(random_string 15) # 380| t0=$(date --iso-8601=seconds) # 381| run_podman run --name=$cname --rm $IMAGE true Error: SHELLCHECK_WARNING (CWE-571): [#def20] /usr/share/podman/test/system/090-events.bats:391:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 389| # 390| @test "events - volume events" { # 391|-> local vname=v$(random_string 10) # 392| run_podman volume create $vname # 393| run_podman volume rm $vname Error: SHELLCHECK_WARNING (CWE-571): [#def21] /usr/share/podman/test/system/130-kill.bats:10:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 8| # bats test_tags=distro-integration # 9| @test "podman kill - test signal handling in containers" { # 10|-> local cname=c-$(random_string 10) # 11| local fifo=${PODMAN_TMPDIR}/podman-kill-fifo.$(random_string 10) # 12| mkfifo $fifo Error: SHELLCHECK_WARNING (CWE-569): [#def22] /usr/share/podman/test/system/150-login.bats:353:39: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 351| run_podman rmi $image1 # 352| # 353|-> run_podman images $IMAGE --format {{.ID}} # 354| local podman_image_id=$output # 355| Error: SHELLCHECK_WARNING (CWE-569): [#def23] /usr/share/podman/test/system/150-login.bats:353:40: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 351| run_podman rmi $image1 # 352| # 353|-> run_podman images $IMAGE --format {{.ID}} # 354| local podman_image_id=$output # 355| Error: SHELLCHECK_WARNING (CWE-569): [#def24] /usr/share/podman/test/system/150-login.bats:353:44: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 351| run_podman rmi $image1 # 352| # 353|-> run_podman images $IMAGE --format {{.ID}} # 354| local podman_image_id=$output # 355| Error: SHELLCHECK_WARNING (CWE-569): [#def25] /usr/share/podman/test/system/150-login.bats:353:45: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 351| run_podman rmi $image1 # 352| # 353|-> run_podman images $IMAGE --format {{.ID}} # 354| local podman_image_id=$output # 355| Error: SHELLCHECK_WARNING (CWE-156): [#def26] /usr/share/podman/test/system/170-run-userns.bats:54:23: warning[SC2046]: Quote this to prevent word splitting. # 52| # Remove the pod and the pause image # 53| run_podman pod rm $random_pod_name # 54|-> run_podman rmi -f $(pause_image) # 55| } # 56| Error: SHELLCHECK_WARNING (CWE-156): [#def27] /usr/share/podman/test/system/170-run-userns.bats:148:23: warning[SC2046]: Quote this to prevent word splitting. # 146| run_podman run --rm --pod $pid $IMAGE id -u # 147| is "${output}" "$user" "Container should run as the current user" # 148|-> run_podman rmi -f $(pause_image) # 149| } # 150| Error: SHELLCHECK_WARNING (CWE-571): [#def28] /usr/share/podman/test/system/195-run-namespaces.bats:21:19: warning[SC2155]: Declare and assign separately to avoid masking return values. # 19| for nstype in private host; do # 20| while read name option; do # 21|-> local cname="c_${name}_$(random_string)" # 22| # ipc is special, private does not allow joining from another container. # 23| # Instead we must use "shareable". Error: SHELLCHECK_WARNING (CWE-156): [#def29] /usr/share/podman/test/system/200-pod.bats:12:29: warning[SC2046]: Quote this to prevent word splitting. # 10| run_podman pod rm -f -t 0 -a # 11| run_podman rm -f -t 0 -a # 12|-> run_podman rmi --ignore $(pause_image) # 13| basic_teardown # 14| if [[ -n "$LOOPDEVICE" ]]; then Error: SHELLCHECK_WARNING (CWE-571): [#def30] /usr/share/podman/test/system/200-pod.bats:234:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 232| # existing 'pause' script in our testimage. We assign a bogus # 233| # entrypoint to confirm that --infra-command will override. # 234|-> local infra_image="infra_$(random_string 10 | tr A-Z a-z)" # 235| local infra_command="/pause_$(random_string 10)" # 236| local infra_name="infra_container_$(random_string 10 | tr A-Z a-z)" Error: SHELLCHECK_WARNING (CWE-571): [#def31] /usr/share/podman/test/system/200-pod.bats:235:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 233| # entrypoint to confirm that --infra-command will override. # 234| local infra_image="infra_$(random_string 10 | tr A-Z a-z)" # 235|-> local infra_command="/pause_$(random_string 10)" # 236| local infra_name="infra_container_$(random_string 10 | tr A-Z a-z)" # 237| run_podman build -t $infra_image - << EOF Error: SHELLCHECK_WARNING (CWE-571): [#def32] /usr/share/podman/test/system/200-pod.bats:236:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 234| local infra_image="infra_$(random_string 10 | tr A-Z a-z)" # 235| local infra_command="/pause_$(random_string 10)" # 236|-> local infra_name="infra_container_$(random_string 10 | tr A-Z a-z)" # 237| run_podman build -t $infra_image - << EOF # 238| FROM $IMAGE Error: SHELLCHECK_WARNING (CWE-571): [#def33] /usr/share/podman/test/system/200-pod.bats:355:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 353| # 354| @test "podman pod create should fail when infra-name is already in use" { # 355|-> local infra_name="infra_container_$(random_string 10 | tr A-Z a-z)" # 356| local infra_image="quay.io/libpod/k8s-pause:3.5" # 357| local pod_name="$(random_string 10 | tr A-Z a-z)" Error: SHELLCHECK_WARNING (CWE-571): [#def34] /usr/share/podman/test/system/200-pod.bats:357:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 355| local infra_name="infra_container_$(random_string 10 | tr A-Z a-z)" # 356| local infra_image="quay.io/libpod/k8s-pause:3.5" # 357|-> local pod_name="$(random_string 10 | tr A-Z a-z)" # 358| # 359| run_podman --noout pod create --name $pod_name --infra-name "$infra_name" --infra-image "$infra_image" Error: SHELLCHECK_WARNING (CWE-571): [#def35] /usr/share/podman/test/system/200-pod.bats:371:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 369| # 370| @test "podman pod create --share" { # 371|-> local pod_name="$(random_string 10 | tr A-Z a-z)" # 372| run_podman 125 pod create --share bogus --name $pod_name # 373| is "$output" ".*invalid kernel namespace to share: bogus. Options are: cgroup, ipc, net, pid, uts or none" \ Error: SHELLCHECK_WARNING (CWE-571): [#def36] /usr/share/podman/test/system/200-pod.bats:388:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 386| # 387| @test "podman pod create --pod new:$POD --hostname" { # 388|-> local pod_name="$(random_string 10 | tr A-Z a-z)" # 389| run_podman run --rm --pod "new:$pod_name" --hostname foobar $IMAGE hostname # 390| is "$output" "foobar" "--hostname should work when creating a new:pod" Error: SHELLCHECK_WARNING (CWE-571): [#def37] /usr/share/podman/test/system/200-pod.bats:397:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 395| # 396| @test "podman rm --force to remove infra container" { # 397|-> local pod_name="$(random_string 10 | tr A-Z a-z)" # 398| run_podman create --pod "new:$pod_name" $IMAGE # 399| container_ID="$output" Error: SHELLCHECK_WARNING (CWE-457): [#def38] /usr/share/podman/test/system/200-pod.bats:422:43: warning[SC2154]: infraID is referenced but not assigned (did you mean 'infra_ID'?). # 420| infra_ID="$output" # 421| # 422|-> run_podman container rm --force --all $infraID # 423| is "$output" ".*$infra_ID.*" # 424| is "$output" ".*$container_1_ID.*" Error: SHELLCHECK_WARNING (CWE-569): [#def39] /usr/share/podman/test/system/200-pod.bats:431:42: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 429| @test "podman pod create share net" { # 430| run_podman pod create --name test # 431|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 432| is "$output" "false" "Default network sharing should be false" # 433| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def40] /usr/share/podman/test/system/200-pod.bats:431:43: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 429| @test "podman pod create share net" { # 430| run_podman pod create --name test # 431|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 432| is "$output" "false" "Default network sharing should be false" # 433| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def41] /usr/share/podman/test/system/200-pod.bats:431:68: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 429| @test "podman pod create share net" { # 430| run_podman pod create --name test # 431|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 432| is "$output" "false" "Default network sharing should be false" # 433| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def42] /usr/share/podman/test/system/200-pod.bats:431:69: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 429| @test "podman pod create share net" { # 430| run_podman pod create --name test # 431|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 432| is "$output" "false" "Default network sharing should be false" # 433| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def43] /usr/share/podman/test/system/200-pod.bats:436:42: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 434| # 435| run_podman pod create --share ipc --network private test # 436|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 437| is "$output" "false" "Private network sharing with only ipc should be false" # 438| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def44] /usr/share/podman/test/system/200-pod.bats:436:43: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 434| # 435| run_podman pod create --share ipc --network private test # 436|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 437| is "$output" "false" "Private network sharing with only ipc should be false" # 438| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def45] /usr/share/podman/test/system/200-pod.bats:436:68: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 434| # 435| run_podman pod create --share ipc --network private test # 436|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 437| is "$output" "false" "Private network sharing with only ipc should be false" # 438| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def46] /usr/share/podman/test/system/200-pod.bats:436:69: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 434| # 435| run_podman pod create --share ipc --network private test # 436|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 437| is "$output" "false" "Private network sharing with only ipc should be false" # 438| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-571): [#def47] /usr/share/podman/test/system/200-pod.bats:440:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 438| run_podman pod rm test # 439| # 440|-> local name="$(random_string 10 | tr A-Z a-z)" # 441| run_podman pod create --name $name --share net --network private # 442| run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} Error: SHELLCHECK_WARNING (CWE-569): [#def48] /usr/share/podman/test/system/200-pod.bats:442:43: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 440| local name="$(random_string 10 | tr A-Z a-z)" # 441| run_podman pod create --name $name --share net --network private # 442|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 443| is "$output" "false" "Private network sharing with only net should be false" # 444| Error: SHELLCHECK_WARNING (CWE-569): [#def49] /usr/share/podman/test/system/200-pod.bats:442:44: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 440| local name="$(random_string 10 | tr A-Z a-z)" # 441| run_podman pod create --name $name --share net --network private # 442|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 443| is "$output" "false" "Private network sharing with only net should be false" # 444| Error: SHELLCHECK_WARNING (CWE-569): [#def50] /usr/share/podman/test/system/200-pod.bats:442:69: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 440| local name="$(random_string 10 | tr A-Z a-z)" # 441| run_podman pod create --name $name --share net --network private # 442|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 443| is "$output" "false" "Private network sharing with only net should be false" # 444| Error: SHELLCHECK_WARNING (CWE-569): [#def51] /usr/share/podman/test/system/200-pod.bats:442:70: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 440| local name="$(random_string 10 | tr A-Z a-z)" # 441| run_podman pod create --name $name --share net --network private # 442|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 443| is "$output" "false" "Private network sharing with only net should be false" # 444| Error: SHELLCHECK_WARNING (CWE-569): [#def52] /usr/share/podman/test/system/200-pod.bats:446:43: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 444| # 445| run_podman pod create --share net --network host --replace $name # 446|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 447| is "$output" "true" "Host network sharing with only net should be true" # 448| run_podman pod rm $name Error: SHELLCHECK_WARNING (CWE-569): [#def53] /usr/share/podman/test/system/200-pod.bats:446:44: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 444| # 445| run_podman pod create --share net --network host --replace $name # 446|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 447| is "$output" "true" "Host network sharing with only net should be true" # 448| run_podman pod rm $name Error: SHELLCHECK_WARNING (CWE-569): [#def54] /usr/share/podman/test/system/200-pod.bats:446:69: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 444| # 445| run_podman pod create --share net --network host --replace $name # 446|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 447| is "$output" "true" "Host network sharing with only net should be true" # 448| run_podman pod rm $name Error: SHELLCHECK_WARNING (CWE-569): [#def55] /usr/share/podman/test/system/200-pod.bats:446:70: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 444| # 445| run_podman pod create --share net --network host --replace $name # 446|-> run_podman pod inspect $name --format {{.InfraConfig.HostNetwork}} # 447| is "$output" "true" "Host network sharing with only net should be true" # 448| run_podman pod rm $name Error: SHELLCHECK_WARNING (CWE-569): [#def56] /usr/share/podman/test/system/200-pod.bats:451:42: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 449| # 450| run_podman pod create --name test --share ipc --network host # 451|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "true" "Host network sharing with only ipc should be true" # 453| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def57] /usr/share/podman/test/system/200-pod.bats:451:43: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it. # 449| # 450| run_podman pod create --name test --share ipc --network host # 451|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "true" "Host network sharing with only ipc should be true" # 453| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def58] /usr/share/podman/test/system/200-pod.bats:451:68: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 449| # 450| run_podman pod create --name test --share ipc --network host # 451|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "true" "Host network sharing with only ipc should be true" # 453| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-569): [#def59] /usr/share/podman/test/system/200-pod.bats:451:69: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it. # 449| # 450| run_podman pod create --name test --share ipc --network host # 451|-> run_podman pod inspect test --format {{.InfraConfig.HostNetwork}} # 452| is "$output" "true" "Host network sharing with only ipc should be true" # 453| run_podman pod rm test Error: SHELLCHECK_WARNING (CWE-571): [#def60] /usr/share/podman/test/system/200-pod.bats:491:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 489| @test "pod exit policies - play kube" { # 490| # play-kube sets the exit policy to "stop" # 491|-> local name="$(random_string 10 | tr A-Z a-z)" # 492| # 493| kubeFile="apiVersion: v1 Error: SHELLCHECK_WARNING (CWE-252): [#def61] /usr/share/podman/test/system/250-systemd.bats:43:9: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 41| # is forgiving about that, but RHEL8 systemd chokes with EINVAL) # 42| ( # 43|-> cd $UNIT_DIR # 44| run_podman generate systemd --files --name \ # 45| -e http_proxy -e https_proxy -e no_proxy \ Error: SHELLCHECK_WARNING (CWE-156): [#def62] /usr/share/podman/test/system/250-systemd.bats:270:20: warning[SC2046]: Quote this to prevent word splitting. # 268| run_podman rm -f $cname # 269| run_podman pod rm -f $podname # 270|-> run_podman rmi $(pause_image) # 271| } # 272| Error: SHELLCHECK_WARNING (CWE-571): [#def63] /usr/share/podman/test/system/250-systemd.bats:306:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 304| # 305| cname=$(random_string) # 306|-> local netname=testnet-$(random_string 10) # 307| # 308| # create network and container with network Error: SHELLCHECK_WARNING (CWE-156): [#def64] /usr/share/podman/test/system/250-systemd.bats:485:20: warning[SC2046]: Quote this to prevent word splitting. # 483| run_podman 1 container exists $service_container # 484| run_podman 1 pod exists test_pod # 485|-> run_podman rmi $(pause_image) # 486| run_podman network rm podman-default-kube-network # 487| rm -f $UNIT_DIR/$unit_name Error: SHELLCHECK_WARNING (CWE-457): [#def65] /usr/share/podman/test/system/250-systemd.bats:487:21: warning[SC2154]: unit_name is referenced but not assigned. # 485| run_podman rmi $(pause_image) # 486| run_podman network rm podman-default-kube-network # 487|-> rm -f $UNIT_DIR/$unit_name # 488| } # 489| Error: SHELLCHECK_WARNING (CWE-571): [#def66] /usr/share/podman/test/system/252-quadlet.bats:187:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 185| # Network=none is to work around a Pasta bug, can be removed once a patched Pasta is available. # 186| # Ref https://github.com/containers/podman/pull/21563#issuecomment-1965145324 # 187|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 188| cat > $quadlet_file <<EOF # 189| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def67] /usr/share/podman/test/system/252-quadlet.bats:226:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 224| dir1=$PODMAN_TMPDIR/$(random_string) # 225| dir2=$PODMAN_TMPDIR/$(random_string) # 226|-> local quadlet_file=basic_$(random_string).container # 227| mkdir -p $dir1 $dir2 # 228| Error: SHELLCHECK_WARNING (CWE-571): [#def68] /usr/share/podman/test/system/252-quadlet.bats:248:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 246| # 247| @test "quadlet - envvar" { # 248|-> local quadlet_file=$PODMAN_TMPDIR/envvar_$(random_string).container # 249| cat > $quadlet_file <<EOF # 250| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def69] /usr/share/podman/test/system/252-quadlet.bats:272:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 270| # 271| @test "quadlet - ContainerName and journal output check" { # 272|-> local quadlet_file=$PODMAN_TMPDIR/containername_$(random_string).container # 273| local token_out="STDOUT$(random_string 10)" # 274| local token_err="STDERR$(random_string 10)" Error: SHELLCHECK_WARNING (CWE-571): [#def70] /usr/share/podman/test/system/252-quadlet.bats:305:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 303| # 304| @test "quadlet - labels" { # 305|-> local quadlet_file=$PODMAN_TMPDIR/labels_$(random_string).container # 306| cat > $quadlet_file <<EOF # 307| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def71] /usr/share/podman/test/system/252-quadlet.bats:331:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 329| # 330| @test "quadlet - oneshot" { # 331|-> local quadlet_file=$PODMAN_TMPDIR/oneshot_$(random_string).container # 332| cat > $quadlet_file <<EOF # 333| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def72] /usr/share/podman/test/system/252-quadlet.bats:354:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 352| # 353| @test "quadlet - volume" { # 354|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).volume # 355| cat > $quadlet_file <<EOF # 356| [Volume] Error: SHELLCHECK_WARNING (CWE-571): [#def73] /usr/share/podman/test/system/252-quadlet.bats:380:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 378| @test "quadlet - volume dependency" { # 379| # Save the unit name to use as the volume for the container # 380|-> local quadlet_vol_unit=dep_$(random_string).volume # 381| local quadlet_vol_file=$PODMAN_TMPDIR/${quadlet_vol_unit} # 382| cat > $quadlet_vol_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def74] /usr/share/podman/test/system/252-quadlet.bats:393:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 391| local volume_name=systemd-$(basename $quadlet_vol_file .volume) # 392| # 393|-> local quadlet_file=$PODMAN_TMPDIR/user_$(random_string).container # 394| cat > $quadlet_file <<EOF # 395| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def75] /usr/share/podman/test/system/252-quadlet.bats:429:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 427| @test "quadlet - named volume dependency" { # 428| # Save the unit name to use as the volume for the container # 429|-> local quadlet_vol_unit=dep_$(random_string).volume # 430| local quadlet_vol_file=$PODMAN_TMPDIR/${quadlet_vol_unit} # 431| cat > $quadlet_vol_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def76] /usr/share/podman/test/system/252-quadlet.bats:444:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 442| local volume_name="foo" # 443| # 444|-> local quadlet_file=$PODMAN_TMPDIR/user_$(random_string).container # 445| cat > $quadlet_file <<EOF # 446| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def77] /usr/share/podman/test/system/252-quadlet.bats:482:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 480| # 481| @test "quadlet - network" { # 482|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).network # 483| cat > $quadlet_file <<EOF # 484| [Network] Error: SHELLCHECK_WARNING (CWE-571): [#def78] /usr/share/podman/test/system/252-quadlet.bats:507:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 505| @test "quadlet - network dependency" { # 506| # Save the unit name to use as the network for the container # 507|-> local quadlet_network_unit=dep_$(random_string).network # 508| local quadlet_network_file=$PODMAN_TMPDIR/${quadlet_network_unit} # 509| cat > $quadlet_network_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def79] /usr/share/podman/test/system/252-quadlet.bats:520:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 518| local network_name=systemd-$(basename $quadlet_network_file .network) # 519| # 520|-> local quadlet_file=$PODMAN_TMPDIR/user_$(random_string).container # 521| cat > $quadlet_file <<EOF # 522| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def80] /usr/share/podman/test/system/252-quadlet.bats:553:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 551| @test "quadlet - named network dependency" { # 552| # Save the unit name to use as the network for the container # 553|-> local quadlet_network_unit=dep_$(random_string).network # 554| local quadlet_network_file=$PODMAN_TMPDIR/${quadlet_network_unit} # 555| cat > $quadlet_network_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def81] /usr/share/podman/test/system/252-quadlet.bats:568:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 566| local network_name="foo" # 567| # 568|-> local quadlet_file=$PODMAN_TMPDIR/user_$(random_string).container # 569| cat > $quadlet_file <<EOF # 570| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def82] /usr/share/podman/test/system/252-quadlet.bats:626:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 624| # 625| # Create the Quadlet file # 626|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).kube # 627| cat > $quadlet_file <<EOF # 628| [Kube] Error: SHELLCHECK_WARNING (CWE-156): [#def83] /usr/share/podman/test/system/252-quadlet.bats:642:20: warning[SC2046]: Quote this to prevent word splitting. # 640| # 641| service_cleanup $QUADLET_SERVICE_NAME inactive # 642|-> run_podman rmi $(pause_image) # 643| run_podman network rm podman-default-kube-network # 644| } Error: SHELLCHECK_WARNING (CWE-571): [#def84] /usr/share/podman/test/system/252-quadlet.bats:648:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 646| @test "quadlet kube - named network dependency" { # 647| # Save the unit name to use as the network for the container # 648|-> local quadlet_network_unit=dep_$(random_string).network # 649| local quadlet_network_file=$PODMAN_TMPDIR/${quadlet_network_unit} # 650| cat > $quadlet_network_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def85] /usr/share/podman/test/system/252-quadlet.bats:686:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 684| # 685| # Create the Quadlet file # 686|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).kube # 687| cat > $quadlet_file <<EOF # 688| [Kube] Error: SHELLCHECK_WARNING (CWE-156): [#def86] /usr/share/podman/test/system/252-quadlet.bats:718:20: warning[SC2046]: Quote this to prevent word splitting. # 716| service_cleanup $QUADLET_SERVICE_NAME inactive # 717| run_podman network rm $network_name # 718|-> run_podman rmi $(pause_image) # 719| } # 720| Error: SHELLCHECK_WARNING (CWE-571): [#def87] /usr/share/podman/test/system/252-quadlet.bats:724:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 722| skip_if_no_selinux # 723| skip_if_rootless # 724|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 725| cat > $quadlet_file <<EOF # 726| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def88] /usr/share/podman/test/system/252-quadlet.bats:740:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 738| @test "quadlet - selinux disable" { # 739| skip_if_no_selinux # 740|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 741| cat > $quadlet_file <<EOF # 742| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def89] /usr/share/podman/test/system/252-quadlet.bats:763:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 761| skip_if_no_selinux # 762| NAME=$(random_string) # 763|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 764| cat > $quadlet_file <<EOF # 765| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def90] /usr/share/podman/test/system/252-quadlet.bats:792:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 790| create_secret # 791| # 792|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 793| cat > $quadlet_file <<EOF # 794| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def91] /usr/share/podman/test/system/252-quadlet.bats:818:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 816| create_secret # 817| # 818|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 819| cat > $quadlet_file <<EOF # 820| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def92] /usr/share/podman/test/system/252-quadlet.bats:847:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 845| # seem to be any systemctly way to find this. # 846| percent_t_file="${PODMAN_TMPDIR}/foo" # 847|-> local service=get-percent-t.$(random_string 10).service # 848| local unitfile=${UNIT_DIR}/$service # 849| cat >$unitfile <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def93] /usr/share/podman/test/system/252-quadlet.bats:873:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 871| echo $file_content > $tmp_path/$file_name # 872| # 873|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 874| cat > $quadlet_file <<EOF # 875| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def94] /usr/share/podman/test/system/252-quadlet.bats:892:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 890| # 891| @test "quadlet - tmpfs" { # 892|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 893| cat > $quadlet_file <<EOF # 894| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def95] /usr/share/podman/test/system/252-quadlet.bats:917:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 915| # 916| @test "quadlet - userns" { # 917|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).container # 918| cat > $quadlet_file <<EOF # 919| [Container] Error: SHELLCHECK_WARNING (CWE-571): [#def96] /usr/share/podman/test/system/252-quadlet.bats:943:13: warning[SC2155]: Declare and assign separately to avoid masking return values. # 941| " # 942| while read exit_code_prop cmd exit_code service_state; do # 943|-> local basename=propagate-${exit_code_prop}-${cmd}-$(random_string) # 944| local quadlet_file=$PODMAN_TMPDIR/$basename.kube # 945| local yaml_file=$PODMAN_TMPDIR/$basename.yaml Error: SHELLCHECK_WARNING (CWE-156): [#def97] /usr/share/podman/test/system/252-quadlet.bats:1012:19: warning[SC2046]: Quote this to prevent word splitting. # 1010| done < <(parse_table "$exit_tests") # 1011| # 1012|-> run_podman rmi $(pause_image) # 1013| run_podman network rm podman-default-kube-network # 1014| } Error: SHELLCHECK_WARNING (CWE-456): [#def98] /usr/share/podman/test/system/252-quadlet.bats:1020:5: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string). # 1018| local_path=local_path$(random_string) # 1019| pod_name=test_pod # 1020|-> container_name=test # 1021| # 1022| cat >$yaml_source <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def99] /usr/share/podman/test/system/252-quadlet.bats:1051:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1049| # 1050| # Create the Quadlet file # 1051|-> local quadlet_file=$PODMAN_TMPDIR/basic_$(random_string).kube # 1052| cat > $quadlet_file <<EOF # 1053| [Kube] Error: SHELLCHECK_WARNING (CWE-156): [#def100] /usr/share/podman/test/system/252-quadlet.bats:1073:20: warning[SC2046]: Quote this to prevent word splitting. # 1071| # 1072| service_cleanup $QUADLET_SERVICE_NAME inactive # 1073|-> run_podman rmi $(pause_image) # 1074| run_podman network rm podman-default-kube-network # 1075| } Error: SHELLCHECK_WARNING (CWE-571): [#def101] /usr/share/podman/test/system/252-quadlet.bats:1081:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1079| # 1080| local registry=localhost:${PODMAN_LOGIN_REGISTRY_PORT} # 1081|-> local image_for_test=$registry/quadlet_image_test:$(random_string) # 1082| local authfile=$PODMAN_TMPDIR/authfile.json # 1083| Error: SHELLCHECK_WARNING (CWE-571): [#def102] /usr/share/podman/test/system/252-quadlet.bats:1084:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1082| local authfile=$PODMAN_TMPDIR/authfile.json # 1083| # 1084|-> local quadlet_image_unit=image_test_$(random_string).image # 1085| local quadlet_image_file=$PODMAN_TMPDIR/$quadlet_image_unit # 1086| cat > $quadlet_image_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def103] /usr/share/podman/test/system/252-quadlet.bats:1093:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1091| EOF # 1092| # 1093|-> local quadlet_volume_unit=image_test_$(random_string).volume # 1094| local quadlet_volume_file=$PODMAN_TMPDIR/$quadlet_volume_unit # 1095| local volume_name=systemd-$(basename $quadlet_volume_file .volume) Error: SHELLCHECK_WARNING (CWE-571): [#def104] /usr/share/podman/test/system/252-quadlet.bats:1102:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1100| EOF # 1101| # 1102|-> local quadlet_container_unit=image_test_$(random_string).container # 1103| local quadlet_container_file=$PODMAN_TMPDIR/$quadlet_container_unit # 1104| cat > $quadlet_container_file <<EOF Error: SHELLCHECK_WARNING (CWE-156): [#def105] /usr/share/podman/test/system/252-quadlet.bats:1305:29: warning[SC2046]: Quote this to prevent word splitting. # 1303| service_cleanup $pod_service inactive # 1304| run_podman volume rm $quadlet_kube_volume_name # 1305|-> run_podman rmi --ignore $(pause_image) # 1306| run_podman network rm podman-default-kube-network # 1307| } Error: SHELLCHECK_WARNING (CWE-571): [#def106] /usr/share/podman/test/system/252-quadlet.bats:1310:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1308| # 1309| @test "quadlet - kube down force" { # 1310|-> local test_random_string=$(random_string) # 1311| # 1312| local quadlet_kube_volume_name=test-volume_$test_random_string Error: SHELLCHECK_WARNING (CWE-156): [#def107] /usr/share/podman/test/system/252-quadlet.bats:1385:29: warning[SC2046]: Quote this to prevent word splitting. # 1383| # Volume should not exist # 1384| run_podman 1 volume exists ${quadlet_kube_volume_name} # 1385|-> run_podman rmi --ignore $(pause_image) # 1386| run_podman network rm podman-default-kube-network # 1387| } Error: SHELLCHECK_WARNING (CWE-571): [#def108] /usr/share/podman/test/system/252-quadlet.bats:1392:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1390| local quadlet_tmpdir=$PODMAN_TMPDIR/quadlets # 1391| local archive_file=$PODMAN_TMPDIR/archive-file.tar # 1392|-> local image_for_test=localhost/quadlet_image_test:$(random_string) # 1393| # 1394| local quadlet_image_unit=image_test_$(random_string).image Error: SHELLCHECK_WARNING (CWE-571): [#def109] /usr/share/podman/test/system/252-quadlet.bats:1394:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1392| local image_for_test=localhost/quadlet_image_test:$(random_string) # 1393| # 1394|-> local quadlet_image_unit=image_test_$(random_string).image # 1395| local quadlet_image_file=$PODMAN_TMPDIR/$quadlet_image_unit # 1396| cat > $quadlet_image_file <<EOF Error: SHELLCHECK_WARNING (CWE-571): [#def110] /usr/share/podman/test/system/252-quadlet.bats:1402:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1400| EOF # 1401| # 1402|-> local quadlet_volume_unit=image_test_$(random_string).volume # 1403| local quadlet_volume_file=$PODMAN_TMPDIR/$quadlet_volume_unit # 1404| local volume_name=systemd-$(basename $quadlet_volume_file .volume) Error: SHELLCHECK_WARNING (CWE-571): [#def111] /usr/share/podman/test/system/252-quadlet.bats:1411:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1409| EOF # 1410| # 1411|-> local quadlet_container_unit=image_test_$(random_string).container # 1412| local quadlet_container_file=$PODMAN_TMPDIR/$quadlet_container_unit # 1413| cat > $quadlet_container_file <<EOF Error: SHELLCHECK_WARNING (CWE-156): [#def112] /usr/share/podman/test/system/252-quadlet.bats:1473:29: warning[SC2046]: Quote this to prevent word splitting. # 1471| service_cleanup $container_service failed # 1472| run_podman image rm --ignore $image_for_test # 1473|-> run_podman rmi --ignore $(pause_image) # 1474| run_podman volume rm $volume_name # 1475| } Error: SHELLCHECK_WARNING (CWE-571): [#def113] /usr/share/podman/test/system/252-quadlet.bats:1480:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1478| local quadlet_tmpdir=$PODMAN_TMPDIR/quadlets # 1479| # 1480|-> local test_pod_name=pod_test_$(random_string) # 1481| local quadlet_pod_unit=$test_pod_name.pod # 1482| local quadlet_pod_file=$PODMAN_TMPDIR/$quadlet_pod_unit Error: SHELLCHECK_WARNING (CWE-571): [#def114] /usr/share/podman/test/system/252-quadlet.bats:1488:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1486| EOF # 1487| # 1488|-> local quadlet_container_unit=pod_test_$(random_string).container # 1489| local quadlet_container_file=$PODMAN_TMPDIR/$quadlet_container_unit # 1490| cat > $quadlet_container_file <<EOF Error: SHELLCHECK_WARNING (CWE-156): [#def115] /usr/share/podman/test/system/252-quadlet.bats:1536:20: warning[SC2046]: Quote this to prevent word splitting. # 1534| run_podman 1 container exists ${container_name} # 1535| # 1536|-> run_podman rmi $(pause_image) # 1537| } # 1538| Error: SHELLCHECK_WARNING (CWE-571): [#def116] /usr/share/podman/test/system/252-quadlet.bats:1582:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1580| # 1581| # Create the Quadlet file # 1582|-> local quadlet_file=$quadlet_tmpdir/build_$(random_string).kube # 1583| cat > $quadlet_file <<EOF # 1584| [Kube] Error: SHELLCHECK_WARNING (CWE-156): [#def117] /usr/share/podman/test/system/252-quadlet.bats:1603:56: warning[SC2046]: Quote this to prevent word splitting. # 1601| # 1602| service_cleanup $QUADLET_SERVICE_NAME inactive # 1603|-> run_podman rmi $untagged_image:latest $built_image $(pause_image) # 1604| run_podman network rm podman-default-kube-network # 1605| } Error: SHELLCHECK_WARNING (CWE-571): [#def118] /usr/share/podman/test/system/252-quadlet.bats:1610:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1608| local quadlet_tmpdir="${PODMAN_TMPDIR}/dropins" # 1609| # 1610|-> local quadlet_file="truncated-$(random_string).container" # 1611| # 1612| local -A dropin_dirs=( Error: SHELLCHECK_WARNING (CWE-156): [#def119] /usr/share/podman/test/system/260-sdnotify.bats:320:20: warning[SC2046]: Quote this to prevent word splitting. # 318| # Clean up pod and pause image # 319| run_podman play kube --down $PODMAN_TMPDIR/test.yaml # 320|-> run_podman rmi $(pause_image) # 321| run_podman network rm podman-default-kube-network # 322| } Error: SHELLCHECK_WARNING (CWE-156): [#def120] /usr/share/podman/test/system/260-sdnotify.bats:436:20: warning[SC2046]: Quote this to prevent word splitting. # 434| # Clean up pod and pause image # 435| run_podman play kube --down $yaml_source # 436|-> run_podman rmi $(pause_image) # 437| run_podman network rm podman-default-kube-network # 438| } Error: SHELLCHECK_WARNING (CWE-156): [#def121] /usr/share/podman/test/system/260-sdnotify.bats:527:20: warning[SC2046]: Quote this to prevent word splitting. # 525| is "$output" "Error: unsupported exit-code propagation \"bogus\"" "error on unsupported exit-code propagation" # 526| # 527|-> run_podman rmi $(pause_image) # 528| run_podman network rm podman-default-kube-network # 529| } Error: SHELLCHECK_WARNING (CWE-571): [#def122] /usr/share/podman/test/system/500-networking.bats:23:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 21| # 22| # check deterministic list order # 23|-> local net1=a-$(random_string 10) # 24| local net2=b-$(random_string 10) # 25| local net3=c-$(random_string 10) Error: SHELLCHECK_WARNING (CWE-571): [#def123] /usr/share/podman/test/system/500-networking.bats:24:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 22| # check deterministic list order # 23| local net1=a-$(random_string 10) # 24|-> local net2=b-$(random_string 10) # 25| local net3=c-$(random_string 10) # 26| run_podman network create $net1 Error: SHELLCHECK_WARNING (CWE-571): [#def124] /usr/share/podman/test/system/500-networking.bats:25:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 23| local net1=a-$(random_string 10) # 24| local net2=b-$(random_string 10) # 25|-> local net3=c-$(random_string 10) # 26| run_podman network create $net1 # 27| run_podman network create $net2 Error: SHELLCHECK_WARNING (CWE-571): [#def125] /usr/share/podman/test/system/500-networking.bats:161:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 159| # 160| @test "podman pod manages /etc/hosts correctly" { # 161|-> local pod_name=pod-$(random_string 10) # 162| local infra_name=infra-$(random_string 10) # 163| local con1_name=con1-$(random_string 10) Error: SHELLCHECK_WARNING (CWE-571): [#def126] /usr/share/podman/test/system/500-networking.bats:162:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 160| @test "podman pod manages /etc/hosts correctly" { # 161| local pod_name=pod-$(random_string 10) # 162|-> local infra_name=infra-$(random_string 10) # 163| local con1_name=con1-$(random_string 10) # 164| local con2_name=con2-$(random_string 10) Error: SHELLCHECK_WARNING (CWE-571): [#def127] /usr/share/podman/test/system/500-networking.bats:163:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 161| local pod_name=pod-$(random_string 10) # 162| local infra_name=infra-$(random_string 10) # 163|-> local con1_name=con1-$(random_string 10) # 164| local con2_name=con2-$(random_string 10) # 165| run_podman pod create --name $pod_name --infra-name $infra_name Error: SHELLCHECK_WARNING (CWE-571): [#def128] /usr/share/podman/test/system/500-networking.bats:164:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 162| local infra_name=infra-$(random_string 10) # 163| local con1_name=con1-$(random_string 10) # 164|-> local con2_name=con2-$(random_string 10) # 165| run_podman pod create --name $pod_name --infra-name $infra_name # 166| pid="$output" Error: SHELLCHECK_WARNING (CWE-156): [#def129] /usr/share/podman/test/system/500-networking.bats:188:20: warning[SC2046]: Quote this to prevent word splitting. # 186| # 187| # Clean up # 188|-> run_podman rmi $(pause_image) # 189| } # 190| Error: SHELLCHECK_WARNING (CWE-571): [#def130] /usr/share/podman/test/system/500-networking.bats:196:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 194| CIDR="$(random_rfc1918_subnet)" # 195| IP=$(hostname -I | cut -f 1 -d " ") # 196|-> local conname=con-$(random_string 10) # 197| run_podman run --rm --network slirp4netns:cidr="${CIDR}.0/24" \ # 198| --name $conname --hostname $conname $IMAGE cat /etc/hosts Error: SHELLCHECK_WARNING (CWE-571): [#def131] /usr/share/podman/test/system/500-networking.bats:243:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 241| myport=$(random_free_port) # 242| # 243|-> local mynetname=testnet-$(random_string 10) # 244| local mysubnet=$(random_rfc1918_subnet) # 245| Error: SHELLCHECK_WARNING (CWE-571): [#def132] /usr/share/podman/test/system/500-networking.bats:411:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 409| is_rootless || skip "only meaningful for rootless" # 410| # 411|-> local mynetname=testnet-$(random_string 10) # 412| run_podman --noout network create $mynetname # 413| is "$output" "" "output should be empty" Error: SHELLCHECK_WARNING (CWE-571): [#def133] /usr/share/podman/test/system/500-networking.bats:452:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 450| # ipv4 cni # 451| local mysubnet=$(random_rfc1918_subnet) # 452|-> local netname=testnet-$(random_string 10) # 453| # 454| run_podman network create --subnet $mysubnet.0/24 $netname Error: SHELLCHECK_WARNING (CWE-571): [#def134] /usr/share/podman/test/system/500-networking.bats:486:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 484| echo $random_1 > $INDEX1 # 485| # 486|-> local netname=testnet-$(random_string 10) # 487| run_podman network create $netname # 488| is "$output" "$netname" "output of 'network create'" Error: SHELLCHECK_WARNING (CWE-571): [#def135] /usr/share/podman/test/system/500-networking.bats:490:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 488| is "$output" "$netname" "output of 'network create'" # 489| # 490|-> local netname2=testnet2-$(random_string 10) # 491| run_podman network create $netname2 # 492| is "$output" "$netname2" "output of 'network create'" Error: SHELLCHECK_WARNING (CWE-571): [#def136] /usr/share/podman/test/system/500-networking.bats:499:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 497| background_cid=$output # 498| # 499|-> local hostname=host-$(random_string 10) # 500| # Run a httpd container on first network with exposed port # 501| run_podman run -d -p "$HOST_PORT:80" \ Error: SHELLCHECK_WARNING (CWE-571): [#def137] /usr/share/podman/test/system/500-networking.bats:601:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 599| echo $random_1 > $INDEX1 # 600| # 601|-> local netname=testnet-$(random_string 10) # 602| run_podman network create $netname # 603| is "$output" "$netname" "output of 'network create'" Error: SHELLCHECK_WARNING (CWE-571): [#def138] /usr/share/podman/test/system/500-networking.bats:704:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 702| # 703| # create network with dns # 704|-> local netname=testnet-$(random_string 10) # 705| local subnet=$(random_rfc1918_subnet) # 706| run_podman network create --subnet "$subnet.0/24" $netname Error: SHELLCHECK_WARNING (CWE-571): [#def139] /usr/share/podman/test/system/500-networking.bats:942:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 940| skip_if_cgroupsv1 "run --uidmap fails on cgroups v1 (issue 15025, wontfix)" # 941| # 942|-> local net1=a-$(random_string 10) # 943| # use /29 subnet to limit available ip space, a 29 gives 5 usable addresses (6 - 1 for the gw) # 944| local subnet="$(random_rfc1918_subnet).0/29" Error: SHELLCHECK_WARNING (CWE-571): [#def140] /usr/share/podman/test/system/500-networking.bats:946:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 944| local subnet="$(random_rfc1918_subnet).0/29" # 945| run_podman network create --subnet $subnet $net1 # 946|-> local cname=con1-$(random_string 10) # 947| local cname2= # 948| local cname3= Error: SHELLCHECK_WARNING (CWE-571): [#def141] /usr/share/podman/test/system/500-networking.bats:1004:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1002| # 1003| @test "podman network inspect running containers" { # 1004|-> local cname1=c1-$(random_string 10) # 1005| local cname2=c2-$(random_string 10) # 1006| local cname3=c3-$(random_string 10) Error: SHELLCHECK_WARNING (CWE-571): [#def142] /usr/share/podman/test/system/500-networking.bats:1005:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1003| @test "podman network inspect running containers" { # 1004| local cname1=c1-$(random_string 10) # 1005|-> local cname2=c2-$(random_string 10) # 1006| local cname3=c3-$(random_string 10) # 1007| Error: SHELLCHECK_WARNING (CWE-571): [#def143] /usr/share/podman/test/system/500-networking.bats:1006:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1004| local cname1=c1-$(random_string 10) # 1005| local cname2=c2-$(random_string 10) # 1006|-> local cname3=c3-$(random_string 10) # 1007| # 1008| local netname=net-$(random_string 10) Error: SHELLCHECK_WARNING (CWE-571): [#def144] /usr/share/podman/test/system/500-networking.bats:1008:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 1006| local cname3=c3-$(random_string 10) # 1007| # 1008|-> local netname=net-$(random_string 10) # 1009| local subnet=$(random_rfc1918_subnet) # 1010| Error: SHELLCHECK_WARNING (CWE-571): [#def145] /usr/share/podman/test/system/505-networking-pasta.bats:159:15: warning[SC2155]: Declare and assign separately to avoid masking return values. # 157| local xseq="$(echo ${xport} | tr '-' ' ')" # 158| else # 159|-> local port=$(random_free_port "" ${address} ${proto}) # 160| local xport="$((port + delta))" # 161| local seq="${port} ${port}" Error: SHELLCHECK_WARNING (CWE-457): [#def146] /usr/share/podman/test/system/505-networking-pasta.bats:159:42: warning[SC2154]: address is referenced but not assigned. # 157| local xseq="$(echo ${xport} | tr '-' ' ')" # 158| else # 159|-> local port=$(random_free_port "" ${address} ${proto}) # 160| local xport="$((port + delta))" # 161| local seq="${port} ${port}" Error: SHELLCHECK_WARNING (CWE-571): [#def147] /usr/share/podman/test/system/505-networking-pasta.bats:206:15: warning[SC2155]: Declare and assign separately to avoid masking return values. # 204| if [ "${bytes}" != "1" ]; then # 205| dd if=/dev/urandom bs=${bytes} count=1 of="${XFER_FILE}" # 206|-> local expect="$(cat "${XFER_FILE}" | md5sum)" # 207| else # 208| printf "x" > "${XFER_FILE}" Error: SHELLCHECK_WARNING (CWE-156): [#def148] /usr/share/podman/test/system/505-networking-pasta.bats:326:20: warning[SC2046]: Quote this to prevent word splitting. # 324| # 325| run_podman pod rm "${pname}" # 326|-> run_podman rmi $(pause_image) # 327| } # 328| Error: SHELLCHECK_WARNING (CWE-156): [#def149] /usr/share/podman/test/system/505-networking-pasta.bats:748:13: warning[SC2046]: Quote this to prevent word splitting. # 746| run_podman run --rm "--net=pasta:--pid,${pidfile}" $IMAGE true # 747| sleep 1 # 748|-> ! ps -p $(cat "${pidfile}") && rm "${pidfile}" # 749| } # 750| Error: SHELLCHECK_WARNING (CWE-571): [#def150] /usr/share/podman/test/system/520-checkpoint.bats:147:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 145| # Create a volume, find unused network port, and create a webserv container # 146| run_podman $p_opts volume create myvol # 147|-> local cname=c_$(random_string 10) # 148| local host_port=$(random_free_port) # 149| local server=http://127.0.0.1:$host_port Error: SHELLCHECK_WARNING (CWE-571): [#def151] /usr/share/podman/test/system/520-checkpoint.bats:238:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 236| # Refer to https://github.com/containers/podman/issues/16666#issuecomment-1337860545 # 237| # for the correct behavior, this should cover all cases listed there. # 238|-> local netname=net-$(random_string) # 239| local subnet="$(random_rfc1918_subnet)" # 240| run_podman network create --subnet "$subnet.0/24" $netname Error: SHELLCHECK_WARNING (CWE-156): [#def152] /usr/share/podman/test/system/610-format.bats:181:20: warning[SC2046]: Quote this to prevent word splitting. # 179| # Clean up # 180| run_podman pod rm mypod # 181|-> run_podman rmi $(pause_image) # 182| run_podman rm -f -t0 mycontainer # 183| run_podman secret rm mysecret Error: SHELLCHECK_WARNING (CWE-156): [#def153] /usr/share/podman/test/system/710-kube.bats:90:22: warning[SC2046]: Quote this to prevent word splitting. # 88| run_podman pod rm -a # 89| run_podman rm -a # 90|-> run_podman rmi $(pause_image) # 91| run_podman network rm podman-default-kube-network # 92| } Error: SHELLCHECK_WARNING (CWE-571): [#def154] /usr/share/podman/test/system/710-kube.bats:95:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 93| # 94| @test "podman kube generate - pod" { # 95|-> local pname=p$(random_string 15) # 96| local cname1=c1$(random_string 15) # 97| local cname2=c2$(random_string 15) Error: SHELLCHECK_WARNING (CWE-571): [#def155] /usr/share/podman/test/system/710-kube.bats:96:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 94| @test "podman kube generate - pod" { # 95| local pname=p$(random_string 15) # 96|-> local cname1=c1$(random_string 15) # 97| local cname2=c2$(random_string 15) # 98| Error: SHELLCHECK_WARNING (CWE-571): [#def156] /usr/share/podman/test/system/710-kube.bats:97:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 95| local pname=p$(random_string 15) # 96| local cname1=c1$(random_string 15) # 97|-> local cname2=c2$(random_string 15) # 98| # 99| run_podman pod create --name $pname --publish 9999:8888 Error: SHELLCHECK_WARNING (CWE-156): [#def157] /usr/share/podman/test/system/710-kube.bats:151:20: warning[SC2046]: Quote this to prevent word splitting. # 149| run_podman rm $cname1 $cname2 # 150| run_podman pod rm $pname # 151|-> run_podman rmi $(pause_image) # 152| } # 153| Error: SHELLCHECK_WARNING (CWE-571): [#def158] /usr/share/podman/test/system/710-kube.bats:156:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 154| @test "podman kube generate - deployment" { # 155| skip_if_remote "containersconf needs to be set on server side" # 156|-> local pname=p$(random_string 15) # 157| local cname1=c1$(random_string 15) # 158| local cname2=c2$(random_string 15) Error: SHELLCHECK_WARNING (CWE-571): [#def159] /usr/share/podman/test/system/710-kube.bats:157:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 155| skip_if_remote "containersconf needs to be set on server side" # 156| local pname=p$(random_string 15) # 157|-> local cname1=c1$(random_string 15) # 158| local cname2=c2$(random_string 15) # 159| Error: SHELLCHECK_WARNING (CWE-571): [#def160] /usr/share/podman/test/system/710-kube.bats:158:11: warning[SC2155]: Declare and assign separately to avoid masking return values. # 156| local pname=p$(random_string 15) # 157| local cname1=c1$(random_string 15) # 158|-> local cname2=c2$(random_string 15) # 159| # 160| run_podman pod create --name $pname Error: SHELLCHECK_WARNING (CWE-156): [#def161] /usr/share/podman/test/system/710-kube.bats:192:20: warning[SC2046]: Quote this to prevent word splitting. # 190| run_podman rm $cname1 $cname2 # 191| run_podman pod rm $pname # 192|-> run_podman rmi $(pause_image) # 193| } # 194| Error: SHELLCHECK_WARNING (CWE-563): [#def162] /usr/share/podman/test/system/helpers.bash:32:1: warning[SC2034]: IMAGE appears unused. Verify use (or export if used externally). # 30| # 31| # Because who wants to spell that out each time? # 32|-> IMAGE=$PODMAN_TEST_IMAGE_FQN # 33| SYSTEMD_IMAGE=$PODMAN_SYSTEMD_IMAGE_FQN # 34| Error: SHELLCHECK_WARNING (CWE-156): [#def163] /usr/share/podman/test/system/helpers.registry.bash:29:41: warning[SC2046]: Quote this to prevent word splitting. # 27| # already-started registry, but its port is now DROPped, # 28| # so the test times out trying to talk to registry # 29|-> run_podman --storage-driver vfs $(podman_isolation_opts ${PODMAN_LOGIN_WORKDIR}) network reload --all # 30| return # 31| fi Error: SHELLCHECK_WARNING (CWE-571): [#def164] /usr/share/podman/test/system/helpers.systemd.bash:9:16: warning[SC2155]: Declare and assign separately to avoid masking return values. # 7| if [ -z "$XDG_RUNTIME_DIR" ]; then # 8| if is_rootless; then # 9|-> export XDG_RUNTIME_DIR=/run/user/$(id -u) # 10| fi # 11| fi Error: SHELLCHECK_WARNING (CWE-571): [#def165] /usr/share/podman/test/system/setup_suite.bash:28:12: warning[SC2155]: Declare and assign separately to avoid masking return values. # 26| # FIXME: racy! It could be many minutes between now and when we start it. # 27| # To mitigate, we use a range not used anywhere else in system tests. # 28|-> export PODMAN_LOGIN_REGISTRY_PORT=$(random_free_port 42000-42999) # 29| # 30| # The above does not handle errors. Do a final confirmation.
analyzer-version-clippy | 1.82.0 |
analyzer-version-cppcheck | 2.16.0 |
analyzer-version-gcc | 14.2.1 |
analyzer-version-gcc-analyzer | 15.0.0 |
analyzer-version-shellcheck | 0.10.0 |
analyzer-version-unicontrol | 0.0.2 |
diffbase-analyzer-version-clippy | 1.82.0 |
diffbase-analyzer-version-cppcheck | 2.16.0 |
diffbase-analyzer-version-gcc | 14.2.1 |
diffbase-analyzer-version-gcc-analyzer | 15.0.0 |
diffbase-analyzer-version-shellcheck | 0.10.0 |
diffbase-analyzer-version-unicontrol | 0.0.2 |
diffbase-enabled-plugins | clippy, cppcheck, gcc, shellcheck, unicontrol |
diffbase-exit-code | 0 |
diffbase-host | ip-172-16-1-29.us-west-2.compute.internal |
diffbase-mock-config | fedora-rawhide-gcc-latest-x86_64 |
diffbase-project-name | podman-5.3.0~rc3-1.fc42 |
diffbase-store-results-to | /tmp/tmpmfh71xmu/podman-5.3.0~rc3-1.fc42.tar.xz |
diffbase-time-created | 2024-11-13 02:39:08 |
diffbase-time-finished | 2024-11-13 02:50:18 |
diffbase-tool | csmock |
diffbase-tool-args | '/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpmfh71xmu/podman-5.3.0~rc3-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpmfh71xmu/podman-5.3.0~rc3-1.fc42.src.rpm' |
diffbase-tool-version | csmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9 |
enabled-plugins | clippy, cppcheck, gcc, shellcheck, unicontrol |
exit-code | 0 |
host | ip-172-16-1-29.us-west-2.compute.internal |
mock-config | fedora-rawhide-gcc-latest-x86_64 |
project-name | podman-5.2.5-1.fc41 |
store-results-to | /tmp/tmpx7lruobi/podman-5.2.5-1.fc41.tar.xz |
time-created | 2024-11-13 02:27:08 |
time-finished | 2024-11-13 02:38:43 |
title | Fixed findings |
tool | csmock |
tool-args | '/usr/bin/csmock' '-r' 'fedora-rawhide-gcc-latest-x86_64' '-t' 'clippy,cppcheck,gcc,unicontrol,shellcheck' '-o' '/tmp/tmpx7lruobi/podman-5.2.5-1.fc41.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install=gcc-latest' '--gcc-analyzer-bin=/opt/gcc-latest/bin/gcc' '/tmp/tmpx7lruobi/podman-5.2.5-1.fc41.src.rpm' |
tool-version | csmock-3.7.1.20241107.094801.gb3f0f26.pr_192-1.el9 |