Fixed findings

List of Findings

Error: COMPILER_WARNING: [#def1]
game-music-emu-0.6.3/gme/Blip_Buffer.cpp:3: included_from: Included from here.
game-music-emu-0.6.3/gme/Blip_Buffer.h:236:46: warning[-Wtemplate-id-cdtor]: template-id not allowed for constructor in C++20
#  236 |         Blip_Synth<quality, range>           (const Blip_Synth<quality, range>  &) = delete;
#      |                                              ^
game-music-emu-0.6.3/gme/Blip_Buffer.h:236:46: note: remove the ‘< >’
#  234|   
#  235|   	// disable broken defaulted constructors, Blip_Synth_ isn't safe to move/copy
#  236|-> 	Blip_Synth<quality, range>           (const Blip_Synth<quality, range>  &) = delete;
#  237|   	Blip_Synth<quality, range>           (      Blip_Synth<quality, range> &&) = delete;
#  238|   	Blip_Synth<quality, range>& operator=(const Blip_Synth<quality, range> &)  = delete;

Error: COMPILER_WARNING: [#def2]
game-music-emu-0.6.3/gme/Blip_Buffer.h:237:53: warning[-Wtemplate-id-cdtor]: template-id not allowed for constructor in C++20
#  237 |         Blip_Synth<quality, range>           (      Blip_Synth<quality, range> &&) = delete;
#      |                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
game-music-emu-0.6.3/gme/Blip_Buffer.h:237:53: note: remove the ‘< >’
#  235|   	// disable broken defaulted constructors, Blip_Synth_ isn't safe to move/copy
#  236|   	Blip_Synth<quality, range>           (const Blip_Synth<quality, range>  &) = delete;
#  237|-> 	Blip_Synth<quality, range>           (      Blip_Synth<quality, range> &&) = delete;
#  238|   	Blip_Synth<quality, range>& operator=(const Blip_Synth<quality, range> &)  = delete;
#  239|   };

Error: CPPCHECK_WARNING (CWE-476): [#def3]
game-music-emu-0.6.3/gme/Data_Reader.cpp:370: error[nullPointer]: Null pointer dereference
#  368|   #endif
#  369|   	long pos = tell();
#  370|-> 	fseek( (FILE*) file_, 0, SEEK_END );
#  371|   	long result = tell();
#  372|   	fseek( (FILE*) file_, pos, SEEK_SET );

Error: CPPCHECK_WARNING (CWE-476): [#def4]
game-music-emu-0.6.3/gme/Data_Reader.cpp:372: error[nullPointer]: Null pointer dereference
#  370|   	fseek( (FILE*) file_, 0, SEEK_END );
#  371|   	long result = tell();
#  372|-> 	fseek( (FILE*) file_, pos, SEEK_SET );
#  373|   	return result;
#  374|   }

Error: CPPCHECK_WARNING (CWE-476): [#def5]
game-music-emu-0.6.3/gme/Data_Reader.cpp:406: error[nullPointer]: Null pointer dereference
#  404|   #endif
#  405|   	const auto &file = reinterpret_cast<FILE*>( file_ );
#  406|-> 	if ( s == static_cast<long>( fread( p, 1, static_cast<size_t>(s), file ) ) )
#  407|   		return 0;
#  408|   	if ( feof( file ) )

Error: CPPCHECK_WARNING (CWE-476): [#def6]
game-music-emu-0.6.3/gme/Data_Reader.cpp:408: error[nullPointer]: Null pointer dereference
#  406|   	if ( s == static_cast<long>( fread( p, 1, static_cast<size_t>(s), file ) ) )
#  407|   		return 0;
#  408|-> 	if ( feof( file ) )
#  409|   		return eof_error;
#  410|   	return "Couldn't read from file";

Error: COMPILER_WARNING (CWE-476): [#def7]
game-music-emu-0.6.3/gme/Data_Reader.cpp:408:18: warning[-Wnonnull]: argument 1 null where non-null expected
#  408 |         if ( feof( file ) )
#      |              ~~~~^~~~~~~~
/usr/include/stdio.h:849:12: note: in a call to function ‘feof’ declared ‘nonnull’
#  849 | extern int feof (FILE *__stream) __THROW __wur __nonnull ((1));
#      |            ^~~~
#  406|   	if ( s == static_cast<long>( fread( p, 1, static_cast<size_t>(s), file ) ) )
#  407|   		return 0;
#  408|-> 	if ( feof( file ) )
#  409|   		return eof_error;
#  410|   	return "Couldn't read from file";

Error: CPPCHECK_WARNING (CWE-476): [#def8]
game-music-emu-0.6.3/gme/Data_Reader.cpp:419: error[nullPointer]: Null pointer dereference
#  417|   		return gztell( reinterpret_cast<gzFile>( file_ ) );
#  418|   #endif
#  419|-> 	return ftell( reinterpret_cast<FILE*>( file_ ) );
#  420|   }
#  421|   

Error: COMPILER_WARNING (CWE-476): [#def9]
game-music-emu-0.6.3/gme/Data_Reader.cpp:419:21: warning[-Wnonnull]: argument 1 null where non-null expected
#  419 |         return ftell( reinterpret_cast<FILE*>( file_ ) );
#      |                ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/stdio.h: scope_hint: In member function ‘Std_File_Reader::tell() const’
/usr/include/stdio.h:772:17: note: in a call to function ‘ftell’ declared ‘nonnull’
#  772 | extern long int ftell (FILE *__stream) __wur __nonnull ((1));
#      |                 ^~~~~
#  417|   		return gztell( reinterpret_cast<gzFile>( file_ ) );
#  418|   #endif
#  419|-> 	return ftell( reinterpret_cast<FILE*>( file_ ) );
#  420|   }
#  421|   

Error: COMPILER_WARNING (CWE-476): [#def10]
game-music-emu-0.6.3/gme/Data_Reader.cpp: scope_hint: In member function ‘Std_File_Reader::seek(long)’
game-music-emu-0.6.3/gme/Data_Reader.cpp:434:20: warning[-Wnonnull]: argument 1 null where non-null expected
#  434 |         if ( !fseek( reinterpret_cast<FILE*>( file_ ), n, SEEK_SET ) )
#      |               ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/stdio.h:766:12: note: in a call to function ‘fseek’ declared ‘nonnull’
#  766 | extern int fseek (FILE *__stream, long int __off, int __whence)
#      |            ^~~~~
#  432|   	}
#  433|   #endif
#  434|-> 	if ( !fseek( reinterpret_cast<FILE*>( file_ ), n, SEEK_SET ) )
#  435|   		return nullptr;
#  436|   	if ( n > size() )

Error: CPPCHECK_WARNING (CWE-119): [#def11]
game-music-emu-0.6.3/gme/Nsfe_Emu.cpp:167: error[bufferAccessOutOfBounds]: Buffer is accessed out of bounds: info.load_addr
#  165|   				this->actual_track_count_ = finfo.track_count;
#  166|   				info.first_track = finfo.first_track;
#  167|-> 				memcpy( info.load_addr, finfo.load_addr, 2 * 3 );
#  168|   				break;
#  169|   			}

Scan Properties