gnome-session-48.0-1.fc43

List of Findings

Error: COMPILER_WARNING (CWE-477): [#def1]
gnome-session-48.0/gnome-session/gsm-app.c:40:9: warning[-Wdeprecated-declarations]: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead
#   40 |         GTimeVal         last_restart_time;
#      |         ^~~~~~~~
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-app.c:24: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:580:8: note: declared here
#  580 | struct _GTimeVal
#      |        ^~~~~~~~~
#   38|           char            *startup_id;
#   39|           gboolean         registered;
#   40|->         GTimeVal         last_restart_time;
#   41|           GDBusConnection *connection;
#   42|           GsmExportedApp  *skeleton;

Error: COMPILER_WARNING (CWE-477): [#def2]
gnome-session-48.0/gnome-session/gsm-app.c: scope_hint: In function ‘gsm_app_restart’
gnome-session-48.0/gnome-session/gsm-app.c:516:9: warning[-Wdeprecated-declarations]: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead
#  516 |         GTimeVal current_time;
#      |         ^~~~~~~~
/usr/include/glib-2.0/glib/gtypes.h:580:8: note: declared here
#  580 | struct _GTimeVal
#      |        ^~~~~~~~~
#  514|   {
#  515|           GsmAppPrivate *priv = gsm_app_get_instance_private (app);
#  516|->         GTimeVal current_time;
#  517|           g_debug ("Re-starting app: %s", priv->id);
#  518|   

Error: COMPILER_WARNING (CWE-477): [#def3]
gnome-session-48.0/gnome-session/gsm-app.c:519:9: warning[-Wdeprecated-declarations]: ‘g_get_current_time’ is deprecated: Use 'g_get_real_time' instead
#  519 |         g_get_current_time (&current_time);
#      |         ^~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/giochannel.h:35: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
/usr/include/glib-2.0/glib/gmain.h:825:8: note: declared here
#  825 | void   g_get_current_time                 (GTimeVal       *result);
#      |        ^~~~~~~~~~~~~~~~~~
#  517|           g_debug ("Re-starting app: %s", priv->id);
#  518|   
#  519|->         g_get_current_time (&current_time);
#  520|           if (priv->last_restart_time.tv_sec > 0
#  521|               && (current_time.tv_sec - priv->last_restart_time.tv_sec) < _GSM_APP_RESPAWN_RATELIMIT_SECONDS) {

Error: COMPILER_WARNING: [#def4]
gnome-session-48.0/gnome-session/gsm-client.c:530:1: warning[-Wenum-int-mismatch]: conflicting types for ‘gsm_client_query_end_session’ due to enum/integer mismatch; have ‘gboolean(GsmClient *, GsmClientEndSessionFlag,  GError **)’ {aka ‘int(struct _GsmClient *, GsmClientEndSessionFlag,  struct _GError **)’}
#  530 | gsm_client_query_end_session (GsmClient                *client,
#      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
gnome-session-48.0/gnome-session/gsm-client.c:22: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-client.h:115:23: note: previous declaration of ‘gsm_client_query_end_session’ with type ‘gboolean(GsmClient *, guint,  GError **)’ {aka ‘int(struct _GsmClient *, unsigned int,  struct _GError **)’}
#  115 | gboolean              gsm_client_query_end_session          (GsmClient  *client,
#      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  528|   
#  529|   gboolean
#  530|-> gsm_client_query_end_session (GsmClient                *client,
#  531|                                 GsmClientEndSessionFlag   flags,
#  532|                                 GError                  **error)

Error: COMPILER_WARNING: [#def5]
gnome-session-48.0/gnome-session/gsm-client.c:540:1: warning[-Wenum-int-mismatch]: conflicting types for ‘gsm_client_end_session’ due to enum/integer mismatch; have ‘gboolean(GsmClient *, GsmClientEndSessionFlag,  GError **)’ {aka ‘int(struct _GsmClient *, GsmClientEndSessionFlag,  struct _GError **)’}
#  540 | gsm_client_end_session (GsmClient                *client,
#      | ^~~~~~~~~~~~~~~~~~~~~~
gnome-session-48.0/gnome-session/gsm-client.h:112:23: note: previous declaration of ‘gsm_client_end_session’ with type ‘gboolean(GsmClient *, guint,  GError **)’ {aka ‘int(struct _GsmClient *, unsigned int,  struct _GError **)’}
#  112 | gboolean              gsm_client_end_session                (GsmClient  *client,
#      |                       ^~~~~~~~~~~~~~~~~~~~~~
#  538|   
#  539|   gboolean
#  540|-> gsm_client_end_session (GsmClient                *client,
#  541|                           GsmClientEndSessionFlag   flags,
#  542|                           GError                  **error)

Error: COMPILER_WARNING: [#def6]
gnome-session-48.0/gnome-session/gsm-fail-whale.c:27: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-fail-whale.h:18: warning[-Wheader-guard]: header guard ‘__GSM_FAIL_WHALE_H___’ followed by ‘#define’ of a different macro
#   18 | #ifndef __GSM_FAIL_WHALE_H___
gnome-session-48.0/gnome-session/gsm-fail-whale.h:19: note: ‘__GSM_FAIL_WHALE_H__’ is defined here; did you mean ‘__GSM_FAIL_WHALE_H___’?
#   19 | #define __GSM_FAIL_WHALE_H__
#   16|    */
#   17|   
#   18|-> #ifndef __GSM_FAIL_WHALE_H___
#   19|   #define __GSM_FAIL_WHALE_H__
#   20|   

Error: COMPILER_WARNING (CWE-477): [#def7]
gnome-session-48.0/gnome-session/gsm-inhibitor.c: scope_hint: In function ‘gsm_inhibitor_class_init’
gnome-session-48.0/gnome-session/gsm-inhibitor.c:604:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  604 |         g_type_class_add_private (klass, sizeof (GsmInhibitorPrivate));
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:31: included_from: Included from here.
/usr/include/glib-2.0/gobject/gtype.h:1503:10: note: declared here
# 1503 | void     g_type_class_add_private       (gpointer                    g_class,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~
#  602|                                                               G_PARAM_READWRITE | G_PARAM_CONSTRUCT));
#  603|   
#  604|->         g_type_class_add_private (klass, sizeof (GsmInhibitorPrivate));
#  605|   }
#  606|   

Error: COMPILER_WARNING (CWE-252): [#def8]
gnome-session-48.0/gnome-session/gsm-manager.c: scope_hint: In function ‘do_query_end_session_exit’
gnome-session-48.0/gnome-session/gsm-manager.c:3926:17: warning[-Wunused-result]: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’
# 3926 |                 system("/usr/sbin/grub2-set-bootflag boot_success");
#      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 3924|                    * initiated directly from gdm.
# 3925|                    */
# 3926|->                 system("/usr/sbin/grub2-set-bootflag boot_success");
# 3927|                   reboot = TRUE;
# 3928|                   break;

Error: COMPILER_WARNING (CWE-252): [#def9]
gnome-session-48.0/gnome-session/gsm-manager.c:3936:17: warning[-Wunused-result]: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’
# 3936 |                 system("/usr/sbin/grub2-set-bootflag boot_success");
#      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 3934|                    * initiated directly from gdm.
# 3935|                    */
# 3936|->                 system("/usr/sbin/grub2-set-bootflag boot_success");
# 3937|                   shutdown = TRUE;
# 3938|                   break;

Error: COMPILER_WARNING (CWE-477): [#def10]
gnome-session-48.0/gnome-session/gsm-presence.c: scope_hint: In function ‘gsm_presence_class_init’
gnome-session-48.0/gnome-session/gsm-presence.c:530:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  530 |         g_type_class_add_private (klass, sizeof (GsmPresencePrivate));
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:31: included_from: Included from here.
/usr/include/glib-2.0/gobject/gtype.h:1503:10: note: declared here
# 1503 | void     g_type_class_add_private       (gpointer                    g_class,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~
#  528|                                                               G_PARAM_READWRITE | G_PARAM_CONSTRUCT));
#  529|   
#  530|->         g_type_class_add_private (klass, sizeof (GsmPresencePrivate));
#  531|   }
#  532|   

Error: COMPILER_WARNING (CWE-477): [#def11]
gnome-session-48.0/gnome-session/gsm-shell-extensions.c: scope_hint: In function ‘gsm_shell_extensions_class_init’
gnome-session-48.0/gnome-session/gsm-shell-extensions.c:74:3: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#   74 |   g_type_class_add_private (object_class, sizeof (GsmShellExtensionsPrivate));
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:31: included_from: Included from here.
/usr/include/glib-2.0/glib-object.h:24: included_from: Included from here.
/usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-shell-extensions.c:25: included_from: Included from here.
/usr/include/glib-2.0/gobject/gtype.h:1503:10: note: declared here
# 1503 | void     g_type_class_add_private       (gpointer                    g_class,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~
#   72|     object_class = G_OBJECT_CLASS (klass);
#   73|     object_class->finalize = gsm_shell_extensions_finalize;
#   74|->   g_type_class_add_private (object_class, sizeof (GsmShellExtensionsPrivate));
#   75|   }
#   76|   

Error: COMPILER_WARNING (CWE-477): [#def12]
gnome-session-48.0/gnome-session/gsm-shell.c: scope_hint: In function ‘gsm_shell_class_init’
gnome-session-48.0/gnome-session/gsm-shell.c:182:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  182 |         g_type_class_add_private (shell_class, sizeof (GsmShellPrivate));
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:31: included_from: Included from here.
/usr/include/glib-2.0/glib-object.h:24: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-shell.c:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gtype.h:1503:10: note: declared here
# 1503 | void     g_type_class_add_private       (gpointer                    g_class,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~
#  180|                                 G_TYPE_NONE, 0);
#  181|   
#  182|->         g_type_class_add_private (shell_class, sizeof (GsmShellPrivate));
#  183|   }
#  184|   

Error: COMPILER_WARNING (CWE-477): [#def13]
gnome-session-48.0/gnome-session/gsm-store.c: scope_hint: In function ‘gsm_store_class_init’
gnome-session-48.0/gnome-session/gsm-store.c:360:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  360 |         g_type_class_add_private (klass, sizeof (GsmStorePrivate));
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:31: included_from: Included from here.
/usr/include/glib-2.0/glib-object.h:24: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-store.c:30: included_from: Included from here.
/usr/include/glib-2.0/gobject/gtype.h:1503:10: note: declared here
# 1503 | void     g_type_class_add_private       (gpointer                    g_class,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~
#  358|                                                                  G_PARAM_READWRITE | G_PARAM_CONSTRUCT));
#  359|   
#  360|->         g_type_class_add_private (klass, sizeof (GsmStorePrivate));
#  361|   }
#  362|   

Error: COMPILER_WARNING (CWE-477): [#def14]
gnome-session-48.0/gnome-session/gsm-systemd.c: scope_hint: In function ‘gsm_systemd_class_init’
gnome-session-48.0/gnome-session/gsm-systemd.c:163:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  163 |         g_type_class_add_private (manager_class, sizeof (GsmSystemdPrivate));
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:31: included_from: Included from here.
/usr/include/glib-2.0/glib-object.h:24: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-systemd.h:26: included_from: Included from here.
gnome-session-48.0/gnome-session/gsm-systemd.c:22: included_from: Included from here.
/usr/include/glib-2.0/gobject/gtype.h:1503:10: note: declared here
# 1503 | void     g_type_class_add_private       (gpointer                    g_class,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~
#  161|           g_object_class_override_property (object_class, PROP_ACTIVE, "active");
#  162|   
#  163|->         g_type_class_add_private (manager_class, sizeof (GsmSystemdPrivate));
#  164|   }
#  165|   

Error: COMPILER_WARNING (CWE-477): [#def15]
gnome-session-48.0/gnome-session/gsm-systemd.c: scope_hint: In function ‘gsm_systemd_can_switch_user’
gnome-session-48.0/gnome-session/gsm-systemd.c:592:9: warning[-Wdeprecated-declarations]: ‘sd_seat_can_multi_session’ is deprecated
#  592 |         ret = sd_seat_can_multi_session (seat);
#      |         ^~~
gnome-session-48.0/gnome-session/gsm-systemd.c:31: included_from: Included from here.
/usr/include/systemd/sd-login.h:214:5: note: declared here
#  214 | int sd_seat_can_multi_session(const char *seat) _sd_deprecated_;
#      |     ^~~~~~~~~~~~~~~~~~~~~~~~~
#  590|   
#  591|           sd_session_get_seat (manager->priv->session_id, &seat);
#  592|->         ret = sd_seat_can_multi_session (seat);
#  593|           free (seat);
#  594|   

Error: COMPILER_WARNING (CWE-704): [#def16]
gnome-session-48.0/gnome-session/gsm-systemd.c: scope_hint: In function ‘gsm_systemd_set_inhibitors’
gnome-session-48.0/gnome-session/gsm-systemd.c:958:52: warning[-Wdiscarded-qualifiers]: passing argument 2 of ‘gsm_systemd_call_inhibit’ discards ‘const’ qualifier from pointer target type
#  958 |                 gsm_systemd_call_inhibit (manager, locks);
#      |                                                    ^~~~~
gnome-session-48.0/gnome-session/gsm-systemd.c:918:39: note: expected ‘char *’ but argument is of type ‘const gchar *’ {aka ‘const char *’}
#  918 |                           char       *what)
#      |                           ~~~~~~~~~~~~^~~~
#  956|           if (locks != NULL) {
#  957|                   g_debug ("Adding system inhibitor on %s", locks);
#  958|->                 gsm_systemd_call_inhibit (manager, locks);
#  959|           } else {
#  960|                   drop_system_inhibitor (manager);

Error: COMPILER_WARNING (CWE-704): [#def17]
gnome-session-48.0/gnome-session/gsm-systemd.c: scope_hint: In function ‘gsm_systemd_reacquire_inhibitors’
gnome-session-48.0/gnome-session/gsm-systemd.c:970:52: warning[-Wdiscarded-qualifiers]: passing argument 2 of ‘gsm_systemd_call_inhibit’ discards ‘const’ qualifier from pointer target type
#  970 |                 gsm_systemd_call_inhibit (manager, locks);
#      |                                                    ^~~~~
gnome-session-48.0/gnome-session/gsm-systemd.c:918:39: note: expected ‘char *’ but argument is of type ‘const gchar *’ {aka ‘const char *’}
#  918 |                           char       *what)
#      |                           ~~~~~~~~~~~~^~~~
#  968|           if (locks != NULL) {
#  969|                   g_debug ("Reacquiring system inhibitor on %s", locks);
#  970|->                 gsm_systemd_call_inhibit (manager, locks);
#  971|           } else {
#  972|                   drop_system_inhibitor (manager);

Error: COMPILER_WARNING (CWE-477): [#def18]
gnome-session-48.0/gnome-session/gsm-xsmp-client.c: scope_hint: In function ‘gsm_xsmp_client_class_init’
gnome-session-48.0/gnome-session/gsm-xsmp-client.c:1041:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
# 1041 |         g_type_class_add_private (klass, sizeof (GsmXSMPClientPrivate));
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:26: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:31: included_from: Included from here.
/usr/include/glib-2.0/gobject/gtype.h:1503:10: note: declared here
# 1503 | void     g_type_class_add_private       (gpointer                    g_class,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~
# 1039|                                                                  G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
# 1040|   
# 1041|->         g_type_class_add_private (klass, sizeof (GsmXSMPClientPrivate));
# 1042|   }
# 1043|   

Error: CPPCHECK_WARNING (CWE-476): [#def19]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:424: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  422|           file_entry = malloc (sizeof (IceAuthFileEntry));
#  423|   
#  424|->         file_entry->protocol_name = strdup (protocol);
#  425|           file_entry->protocol_data = NULL;
#  426|           file_entry->protocol_data_length = 0;

Error: CPPCHECK_WARNING (CWE-476): [#def20]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:425: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  423|   
#  424|           file_entry->protocol_name = strdup (protocol);
#  425|->         file_entry->protocol_data = NULL;
#  426|           file_entry->protocol_data_length = 0;
#  427|           file_entry->network_id = strdup (network_id);

Error: CPPCHECK_WARNING (CWE-476): [#def21]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:426: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  424|           file_entry->protocol_name = strdup (protocol);
#  425|           file_entry->protocol_data = NULL;
#  426|->         file_entry->protocol_data_length = 0;
#  427|           file_entry->network_id = strdup (network_id);
#  428|           file_entry->auth_name = strdup (GSM_ICE_MAGIC_COOKIE_AUTH_NAME);

Error: CPPCHECK_WARNING (CWE-476): [#def22]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:427: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  425|           file_entry->protocol_data = NULL;
#  426|           file_entry->protocol_data_length = 0;
#  427|->         file_entry->network_id = strdup (network_id);
#  428|           file_entry->auth_name = strdup (GSM_ICE_MAGIC_COOKIE_AUTH_NAME);
#  429|           file_entry->auth_data = IceGenerateMagicCookie (GSM_ICE_MAGIC_COOKIE_LEN);

Error: CPPCHECK_WARNING (CWE-476): [#def23]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:428: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  426|           file_entry->protocol_data_length = 0;
#  427|           file_entry->network_id = strdup (network_id);
#  428|->         file_entry->auth_name = strdup (GSM_ICE_MAGIC_COOKIE_AUTH_NAME);
#  429|           file_entry->auth_data = IceGenerateMagicCookie (GSM_ICE_MAGIC_COOKIE_LEN);
#  430|           file_entry->auth_data_length = GSM_ICE_MAGIC_COOKIE_LEN;

Error: CPPCHECK_WARNING (CWE-476): [#def24]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:429: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  427|           file_entry->network_id = strdup (network_id);
#  428|           file_entry->auth_name = strdup (GSM_ICE_MAGIC_COOKIE_AUTH_NAME);
#  429|->         file_entry->auth_data = IceGenerateMagicCookie (GSM_ICE_MAGIC_COOKIE_LEN);
#  430|           file_entry->auth_data_length = GSM_ICE_MAGIC_COOKIE_LEN;
#  431|   

Error: CPPCHECK_WARNING (CWE-476): [#def25]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:430: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  428|           file_entry->auth_name = strdup (GSM_ICE_MAGIC_COOKIE_AUTH_NAME);
#  429|           file_entry->auth_data = IceGenerateMagicCookie (GSM_ICE_MAGIC_COOKIE_LEN);
#  430|->         file_entry->auth_data_length = GSM_ICE_MAGIC_COOKIE_LEN;
#  431|   
#  432|           /* Also create an in-memory copy, which is what the server will

Error: CPPCHECK_WARNING (CWE-476): [#def26]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:435: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  433|            * actually use for checking client auth.
#  434|            */
#  435|->         data_entry.protocol_name = file_entry->protocol_name;
#  436|           data_entry.network_id = file_entry->network_id;
#  437|           data_entry.auth_name = file_entry->auth_name;

Error: CPPCHECK_WARNING (CWE-476): [#def27]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:436: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  434|            */
#  435|           data_entry.protocol_name = file_entry->protocol_name;
#  436|->         data_entry.network_id = file_entry->network_id;
#  437|           data_entry.auth_name = file_entry->auth_name;
#  438|           data_entry.auth_data = file_entry->auth_data;

Error: CPPCHECK_WARNING (CWE-476): [#def28]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:437: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  435|           data_entry.protocol_name = file_entry->protocol_name;
#  436|           data_entry.network_id = file_entry->network_id;
#  437|->         data_entry.auth_name = file_entry->auth_name;
#  438|           data_entry.auth_data = file_entry->auth_data;
#  439|           data_entry.auth_data_length = file_entry->auth_data_length;

Error: CPPCHECK_WARNING (CWE-476): [#def29]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:438: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  436|           data_entry.network_id = file_entry->network_id;
#  437|           data_entry.auth_name = file_entry->auth_name;
#  438|->         data_entry.auth_data = file_entry->auth_data;
#  439|           data_entry.auth_data_length = file_entry->auth_data_length;
#  440|           IceSetPaAuthData (1, &data_entry);

Error: CPPCHECK_WARNING (CWE-476): [#def30]
gnome-session-48.0/gnome-session/gsm-xsmp-server.c:439: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: file_entry
#  437|           data_entry.auth_name = file_entry->auth_name;
#  438|           data_entry.auth_data = file_entry->auth_data;
#  439|->         data_entry.auth_data_length = file_entry->auth_data_length;
#  440|           IceSetPaAuthData (1, &data_entry);
#  441|   

Error: COMPILER_WARNING (CWE-477): [#def31]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-app.c:40:9: warning[-Wdeprecated-declarations]: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead
#   38|           char            *startup_id;
#   39|           gboolean         registered;
#   40|->         GTimeVal         last_restart_time;
#   41|           GDBusConnection *connection;
#   42|           GsmExportedApp  *skeleton;

Error: COMPILER_WARNING (CWE-477): [#def32]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-app.c:516:9: warning[-Wdeprecated-declarations]: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead
#  514|   {
#  515|           GsmAppPrivate *priv = gsm_app_get_instance_private (app);
#  516|->         GTimeVal current_time;
#  517|           g_debug ("Re-starting app: %s", priv->id);
#  518|   

Error: COMPILER_WARNING (CWE-477): [#def33]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-app.c:519:9: warning[-Wdeprecated-declarations]: ‘g_get_current_time’ is deprecated: Use 'g_get_real_time' instead
#  517|           g_debug ("Re-starting app: %s", priv->id);
#  518|   
#  519|->         g_get_current_time (&current_time);
#  520|           if (priv->last_restart_time.tv_sec > 0
#  521|               && (current_time.tv_sec - priv->last_restart_time.tv_sec) < _GSM_APP_RESPAWN_RATELIMIT_SECONDS) {

Error: COMPILER_WARNING: [#def34]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-inhibitor.c:243:27: warning[warning]: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
#  241|   gsm_inhibitor_init (GsmInhibitor *inhibitor)
#  242|   {
#  243|->         inhibitor->priv = GSM_INHIBITOR_GET_PRIVATE (inhibitor);
#  244|   }
#  245|   

Error: COMPILER_WARNING (CWE-477): [#def35]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-inhibitor.c:604:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  602|                                                               G_PARAM_READWRITE | G_PARAM_CONSTRUCT));
#  603|   
#  604|->         g_type_class_add_private (klass, sizeof (GsmInhibitorPrivate));
#  605|   }
#  606|   

Error: COMPILER_WARNING: [#def36]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-presence.c:396:26: warning[warning]: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
#  394|   gsm_presence_init (GsmPresence *presence)
#  395|   {
#  396|->         presence->priv = GSM_PRESENCE_GET_PRIVATE (presence);
#  397|   
#  398|           presence->priv->idle_monitor = gnome_idle_monitor_new ();

Error: COMPILER_WARNING (CWE-477): [#def37]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-presence.c:530:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  528|                                                               G_PARAM_READWRITE | G_PARAM_CONSTRUCT));
#  529|   
#  530|->         g_type_class_add_private (klass, sizeof (GsmPresencePrivate));
#  531|   }
#  532|   

Error: COMPILER_WARNING (CWE-477): [#def38]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-shell-extensions.c:74:3: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#   72|     object_class = G_OBJECT_CLASS (klass);
#   73|     object_class->finalize = gsm_shell_extensions_finalize;
#   74|->   g_type_class_add_private (object_class, sizeof (GsmShellExtensionsPrivate));
#   75|   }
#   76|   

Error: COMPILER_WARNING: [#def39]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-shell-extensions.c:169:16: warning[warning]: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
#  167|     GSettingsSchema *schema;
#  168|   
#  169|->   self->priv = SHELL_EXTENSIONS_PRIVATE (self);
#  170|   
#  171|     source = g_settings_schema_source_get_default ();

Error: COMPILER_WARNING (CWE-477): [#def40]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-shell.c:182:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  180|                                 G_TYPE_NONE, 0);
#  181|   
#  182|->         g_type_class_add_private (shell_class, sizeof (GsmShellPrivate));
#  183|   }
#  184|   

Error: COMPILER_WARNING: [#def41]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-shell.c:222:23: warning[warning]: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
#  220|   gsm_shell_init (GsmShell *shell)
#  221|   {
#  222|->         shell->priv = GSM_SHELL_GET_PRIVATE (shell);
#  223|   
#  224|           gsm_shell_ensure_connection (shell);

Error: COMPILER_WARNING (CWE-477): [#def42]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-store.c:360:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  358|                                                                  G_PARAM_READWRITE | G_PARAM_CONSTRUCT));
#  359|   
#  360|->         g_type_class_add_private (klass, sizeof (GsmStorePrivate));
#  361|   }
#  362|   

Error: COMPILER_WARNING: [#def43]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-store.c:374:23: warning[warning]: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
#  372|   {
#  373|   
#  374|->         store->priv = GSM_STORE_GET_PRIVATE (store);
#  375|   
#  376|           store->priv->objects = g_hash_table_new_full (g_str_hash,

Error: COMPILER_WARNING (CWE-477): [#def44]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-systemd.c:163:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
#  161|           g_object_class_override_property (object_class, PROP_ACTIVE, "active");
#  162|   
#  163|->         g_type_class_add_private (manager_class, sizeof (GsmSystemdPrivate));
#  164|   }
#  165|   

Error: COMPILER_WARNING: [#def45]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-systemd.c:373:25: warning[warning]: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
#  371|           GVariant *res;
#  372|   
#  373|->         manager->priv = G_TYPE_INSTANCE_GET_PRIVATE (manager,
#  374|                                                        GSM_TYPE_SYSTEMD,
#  375|                                                        GsmSystemdPrivate);

Error: COMPILER_WARNING (CWE-477): [#def46]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-systemd.c:592:9: warning[-Wdeprecated-declarations]: ‘sd_seat_can_multi_session’ is deprecated
#  590|   
#  591|           sd_session_get_seat (manager->priv->session_id, &seat);
#  592|->         ret = sd_seat_can_multi_session (seat);
#  593|           free (seat);
#  594|   

Error: COMPILER_WARNING (CWE-704): [#def47]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-systemd.c:958:52: warning[-Wdiscarded-qualifiers]: passing argument 2 of ‘gsm_systemd_call_inhibit’ discards ‘const’ qualifier from pointer target type
#  956|           if (locks != NULL) {
#  957|                   g_debug ("Adding system inhibitor on %s", locks);
#  958|->                 gsm_systemd_call_inhibit (manager, locks);
#  959|           } else {
#  960|                   drop_system_inhibitor (manager);

Error: COMPILER_WARNING (CWE-704): [#def48]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-systemd.c:970:52: warning[-Wdiscarded-qualifiers]: passing argument 2 of ‘gsm_systemd_call_inhibit’ discards ‘const’ qualifier from pointer target type
#  968|           if (locks != NULL) {
#  969|                   g_debug ("Reacquiring system inhibitor on %s", locks);
#  970|->                 gsm_systemd_call_inhibit (manager, locks);
#  971|           } else {
#  972|                   drop_system_inhibitor (manager);

Error: COMPILER_WARNING: [#def49]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-xsmp-client.c:199:24: warning[warning]: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
#  197|   gsm_xsmp_client_init (GsmXSMPClient *client)
#  198|   {
#  199|->         client->priv = GSM_XSMP_CLIENT_GET_PRIVATE (client);
#  200|   
#  201|           client->priv->props = g_ptr_array_new ();

Error: COMPILER_WARNING (CWE-477): [#def50]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-xsmp-client.c:1041:9: warning[-Wdeprecated-declarations]: ‘g_type_class_add_private’ is deprecated
# 1039|                                                                  G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
# 1040|   
# 1041|->         g_type_class_add_private (klass, sizeof (GsmXSMPClientPrivate));
# 1042|   }
# 1043|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def51]
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-xsmp-server.c:424:9: warning[-Wanalyzer-possible-null-dereference]: dereference of possibly-NULL ‘file_entry’
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-xsmp-server.c:422:22: acquire_memory: this call could return NULL
gnome-session-48.0/redhat-linux-build/../gnome-session/gsm-xsmp-server.c:424:9: danger: ‘file_entry’ could be NULL: unchecked value from [(1)](sarif:/runs/0/results/0/codeFlows/0/threadFlows/0/locations/0)
#  422|           file_entry = malloc (sizeof (IceAuthFileEntry));
#  423|   
#  424|->         file_entry->protocol_name = strdup (protocol);
#  425|           file_entry->protocol_data = NULL;
#  426|           file_entry->protocol_data_length = 0;

Error: COMPILER_WARNING (CWE-477): [#def52]
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-check-accelerated-gles-helper.c:103:9: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_push’ is deprecated: Use 'gdk_x11_display_error_trap_push' instead
#  101|           char *renderer = NULL;
#  102|   
#  103|->         gdk_error_trap_push ();
#  104|   
#  105|           display = GDK_DISPLAY_XDISPLAY (gdk_display_get_default ());

Error: COMPILER_WARNING (CWE-477): [#def53]
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-check-accelerated-gles-helper.c:187:9: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_pop_ignored’ is deprecated: Use 'gdk_x11_display_error_trap_pop_ignored' instead
#  185|                   XDestroyWindow (display, win);
#  186|   
#  187|->         gdk_error_trap_pop_ignored ();
#  188|           return renderer;
#  189|   }

Error: COMPILER_WARNING: [#def54]
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-ctl.c:153:9: warning[warning]: Deprecated pre-processor symbol: replace with "g_main_loop_quit"
#  151|           MonitorLeader *data = (MonitorLeader*) user_data;
#  152|   
#  153|->         g_main_quit (data->loop);
#  154|   
#  155|           return G_SOURCE_REMOVE;

Error: GCC_ANALYZER_WARNING (CWE-910): [#def55]
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:316:7: warning[-Wanalyzer-fd-use-after-close]: ‘write’ on closed file descriptor ‘pipefd[1]’
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:279:6: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:286:9: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:287:6: branch_false: following ‘false’ branch (when ‘pid >= 0’)...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:293:6: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:293:6: branch_false: following ‘false’ branch (when ‘pid != 0’)...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:307:3: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:312:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:316:7: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:317:7: release_resource: closed here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:318:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:324:11: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:324:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:327:39: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:327:14: branch_true: following ‘true’ branch...
 branch_true: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:312:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:316:7: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:316:7: danger: ‘write’ on closed file descriptor ‘pipefd[1]’; ‘close’ was at [(12)](sarif:/runs/0/results/0/codeFlows/0/threadFlows/0/locations/11)
#  314|             tcsetpgrp (0, pid);
#  315|           }
#  316|->       write(pipefd[1], "\0", 1);
#  317|         close(pipefd[1]);
#  318|         if (waitpid (pid, &status, 0) == -1)

Error: GCC_ANALYZER_WARNING (CWE-1341): [#def56]
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:317:7: warning[-Wanalyzer-fd-double-close]: double ‘close’ of file descriptor ‘pipefd[1]’
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:279:6: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:286:9: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:287:6: branch_false: following ‘false’ branch (when ‘pid >= 0’)...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:293:6: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:293:6: branch_false: following ‘false’ branch (when ‘pid != 0’)...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:307:3: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:312:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:316:7: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:317:7: release_resource: first ‘close’ here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:318:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:324:11: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:324:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:327:39: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:327:14: branch_true: following ‘true’ branch...
 branch_true: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:312:10: branch_false: following ‘false’ branch...
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:316:7: branch_false: ...to here
gnome-session-48.0/redhat-linux-build/../tools/gnome-session-inhibit.c:317:7: danger: second ‘close’ here; first ‘close’ was at [(12)](sarif:/runs/0/results/1/codeFlows/0/threadFlows/0/locations/11)
#  315|           }
#  316|         write(pipefd[1], "\0", 1);
#  317|->       close(pipefd[1]);
#  318|         if (waitpid (pid, &status, 0) == -1)
#  319|           {

Error: COMPILER_WARNING (CWE-477): [#def57]
gnome-session-48.0/tools/gnome-session-check-accelerated-gles-helper.c: scope_hint: In function ‘get_gles_renderer’
gnome-session-48.0/tools/gnome-session-check-accelerated-gles-helper.c:103:9: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_push’ is deprecated: Use 'gdk_x11_display_error_trap_push' instead
#  103 |         gdk_error_trap_push ();
#      |         ^~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdk.h:50: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
gnome-session-48.0/tools/gnome-session-check-accelerated-gles-helper.c:29: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkmain.h:70:32: note: declared here
#   70 | void                           gdk_error_trap_push        (void);
#      |                                ^~~~~~~~~~~~~~~~~~~
#  101|           char *renderer = NULL;
#  102|   
#  103|->         gdk_error_trap_push ();
#  104|   
#  105|           display = GDK_DISPLAY_XDISPLAY (gdk_display_get_default ());

Error: COMPILER_WARNING (CWE-477): [#def58]
gnome-session-48.0/tools/gnome-session-check-accelerated-gles-helper.c:187:9: warning[-Wdeprecated-declarations]: ‘gdk_error_trap_pop_ignored’ is deprecated: Use 'gdk_x11_display_error_trap_pop_ignored' instead
#  187 |         gdk_error_trap_pop_ignored ();
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkmain.h:75:32: note: declared here
#   75 | void                           gdk_error_trap_pop_ignored (void);
#      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~
#  185|                   XDestroyWindow (display, win);
#  186|   
#  187|->         gdk_error_trap_pop_ignored ();
#  188|           return renderer;
#  189|   }

Error: COMPILER_WARNING (CWE-252): [#def59]
gnome-session-48.0/tools/gnome-session-ctl.c: scope_hint: In function ‘leader_fifo_io_cb’
gnome-session-48.0/tools/gnome-session-ctl.c:169:17: warning[-Wunused-result]: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’
#  169 |                 read (data->fifo_fd, buf, 1);
#      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  167|           if (condition & G_IO_IN) {
#  168|                   char buf[1];
#  169|->                 read (data->fifo_fd, buf, 1);
#  170|                   g_main_loop_quit (data->loop);
#  171|           }

Error: COMPILER_WARNING (CWE-252): [#def60]
gnome-session-48.0/tools/gnome-session-inhibit.c: scope_hint: In function ‘wait_for_child_app’
gnome-session-48.0/tools/gnome-session-inhibit.c:316:7: warning[-Wunused-result]: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’
#  316 |       write(pipefd[1], "\0", 1);
#      |       ^~~~~~~~~~~~~~~~~~~~~~~~~
#  314|             tcsetpgrp (0, pid);
#  315|           }
#  316|->       write(pipefd[1], "\0", 1);
#  317|         close(pipefd[1]);
#  318|         if (waitpid (pid, &status, 0) == -1)

Scan Properties