Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-477): [#def1]
gnome-shell-48.0/redhat-linux-build/../subprojects/shew/src/shew-external-window-x11.c:66:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_error_trap_push’ is deprecated
#   64|     XWindowAttributes attrs;
#   65|   
#   66|->   gdk_x11_display_error_trap_push (display);
#   67|     result = XGetWindowAttributes (GDK_DISPLAY_XDISPLAY (display), xid, &attrs);
#   68|     if (gdk_x11_display_error_trap_pop (display))

Error: COMPILER_WARNING (CWE-477): [#def2]
gnome-shell-48.0/redhat-linux-build/../subprojects/shew/src/shew-external-window-x11.c:67:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_get_xdisplay’ is deprecated
#   65|   
#   66|     gdk_x11_display_error_trap_push (display);
#   67|->   result = XGetWindowAttributes (GDK_DISPLAY_XDISPLAY (display), xid, &attrs);
#   68|     if (gdk_x11_display_error_trap_pop (display))
#   69|       return FALSE;

Error: COMPILER_WARNING (CWE-477): [#def3]
gnome-shell-48.0/redhat-linux-build/../subprojects/shew/src/shew-external-window-x11.c:68:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_error_trap_pop’ is deprecated
#   66|     gdk_x11_display_error_trap_push (display);
#   67|     result = XGetWindowAttributes (GDK_DISPLAY_XDISPLAY (display), xid, &attrs);
#   68|->   if (gdk_x11_display_error_trap_pop (display))
#   69|       return FALSE;
#   70|   

Error: COMPILER_WARNING (CWE-477): [#def4]
gnome-shell-48.0/redhat-linux-build/../subprojects/shew/src/shew-external-window-x11.c:119:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_get_xdisplay’ is deprecated
#  117|   
#  118|   #ifdef GDK_WINDOWING_X11
#  119|->   XSetTransientForHint (GDK_SURFACE_XDISPLAY (child_surface),
#  120|                           GDK_SURFACE_XID (child_surface),
#  121|                           external_window_x11->foreign_xid);

Error: COMPILER_WARNING (CWE-477): [#def5]
gnome-shell-48.0/redhat-linux-build/../subprojects/shew/src/shew-external-window-x11.c:120:25: warning[-Wdeprecated-declarations]: ‘gdk_x11_surface_get_xid’ is deprecated
#  118|   #ifdef GDK_WINDOWING_X11
#  119|     XSetTransientForHint (GDK_SURFACE_XDISPLAY (child_surface),
#  120|->                         GDK_SURFACE_XID (child_surface),
#  121|                           external_window_x11->foreign_xid);
#  122|   #endif

Error: COMPILER_WARNING (CWE-477): [#def6]
gnome-shell-48.0/redhat-linux-build/../subprojects/shew/src/shew-window-exporter.c:94:7: warning[-Wdeprecated-declarations]: ‘gdk_x11_surface_get_xid’ is deprecated
#   92|       {
#   93|         GdkSurface *s = gtk_native_get_surface (GTK_NATIVE (widget));
#   94|->       guint32 xid = (guint32) gdk_x11_surface_get_xid (s);
#   95|   
#   96|         g_task_return_pointer (task, g_strdup_printf ("x11:%x", xid), g_free);

Error: COMPILER_WARNING (CWE-477): [#def7]
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c: scope_hint: In function ‘check_foreign_xid’
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c:66:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_error_trap_push’ is deprecated
#   66 |   gdk_x11_display_error_trap_push (display);
#      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gdk/x11/gdkx.h:39: included_from: Included from here.
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c:24: included_from: Included from here.
/usr/include/gtk-4.0/gdk/x11/gdkx11display.h:120:32: note: declared here
#  120 | void                           gdk_x11_display_error_trap_push        (GdkDisplay *display);
#      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   64|     XWindowAttributes attrs;
#   65|   
#   66|->   gdk_x11_display_error_trap_push (display);
#   67|     result = XGetWindowAttributes (GDK_DISPLAY_XDISPLAY (display), xid, &attrs);
#   68|     if (gdk_x11_display_error_trap_pop (display))

Error: COMPILER_WARNING (CWE-477): [#def8]
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c:67:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_get_xdisplay’ is deprecated
#   67 |   result = XGetWindowAttributes (GDK_DISPLAY_XDISPLAY (display), xid, &attrs);
#      |   ^~~~~~
/usr/include/gtk-4.0/gdk/x11/gdkx11display.h:60:15: note: declared here
#   60 | Display *     gdk_x11_display_get_xdisplay     (GdkDisplay  *display);
#      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   65|   
#   66|     gdk_x11_display_error_trap_push (display);
#   67|->   result = XGetWindowAttributes (GDK_DISPLAY_XDISPLAY (display), xid, &attrs);
#   68|     if (gdk_x11_display_error_trap_pop (display))
#   69|       return FALSE;

Error: COMPILER_WARNING (CWE-477): [#def9]
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c:68:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_error_trap_pop’ is deprecated
#   68 |   if (gdk_x11_display_error_trap_pop (display))
#      |   ^~
/usr/include/gtk-4.0/gdk/x11/gdkx11display.h:123:32: note: declared here
#  123 | G_GNUC_WARN_UNUSED_RESULT int  gdk_x11_display_error_trap_pop         (GdkDisplay *display);
#      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   66|     gdk_x11_display_error_trap_push (display);
#   67|     result = XGetWindowAttributes (GDK_DISPLAY_XDISPLAY (display), xid, &attrs);
#   68|->   if (gdk_x11_display_error_trap_pop (display))
#   69|       return FALSE;
#   70|   

Error: COMPILER_WARNING (CWE-477): [#def10]
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c: scope_hint: In function ‘shew_external_window_x11_set_parent_of’
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c:119:3: warning[-Wdeprecated-declarations]: ‘gdk_x11_display_get_xdisplay’ is deprecated
#  119 |   XSetTransientForHint (GDK_SURFACE_XDISPLAY (child_surface),
#      |   ^~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gdk/x11/gdkx11display.h:60:15: note: declared here
#   60 | Display *     gdk_x11_display_get_xdisplay     (GdkDisplay  *display);
#      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  117|   
#  118|   #ifdef GDK_WINDOWING_X11
#  119|->   XSetTransientForHint (GDK_SURFACE_XDISPLAY (child_surface),
#  120|                           GDK_SURFACE_XID (child_surface),
#  121|                           external_window_x11->foreign_xid);

Error: COMPILER_WARNING (CWE-477): [#def11]
gnome-shell-48.0/subprojects/shew/src/shew-external-window-x11.c:120:25: warning[-Wdeprecated-declarations]: ‘gdk_x11_surface_get_xid’ is deprecated
#  120 |                         GDK_SURFACE_XID (child_surface),
#      |                         ^~~~~~~~~~~~~~~
/usr/include/gtk-4.0/gdk/x11/gdkx.h:47: included_from: Included from here.
/usr/include/gtk-4.0/gdk/x11/gdkx11surface.h:56:10: note: declared here
#   56 | Window   gdk_x11_surface_get_xid           (GdkSurface   *surface);
#      |          ^~~~~~~~~~~~~~~~~~~~~~~
#  118|   #ifdef GDK_WINDOWING_X11
#  119|     XSetTransientForHint (GDK_SURFACE_XDISPLAY (child_surface),
#  120|->                         GDK_SURFACE_XID (child_surface),
#  121|                           external_window_x11->foreign_xid);
#  122|   #endif

Error: COMPILER_WARNING (CWE-477): [#def12]
gnome-shell-48.0/subprojects/shew/src/shew-window-exporter.c: scope_hint: In function ‘shew_window_exporter_export’
gnome-shell-48.0/subprojects/shew/src/shew-window-exporter.c:94:7: warning[-Wdeprecated-declarations]: ‘gdk_x11_surface_get_xid’ is deprecated
#   94 |       guint32 xid = (guint32) gdk_x11_surface_get_xid (s);
#      |       ^~~~~~~
/usr/include/gtk-4.0/gdk/x11/gdkx.h:47: included_from: Included from here.
gnome-shell-48.0/subprojects/shew/src/shew-window-exporter.c:24: included_from: Included from here.
/usr/include/gtk-4.0/gdk/x11/gdkx11surface.h:56:10: note: declared here
#   56 | Window   gdk_x11_surface_get_xid           (GdkSurface   *surface);
#      |          ^~~~~~~~~~~~~~~~~~~~~~~
#   92|       {
#   93|         GdkSurface *s = gtk_native_get_surface (GTK_NATIVE (widget));
#   94|->       guint32 xid = (guint32) gdk_x11_surface_get_xid (s);
#   95|   
#   96|         g_task_return_pointer (task, g_strdup_printf ("x11:%x", xid), g_free);

Scan Properties

analyzer-version-clippy1.86.0
analyzer-version-cppcheck2.17.1
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.86.0
diffbase-analyzer-version-cppcheck2.17.1
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-117.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namegnome-shell-48.1-2.fc43
diffbase-store-results-to/tmp/tmpuayn731m/gnome-shell-48.1-2.fc43.tar.xz
diffbase-time-created2025-04-25 12:48:12
diffbase-time-finished2025-04-25 12:52:14
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpuayn731m/gnome-shell-48.1-2.fc43.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpuayn731m/gnome-shell-48.1-2.fc43.src.rpm'
diffbase-tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-117.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namegnome-shell-48.0-1.fc42
store-results-to/tmp/tmpot8_t6s4/gnome-shell-48.0-1.fc42.tar.xz
time-created2025-04-25 12:43:22
time-finished2025-04-25 12:47:51
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpot8_t6s4/gnome-shell-48.0-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpot8_t6s4/gnome-shell-48.0-1.fc42.src.rpm'
tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9