gnome-software-48.1-1.fc43

List of Findings

Error: CPPCHECK_WARNING (CWE-758): [#def1]
gnome-software-48.1/lib/gs-plugin-types.h:169: error[shiftTooManyBitsSigned]: Shifting signed 32-bit value by 31 bits is undefined behaviour
#  167|   	GS_PLUGIN_REFINE_FLAGS_REQUIRE_DEVELOPER_NAME	= 1 << 29,
#  168|   	GS_PLUGIN_REFINE_FLAGS_REQUIRE_KUDOS		= 1 << 30,
#  169|-> 	GS_PLUGIN_REFINE_FLAGS_REQUIRE_CONTENT_RATING	= 1 << 31,
#  170|   	GS_PLUGIN_REFINE_FLAGS_MASK			= ~0,
#  171|   } GsPluginRefineFlags;

Error: CPPCHECK_WARNING (CWE-457): [#def2]
gnome-software-48.1/plugins/dkms/gs-dkms-helper.c:40: error[legacyUninitvar]: Uninitialized variable: key_filename
#   38|   
#   39|   	/* FIXME: use the return code instead of text parsing once the https://github.com/lcp/mokutil/issues/88 is addressed */
#   40|-> 	not_found_output = g_strconcat (key_filename, " not found\n", NULL);
#   41|   	not_enrolled_output = g_strconcat (key_filename, " is not enrolled\n", NULL);
#   42|   	pending_output = g_strconcat (key_filename, " is already in the enrollment request\n", NULL);

Error: GCC_ANALYZER_WARNING (CWE-688): [#def3]
gnome-software-48.1/redhat-linux-build/../lib/gs-app-query.c:148:21: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
gnome-software-48.1/redhat-linux-build/../lib/gs-app-query.c:131:1: enter_function: entry to ‘gs_app_query_sanitize_keywords’
gnome-software-48.1/redhat-linux-build/../lib/gs-app-query.c:136:12: branch_false: following ‘false’ branch...
gnome-software-48.1/redhat-linux-build/../lib/gs-app-query.c:142:12: branch_false: following ‘false’ branch...
gnome-software-48.1/redhat-linux-build/../lib/gs-app-query.c:146:42: branch_false: ...to here
gnome-software-48.1/redhat-linux-build/../lib/gs-app-query.c:148:21: danger: argument 1 (‘<unknown>’) NULL where non-null expected
#argument 1 of ‘__builtin_strchr’ must be non-null
#  146|   		g_autofree gchar *term = g_strdup (terms[0]);
#  147|   		g_strstrip (term);
#  148|-> 		if (strchr (term, ' ')) {
#  149|   			g_auto(GStrv) split = g_strsplit (term, " ", -1);
#  150|   			for (guint i = 0; split[i] != NULL; i++) {

Error: GCC_ANALYZER_WARNING (CWE-688): [#def4]
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:119:41: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:504:1: enter_function: entry to ‘gs_category_get_property’
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:525:17: call_function: calling ‘gs_category_get_size’ from ‘gs_category_get_property’
#  117|   
#  118|   	/* The ‘all’ subcategory is a bit special. */
#  119|-> 	if (category->parent != NULL && g_str_equal (gs_category_get_id (category), "all"))
#  120|   		return gs_category_get_size (category->parent);
#  121|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:716:47: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:678:1: enter_function: entry to ‘gs_category_new_for_desktop_data’
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:688:27: branch_true: following ‘true’ branch...
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:690:45: branch_true: ...to here
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:694:17: call_function: calling ‘gs_category_add_child’ from ‘gs_category_new_for_desktop_data’
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:694:17: return_function: returning to ‘gs_category_new_for_desktop_data’ from ‘gs_category_add_child’
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:702:12: branch_true: following ‘true’ branch (when ‘subcategory_all’ is non-NULL)...
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:703:17: branch_true: ...to here
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:703:17: branch_true: following ‘true’ branch...
 branch_true: ...to here
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:705:35: branch_true: following ‘true’ branch...
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:710:33: branch_true: ...to here
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:711:28: branch_false: following ‘false’ branch (when ‘subcategory_all != child’)...
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:715:42: branch_false: ...to here
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:715:42: call_function: calling ‘gs_category_get_desktop_groups’ from ‘gs_category_new_for_desktop_data’
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:715:42: return_function: returning to ‘gs_category_new_for_desktop_data’ from ‘gs_category_get_desktop_groups’
gnome-software-48.1/redhat-linux-build/../lib/gs-category.c:716:47: danger: dereference of NULL ‘gs_category_get_desktop_groups(child)’
#  714|   			/* add all desktop groups */
#  715|   			desktop_groups = gs_category_get_desktop_groups (child);
#  716|-> 			for (guint j = 0; j < desktop_groups->len; j++) {
#  717|   				const gchar *tmp = g_ptr_array_index (desktop_groups, j);
#  718|   				gs_category_add_desktop_group (subcategory_all, tmp);

Error: GCC_ANALYZER_WARNING (CWE-457): [#def6]
gnome-software-48.1/redhat-linux-build/../lib/gs-profiler.h:99:33: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘*head.description’
gnome-software-48.1/redhat-linux-build/../plugins/flatpak/gs-plugin-flatpak.c:671:1: enter_function: entry to ‘refine_thread_cb’
gnome-software-48.1/redhat-linux-build/../plugins/flatpak/gs-plugin-flatpak.c:686:9: branch_true: following ‘true’ branch...
 branch_true: ...to here
gnome-software-48.1/redhat-linux-build/../plugins/flatpak/gs-plugin-flatpak.c:688:27: branch_true: following ‘true’ branch...
gnome-software-48.1/redhat-linux-build/../plugins/flatpak/gs-plugin-flatpak.c:689:30: branch_true: ...to here
gnome-software-48.1/redhat-linux-build/../plugins/flatpak/gs-plugin-flatpak.c:690:22: call_function: calling ‘refine_app’ from ‘refine_thread_cb’
#   97|   				"gnome-software",
#   98|   				head->name,
#   99|-> 				head->description);
#  100|   
#  101|   	g_clear_pointer (&head->name, g_free);

Error: CPPCHECK_WARNING (CWE-457): [#def7]
gnome-software-48.1/src/gs-app-context-bar.c:891: error[legacyUninitvar]: Uninitialized variable: dialog
#  889|   		g_assert_not_reached ();
#  890|   
#  891|-> 	adw_dialog_present (dialog, GTK_WIDGET (self));
#  892|   
#  893|   }

Error: CPPCHECK_WARNING (CWE-457): [#def8]
gnome-software-48.1/src/gs-dkms-dialog.c:135: error[legacyUninitvar]: Uninitialized variable: key_kind
#  133|   		g_assert_not_reached ();
#  134|   
#  135|-> 	gs_dkms_enroll_async (key_kind, self->password, self->cancellable, gs_dkms_dialog_enrolled_cb, g_steal_pointer (&task));
#  136|   }
#  137|   

Error: CPPCHECK_WARNING (CWE-457): [#def9]
gnome-software-48.1/src/gs-updates-paused-banner.c:95: error[legacyUninitvar]: Uninitialized variable: title
#   93|   	}
#   94|   
#   95|-> 	adw_banner_set_title (ADW_BANNER (self->banner), title);
#   96|   }
#   97|   

Scan Properties

analyzer-version-clippy1.86.0
analyzer-version-cppcheck2.17.1
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-235.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namegnome-software-48.1-1.fc43
store-results-to/tmp/tmpiuj6afjh/gnome-software-48.1-1.fc43.tar.xz
time-created2025-04-25 12:52:14
time-finished2025-04-25 12:59:02
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpiuj6afjh/gnome-software-48.1-1.fc43.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpiuj6afjh/gnome-software-48.1-1.fc43.src.rpm'
tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9