go-rpm-macros-3.6.0-7.fc43

List of Findings

Error: SHELLCHECK_WARNING: [#def1]
/usr/bin/go-rpm-integration:36:1: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#   34|   arguments are optional.
#   35|   
#   36|-> “install”-specific arguments:
#   37|   
#   38|   -i <go import path>  is a mandatory argument

Error: SHELLCHECK_WARNING: [#def2]
/usr/bin/go-rpm-integration:36:9: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#   34|   arguments are optional.
#   35|   
#   36|-> “install”-specific arguments:
#   37|   
#   38|   -i <go import path>  is a mandatory argument

Error: SHELLCHECK_WARNING: [#def3]
/usr/bin/go-rpm-integration:50:1: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#   48|                        can be specified several times
#   49|   
#   50|-> “check”-specific arguments:
#   51|   
#   52|   -i <go import path>  is a mandatory argument

Error: SHELLCHECK_WARNING: [#def4]
/usr/bin/go-rpm-integration:50:7: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#   48|                        can be specified several times
#   49|   
#   50|-> “check”-specific arguments:
#   51|   
#   52|   -i <go import path>  is a mandatory argument

Error: SHELLCHECK_WARNING: [#def5]
/usr/bin/go-rpm-integration:62:1: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#   60|                        specified
#   61|   
#   62|-> “provides”-specific arguments:
#   63|   
#   64|   -v <version string>: tag the provides with <version string>

Error: SHELLCHECK_WARNING: [#def6]
/usr/bin/go-rpm-integration:62:10: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#   60|                        specified
#   61|   
#   62|-> “provides”-specific arguments:
#   63|   
#   64|   -v <version string>: tag the provides with <version string>

Error: SHELLCHECK_WARNING: [#def7]
/usr/bin/go-rpm-integration:104:28: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  102|   Error: Attempt to install to multiple Go import paths. Aborting…
#  103|   
#  104|-> The installation target of “$0 install” is a unique Go import
#  105|   path tree. Some of the presets rpm passes to this command in the %install stage
#  106|   rely on this unicity.

Error: SHELLCHECK_WARNING: [#def8]
/usr/bin/go-rpm-integration:104:39: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  102|   Error: Attempt to install to multiple Go import paths. Aborting…
#  103|   
#  104|-> The installation target of “$0 install” is a unique Go import
#  105|   path tree. Some of the presets rpm passes to this command in the %install stage
#  106|   rely on this unicity.

Error: SHELLCHECK_WARNING: [#def9]
/usr/bin/go-rpm-integration:120:4: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  118|      removing alternative leftovers (usually done, in the %prep stage of rpm)
#  119|    — and only then deploy the result to the canonical import path using
#  120|->    “$0 install -i <canonical-import-path>”
#  121|   
#  122|   You MAY use symbolic links to maintain compatibility with codebases that refer

Error: SHELLCHECK_WARNING: [#def10]
/usr/bin/go-rpm-integration:120:42: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  118|      removing alternative leftovers (usually done, in the %prep stage of rpm)
#  119|    — and only then deploy the result to the canonical import path using
#  120|->    “$0 install -i <canonical-import-path>”
#  121|   
#  122|   You MAY use symbolic links to maintain compatibility with codebases that refer

Error: SHELLCHECK_WARNING: [#def11]
/usr/bin/go-rpm-integration:137:4: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  135|      reference changed to the alternative name
#  136|    — and only then deploy, from this separate copy, to the alternative name
#  137|->    “$0 install -i <alternative-import-path> \
#  138|                                  -s <separate-source>”
#  139|   

Error: SHELLCHECK_WARNING: [#def12]
/usr/bin/go-rpm-integration:138:52: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  136|    — and only then deploy, from this separate copy, to the alternative name
#  137|      “$0 install -i <alternative-import-path> \
#  138|->                                -s <separate-source>”
#  139|   
#  140|   This later pattern is not recommended as it helps entrenching naming confusion.

Error: SHELLCHECK_WARNING: [#def13]
/usr/bin/go-rpm-integration:149:1: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  147|   Error: Attempt to overwrite an existing installation. Aborting…
#  148|   
#  149|-> “$0 install” aims at deploying clean Go source project files in
#  150|   the %install stage of rpm.
#  151|   

Error: SHELLCHECK_WARNING: [#def14]
/usr/bin/go-rpm-integration:149:12: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  147|   Error: Attempt to overwrite an existing installation. Aborting…
#  148|   
#  149|-> “$0 install” aims at deploying clean Go source project files in
#  150|   the %install stage of rpm.
#  151|   

Error: SHELLCHECK_WARNING: [#def15]
/usr/bin/go-rpm-integration:153:34: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  151|   
#  152|   You SHOULD have prepared the project files in the rpm %prep stage and resolved
#  153|-> any file conflict before calling “$0 install”. That means a
#  154|   specific Go import path is usually deployed in a single call.
#  155|   

Error: SHELLCHECK_WARNING: [#def16]
/usr/bin/go-rpm-integration:153:45: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  151|   
#  152|   You SHOULD have prepared the project files in the rpm %prep stage and resolved
#  153|-> any file conflict before calling “$0 install”. That means a
#  154|   specific Go import path is usually deployed in a single call.
#  155|   

Error: SHELLCHECK_WARNING: [#def17]
/usr/bin/go-rpm-integration:157:1: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  155|   
#  156|   If you wish to deploy the same import path using multiple
#  157|-> “$0 install” calls you MUST make sure they use consistent
#  158|   versionning and exclusion arguments. Those arguments are recorded on disk to
#  159|   allow reliable provides computation in later rpm stages.

Error: SHELLCHECK_WARNING: [#def18]
/usr/bin/go-rpm-integration:157:12: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  155|   
#  156|   If you wish to deploy the same import path using multiple
#  157|-> “$0 install” calls you MUST make sure they use consistent
#  158|   versionning and exclusion arguments. Those arguments are recorded on disk to
#  159|   allow reliable provides computation in later rpm stages.

Error: SHELLCHECK_WARNING: [#def19]
/usr/bin/go-rpm-integration:162:17: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  160|   
#  161|   If used outside rpm, you MUST ensure some other way no conflicting installation
#  162|-> already exists. “$0 install” has no way to remove cleanly such
#  163|   an installation. Installing blindly over another deployment would leave in
#  164|   place, all the files, not present in the new installation, resulting in an

Error: SHELLCHECK_WARNING: [#def20]
/usr/bin/go-rpm-integration:162:28: warning[SC1111]: This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).
#  160|   
#  161|   If used outside rpm, you MUST ensure some other way no conflicting installation
#  162|-> already exists. “$0 install” has no way to remove cleanly such
#  163|   an installation. Installing blindly over another deployment would leave in
#  164|   place, all the files, not present in the new installation, resulting in an

Error: SHELLCHECK_WARNING (CWE-563): [#def21]
/usr/bin/go-rpm-integration:175:1: warning[SC2034]: goldflags appears unused. Verify use (or export if used externally).
#  173|   sourcedir="${PWD}"
#  174|   bindir="${GO_BUILD_DIR:-${PWD}/_build}"
#  175|-> goldflags=''
#  176|   gopath=/usr/share/gocode
#  177|   filelist='devel.file-list'

Error: SHELLCHECK_WARNING (CWE-456): [#def22]
/usr/bin/go-rpm-integration:191:1: warning[SC2209]: Use var=$(command) to assign output (or quote to assign string).
#  189|   iflags_e=()
#  190|   vinstall=install
#  191|-> vln=ln
#  192|   
#  193|   if [[ $# -eq 0 ]] ; then

Error: SHELLCHECK_WARNING (CWE-563): [#def23]
/usr/bin/go-rpm-integration:242:37: warning[SC2034]: ldflags appears unused. Verify use (or export if used externally).
#  240|       -o|--output)                    filelist="${2}"               ; shift;;
#  241|       -O|--output-root)               filelistroot="${2}"           ; shift;;
#  242|->     -l|--ldflags)                   ldflags="${2}"                ; shift;;
#  243|       -V|--version)                   imetadata["version"]="${2}"   ; shift;;
#  244|       -T|--tag)                       imetadata["tag"]="${2}"       ; shift;;

Error: SHELLCHECK_WARNING (CWE-88): [#def24]
/usr/bin/go-rpm-integration:287:6: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  285|   
#  286|   expandflags() {
#  287|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  288|   }
#  289|   

Error: SHELLCHECK_WARNING (CWE-88): [#def25]
/usr/bin/go-rpm-integration:287:27: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  285|   
#  286|   expandflags() {
#  287|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  288|   }
#  289|   

Error: SHELLCHECK_WARNING (CWE-88): [#def26]
/usr/bin/go-rpm-integration:287:48: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  285|   
#  286|   expandflags() {
#  287|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  288|   }
#  289|   

Error: SHELLCHECK_WARNING (CWE-88): [#def27]
/usr/bin/go-rpm-integration:287:69: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  285|   
#  286|   expandflags() {
#  287|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  288|   }
#  289|   

Error: SHELLCHECK_WARNING (CWE-571): [#def28]
/usr/bin/go-rpm-integration:347:7: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  345|   done
#  346|   file=$(realpath -sm "${file}")
#  347|-> local workdir="$(realpath -sm .)"
#  348|   if [[ ${file}/ == ${workdir}/* ]] ; then
#  349|     local dest="${prefix}${gopath}/src/${goipath}${file#${workdir}}"

Error: SHELLCHECK_WARNING (CWE-571): [#def29]
/usr/bin/go-rpm-integration:353:7: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  351|     local dest="${prefix}${file}"
#  352|   fi
#  353|-> local destdir=$(dirname "${dest}")
#  354|   if [[ ! -d "${destdir}" ]] ; then
#  355|     installfile "${goipath}" "${destdir#${prefix}}"

Error: SHELLCHECK_WARNING (CWE-156): [#def30]
/usr/bin/go-rpm-integration:362:15: warning[SC2046]: Quote this to prevent word splitting.
#  360|   else
#  361|     if [[ -L "${file}" ]] ; then
#  362|->     ${vln} -s $(readlink "${file}") "${dest}"
#  363|       touch -h -r          "${file}"  "${dest}"
#  364|     else

Error: SHELLCHECK_WARNING (CWE-156): [#def31]
/usr/bin/go-rpm-integration:382:49: warning[SC2046]: Quote this to prevent word splitting.
#  380|   local goipath="${1}"
#  381|   GOPATH="${sourcedir}" GO111MODULE=off \
#  382|->   golist --to-install --package-path ${goipath} $(expandflags)
#  383|   }
#  384|   

Error: SHELLCHECK_WARNING (CWE-156): [#def32]
/usr/bin/go-rpm-integration:388:60: warning[SC2046]: Quote this to prevent word splitting.
#  386|   local goipath="${1}"
#  387|   GOPATH="${workroot}${GOPATH+:${GOPATH}}" GO111MODULE=off \
#  388|->   golist --provided --with-tests --package-path ${goipath} $(expandflags) |\
#  389|       while read -r -d $'\n' dir ; do
#  390|         pushd "${workroot}/src/${dir}" >/dev/null

Error: SHELLCHECK_WARNING (CWE-156): [#def33]
/usr/bin/go-rpm-integration:405:51: warning[SC2046]: Quote this to prevent word splitting.
#  403|     echo "golang-ipath(${goipath})"
#  404|     GOPATH="${prefix}${gopath}" GO111MODULE=off \
#  405|->     golist --provided --package-path "${goipath}" $(expandflags) \
#  406|              --skip-self --template 'golang({{.}})\n'
#  407|   ) | while IFS= read -r prov ; do

Error: SHELLCHECK_WARNING (CWE-156): [#def34]
/usr/bin/go-rpm-integration:419:44: warning[SC2046]: Quote this to prevent word splitting.
#  417|   requires() {
#  418|   GOPATH="${prefix}${gopath}" GO111MODULE=off \
#  419|->   golist --imported  --package-path "${1}" $(expandflags) \
#  420|            --skip-self --template 'golang({{.}})\n'
#  421|   }

Error: SHELLCHECK_WARNING (CWE-88): [#def35]
/usr/lib/rpm/gosymlink.deps:120:6: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  118|   
#  119|   expandflags() {
#  120|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  121|   }
#  122|   

Error: SHELLCHECK_WARNING (CWE-88): [#def36]
/usr/lib/rpm/gosymlink.deps:120:27: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  118|   
#  119|   expandflags() {
#  120|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  121|   }
#  122|   

Error: SHELLCHECK_WARNING (CWE-88): [#def37]
/usr/lib/rpm/gosymlink.deps:120:48: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  118|   
#  119|   expandflags() {
#  120|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  121|   }
#  122|   

Error: SHELLCHECK_WARNING (CWE-88): [#def38]
/usr/lib/rpm/gosymlink.deps:120:69: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#  118|   
#  119|   expandflags() {
#  120|-> echo ${flags_d[@]/#/ -d } ${flags_t[@]/#/ -t } ${flags_r[@]/#/ -r } ${flags_e[@]/#/ -e }
#  121|   }
#  122|   

Error: SHELLCHECK_WARNING (CWE-156): [#def39]
/usr/lib/rpm/gosymlink.deps:128:51: warning[SC2046]: Quote this to prevent word splitting.
#  126|     echo "golang-symlink(${goipath})"
#  127|     GOPATH="${prefix}${gopath}" GO111MODULE=off \
#  128|->     golist --provided --package-path "${goipath}" $(expandflags) \
#  129|              --skip-self --template 'golang({{.}})\n'
#  130|   ) | while IFS= read -r prov ; do

Error: SHELLCHECK_WARNING (CWE-571): [#def40]
/usr/lib/rpm/gosymlink.deps:147:9: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  145|   # Resolve a symlink target in presence of a build root
#  146|   resolvelink() {
#  147|->   local lt=$(realpath -m "$1")
#  148|     echo "${prefix}${lt#${prefix}}"
#  149|   }

Error: SHELLCHECK_WARNING (CWE-571): [#def41]
/usr/lib/rpm/gosymlink.deps:181:9: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  179|   processlink() {
#  180|     local link="$1"
#  181|->   local nexttarget=$(resolvelink "${link}")
#  182|     local linktarget=$(ultimateresolvelink "${nexttarget}")
#  183|     if isgopathdir "${linktarget}" ; then

Error: SHELLCHECK_WARNING (CWE-571): [#def42]
/usr/lib/rpm/gosymlink.deps:182:9: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  180|     local link="$1"
#  181|     local nexttarget=$(resolvelink "${link}")
#  182|->   local linktarget=$(ultimateresolvelink "${nexttarget}")
#  183|     if isgopathdir "${linktarget}" ; then
#  184|       local lockdir=$(findlockdir "${linktarget}")

Error: SHELLCHECK_WARNING (CWE-571): [#def43]
/usr/lib/rpm/gosymlink.deps:184:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  182|     local linktarget=$(ultimateresolvelink "${nexttarget}")
#  183|     if isgopathdir "${linktarget}" ; then
#  184|->     local lockdir=$(findlockdir "${linktarget}")
#  185|       [[ -e "${lockdir}/.goipath" ]] && readmetadata "${lockdir}/.goipath"
#  186|       case ${action} in

Scan Properties