Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-401): [#def1]
guestfs-tools-1.53.8/common/mltools/../options/keys.c:266:1: warning[-Wanalyzer-malloc-leak]: leak of ‘key.<Ua320>.string.s’
guestfs-tools-1.53.8/common/mltools/../options/keys.c:218:1: enter_function: entry to ‘key_store_add_from_selector’
guestfs-tools-1.53.8/common/mltools/../options/keys.c:225:6: branch_false: following ‘false’ branch...
guestfs-tools-1.53.8/common/mltools/../options/keys.c:227:17: branch_false: ...to here
guestfs-tools-1.53.8/common/mltools/../options/keys.c:230:6: branch_false: following ‘false’ branch...
guestfs-tools-1.53.8/common/mltools/../options/keys.c:232:12: branch_false: ...to here
guestfs-tools-1.53.8/common/mltools/../options/keys.c:233:6: branch_false: following ‘false’ branch...
guestfs-tools-1.53.8/common/mltools/../options/keys.c:237:6: branch_false: ...to here
guestfs-tools-1.53.8/common/mltools/../options/keys.c:237:6: branch_false: following ‘false’ branch...
guestfs-tools-1.53.8/common/mltools/../options/keys.c:240:7: branch_false: ...to here
guestfs-tools-1.53.8/common/mltools/../options/keys.c:242:8: branch_false: following ‘false’ branch...
guestfs-tools-1.53.8/common/mltools/../options/keys.c:246:34: branch_false: ...to here
guestfs-tools-1.53.8/common/mltools/../options/keys.c:246:20: acquire_memory: allocated here
guestfs-tools-1.53.8/common/mltools/../options/keys.c:247:8: branch_false: following ‘false’ branch...
guestfs-tools-1.53.8/common/mltools/../options/keys.c:265:10: branch_false: ...to here
guestfs-tools-1.53.8/common/mltools/../options/keys.c:265:10: call_function: calling ‘key_store_import_key’ from ‘key_store_add_from_selector’
guestfs-tools-1.53.8/common/mltools/../options/keys.c:265:10: return_function: returning to ‘key_store_add_from_selector’ from ‘key_store_import_key’
guestfs-tools-1.53.8/common/mltools/../options/keys.c:266:1: danger: ‘key.<Ua320>.string.s’ leaks here; was allocated at [(12)](sarif:/runs/0/results/0/codeFlows/0/threadFlows/0/locations/11)
#  264|   
#  265|     return key_store_import_key (ks, &key);
#  266|-> }
#  267|   
#  268|   /* Turn /dev/mapper/VG-LV into /dev/VG/LV, in-place. */

Error: GCC_ANALYZER_WARNING (CWE-401): [#def2]
guestfs-tools-1.53.8/common/options/keys.c:266:1: warning[-Wanalyzer-malloc-leak]: leak of 'key.<U2320>.string.s'
guestfs-tools-1.53.8/common/options/keys.c:218:1: enter_function: entry to 'key_store_add_from_selector'
guestfs-tools-1.53.8/common/options/keys.c:225:6: branch_false: following 'false' branch...
guestfs-tools-1.53.8/common/options/keys.c:227:17: branch_false: ...to here
guestfs-tools-1.53.8/common/options/keys.c:230:6: branch_false: following 'false' branch...
guestfs-tools-1.53.8/common/options/keys.c:232:12: branch_false: ...to here
guestfs-tools-1.53.8/common/options/keys.c:233:6: branch_false: following 'false' branch...
guestfs-tools-1.53.8/common/options/keys.c:237:6: branch_false: ...to here
guestfs-tools-1.53.8/common/options/keys.c:237:6: branch_false: following 'false' branch...
guestfs-tools-1.53.8/common/options/keys.c:240:7: branch_false: ...to here
guestfs-tools-1.53.8/common/options/keys.c:242:8: branch_false: following 'false' branch...
guestfs-tools-1.53.8/common/options/keys.c:246:34: branch_false: ...to here
guestfs-tools-1.53.8/common/options/keys.c:246:20: acquire_memory: allocated here
guestfs-tools-1.53.8/common/options/keys.c:247:8: branch_false: following 'false' branch...
guestfs-tools-1.53.8/common/options/keys.c:265:10: branch_false: ...to here
guestfs-tools-1.53.8/common/options/keys.c:265:10: call_function: calling 'key_store_import_key' from 'key_store_add_from_selector'
guestfs-tools-1.53.8/common/options/keys.c:265:10: return_function: returning to 'key_store_add_from_selector' from 'key_store_import_key'
guestfs-tools-1.53.8/common/options/keys.c:266:1: danger: 'key.<U2320>.string.s' leaks here; was allocated at [(12)](sarif:/runs/0/results/0/codeFlows/0/threadFlows/0/locations/11)
#  264|   
#  265|     return key_store_import_key (ks, &key);
#  266|-> }
#  267|   
#  268|   /* Turn /dev/mapper/VG-LV into /dev/VG/LV, in-place. */

Scan Properties

analyzer-version-clippy1.86.0
analyzer-version-cppcheck2.17.1
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.86.0
diffbase-analyzer-version-cppcheck2.17.1
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-86.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameguestfs-tools-1.53.9-1.fc43
diffbase-store-results-to/tmp/tmpwfdm_s26/guestfs-tools-1.53.9-1.fc43.tar.xz
diffbase-time-created2025-04-25 12:59:47
diffbase-time-finished2025-04-25 13:02:36
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpwfdm_s26/guestfs-tools-1.53.9-1.fc43.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpwfdm_s26/guestfs-tools-1.53.9-1.fc43.src.rpm'
diffbase-tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-86.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-nameguestfs-tools-1.53.8-1.fc42
store-results-to/tmp/tmphzjsyrn8/guestfs-tools-1.53.8-1.fc42.tar.xz
time-created2025-04-25 12:56:00
time-finished2025-04-25 12:59:34
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmphzjsyrn8/guestfs-tools-1.53.8-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmphzjsyrn8/guestfs-tools-1.53.8-1.fc42.src.rpm'
tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9