Fixed findings

List of Findings

Error: COMPILER_WARNING: [#def1]
kexec-tools-2.0.30/kexec/arch/i386/crashdump-x86.c: scope_hint: In function ‘cmdline_add_efi’
kexec-tools-2.0.30/kexec/arch/i386/crashdump-x86.c:787:49: warning[-Wformat=]: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’}
#  787 |         sprintf(acpi_rsdp_buf, " acpi_rsdp=0x%llx", acpi_rsdp);
#      |                                              ~~~^   ~~~~~~~~~
#      |                                                 |   |
#      |                                                 |   uint64_t {aka long unsigned int}
#      |                                                 long long unsigned int
#      |                                              %lx
#  785|   		return;
#  786|   
#  787|-> 	sprintf(acpi_rsdp_buf, " acpi_rsdp=0x%llx", acpi_rsdp);
#  788|   	if (strlen(cmdline) + strlen(acpi_rsdp_buf) > (COMMAND_LINE_SIZE - 1))
#  789|   		die("Command line overflow\n");

Error: COMPILER_WARNING: [#def2]
kexec-tools-2.0.30/kexec/arch/i386/kexec-x86-common.c: scope_hint: In function ‘efi_get_acpi_rsdp’
kexec-tools-2.0.30/kexec/arch/i386/kexec-x86-common.c:425:41: warning[-Wformat=]: format ‘%llx’ expects argument of type ‘long long unsigned int *’, but argument 3 has type ‘uint64_t *’ {aka ‘long unsigned int *’}
#  425 |                         sscanf(s, "0x%llx", &acpi_rsdp);
#      |                                      ~~~^   ~~~~~~~~~~
#      |                                         |   |
#      |                                         |   uint64_t * {aka long unsigned int *}
#      |                                         long long unsigned int *
#      |                                      %lx
#  423|   		if ((strstr(line, "ACPI20=")) || (strstr(line, "ACPI="))) {
#  424|   			s = strchr(line, '=') + 1;
#  425|-> 			sscanf(s, "0x%llx", &acpi_rsdp);
#  426|   			break;
#  427|   		}

Error: COMPILER_WARNING: [#def3]
kexec-tools-2.0.30/kexec/arch/i386/x86-linux-setup.c:37: included_from: Included from here.
kexec-tools-2.0.30/kexec/arch/i386/x86-linux-setup.c: scope_hint: In function ‘add_e820_map_from_mr’
kexec-tools-2.0.30/kexec/arch/i386/x86-linux-setup.c:763:27: warning[-Wformat=]: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’}
#  763 |                 dbgprintf("%016llx-%016llx (%d)\n",
#      |                           ^~~~~~~~~~~~~~~~~~~~~~~~
#  764 |                                 e820[i].addr,
#      |                                 ~~~~~~~~~~~~
#      |                                        |
#      |                                        uint64_t {aka long unsigned int}
kexec-tools-2.0.30/kexec/kexec.h:123:33: note: in definition of macro ‘dbgprintf’
#  123 |                 fprintf(stderr, __VA_ARGS__); \
#      |                                 ^~~~~~~~~~~
kexec-tools-2.0.30/kexec/arch/i386/x86-linux-setup.c:763:34: note: format string is defined here
#  763 |                 dbgprintf("%016llx-%016llx (%d)\n",
#      |                            ~~~~~~^
#      |                                  |
#      |                                  long long unsigned int
#      |                            %016lx
#  761|   				break;
#  762|   		}
#  763|-> 		dbgprintf("%016llx-%016llx (%d)\n",
#  764|   				e820[i].addr,
#  765|   				e820[i].addr + e820[i].size - 1,

Error: COMPILER_WARNING: [#def4]
kexec-tools-2.0.30/kexec/arch/i386/x86-linux-setup.c:763:27: warning[-Wformat=]: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’ {aka ‘long unsigned int’}
#  763 |                 dbgprintf("%016llx-%016llx (%d)\n",
#      |                           ^~~~~~~~~~~~~~~~~~~~~~~~
#  764 |                                 e820[i].addr,
#  765 |                                 e820[i].addr + e820[i].size - 1,
#      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#      |                                                             |
#      |                                                             uint64_t {aka long unsigned int}
kexec-tools-2.0.30/kexec/kexec.h:123:33: note: in definition of macro ‘dbgprintf’
#  123 |                 fprintf(stderr, __VA_ARGS__); \
#      |                                 ^~~~~~~~~~~
kexec-tools-2.0.30/kexec/arch/i386/x86-linux-setup.c:763:42: note: format string is defined here
#  763 |                 dbgprintf("%016llx-%016llx (%d)\n",
#      |                                    ~~~~~~^
#      |                                          |
#      |                                          long long unsigned int
#      |                                    %016lx
#  761|   				break;
#  762|   		}
#  763|-> 		dbgprintf("%016llx-%016llx (%d)\n",
#  764|   				e820[i].addr,
#  765|   				e820[i].addr + e820[i].size - 1,

Error: COMPILER_WARNING: [#def5]
kexec-tools-2.0.30/util_lib/elf_info.c: scope_hint: In function ‘dump_dmesg_structured’
kexec-tools-2.0.30/util_lib/elf_info.c:893:65: warning[-Wformat=]: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’}
#  893 |                                 fprintf(stderr, "log_buf = 0x%llx, idx = 0x%x\n",
#      |                                                              ~~~^
#      |                                                                 |
#      |                                                                 long long unsigned int
#      |                                                              %lx
#  894 |                                         log_buf, current_idx);
#      |                                         ~~~~~~~                  
#      |                                         |
#      |                                         uint64_t {aka long unsigned int}
#  891|   				fprintf(stderr, "Cycle when parsing dmesg detected.\n");
#  892|   				fprintf(stderr, "The prink log_buf is most likely corrupted.\n");
#  893|-> 				fprintf(stderr, "log_buf = 0x%llx, idx = 0x%x\n",
#  894|   					log_buf, current_idx);
#  895|   				exit(68);

Error: COMPILER_WARNING: [#def6]
kexec-tools-2.0.30/util_lib/elf_info.c:907:65: warning[-Wformat=]: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’}
#  907 |                                 fprintf(stderr, "log_buf = 0x%llx, idx = 0x%x\n",
#      |                                                              ~~~^
#      |                                                                 |
#      |                                                                 long long unsigned int
#      |                                                              %lx
#  908 |                                         log_buf, current_idx);
#      |                                         ~~~~~~~                  
#      |                                         |
#      |                                         uint64_t {aka long unsigned int}
#  905|   				fprintf(stderr, "Index outside log_buf detected.\n");
#  906|   				fprintf(stderr, "The prink log_buf is most likely corrupted.\n");
#  907|-> 				fprintf(stderr, "log_buf = 0x%llx, idx = 0x%x\n",
#  908|   					log_buf, current_idx);
#  909|   				exit(69);

Scan Properties

analyzer-version-clippy1.86.0
analyzer-version-cppcheck2.17.1
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.86.0
diffbase-analyzer-version-cppcheck2.17.1
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-246.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namekexec-tools-2.0.31-1.fc43
diffbase-store-results-to/tmp/tmpmc4t1n22/kexec-tools-2.0.31-1.fc43.tar.xz
diffbase-time-created2025-04-25 13:15:13
diffbase-time-finished2025-04-25 13:16:33
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpmc4t1n22/kexec-tools-2.0.31-1.fc43.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpmc4t1n22/kexec-tools-2.0.31-1.fc43.src.rpm'
diffbase-tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-246.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namekexec-tools-2.0.30-3.fc42
store-results-to/tmp/tmp20vb3rf4/kexec-tools-2.0.30-3.fc42.tar.xz
time-created2025-04-25 13:13:10
time-finished2025-04-25 13:14:53
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmp20vb3rf4/kexec-tools-2.0.30-3.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmp20vb3rf4/kexec-tools-2.0.30-3.fc42.src.rpm'
tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9