Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-457): [#def1]
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:150:23: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘dev’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:57:5: enter_function: entry to ‘solidigm_get_telemetry_log’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:91:12: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:95:13: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:95:12: branch_true: following ‘true’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:96:34: branch_true: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:98:12: branch_true: following ‘true’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:99:21: branch_true: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:99:20: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:104:46: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:106:23: call_function: calling ‘read_file2buffer’ from ‘solidigm_get_telemetry_log’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:106:23: return_function: returning to ‘solidigm_get_telemetry_log’ from ‘read_file2buffer’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:110:12: branch_false: following ‘false’ branch (when ‘err == 0’)...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:113:13: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:113:12: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:119:13: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:119:12: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:145:14: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:145:12: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:150:23: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:150:23: danger: use of uninitialized value ‘dev’ here
#  148|   		__u8 mdts = 0;
#  149|   
#  150|-> 		err = nvme_get_telemetry_max(dev_fd(dev), NULL, &max_data_tx);
#  151|   		if (err < 0) {
#  152|   			SOLIDIGM_LOG_WARNING("identify_ctrl: %s",

Error: GCC_ANALYZER_WARNING (CWE-457): [#def2]
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:187:26: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘dev’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:57:5: enter_function: entry to ‘solidigm_get_telemetry_log’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:91:12: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:95:13: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:95:12: branch_true: following ‘true’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:96:34: branch_true: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:98:12: branch_true: following ‘true’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:99:21: branch_true: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:99:20: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:104:46: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:106:23: call_function: calling ‘read_file2buffer’ from ‘solidigm_get_telemetry_log’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:106:23: return_function: returning to ‘solidigm_get_telemetry_log’ from ‘read_file2buffer’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:110:12: branch_false: following ‘false’ branch (when ‘err == 0’)...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:113:13: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:113:12: branch_true: following ‘true’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:114:17: branch_true: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:185:12: branch_false: following ‘false’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:187:26: branch_false: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry.c:187:26: danger: use of uninitialized value ‘dev’ here
#  185|   	if (!cfg.is_input_file) {
#  186|   		/* Redundant close() to make static code analysis happy */
#  187|-> 		close(dev->direct.fd);
#  188|   		dev_close(dev);
#  189|   	}

Error: GCC_ANALYZER_WARNING (CWE-457): [#def3]
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry/data-area.c:173:26: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘array_size_dimension[0]’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry/data-area.c:456:5: enter_function: entry to ‘solidigm_telemetry_log_data_areas_parse’
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry/data-area.c:464:12: branch_true: following ‘true’ branch...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry/data-area.c:465:17: branch_true: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry/data-area.c:468:71: branch_true: following ‘true’ branch (when ‘da <= last_da’)...
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry/data-area.c:469:25: branch_true: ...to here
nvme-cli-2.12/redhat-linux-build/../plugins/solidigm/solidigm-telemetry/data-area.c:469:25: call_function: calling ‘telemetry_log_data_area_toc_parse’ from ‘solidigm_telemetry_log_data_areas_parse’
#  171|   	}
#  172|   	if (array_rank > 1) {
#  173|-> 		uint32_t linear_pos_per_index = array_size_dimension[0];
#  174|   		uint32_t prev_index_offset_bit = 0;
#  175|   		struct json_object *dimension_output;

Scan Properties

analyzer-version-clippy1.86.0
analyzer-version-cppcheck2.17.1
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.86.0
diffbase-analyzer-version-cppcheck2.17.1
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-124.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namenvme-cli-2.13-1.fc43
diffbase-store-results-to/tmp/tmpc5z_homa/nvme-cli-2.13-1.fc43.tar.xz
diffbase-time-created2025-04-25 14:35:19
diffbase-time-finished2025-04-25 14:37:47
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpc5z_homa/nvme-cli-2.13-1.fc43.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpc5z_homa/nvme-cli-2.13-1.fc43.src.rpm'
diffbase-tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-124.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namenvme-cli-2.12-1.fc42
store-results-to/tmp/tmpum4e8isn/nvme-cli-2.12-1.fc42.tar.xz
time-created2025-04-25 14:32:13
time-finished2025-04-25 14:35:07
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpum4e8isn/nvme-cli-2.12-1.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpum4e8isn/nvme-cli-2.12-1.fc42.src.rpm'
tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9