plasma-desktop-6.3.4-1.fc43

List of Findings

Error: SHELLCHECK_WARNING (CWE-156): [#def1]
/usr/share/sddm/themes/01-breeze-fedora/Messages.sh:2:11: warning[SC2046]: Quote this to prevent word splitting.
#    1|   #! /usr/bin/env bash
#    2|-> $XGETTEXT `find . -name \*.qml` -L Java -o $podir/plasma-desktop-sddm-theme.pot

Error: SHELLCHECK_WARNING (CWE-457): [#def2]
/usr/share/sddm/themes/01-breeze-fedora/Messages.sh:2:44: warning[SC2154]: podir is referenced but not assigned.
#    1|   #! /usr/bin/env bash
#    2|-> $XGETTEXT `find . -name \*.qml` -L Java -o $podir/plasma-desktop-sddm-theme.pot

Error: SHELLCHECK_WARNING (CWE-156): [#def3]
/usr/share/sddm/themes/breeze/Messages.sh:2:11: warning[SC2046]: Quote this to prevent word splitting.
#    1|   #! /usr/bin/env bash
#    2|-> $XGETTEXT `find . -name \*.qml` -L Java -o $podir/plasma-desktop-sddm-theme.pot

Error: SHELLCHECK_WARNING (CWE-457): [#def4]
/usr/share/sddm/themes/breeze/Messages.sh:2:44: warning[SC2154]: podir is referenced but not assigned.
#    1|   #! /usr/bin/env bash
#    2|-> $XGETTEXT `find . -name \*.qml` -L Java -o $podir/plasma-desktop-sddm-theme.pot

Error: COMPILER_WARNING: [#def5]
plasma-desktop-6.3.4/applets/kimpanel/backend/scim/main.cpp: scope_hint: In function ‘int main(int, char**)’
plasma-desktop-6.3.4/applets/kimpanel/backend/scim/main.cpp:1112:26: warning[-Wzero-as-null-pointer-constant]: zero as null pointer constant
# 1112 |     new_argv[new_argc] = 0;
#      |                          ^
# 1110|       }
# 1111|   
# 1112|->     new_argv[new_argc] = 0;
# 1113|   
# 1114|       if (!config_name.length()) {

Error: COMPILER_WARNING (CWE-477): [#def6]
plasma-desktop-6.3.4/containments/desktop/plugins/folder/eventgenerator.cpp: scope_hint: In member function ‘void EventGenerator::sendMouseEvent(QQuickItem*, MouseEvent, int, int, int, Qt::MouseButtons, Qt::KeyboardModifiers)’
plasma-desktop-6.3.4/containments/desktop/plugins/folder/eventgenerator.cpp:49:102: warning[-Wdeprecated-declarations]: ‘QMouseEvent::QMouseEvent(QEvent::Type, const QPointF&, Qt::MouseButton, Qt::MouseButtons, Qt::KeyboardModifiers, const QPointingDevice*)’ is deprecated: Use another constructor
#   49 |     QMouseEvent ev(eventType, QPointF(x, y), static_cast<Qt::MouseButton>(button), buttons, modifiers);
#      |                                                                                                      ^
/usr/include/qt6/QtQuick/qquickitem.h:14: included_from: Included from here.
/usr/include/qt6/QtQuick/QQuickItem:1: included_from: Included from here.
plasma-desktop-6.3.4/containments/desktop/plugins/folder/eventgenerator.cpp:11: included_from: Included from here.
/usr/include/qt6/QtGui/qevent.h:202:5: note: declared here
#  202 |     QMouseEvent(Type type, const QPointF &localPos, Qt::MouseButton button,
#      |     ^~~~~~~~~~~
#   47|           return;
#   48|       }
#   49|->     QMouseEvent ev(eventType, QPointF(x, y), static_cast<Qt::MouseButton>(button), buttons, modifiers);
#   50|   
#   51|       QGuiApplication::sendEvent(item, &ev);

Error: COMPILER_WARNING (CWE-569): [#def7]
plasma-desktop-6.3.4/containments/desktop/plugins/folder/shortcut.cpp: scope_hint: In member function ‘virtual bool ShortCut::eventFilter(QObject*, QEvent*)’
plasma-desktop-6.3.4/containments/desktop/plugins/folder/shortcut.cpp:30:50: warning[-Wparentheses]: suggest parentheses around arithmetic in operand of ‘|’
#   30 |         const int keyInt = keyEvent->modifiers() & ~Qt::KeypadModifier | keyEvent->key();
#      |                            ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
#   28|       if (e->type() == QEvent::KeyPress) {
#   29|           QKeyEvent *keyEvent = static_cast<QKeyEvent *>(e);
#   30|->         const int keyInt = keyEvent->modifiers() & ~Qt::KeypadModifier | keyEvent->key();
#   31|           if (KStandardShortcut::deleteFile().contains(QKeySequence(keyInt))) {
#   32|               Q_EMIT deleteFile();

Error: COMPILER_WARNING (CWE-1164): [#def8]
plasma-desktop-6.3.4/kcms/dateandtime/k4timezonewidget.cpp:59:13: warning[-Wunused-function]: ‘bool localeLessThan(const QString&, const QString&)’ defined but not used
#   59 | static bool localeLessThan(const QString &a, const QString &b)
#      |             ^~~~~~~~~~~~~~
#   57|   };
#   58|   
#   59|-> static bool localeLessThan(const QString &a, const QString &b)
#   60|   {
#   61|       return QString::localeAwareCompare(a, b) < 0;

Error: COMPILER_WARNING (CWE-563): [#def9]
plasma-desktop-6.3.4/kcms/keyboard/keyboardmodel.cpp: scope_hint: In member function ‘virtual int KeyboardModel::rowCount(const QModelIndex&) const’
plasma-desktop-6.3.4/kcms/keyboard/keyboardmodel.cpp:18:48: warning[-Wunused-parameter]: unused parameter ‘parent’
#   18 | int KeyboardModel::rowCount(const QModelIndex &parent) const
#      |                             ~~~~~~~~~~~~~~~~~~~^~~~~~
#   16|   }
#   17|   
#   18|-> int KeyboardModel::rowCount(const QModelIndex &parent) const
#   19|   {
#   20|       return Rules::self().modelInfos.count();

Error: COMPILER_WARNING (CWE-563): [#def10]
plasma-desktop-6.3.4/kcms/keyboard/layoutmodel.cpp: scope_hint: In member function ‘virtual int LayoutModel::rowCount(const QModelIndex&) const’
plasma-desktop-6.3.4/kcms/keyboard/layoutmodel.cpp:26:46: warning[-Wunused-parameter]: unused parameter ‘parent’
#   26 | int LayoutModel::rowCount(const QModelIndex &parent) const
#      |                           ~~~~~~~~~~~~~~~~~~~^~~~~~
#   24|   }
#   25|   
#   26|-> int LayoutModel::rowCount(const QModelIndex &parent) const
#   27|   {
#   28|       return m_data.count();

Error: COMPILER_WARNING (CWE-563): [#def11]
plasma-desktop-6.3.4/kcms/keyboard/userlayoutmodel.cpp: scope_hint: In member function ‘virtual int UserLayoutModel::rowCount(const QModelIndex&) const’
plasma-desktop-6.3.4/kcms/keyboard/userlayoutmodel.cpp:23:50: warning[-Wunused-parameter]: unused parameter ‘parent’
#   23 | int UserLayoutModel::rowCount(const QModelIndex &parent) const
#      |                               ~~~~~~~~~~~~~~~~~~~^~~~~~
#   21|   }
#   22|   
#   23|-> int UserLayoutModel::rowCount(const QModelIndex &parent) const
#   24|   {
#   25|       return m_config->layouts().count();

Error: COMPILER_WARNING (CWE-477): [#def12]
plasma-desktop-6.3.4/kcms/keyboard/xkboptionsmodel.cpp: scope_hint: In member function ‘virtual bool XkbOptionsModel::setData(const QModelIndex&, const QVariant&, int)’
plasma-desktop-6.3.4/kcms/keyboard/xkboptionsmodel.cpp:220:56: warning[-Wdeprecated-declarations]: ‘bool QVariant::canConvert(int) const’ is deprecated
#  220 |     if (role != Roles::CheckedRole || !value.canConvert(QMetaType::Bool)) {
#      |                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/qt6/QtCore/qabstractitemmodel.h:12: included_from: Included from here.
/usr/include/qt6/QtCore/QAbstractItemModel:1: included_from: Included from here.
plasma-desktop-6.3.4/kcms/keyboard/xkboptionsmodel.h:9: included_from: Included from here.
plasma-desktop-6.3.4/kcms/keyboard/xkboptionsmodel.cpp:7: included_from: Included from here.
/usr/include/qt6/QtCore/qvariant.h:353:10: note: declared here
#  353 |     bool canConvert(int targetTypeId) const
#      |          ^~~~~~~~~~
#  218|       }
#  219|   
#  220|->     if (role != Roles::CheckedRole || !value.canConvert(QMetaType::Bool)) {
#  221|           return false;
#  222|       }

Error: COMPILER_WARNING (CWE-477): [#def13]
plasma-desktop-6.3.4/kcms/recentFiles/ExcludedApplicationsModel.cpp: scope_hint: In member function ‘void ExcludedApplicationsModel::load()’
plasma-desktop-6.3.4/kcms/recentFiles/ExcludedApplicationsModel.cpp:87:31: warning[-Wdeprecated-declarations]: ‘QSqlQuery QSqlDatabase::exec(const QString&) const’ is deprecated: Use QSqlQuery::exec() instead.
#   87 |     auto query = database.exec(QStringLiteral("SELECT DISTINCT(initiatingAgent) FROM ResourceScoreCache ORDER BY initiatingAgent"));
#      |                  ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt6/QtSql/QSqlDatabase:1: included_from: Included from here.
plasma-desktop-6.3.4/kcms/recentFiles/ExcludedApplicationsModel.cpp:13: included_from: Included from here.
/usr/include/qt6/QtSql/qsqldatabase.h:60:15: note: declared here
#   60 |     QSqlQuery exec(const QString& query = QString()) const;
#      |               ^~~~
#   85|       }
#   86|   
#   87|->     auto query = database.exec(QStringLiteral("SELECT DISTINCT(initiatingAgent) FROM ResourceScoreCache ORDER BY initiatingAgent"));
#   88|   
#   89|       if (d->applications.length() > 0) {

Error: COMPILER_WARNING: [#def14]
plasma-desktop-6.3.4/kcms/solid_actions/ActionEditor.cpp: scope_hint: In member function ‘void ActionEditor::manageControlStatus()’
plasma-desktop-6.3.4/kcms/solid_actions/ActionEditor.cpp:130:20: warning[-Wimplicit-fallthrough=]: this statement may fall through
#  130 |         atomEnable = true;
#      |         ~~~~~~~~~~~^~~~~~
plasma-desktop-6.3.4/kcms/solid_actions/ActionEditor.cpp:131:5: note: here
#  131 |     case Solid::Predicate::InterfaceCheck:
#      |     ^~~~
#  128|       switch (ui.CbParameterType->currentIndex()) {
#  129|       case Solid::Predicate::PropertyCheck:
#  130|->         atomEnable = true;
#  131|       case Solid::Predicate::InterfaceCheck:
#  132|           isEnable = true;

Error: COMPILER_WARNING (CWE-477): [#def15]
plasma-desktop-6.3.4/kcms/tablet/kcmtablet.cpp: scope_hint: In member function ‘void StylusButtonsModel::recalculateItems()’
plasma-desktop-6.3.4/kcms/tablet/kcmtablet.cpp:241:64: warning[-Wdeprecated-declarations]: ‘const int* libwacom_get_supported_styli(const WacomDevice*, int*)’ is deprecated
#  241 |                 const int *styli = libwacom_get_supported_styli(device, &num_styli);
#      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
plasma-desktop-6.3.4/kcms/tablet/kcmtablet.h:14: included_from: Included from here.
plasma-desktop-6.3.4/kcms/tablet/kcmtablet.cpp:7: included_from: Included from here.
/usr/include/libwacom-1.0/libwacom/libwacom.h:703:12: note: declared here
#  703 | const int *libwacom_get_supported_styli(const WacomDevice *device, int *num_styli);
#      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  239|               } else {
#  240|                   int num_styli = 0;
#  241|->                 const int *styli = libwacom_get_supported_styli(device, &num_styli);
#  242|                   if (num_styli > 0) {
#  243|                       const auto stylus = libwacom_stylus_get_for_id(m_db, styli[0]);

Error: COMPILER_WARNING (CWE-477): [#def16]
plasma-desktop-6.3.4/kcms/tablet/kcmtablet.cpp:243:67: warning[-Wdeprecated-declarations]: ‘const WacomStylus* libwacom_stylus_get_for_id(const WacomDeviceDatabase*, int)’ is deprecated
#  243 |                     const auto stylus = libwacom_stylus_get_for_id(m_db, styli[0]);
#      |                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/libwacom-1.0/libwacom/libwacom.h:922:20: note: declared here
#  922 | const WacomStylus *libwacom_stylus_get_for_id (const WacomDeviceDatabase *db, int id);
#      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
#  241|                   const int *styli = libwacom_get_supported_styli(device, &num_styli);
#  242|                   if (num_styli > 0) {
#  243|->                     const auto stylus = libwacom_stylus_get_for_id(m_db, styli[0]);
#  244|                       if (stylus != nullptr) {
#  245|                           numButtons = libwacom_stylus_get_num_buttons(stylus);

Error: COMPILER_WARNING: [#def17]
plasma-desktop-6.3.4/kcms/touchpad/touchpadbackend.h:52:18: warning[-Woverloaded-virtual=]: ‘virtual bool TouchpadBackend::applyConfig(const QVariantHash&)’ was hidden
#   52 |     virtual bool applyConfig(const QVariantHash &)
#      |                  ^~~~~~~~~~~
plasma-desktop-6.3.4/kcms/touchpad/backends/kwin_wayland/kwinwaylandbackend.h:23:10: note:   by ‘virtual bool KWinWaylandBackend::applyConfig()’
#   23 |     bool applyConfig() override;
#      |          ^~~~~~~~~~~
#   50|       }
#   51|   
#   52|->     virtual bool applyConfig(const QVariantHash &)
#   53|       {
#   54|           return false;

Error: COMPILER_WARNING: [#def18]
plasma-desktop-6.3.4/kcms/touchpad/touchpadbackend.cpp:8: included_from: Included from here.
plasma-desktop-6.3.4/kcms/touchpad/touchpadbackend.h:56:18: warning[-Woverloaded-virtual=]: ‘virtual bool TouchpadBackend::getConfig(QVariantHash&)’ was hidden
#   56 |     virtual bool getConfig(QVariantHash &)
#      |                  ^~~~~~~~~
plasma-desktop-6.3.4/kcms/touchpad/touchpadbackend.cpp:11: included_from: Included from here.
plasma-desktop-6.3.4/kcms/touchpad/backends/kwin_wayland/kwinwaylandbackend.h:24:10: note:   by ‘virtual bool KWinWaylandBackend::getConfig()’
#   24 |     bool getConfig() override;
#      |          ^~~~~~~~~
#   54|           return false;
#   55|       }
#   56|->     virtual bool getConfig(QVariantHash &)
#   57|       {
#   58|           return false;

Scan Properties