plasma-workspace-6.3.4-2.fc43

List of Findings

Error: SHELLCHECK_WARNING (CWE-569): [#def1]
/usr/libexec/kf6/kauth/fontinst_x11:17:10: warning[SC2048]: Use "$@" (with quotes) to prevent whitespace problems.
#   15|   suffix=".fontinst-$$"
#   16|   
#   17|-> for d in $* ; do
#   18|       for f in fonts.scale fonts.dir ; do
#   19|           # Call standard xorg app...

Error: SHELLCHECK_WARNING (CWE-758): [#def2]
/usr/libexec/plasma-sourceenv.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
#    1|-> for i in $@
#    2|   do
#    3|       . $i >/dev/null

Error: SHELLCHECK_WARNING (CWE-88): [#def3]
/usr/libexec/plasma-sourceenv.sh:1:10: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
#    1|-> for i in $@
#    2|   do
#    3|       . $i >/dev/null

Error: COMPILER_WARNING (CWE-563): [#def4]
plasma-workspace-6.3.4/applets/systemtray/container/systemtraycontainer.cpp: scope_hint: In member function ‘void SystemTrayContainer::cleanupConfig()’
plasma-workspace-6.3.4/applets/systemtray/container/systemtraycontainer.cpp:172:38: warning[-Wunused-variable]: unused variable ‘contApplet’
#  172 |             if (SystemTrayContainer *contApplet = qobject_cast<SystemTrayContainer *>(applet)) {
#      |                                      ^~~~~~~~~~
#  170|       for (const auto conts = c->containments(); Plasma::Containment * containment : conts) {
#  171|           for (const auto applets = containment->applets(); Plasma::Applet * applet : applets) {
#  172|->             if (SystemTrayContainer *contApplet = qobject_cast<SystemTrayContainer *>(applet)) {
#  173|                   const uint id = applet->config().readEntry("SystrayContainmentId", 0);
#  174|                   if (id > 0) {

Error: COMPILER_WARNING (CWE-252): [#def5]
plasma-workspace-6.3.4/dataengines/time/timeengine.cpp: scope_hint: In lambda function
plasma-workspace-6.3.4/dataengines/time/timeengine.cpp:71:13: warning[-Wunused-result]: ignoring return value of ‘ssize_t read(int, void*, size_t)’ declared with attribute ‘warn_unused_result’
#   71 |         read(fd, &c, 8);
#      |         ~~~~^~~~~~~~~~~
#   69|       connect(notifier, &QSocketNotifier::activated, this, [this](int fd) {
#   70|           uint64_t c;
#   71|->         read(fd, &c, 8);
#   72|           clockSkewed();
#   73|       });

Error: COMPILER_WARNING (CWE-477): [#def6]
plasma-workspace-6.3.4/kcms/icons/main.cpp: scope_hint: In member function ‘void IconModule::ghnsEntriesChanged()’
plasma-workspace-6.3.4/kcms/icons/main.cpp:132:41: warning[-Wdeprecated-declarations]: ‘void KIconLoader::newIconLoader()’ is deprecated: Since 5.0. Use KIconLoader::emitChange(Group)
#  132 |     KIconLoader::global()->newIconLoader();
#      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
/usr/include/KF6/KIconThemes/KIconLoader:1: included_from: Included from here.
plasma-workspace-6.3.4/kcms/icons/main.cpp:31: included_from: Included from here.
/usr/include/KF6/KIconThemes/kiconloader.h:647:10: note: declared here
#  647 |     void newIconLoader();
#      |          ^~~~~~~~~~~~~
#  130|       // reload the display icontheme items
#  131|       KIconTheme::reconfigure();
#  132|->     KIconLoader::global()->newIconLoader();
#  133|       load();
#  134|       QPixmapCache::clear();

Error: COMPILER_WARNING (CWE-477): [#def7]
plasma-workspace-6.3.4/kcms/icons/main.cpp: scope_hint: In member function ‘void IconModule::installThemeFile(const QString&)’
plasma-workspace-6.3.4/kcms/icons/main.cpp:186:41: warning[-Wdeprecated-declarations]: ‘void KIconLoader::newIconLoader()’ is deprecated: Since 5.0. Use KIconLoader::emitChange(Group)
#  186 |     KIconLoader::global()->newIconLoader();
#      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
/usr/include/KF6/KIconThemes/kiconloader.h:647:10: note: declared here
#  647 |     void newIconLoader();
#      |          ^~~~~~~~~~~~~
#  184|       Q_EMIT showSuccessMessage(i18n("Theme installed successfully."));
#  185|   
#  186|->     KIconLoader::global()->newIconLoader();
#  187|       m_model->load();
#  188|   }

Error: COMPILER_WARNING (CWE-252): [#def8]
plasma-workspace-6.3.4/kcms/kfontinst/dbus/FontInst.cpp: scope_hint: In function ‘bool KFI::renameFontFile(const QString&, const QString&, int, int)’
plasma-workspace-6.3.4/kcms/kfontinst/dbus/FontInst.cpp:401:16: warning[-Wunused-result]: ignoring return value of ‘int chown(const char*, __uid_t, __gid_t)’ declared with attribute ‘warn_unused_result’
#  401 |         ::chown(dest.data(), uid, gid);
#      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
#  399|       Misc::setFilePerms(dest);
#  400|       if (-1 != uid && -1 != gid) {
#  401|->         ::chown(dest.data(), uid, gid);
#  402|       }
#  403|       return true;

Error: COMPILER_WARNING (CWE-252): [#def9]
plasma-workspace-6.3.4/kcms/kfontinst/dbus/Helper.cpp: scope_hint: In function ‘bool KFI::renameFontFile(const QString&, const QString&, int, int)’
plasma-workspace-6.3.4/kcms/kfontinst/dbus/Helper.cpp:190:16: warning[-Wunused-result]: ignoring return value of ‘int chown(const char*, __uid_t, __gid_t)’ declared with attribute ‘warn_unused_result’
#  190 |         ::chown(dest.data(), uid, gid);
#      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
#  188|       Misc::setFilePerms(dest);
#  189|       if (-1 != uid && -1 != gid) {
#  190|->         ::chown(dest.data(), uid, gid);
#  191|       }
#  192|       return true;

Error: COMPILER_WARNING (CWE-252): [#def10]
plasma-workspace-6.3.4/kcms/kfontinst/dbus/Helper.cpp: scope_hint: In member function ‘int KFI::Helper::move(const QVariantMap&)’
plasma-workspace-6.3.4/kcms/kfontinst/dbus/Helper.cpp:225:28: warning[-Wunused-result]: ignoring return value of ‘int chown(const char*, __uid_t, __gid_t)’ declared with attribute ‘warn_unused_result’
#  225 |                     ::chown(QFile::encodeName(destFolder).data(), toUid, toGid);
#      |                     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  223|                   result = Misc::createDir(destFolder) ? (int)FontInst::STATUS_OK : (int)KIO::ERR_WRITE_ACCESS_DENIED;
#  224|                   if (FontInst::STATUS_OK == result) {
#  225|->                     ::chown(QFile::encodeName(destFolder).data(), toUid, toGid);
#  226|                   }
#  227|               }

Error: COMPILER_WARNING (CWE-477): [#def11]
plasma-workspace-6.3.4/kcms/kfontinst/viewpart/CharTip.cpp: scope_hint: In member function ‘void KFI::CCharTip::showTip()’
plasma-workspace-6.3.4/kcms/kfontinst/viewpart/CharTip.cpp:158:34: warning[-Wdeprecated-declarations]: ‘static QString QString::fromUcs4(const uint*, qsizetype)’ is deprecated: Use char32_t* overload.
#  158 |     QString str(QString::fromUcs4(&(m_item.ucs4), 1));
#      |                 ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/usr/include/qt6/QtCore/qhashfunctions.h:9: included_from: Included from here.
/usr/include/qt6/QtCore/qlist.h:11: included_from: Included from here.
/usr/include/qt6/QtCore/qstringlist.h:5: included_from: Included from here.
/usr/include/qt6/QtGui/qcolor.h:10: included_from: Included from here.
/usr/include/qt6/QtGui/QColor:1: included_from: Included from here.
plasma-workspace-6.3.4/kcms/kfontinst/lib/FcEngine.h:8: included_from: Included from here.
plasma-workspace-6.3.4/kcms/kfontinst/viewpart/CharTip.h:8: included_from: Included from here.
plasma-workspace-6.3.4/kcms/kfontinst/viewpart/CharTip.cpp:12: included_from: Included from here.
/usr/include/qt6/QtCore/qstring.h:762:20: note: declared here
#  762 |     static QString fromUcs4(const uint *str, qsizetype size = -1)
#      |                    ^~~~~~~~
#  156|           u"<tr><td align=\"right\"><b>" + i18n("UCS-4") + u"&nbsp;</b></td><td>" + u"U+" + QStringLiteral("%1").arg(m_item.ucs4, 4, 16) + u"&nbsp;</td></tr>";
#  157|   
#  158|->     QString str(QString::fromUcs4(&(m_item.ucs4), 1));
#  159|       details += u"<tr><td align=\"right\"><b>" + i18n("UTF-16") + u"&nbsp;</b></td><td>";
#  160|   

Error: COMPILER_WARNING (CWE-758): [#def12]
plasma-workspace-6.3.4/ksmserver/legacy.cpp: scope_hint: In member function ‘void KSMServer::performLegacySessionSave()’
plasma-workspace-6.3.4/ksmserver/legacy.cpp:181:30: warning[-Wrestrict]: passing argument 2 to ‘restrict’-qualified parameter aliases with argument 4
#  181 |             ::select(fd + 1, &fds, nullptr, &fds, &tmwait);
#      |                              ^~~~           ~~~~
#  179|               tmwait.tv_sec = (wmSaveYourselfTimeout - msecs) / 1000;
#  180|               tmwait.tv_usec = ((wmSaveYourselfTimeout - msecs) % 1000) * 1000;
#  181|->             ::select(fd + 1, &fds, nullptr, &fds, &tmwait);
#  182|           }
#  183|       }

Error: COMPILER_WARNING (CWE-563): [#def13]
plasma-workspace-6.3.4/ksmserver/main.cpp: scope_hint: In function ‘void sanity_check(int, char**)’
plasma-workspace-6.3.4/ksmserver/main.cpp:60:23: warning[-Wunused-parameter]: unused parameter ‘argc’
#   60 | void sanity_check(int argc, char *argv[])
#      |                   ~~~~^~~~
#   58|   }
#   59|   
#   60|-> void sanity_check(int argc, char *argv[])
#   61|   {
#   62|       QString msg;

Error: COMPILER_WARNING (CWE-563): [#def14]
plasma-workspace-6.3.4/ksmserver/main.cpp:60:35: warning[-Wunused-parameter]: unused parameter ‘argv’
#   60 | void sanity_check(int argc, char *argv[])
#      |                             ~~~~~~^~~~~~
#   58|   }
#   59|   
#   60|-> void sanity_check(int argc, char *argv[])
#   61|   {
#   62|       QString msg;

Error: COMPILER_WARNING (CWE-563): [#def15]
plasma-workspace-6.3.4/ksmserver/server.cpp:176:24: warning[-Wunused-variable]: ‘remTempFile’ defined but not used
#  176 | static QTemporaryFile *remTempFile = nullptr;
#      |                        ^~~~~~~~~~~
#  174|   IceAuthDataEntry *authDataEntries = nullptr;
#  175|   
#  176|-> static QTemporaryFile *remTempFile = nullptr;
#  177|   
#  178|   static IceListenObj *listenObjs = nullptr;

Error: COMPILER_WARNING (CWE-1164): [#def16]
plasma-workspace-6.3.4/ksmserver/server.cpp: scope_hint: At global scope
plasma-workspace-6.3.4/ksmserver/server.cpp:308:13: warning[-Wunused-function]: ‘void fprintfhex(FILE*, unsigned int, char*)’ defined but not used
#  308 | static void fprintfhex(FILE *fp, unsigned int len, char *cp)
#      |             ^~~~~~~~~~
#  306|   
#  307|   /* for printing hex digits */
#  308|-> static void fprintfhex(FILE *fp, unsigned int len, char *cp)
#  309|   {
#  310|       static const char hexchars[] = "0123456789abcdef";

Error: COMPILER_WARNING (CWE-569): [#def17]
plasma-workspace-6.3.4/ksmserver/server.cpp: scope_hint: In function ‘X::Status SetAuthentication(int, _IceListenObj**, IceAuthDataEntry**)’
plasma-workspace-6.3.4/ksmserver/server.cpp:362:39: warning[-Wparentheses]: suggest parentheses around assignment used as truth value
#  362 |             if (file_entry->auth_data = (char *)malloc(MAGIC_COOKIE_LEN)) {
#      |                 ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  360|               file_entry->network_id = IceGetListenConnectionString(listenObjs[i / 2]);
#  361|               file_entry->auth_name = strdup("MIT-MAGIC-COOKIE-1");
#  362|->             if (file_entry->auth_data = (char *)malloc(MAGIC_COOKIE_LEN)) {
#  363|                   memcpy(file_entry->auth_data, (*authDataEntries)[i].auth_data, MAGIC_COOKIE_LEN);
#  364|               }

Error: COMPILER_WARNING (CWE-569): [#def18]
plasma-workspace-6.3.4/ksmserver/server.cpp:388:39: warning[-Wparentheses]: suggest parentheses around assignment used as truth value
#  388 |             if (file_entry->auth_data = (char *)malloc(MAGIC_COOKIE_LEN)) {
#      |                 ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  386|               file_entry->network_id = IceGetListenConnectionString(listenObjs[i / 2]);
#  387|               file_entry->auth_name = strdup("MIT-MAGIC-COOKIE-1");
#  388|->             if (file_entry->auth_data = (char *)malloc(MAGIC_COOKIE_LEN)) {
#  389|                   memcpy(file_entry->auth_data, (*authDataEntries)[i + 1].auth_data, MAGIC_COOKIE_LEN);
#  390|               }

Error: COMPILER_WARNING (CWE-1023): [#def19]
plasma-workspace-6.3.4/shell/panelview.cpp:102:16: warning[-Wswitch]: enumeration value ‘Desktop’ not handled in switch
#  100|       connect(this, &PanelView::containmentChanged, this, &PanelView::refreshContainment);
#  101|       connect(this, &PanelView::locationChanged, this, [this](Plasma::Types::Location location) {
#  102|->         switch (location) {
#  103|           case Plasma::Types::LeftEdge:
#  104|           case Plasma::Types::RightEdge:

Error: COMPILER_WARNING (CWE-1023): [#def20]
plasma-workspace-6.3.4/shell/panelview.cpp: scope_hint: In lambda function
plasma-workspace-6.3.4/shell/panelview.cpp:102:16: warning[-Wswitch]: enumeration value ‘Floating’ not handled in switch
#  102 |         switch (location) {
#      |                ^
#  100|       connect(this, &PanelView::containmentChanged, this, &PanelView::refreshContainment);
#  101|       connect(this, &PanelView::locationChanged, this, [this](Plasma::Types::Location location) {
#  102|->         switch (location) {
#  103|           case Plasma::Types::LeftEdge:
#  104|           case Plasma::Types::RightEdge:

Error: COMPILER_WARNING (CWE-1023): [#def21]
plasma-workspace-6.3.4/shell/panelview.cpp:102:16: warning[-Wswitch]: enumeration value ‘FullScreen’ not handled in switch
#  100|       connect(this, &PanelView::containmentChanged, this, &PanelView::refreshContainment);
#  101|       connect(this, &PanelView::locationChanged, this, [this](Plasma::Types::Location location) {
#  102|->         switch (location) {
#  103|           case Plasma::Types::LeftEdge:
#  104|           case Plasma::Types::RightEdge:

Error: COMPILER_WARNING (CWE-457): [#def22]
plasma-workspace-6.3.4/shell/shellcorona.cpp:2342:61: warning[-Wmaybe-uninitialized]: ‘newTrayContainment’ may be used uninitialized
# 2342 |             auto newTrayConfig = newTrayContainment->config();
#      |                                                             ^
plasma-workspace-6.3.4/shell/shellcorona.cpp:2332:34: note: ‘newTrayContainment’ was declared here
# 2332 |             Plasma::Containment *newTrayContainment;
#      |                                  ^~~~~~~~~~~~~~~~~~
# 2340|               }
# 2341|   
# 2342|->             auto newTrayConfig = newTrayContainment->config();
# 2343|               auto oldTrayConfig = oldTrayContainment->config();
# 2344|               oldTrayConfig.copyTo(&newTrayConfig);

Error: COMPILER_WARNING (CWE-457): [#def23]
plasma-workspace-6.3.4/shell/shellcorona.cpp: scope_hint: In member function ‘ShellCorona::clonePanelTo(PanelView*, Plasma::Types::Location, QScreen*)’
plasma-workspace-6.3.4/shell/shellcorona.cpp:2343:61: warning[-Wmaybe-uninitialized]: ‘oldTrayContainment’ may be used uninitialized
# 2343 |             auto oldTrayConfig = oldTrayContainment->config();
#      |                                                             ^
plasma-workspace-6.3.4/shell/shellcorona.cpp:2331:34: note: ‘oldTrayContainment’ was declared here
# 2331 |             Plasma::Containment *oldTrayContainment;
#      |                                  ^~~~~~~~~~~~~~~~~~
# 2341|   
# 2342|               auto newTrayConfig = newTrayContainment->config();
# 2343|->             auto oldTrayConfig = oldTrayContainment->config();
# 2344|               oldTrayConfig.copyTo(&newTrayConfig);
# 2345|   

Error: COMPILER_WARNING (CWE-252): [#def24]
plasma-workspace-6.3.4/startkde/kcminit/main.cpp: scope_hint: In function ‘void sendReady()’
plasma-workspace-6.3.4/startkde/kcminit/main.cpp:37:10: warning[-Wunused-result]: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’
#   37 |     write(ready[1], &c, 1);
#      |     ~~~~~^~~~~~~~~~~~~~~~~
#   35|           return;
#   36|       char c = 0;
#   37|->     write(ready[1], &c, 1);
#   38|       close(ready[1]);
#   39|       ready[1] = -1;

Error: COMPILER_WARNING (CWE-252): [#def25]
plasma-workspace-6.3.4/startkde/kcminit/main.cpp: scope_hint: In function ‘void waitForReady()’
plasma-workspace-6.3.4/startkde/kcminit/main.cpp:46:9: warning[-Wunused-result]: ignoring return value of ‘ssize_t read(int, void*, size_t)’ declared with attribute ‘warn_unused_result’
#   46 |     read(ready[0], &c, 1);
#      |     ~~~~^~~~~~~~~~~~~~~~~
#   44|       char c = 1;
#   45|       close(ready[1]);
#   46|->     read(ready[0], &c, 1);
#   47|       close(ready[0]);
#   48|   }

Error: COMPILER_WARNING (CWE-252): [#def26]
plasma-workspace-6.3.4/startkde/kcminit/main.cpp: scope_hint: In function ‘int main(int, char**)’
plasma-workspace-6.3.4/startkde/kcminit/main.cpp:154:9: warning[-Wunused-result]: ignoring return value of ‘int pipe(int*)’ declared with attribute ‘warn_unused_result’
#  154 |     pipe(ready);
#      |     ~~~~^~~~~~~
#  152|       // early in the login process), the rest is delayed, so fork and make parent
#  153|       // return after the initial phase
#  154|->     pipe(ready);
#  155|       if (fork() != 0) {
#  156|           waitForReady();

Error: COMPILER_WARNING (CWE-252): [#def27]
plasma-workspace-6.3.4/startkde/plasma-session/signalhandler.cpp: scope_hint: In static member function ‘static void SignalHandler::signalHandler(int)’
plasma-workspace-6.3.4/startkde/plasma-session/signalhandler.cpp:45:12: warning[-Wunused-result]: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’
#   45 |     ::write(signalFd[0], &signal, sizeof(signal));
#      |     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   43|   void SignalHandler::signalHandler(int signal)
#   44|   {
#   45|->     ::write(signalFd[0], &signal, sizeof(signal));
#   46|   }
#   47|   

Error: COMPILER_WARNING (CWE-252): [#def28]
plasma-workspace-6.3.4/startkde/plasma-session/signalhandler.cpp: scope_hint: In member function ‘void SignalHandler::handleSignal()’
plasma-workspace-6.3.4/startkde/plasma-session/signalhandler.cpp:52:11: warning[-Wunused-result]: ignoring return value of ‘ssize_t read(int, void*, size_t)’ declared with attribute ‘warn_unused_result’
#   52 |     ::read(signalFd[1], &signal, sizeof(signal));
#      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   50|       m_handler->setEnabled(false);
#   51|       int signal;
#   52|->     ::read(signalFd[1], &signal, sizeof(signal));
#   53|       m_handler->setEnabled(true);
#   54|   

Error: COMPILER_WARNING (CWE-563): [#def29]
plasma-workspace-6.3.4/startkde/startplasma.cpp: scope_hint: In function ‘void {anonymous}::canberraFinishCallback(ca_context*, uint32_t, int, void*)’
plasma-workspace-6.3.4/startkde/startplasma.cpp:789:83: warning[-Wunused-parameter]: unused parameter ‘userdata’
#  789 | void canberraFinishCallback(ca_context *c, uint32_t /*id*/, int error_code, void *userdata)
#      |                                                                             ~~~~~~^~~~~~~~
#  787|   namespace
#  788|   {
#  789|-> void canberraFinishCallback(ca_context *c, uint32_t /*id*/, int error_code, void *userdata)
#  790|   {
#  791|       QMetaObject::invokeMethod(

Error: COMPILER_WARNING (CWE-477): [#def30]
plasma-workspace-6.3.4/wallpapers/image/plugin/utils/mediaproxy.cpp: scope_hint: In member function ‘virtual void MediaProxy::componentComplete()’
plasma-workspace-6.3.4/wallpapers/image/plugin/utils/mediaproxy.cpp:55:40: warning[-Wdeprecated-declarations]: ‘void QGuiApplication::paletteChanged(const QPalette&)’ is deprecated: Handle QEvent::ApplicationPaletteChange instead
#   55 |     connect(qGuiApp, &QGuiApplication::paletteChanged, this, &MediaProxy::slotSystemPaletteChanged);
#      |                                        ^~~~~~~~~~~~~~
/usr/include/qt6/QtGui/QGuiApplication:1: included_from: Included from here.
plasma-workspace-6.3.4/wallpapers/image/plugin/utils/mediaproxy.cpp:13: included_from: Included from here.
/usr/include/qt6/QtGui/qguiapplication.h:161:89: note: declared here
#  161 |     QT_DEPRECATED_VERSION_X_6_0("Handle QEvent::ApplicationPaletteChange instead") void paletteChanged(const QPalette &pal);
#      |                                                                                         ^~~~~~~~~~~~~~
#   53|   
#   54|       // Follow system color scheme
#   55|->     connect(qGuiApp, &QGuiApplication::paletteChanged, this, &MediaProxy::slotSystemPaletteChanged);
#   56|   
#   57|       processSource();

Scan Properties