Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-477): [#def1]
/usr/lib/rpm/redhat/find-requires:12:27: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
#   10|   filelist=`sed "s/[]['\"*?{}]/\\\\\&/g"`
#   11|   
#   12|-> [ -x /usr/lib/rpm/rpmdeps -a -n "$filelist" ] && \
#   13|       echo $filelist | tr '[:blank:]' \\n | /usr/lib/rpm/rpmdeps --requires
#   14|   

Error: SHELLCHECK_WARNING (CWE-156): [#def2]
/usr/lib/rpm/redhat/find-requires:25:10: warning[SC2046]: Quote this to prevent word splitting.
#   23|   
#   24|   for f in $filelist; do
#   25|->     if [ $(echo "$f" | sed -r -ne 's:^.*/lib/modules/(.*)/(.*).ko$:\2:p') ]
#   26|       then
#   27|           is_kmod=1;

Error: SHELLCHECK_WARNING (CWE-563): [#def3]
/usr/lib/rpm/redhat/find-requires:27:9: warning[SC2034]: is_kmod appears unused. Verify use (or export if used externally).
#   25|       if [ $(echo "$f" | sed -r -ne 's:^.*/lib/modules/(.*)/(.*).ko$:\2:p') ]
#   26|       then
#   27|->         is_kmod=1;
#   28|       elif [ $(echo "$f" | sed -r -ne 's:^.*/boot/(.*):\1:p') ]
#   29|       then

Error: SHELLCHECK_WARNING (CWE-156): [#def4]
/usr/lib/rpm/redhat/find-requires:28:12: warning[SC2046]: Quote this to prevent word splitting.
#   26|       then
#   27|           is_kmod=1;
#   28|->     elif [ $(echo "$f" | sed -r -ne 's:^.*/boot/(.*):\1:p') ]
#   29|       then
#   30|   	unset is_kmod;

Scan Properties

analyzer-version-clippy1.86.0
analyzer-version-cppcheck2.17.1
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.86.0
diffbase-analyzer-version-cppcheck2.17.1
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-83.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameredhat-rpm-config-343-4.fc43
diffbase-store-results-to/tmp/tmpckhnvamp/redhat-rpm-config-343-4.fc43.tar.xz
diffbase-time-created2025-04-25 15:28:08
diffbase-time-finished2025-04-25 15:29:13
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpckhnvamp/redhat-rpm-config-343-4.fc43.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpckhnvamp/redhat-rpm-config-343-4.fc43.src.rpm'
diffbase-tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-83.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250425.124705.g1c7c448.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-nameredhat-rpm-config-342-2.fc42
store-results-to/tmp/tmpu9x9qp9a/redhat-rpm-config-342-2.fc42.tar.xz
time-created2025-04-25 15:26:26
time-finished2025-04-25 15:27:54
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpu9x9qp9a/redhat-rpm-config-342-2.fc42.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpu9x9qp9a/redhat-rpm-config-342-2.fc42.src.rpm'
tool-versioncsmock-3.8.1.20250422.172604.g26bc3d6-1.el9