xfce4-session-4.20.2-1.fc43

List of Findings

Error: SHELLCHECK_WARNING (CWE-569): [#def1]
/usr/bin/startxfce4:25:14: warning[SC2048]: Use "$@" (with quotes) to prevent whitespace problems.
#   23|   then
#   24|     OPTS=""
#   25|->   for OPT in $*
#   26|     do
#   27|       if test "x$OPT" = "x--help"

Error: SHELLCHECK_WARNING (CWE-277): [#def2]
/usr/bin/startxfce4:72:19: warning[SC2174]: When used with -p, -m only applies to the deepest directory.
#   70|            echo "XDG_RUNTIME_DIR is invalid or does not exist!"
#   71|            echo "Creating XDG_RUNTIME_DIR..."
#   72|->          mkdir -p -m 0700 "${XDG_RUNTIME_DIR}" || {
#   73|              echo "Unable to create runtime directory ${XDG_RUNTIME_DIR}!"
#   74|              exit 1

Error: SHELLCHECK_WARNING (CWE-457): [#def3]
/usr/bin/startxfce4:233:53: warning[SC2154]: tty_num is referenced but not assigned.
#  231|   
#  232|   if [ -f $BASEDIR/xinitrc ]; then
#  233|->   exec $prog $BASEDIR/xinitrc $CLIENTRC $SERVERRC vt${tty_num}
#  234|   elif [ -f $HOME/.xfce4/xinitrc ]; then
#  235|     mkdir -p $BASEDIR

Error: SHELLCHECK_WARNING (CWE-156): [#def4]
/usr/bin/xflock4:52:12: warning[SC2046]: Quote this to prevent word splitting.
#   50|   # $((2**31 - 1)) is MAXINT, which disables timeout: see
#   51|   # https://dbus.freedesktop.org/doc/api/html/group__DBusPendingCall.html
#   52|-> ret=$(echo $(dbus-send --session \
#   53|                          --dest=org.xfce.SessionManager \
#   54|                          --print-reply=literal \

Error: SHELLCHECK_WARNING: [#def5]
/usr/bin/xflock4:55:44: warning[SC3019]: In POSIX sh, exponentials are undefined.
#   53|                          --dest=org.xfce.SessionManager \
#   54|                          --print-reply=literal \
#   55|->                        --reply-timeout=$((2**31 - 1)) \
#   56|                          --type=method_call \
#   57|                          /org/xfce/SessionManager \

Error: COMPILER_WARNING (CWE-477): [#def6]
xfce4-session-4.20.2/libxfsm/xfsm-util.c: scope_hint: In function 'xfsm_start_application'
xfce4-session-4.20.2/libxfsm/xfsm-util.c:79:42: warning[-Wdeprecated-declarations]: 'gdk_screen_get_number' is deprecated
#   79 |                                          gdk_screen_get_number (screen));
#      |                                          ^~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkx.h:28: included_from: Included from here.
xfce4-session-4.20.2/libxfsm/xfsm-util.h:26: included_from: Included from here.
xfce4-session-4.20.2/libxfsm/xfsm-util.c:39: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkscreen.h:56:14: note: declared here
#   56 | gint         gdk_screen_get_number            (GdkScreen   *screen);
#      |              ^~~~~~~~~~~~~~~~~~~~~
#   77|   
#   78|             screen_name = g_strdup_printf ("%s.%d", display_name,
#   79|->                                          gdk_screen_get_number (screen));
#   80|           }
#   81|         else

Error: COMPILER_WARNING (CWE-477): [#def7]
xfce4-session-4.20.2/libxfsm/xfsm-util.c:79:42: warning[-Wdeprecated-declarations]: 'gdk_screen_get_number' is deprecated
#   77|   
#   78|             screen_name = g_strdup_printf ("%s.%d", display_name,
#   79|->                                          gdk_screen_get_number (screen));
#   80|           }
#   81|         else

Error: COMPILER_WARNING (CWE-477): [#def8]
xfce4-session-4.20.2/libxfsm/xfsm-util.c:82:9: warning[-Wdeprecated-declarations]: 'gdk_screen_make_display_name' is deprecated
#   82 |         screen_name = gdk_screen_make_display_name (screen);
#      |         ^~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkscreen.h:71:14: note: declared here
#   71 | gchar *      gdk_screen_make_display_name     (GdkScreen   *screen);
#      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   80|           }
#   81|         else
#   82|->         screen_name = gdk_screen_make_display_name (screen);
#   83|         argv[argc++] = g_strdup ("env");
#   84|         argv[argc++] = g_strdup_printf ("DISPLAY=%s", screen_name);

Error: COMPILER_WARNING (CWE-477): [#def9]
xfce4-session-4.20.2/libxfsm/xfsm-util.c:82:9: warning[-Wdeprecated-declarations]: 'gdk_screen_make_display_name' is deprecated
#   80|           }
#   81|         else
#   82|->         screen_name = gdk_screen_make_display_name (screen);
#   83|         argv[argc++] = g_strdup ("env");
#   84|         argv[argc++] = g_strdup_printf ("DISPLAY=%s", screen_name);

Error: GCC_ANALYZER_WARNING (CWE-688): [#def10]
xfce4-session-4.20.2/xfce4-session/main.c:119:8: warning[-Wanalyzer-null-argument]: use of NULL ‘authfile’ where non-null expected
xfce4-session-4.20.2/xfce4-session/main.c:90:1: enter_function: entry to ‘setup_environment’
xfce4-session-4.20.2/xfce4-session/main.c:115:6: branch_true: following ‘true’ branch...
xfce4-session-4.20.2/xfce4-session/main.c:116:16: branch_true: ...to here
xfce4-session-4.20.2/xfce4-session/main.c:119:8: danger: argument 1 (‘authfile’) NULL where non-null expected
#  117|     else
#  118|       authfile = xfce_get_homefile (".ICEauthority", NULL);
#  119|->   fd = open (authfile, O_RDWR | O_CREAT, 0600);
#  120|     if (fd < 0)
#  121|       {

Error: COMPILER_WARNING (CWE-477): [#def11]
xfce4-session-4.20.2/xfce4-session/xfsm-compat-kde.c: scope_hint: In function ‘xfsm_compat_kde_startup’
xfce4-session-4.20.2/xfce4-session/xfsm-compat-kde.c:133:3: warning[-Wdeprecated-declarations]: ‘gdk_display_get_n_screens’ is deprecated
#  133 |   if (gdk_display_get_n_screens (gdk_display_get_default ()) > 1)
#      |   ^~
/usr/include/gtk-3.0/gdk/gdkscreen.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gtk/gtk.h:30: included_from: Included from here.
xfce4-session-4.20.2/xfce4-session/xfsm-compat-kde.c:46: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkdisplay.h:54:13: note: declared here
#   54 | gint        gdk_display_get_n_screens      (GdkDisplay  *display);
#      |             ^~~~~~~~~~~~~~~~~~~~~~~~~
#  131|   
#  132|     /* tell kde if we are running multi-head */
#  133|->   if (gdk_display_get_n_screens (gdk_display_get_default ()) > 1)
#  134|       {
#  135|         g_snprintf (command, 256,

Error: COMPILER_WARNING (CWE-477): [#def12]
xfce4-session-4.20.2/xfce4-session/xfsm-compat-kde.c:133:3: warning[-Wdeprecated-declarations]: ‘gdk_display_get_n_screens’ is deprecated
#  131|   
#  132|     /* tell kde if we are running multi-head */
#  133|->   if (gdk_display_get_n_screens (gdk_display_get_default ()) > 1)
#  134|       {
#  135|         g_snprintf (command, 256,

Error: COMPILER_WARNING (CWE-477): [#def13]
xfce4-session-4.20.2/xfce4-session/xfsm-legacy.c: scope_hint: In function ‘xfsm_legacy_perform_session_save’
xfce4-session-4.20.2/xfce4-session/xfsm-legacy.c:335:7: warning[-Wdeprecated-declarations]: ‘wnck_screen_get’ is deprecated: Use 'wnck_handle_get_screen' instead
#  335 |       screen = wnck_screen_get (n);
#      |       ^~~~~~
/usr/include/libwnck-3.0/libwnck/wnck-handle.h:26: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/libwnck.h:26: included_from: Included from here.
xfce4-session-4.20.2/xfce4-session/xfsm-legacy.c:71: included_from: Included from here.
/usr/include/libwnck-3.0/libwnck/screen.h:203:16: note: declared here
#  203 | WnckScreen*    wnck_screen_get                      (int         index);
#      |                ^~~~~~~~~~~~~~~
#  333|     for (n = 0; n < ScreenCount (gdk_x11_get_default_xdisplay ()); ++n)
#  334|       {
#  335|->       screen = wnck_screen_get (n);
#  336|         wnck_screen_force_update (screen);
#  337|   

Error: COMPILER_WARNING (CWE-477): [#def14]
xfce4-session-4.20.2/xfce4-session/xfsm-legacy.c:335:7: warning[-Wdeprecated-declarations]: ‘wnck_screen_get’ is deprecated: Use 'wnck_handle_get_screen' instead
#  333|     for (n = 0; n < ScreenCount (gdk_x11_get_default_xdisplay ()); ++n)
#  334|       {
#  335|->       screen = wnck_screen_get (n);
#  336|         wnck_screen_force_update (screen);
#  337|   

Error: COMPILER_WARNING (CWE-477): [#def15]
xfce4-session-4.20.2/xfce4-session/xfsm-logout-dialog.c: scope_hint: In function ‘xfsm_logout_dialog_screenshot_new’
xfce4-session-4.20.2/xfce4-session/xfsm-logout-dialog.c:527:3: warning[-Wdeprecated-declarations]: ‘gdk_screen_get_width’ is deprecated
#  527 |   screen_rect.width = gdk_screen_get_width (screen);
#      |   ^~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdk.h:32: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkx.h:28: included_from: Included from here.
xfce4-session-4.20.2/xfce4-session/xfsm-logout-dialog.c:48: included_from: Included from here.
/usr/include/gtk-3.0/gdk/gdkscreen.h:58:14: note: declared here
#   58 | gint         gdk_screen_get_width             (GdkScreen   *screen);
#      |              ^~~~~~~~~~~~~~~~~~~~
#  525|     screen_rect.x = 0;
#  526|     screen_rect.y = 0;
#  527|->   screen_rect.width = gdk_screen_get_width (screen);
#  528|     screen_rect.height = gdk_screen_get_height (screen);
#  529|   

Error: COMPILER_WARNING (CWE-477): [#def16]
xfce4-session-4.20.2/xfce4-session/xfsm-logout-dialog.c:527:3: warning[-Wdeprecated-declarations]: ‘gdk_screen_get_width’ is deprecated
#  525|     screen_rect.x = 0;
#  526|     screen_rect.y = 0;
#  527|->   screen_rect.width = gdk_screen_get_width (screen);
#  528|     screen_rect.height = gdk_screen_get_height (screen);
#  529|   

Error: COMPILER_WARNING (CWE-477): [#def17]
xfce4-session-4.20.2/xfce4-session/xfsm-logout-dialog.c:528:3: warning[-Wdeprecated-declarations]: ‘gdk_screen_get_height’ is deprecated
#  528 |   screen_rect.height = gdk_screen_get_height (screen);
#      |   ^~~~~~~~~~~
/usr/include/gtk-3.0/gdk/gdkscreen.h:60:14: note: declared here
#   60 | gint         gdk_screen_get_height            (GdkScreen   *screen);
#      |              ^~~~~~~~~~~~~~~~~~~~~
#  526|     screen_rect.y = 0;
#  527|     screen_rect.width = gdk_screen_get_width (screen);
#  528|->   screen_rect.height = gdk_screen_get_height (screen);
#  529|   
#  530|     window = gdk_screen_get_root_window (screen);

Error: COMPILER_WARNING (CWE-477): [#def18]
xfce4-session-4.20.2/xfce4-session/xfsm-logout-dialog.c:528:3: warning[-Wdeprecated-declarations]: ‘gdk_screen_get_height’ is deprecated
#  526|     screen_rect.y = 0;
#  527|     screen_rect.width = gdk_screen_get_width (screen);
#  528|->   screen_rect.height = gdk_screen_get_height (screen);
#  529|   
#  530|     window = gdk_screen_get_root_window (screen);

Scan Properties