xfce4-settings-4.20.1-1.fc43

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-121): [#def1]
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:245:5: warning[-Wanalyzer-out-of-bounds]: stack-based buffer overflow
#  243|       XfceWlrOutput *output = g_ptr_array_index (outputs, 0);
#  244|       XfceWlrMode *modes[outputs->len];
#  245|->     modes[outputs->len - 1] = NULL;
#  246|   
#  247|       /* walk supported modes from the first output */

Error: GCC_ANALYZER_WARNING (CWE-121): [#def2]
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:275:13: warning[-Wanalyzer-out-of-bounds]: stack-based buffer over-read
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:248:37: branch_true: following ‘true’ branch (when ‘lp’ is non-NULL)...
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:250:20: branch_true: ...to here
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:275:13: danger: read of 8 bytes at offset ‘*outputs.len * 8 + 34359738360’ exceeds the buffer
#  273|   
#  274|           /* modes[0] is supported by all outputs: let's go with it */
#  275|->         if (modes[outputs->len - 1] != NULL)
#  276|               break;
#  277|       }

Error: GCC_ANALYZER_WARNING (CWE-121): [#def3]
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:279:9: warning[-Wanalyzer-out-of-bounds]: stack-based buffer over-read
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:248:37: branch_false: following ‘false’ branch (when ‘lp’ is NULL)...
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:279:9: branch_false: ...to here
xfce4-settings-4.20.1/dialogs/display-settings/display-settings-wayland.c:279:9: danger: read of 8 bytes at offset ‘*outputs.len * 8 + 34359738360’ exceeds the buffer
#  277|       }
#  278|   
#  279|->     if (modes[outputs->len - 1] != NULL)
#  280|           return g_memdup2 (modes, sizeof (XfceWlrMode *) * outputs->len);
#  281|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
xfce4-settings-4.20.1/dialogs/display-settings/main.c:636:27: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1039:1: enter_function: entry to ‘display_settings_combobox_selection_changed’
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1047:8: branch_true: following ‘true’ branch...
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1050:17: branch_true: ...to here
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1061:9: call_function: calling ‘display_setting_resolutions_populate’ from ‘display_settings_combobox_selection_changed’
#  634|       /* Walk all supported modes */
#  635|       output = get_nth_xfce_output (settings, selected_id);
#  636|->     for (guint n = 0; n < output->n_modes; n++)
#  637|       {
#  638|           /* The mode resolution does not match the selected one */

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
xfce4-settings-4.20.1/dialogs/display-settings/main.c:750:5: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1039:1: enter_function: entry to ‘display_settings_combobox_selection_changed’
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1047:8: branch_true: following ‘true’ branch...
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1050:17: branch_true: ...to here
xfce4-settings-4.20.1/dialogs/display-settings/main.c:1061:9: call_function: calling ‘display_setting_resolutions_populate’ from ‘display_settings_combobox_selection_changed’
#  748|   
#  749|       /* Walk all supported modes */
#  750|->     modes = output->modes;
#  751|       for (guint n = 0; n < output->n_modes; n++)
#  752|       {

Error: GCC_ANALYZER_WARNING (CWE-688): [#def6]
xfce4-settings-4.20.1/dialogs/mime-settings/xfce-mime-chooser.c:648:11: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
xfce4-settings-4.20.1/dialogs/mime-settings/xfce-mime-chooser.c:633:1: enter_function: entry to ‘xfce_mime_chooser_get_app_info’
xfce4-settings-4.20.1/dialogs/mime-settings/xfce-mime-chooser.c:642:6: branch_true: following ‘true’ branch...
xfce4-settings-4.20.1/dialogs/mime-settings/xfce-mime-chooser.c:644:34: branch_true: ...to here
xfce4-settings-4.20.1/dialogs/mime-settings/xfce-mime-chooser.c:648:11: danger: argument 1 (‘<unknown>’) NULL where non-null expected
#argument 1 of ‘__builtin_strchr’ must be non-null
#  646|         /* determine the path for the custom command */
#  647|         path = g_strdup (exec);
#  648|->       s = strchr (path, ' ');
#  649|         if (G_UNLIKELY (s != NULL))
#  650|           *s = '\0';

Error: GCC_ANALYZER_WARNING (CWE-126): [#def7]
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:143:9: warning[-Wanalyzer-out-of-bounds]: buffer over-read
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:209:1: enter_function: entry to ‘xfce_gtk_settings_helper_init’
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:222:8: branch_false: following ‘false’ branch...
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:228:22: branch_false: ...to here
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:229:23: branch_true: following ‘true’ branch (when ‘i != 10’)...
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:230:54: branch_true: ...to here
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:237:23: branch_true: following ‘true’ branch (when ‘i != 26’)...
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:240:76: branch_true: ...to here
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:241:12: branch_false: following ‘false’ branch...
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:244:14: branch_false: ...to here
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:252:12: branch_false: following ‘false’ branch...
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:256:35: branch_false: ...to here
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:258:16: branch_false: following ‘false’ branch...
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:262:40: branch_false: ...to here
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:274:20: branch_false: following ‘false’ branch...
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:279:42: branch_false: ...to here
xfce4-settings-4.20.1/xfsettingsd/gtk-settings.c:279:42: call_function: calling ‘gtk_setting_to_xfconf_prop’ from ‘xfce_gtk_settings_helper_init’
#  141|   
#  142|       setting += 4;
#  143|->     if (g_str_has_prefix (setting, "xft-"))
#  144|       {
#  145|           xft = TRUE;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def8]
xfce4-settings-4.20.1/xfsettingsd/pointers.c:892:21: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘val’
xfce4-settings-4.20.1/xfsettingsd/pointers.c:1183:1: enter_function: entry to ‘xfce_pointers_helper_event_filter’
xfce4-settings-4.20.1/xfsettingsd/pointers.c:1194:12: branch_true: following ‘true’ branch...
xfce4-settings-4.20.1/xfsettingsd/pointers.c:1195:13: branch_true: ...to here
xfce4-settings-4.20.1/xfsettingsd/pointers.c:1195:13: call_function: calling ‘xfce_pointers_helper_restore_devices’ from ‘xfce_pointers_helper_event_filter’
#  890|                   else
#  891|                   {
#  892|->                     g_critical ("Unknown property type %s: target = %s, format = %d",
#  893|                                   G_VALUE_TYPE_NAME (val), XGetAtomName (xdisplay, type), format);
#  894|                       break;

Scan Properties