Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-477): [#def1]
kio-6.18.0/src/gui/kprocessrunner.cpp: scope_hint: In member function ‘void KProcessRunner::init(const KService::Ptr&, const QString&, const QString&, const QByteArray&)’
kio-6.18.0/src/gui/kprocessrunner.cpp:321:38: warning[-Wdeprecated-declarations]: ‘void KWaylandExtras::xdgActivationTokenArrived(int, const QString&)’ is deprecated: Since 6.19. Use xdgActivationToken()
#  321 |                     &KWaylandExtras::xdgActivationTokenArrived,
#      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF6/KWindowSystem/KWaylandExtras:1: included_from: Included from here.
kio-6.18.0/src/gui/kprocessrunner.cpp:26: included_from: Included from here.
/usr/include/KF6/KWindowSystem/kwaylandextras.h:113:78: note: declared here
#  113 |     KWINDOWSYSTEM_DEPRECATED_VERSION(6, 19, "Use xdgActivationToken()") void xdgActivationTokenArrived(int serial, const QString &token);
#      |                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
#  319|                   connect(
#  320|                       KWaylandExtras::self(),
#  321|->                     &KWaylandExtras::xdgActivationTokenArrived,
#  322|                       m_process.get(),
#  323|                       [this, launchedSerial](int tokenSerial, const QString &token) {

Error: COMPILER_WARNING (CWE-477): [#def2]
kio-6.18.0/src/gui/kprocessrunner.cpp:331:58: warning[-Wdeprecated-declarations]: ‘static void KWaylandExtras::requestXdgActivationToken(QWindow*, uint32_t, const QString&)’ is deprecated: Since 6.19. Use xdgActivationToken()
#  331 |                 KWaylandExtras::requestXdgActivationToken(window, launchedSerial, resolveServiceAlias());
#      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF6/KWindowSystem/kwaylandextras.h:44:29: note: declared here
#   44 |     Q_INVOKABLE static void requestXdgActivationToken(QWindow *win, uint32_t serial, const QString &app_id);
#      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
#  329|                       },
#  330|                       Qt::SingleShotConnection);
#  331|->                 KWaylandExtras::requestXdgActivationToken(window, launchedSerial, resolveServiceAlias());
#  332|               }
#  333|           }

Error: COMPILER_WARNING (CWE-477): [#def3]
kio-6.18.0/src/gui/openfilemanagerwindowjob.cpp: scope_hint: In member function ‘virtual void KIO::OpenFileManagerWindowDBusStrategy::start(const QList<QUrl>&, const QByteArray&)’
kio-6.18.0/src/gui/openfilemanagerwindowjob.cpp:182:34: warning[-Wdeprecated-declarations]: ‘void KWaylandExtras::xdgActivationTokenArrived(int, const QString&)’ is deprecated: Since 6.19. Use xdgActivationToken()
#  182 |                 &KWaylandExtras::xdgActivationTokenArrived,
#      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF6/KWindowSystem/KWaylandExtras:1: included_from: Included from here.
kio-6.18.0/src/gui/openfilemanagerwindowjob.cpp:30: included_from: Included from here.
/usr/include/KF6/KWindowSystem/kwaylandextras.h:113:78: note: declared here
#  113 |     KWINDOWSYSTEM_DEPRECATED_VERSION(6, 19, "Use xdgActivationToken()") void xdgActivationTokenArrived(int serial, const QString &token);
#      |                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
#  180|               QObject::connect(
#  181|                   KWaylandExtras::self(),
#  182|->                 &KWaylandExtras::xdgActivationTokenArrived,
#  183|                   this,
#  184|                   [launchedSerial, runWithToken](int serial, const QString &token) {

Error: COMPILER_WARNING (CWE-477): [#def4]
kio-6.18.0/src/gui/openfilemanagerwindowjob.cpp:190:54: warning[-Wdeprecated-declarations]: ‘static void KWaylandExtras::requestXdgActivationToken(QWindow*, uint32_t, const QString&)’ is deprecated: Since 6.19. Use xdgActivationToken()
#  190 |             KWaylandExtras::requestXdgActivationToken(window, launchedSerial, {});
#      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF6/KWindowSystem/kwaylandextras.h:44:29: note: declared here
#   44 |     Q_INVOKABLE static void requestXdgActivationToken(QWindow *win, uint32_t serial, const QString &app_id);
#      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
#  188|                   },
#  189|                   Qt::SingleShotConnection);
#  190|->             KWaylandExtras::requestXdgActivationToken(window, launchedSerial, {});
#  191|           } else {
#  192|               runWithToken({});

Error: COMPILER_WARNING (CWE-252): [#def5]
kio-6.18.0/src/kioworkers/file/file.cpp: scope_hint: In member function ‘virtual KIO::WorkerResult FileProtocol::put(const QUrl&, int, KIO::JobFlags)’
kio-6.18.0/src/kioworkers/file/file.cpp:615:27: warning[-Wunused-result]: ignoring return value of ‘virtual bool QFile::open(QIODeviceBase::OpenMode)’, declared with attribute ‘nodiscard’
#  615 |                     f.open(QIODevice::ReadWrite | QIODevice::Append);
#      |                     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt6/QtCore/QFile:1: included_from: Included from here.
kio-6.18.0/src/core/global.h:12: included_from: Included from here.
kio-6.18.0/redhat-linux-build/src/core/kio/global.h:1: included_from: Included from here.
kio-6.18.0/src/kioworkers/file/file.h:12: included_from: Included from here.
kio-6.18.0/src/kioworkers/file/file.cpp:12: included_from: Included from here.
/usr/include/qt6/QtCore/qfile.h:291:32: note: declared here
#  291 |     QFILE_MAYBE_NODISCARD bool open(OpenMode flags) override;
#      |                                ^~~~
#  613|   
#  614|                   if ((_flags & KIO::Resume)) {
#  615|->                     f.open(QIODevice::ReadWrite | QIODevice::Append);
#  616|                   } else {
#  617|                       f.open(QIODevice::Truncate | QIODevice::WriteOnly);

Error: COMPILER_WARNING (CWE-252): [#def6]
kio-6.18.0/src/kioworkers/file/file.cpp:617:27: warning[-Wunused-result]: ignoring return value of ‘virtual bool QFile::open(QIODeviceBase::OpenMode)’, declared with attribute ‘nodiscard’
#  617 |                     f.open(QIODevice::Truncate | QIODevice::WriteOnly);
#      |                     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt6/QtCore/qfile.h:291:32: note: declared here
#  291 |     QFILE_MAYBE_NODISCARD bool open(OpenMode flags) override;
#      |                                ^~~~
#  615|                       f.open(QIODevice::ReadWrite | QIODevice::Append);
#  616|                   } else {
#  617|->                     f.open(QIODevice::Truncate | QIODevice::WriteOnly);
#  618|                       if (_mode != -1) {
#  619|                           // WABA: Make sure that we keep writing permissions ourselves,

Error: COMPILER_WARNING (CWE-252): [#def7]
kio-6.18.0/src/kioworkers/file/kauth/filehelper.cpp: scope_hint: In function ‘void gainPrivilege(Privilege*)’
kio-6.18.0/src/kioworkers/file/kauth/filehelper.cpp:116:12: warning[-Wunused-result]: ignoring return value of ‘int seteuid(__uid_t)’ declared with attribute ‘warn_unused_result’
#  116 |     seteuid(olduid);
#      |     ~~~~~~~^~~~~~~~
#  114|       gid_t oldgid = p->gid;
#  115|   
#  116|->     seteuid(olduid);
#  117|       setegid(oldgid);
#  118|       setgroups(1, &oldgid);

Error: COMPILER_WARNING (CWE-252): [#def8]
kio-6.18.0/src/kioworkers/file/kauth/filehelper.cpp:117:12: warning[-Wunused-result]: ignoring return value of ‘int setegid(__gid_t)’ declared with attribute ‘warn_unused_result’
#  117 |     setegid(oldgid);
#      |     ~~~~~~~^~~~~~~~
#  115|   
#  116|       seteuid(olduid);
#  117|->     setegid(oldgid);
#  118|       setgroups(1, &oldgid);
#  119|   }

Error: COMPILER_WARNING (CWE-477): [#def9]
kio-6.18.0/src/widgets/kfileitemactions.cpp: scope_hint: In lambda function
kio-6.18.0/src/widgets/kfileitemactions.cpp:742:58: warning[-Wdeprecated-declarations]: ‘static void KWaylandExtras::requestXdgActivationToken(QWindow*, uint32_t, const QString&)’ is deprecated: Since 6.19. Use xdgActivationToken()
#  742 |                 KWaylandExtras::requestXdgActivationToken(window, KWaylandExtras::lastInputSerial(window), {});
#      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF6/KWindowSystem/KWaylandExtras:1: included_from: Included from here.
kio-6.18.0/src/widgets/kfileitemactions.cpp:31: included_from: Included from here.
/usr/include/KF6/KWindowSystem/kwaylandextras.h:44:29: note: declared here
#   44 |     Q_INVOKABLE static void requestXdgActivationToken(QWindow *win, uint32_t serial, const QString &app_id);
#      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
#  740|               QObject::connect(openWithAction, &QAction::triggered, this, [] {
#  741|                   auto window = qGuiApp->allWindows().constFirst();
#  742|->                 KWaylandExtras::requestXdgActivationToken(window, KWaylandExtras::lastInputSerial(window), {});
#  743|               });
#  744|               QObject::connect(

Error: COMPILER_WARNING (CWE-477): [#def10]
kio-6.18.0/src/widgets/kfileitemactions.cpp: scope_hint: In member function ‘void KFileItemActionsPrivate::insertOpenWithActionsTo(QAction*, QMenu*, const QStringList&)’
kio-6.18.0/src/widgets/kfileitemactions.cpp:746:34: warning[-Wdeprecated-declarations]: ‘void KWaylandExtras::xdgActivationTokenArrived(int, const QString&)’ is deprecated: Since 6.19. Use xdgActivationToken()
#  746 |                 &KWaylandExtras::xdgActivationTokenArrived,
#      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF6/KWindowSystem/kwaylandextras.h:113:78: note: declared here
#  113 |     KWINDOWSYSTEM_DEPRECATED_VERSION(6, 19, "Use xdgActivationToken()") void xdgActivationTokenArrived(int serial, const QString &token);
#      |                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
#  744|               QObject::connect(
#  745|                   KWaylandExtras::self(),
#  746|->                 &KWaylandExtras::xdgActivationTokenArrived,
#  747|                   this,
#  748|                   [sendMessage](int, const QString &token) {

Scan Properties