libdnf-0.75.0-1.fc44

List of Findings

Error: COMPILER_WARNING (CWE-758): [#def1]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_common_types.dir/common_typesPYTHON_wrap.cxx:3507:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__common_types()’
# 3507 | #  define SWIG_init    PyInit__common_types
#      |                        ^~~~~~~~~~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_common_types.dir/common_typesPYTHON_wrap.cxx:18209:1: note: in expansion of macro ‘SWIG_init’
#18209 | SWIG_init(void) {
#      | ^~~~~~~~~
# 3505|     ------------------------------------------------*/
# 3506|   #if PY_VERSION_HEX >= 0x03000000
# 3507|-> #  define SWIG_init    PyInit__common_types
# 3508|   
# 3509|   #else

Error: COMPILER_WARNING (CWE-758): [#def2]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_conf.dir/confPYTHON_wrap.cxx:3539:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__conf()’
# 3539 | #  define SWIG_init    PyInit__conf
#      |                        ^~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_conf.dir/confPYTHON_wrap.cxx:30752:1: note: in expansion of macro ‘SWIG_init’
#30752 | SWIG_init(void) {
#      | ^~~~~~~~~
# 3537|     ------------------------------------------------*/
# 3538|   #if PY_VERSION_HEX >= 0x03000000
# 3539|-> #  define SWIG_init    PyInit__conf
# 3540|   
# 3541|   #else

Error: COMPILER_WARNING (CWE-758): [#def3]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_error.dir/errorPYTHON_wrap.cxx:3457:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__error()’
# 3457 | #  define SWIG_init    PyInit__error
#      |                        ^~~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_error.dir/errorPYTHON_wrap.cxx:4131:1: note: in expansion of macro ‘SWIG_init’
# 4131 | SWIG_init(void) {
#      | ^~~~~~~~~
# 3455|     ------------------------------------------------*/
# 3456|   #if PY_VERSION_HEX >= 0x03000000
# 3457|-> #  define SWIG_init    PyInit__error
# 3458|   
# 3459|   #else

Error: COMPILER_WARNING (CWE-758): [#def4]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx: scope_hint: At global scope
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx:3515:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__module()’
# 3515 | #  define SWIG_init    PyInit__module
#      |                        ^~~~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx:32645:1: note: in expansion of macro ‘SWIG_init’
#32645 | SWIG_init(void) {
#      | ^~~~~~~~~
# 3513|     ------------------------------------------------*/
# 3514|   #if PY_VERSION_HEX >= 0x03000000
# 3515|-> #  define SWIG_init    PyInit__module
# 3516|   
# 3517|   #else

Error: COMPILER_WARNING (CWE-477): [#def5]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx: scope_hint: In function ‘PyObject* _wrap_ModulePackageContainer_getDisabledStreams(PyObject*, PyObject*)’
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx:29876:42: warning[-Wdeprecated-declarations]: ‘std::map<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > libdnf::ModulePackageContainer::getDisabledStreams()’ is deprecated: Will be removed after 2019-12-31. Use getDisabledModules() instead.
#29876 |       result = (arg1)->getDisabledStreams();
#      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~^~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx:4194: included_from: Included from here.
libdnf-0.75.0/libdnf/module/ModulePackageContainer.hpp:251:40: note: declared here
#  251 |     std::map<std::string, std::string> getDisabledStreams();
#      |                                        ^~~~~~~~~~~~~~~~~~
#29874|     {
#29875|       try {
#29876|->       result = (arg1)->getDisabledStreams();
#29877|       } catch (const libdnf::Error & e) {
#29878|         PyErr_SetString(libdnf_error, const_cast<char*>(e.what()));

Error: COMPILER_WARNING (CWE-477): [#def6]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx: scope_hint: In function ‘PyObject* _wrap_ModulePackageContainer_getResetStreams(PyObject*, PyObject*)’
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_module.dir/modulePYTHON_wrap.cxx:29946:39: warning[-Wdeprecated-declarations]: ‘std::map<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > libdnf::ModulePackageContainer::getResetStreams()’ is deprecated: Will be removed after 2019-12-31. Use getResetModules() instead.
#29946 |       result = (arg1)->getResetStreams();
#      |                ~~~~~~~~~~~~~~~~~~~~~~~^~
libdnf-0.75.0/libdnf/module/ModulePackageContainer.hpp:263:40: note: declared here
#  263 |     std::map<std::string, std::string> getResetStreams();
#      |                                        ^~~~~~~~~~~~~~~
#29944|     {
#29945|       try {
#29946|->       result = (arg1)->getResetStreams();
#29947|       } catch (const libdnf::Error & e) {
#29948|         PyErr_SetString(libdnf_error, const_cast<char*>(e.what()));

Error: COMPILER_WARNING (CWE-758): [#def7]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_repo.dir/repoPYTHON_wrap.cxx:4017:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__repo()’
# 4017 | #  define SWIG_init    PyInit__repo
#      |                        ^~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_repo.dir/repoPYTHON_wrap.cxx:17955:1: note: in expansion of macro ‘SWIG_init’
#17955 | SWIG_init(void) {
#      | ^~~~~~~~~
# 4015|     ------------------------------------------------*/
# 4016|   #if PY_VERSION_HEX >= 0x03000000
# 4017|-> #  define SWIG_init    PyInit__repo
# 4018|   
# 4019|   #else

Error: COMPILER_WARNING (CWE-758): [#def8]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_smartcols.dir/smartcolsPYTHON_wrap.cxx:3481:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__smartcols()’
# 3481 | #  define SWIG_init    PyInit__smartcols
#      |                        ^~~~~~~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_smartcols.dir/smartcolsPYTHON_wrap.cxx:12066:1: note: in expansion of macro ‘SWIG_init’
#12066 | SWIG_init(void) {
#      | ^~~~~~~~~
# 3479|     ------------------------------------------------*/
# 3480|   #if PY_VERSION_HEX >= 0x03000000
# 3481|-> #  define SWIG_init    PyInit__smartcols
# 3482|   
# 3483|   #else

Error: COMPILER_WARNING (CWE-758): [#def9]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_transaction.dir/transactionPYTHON_wrap.cxx:3513:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__transaction()’
# 3513 | #  define SWIG_init    PyInit__transaction
#      |                        ^~~~~~~~~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_transaction.dir/transactionPYTHON_wrap.cxx:21427:1: note: in expansion of macro ‘SWIG_init’
#21427 | SWIG_init(void) {
#      | ^~~~~~~~~
# 3511|     ------------------------------------------------*/
# 3512|   #if PY_VERSION_HEX >= 0x03000000
# 3513|-> #  define SWIG_init    PyInit__transaction
# 3514|   
# 3515|   #else

Error: COMPILER_WARNING (CWE-758): [#def10]
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_utils.dir/utilsPYTHON_wrap.cxx:3974:24: warning[-Wmissing-declarations]: no previous declaration for ‘PyObject* PyInit__utils()’
# 3974 | #  define SWIG_init    PyInit__utils
#      |                        ^~~~~~~~~~~~~
libdnf-0.75.0/build-py3/bindings/python/CMakeFiles/_utils.dir/utilsPYTHON_wrap.cxx:7644:1: note: in expansion of macro ‘SWIG_init’
# 7644 | SWIG_init(void) {
#      | ^~~~~~~~~
# 3972|     ------------------------------------------------*/
# 3973|   #if PY_VERSION_HEX >= 0x03000000
# 3974|-> #  define SWIG_init    PyInit__utils
# 3975|   
# 3976|   #else

Error: COMPILER_WARNING: [#def11]
libdnf-0.75.0/libdnf/dnf-context.cpp:142:1: warning[-Wnon-c-typedef-for-linkage]: anonymous non-C-compatible type given name for linkage purposes by ‘typedef’ declaration
#  142 | {
#      | ^
#      | DnfContextPrivate
libdnf-0.75.0/libdnf/dnf-context.cpp:161:24: note: type is not C-compatible because ‘DnfContextPrivate::native_arches’ has default member initializer
#  161 |     gchar            **native_arches{NULL};
#      |                        ^~~~~~~~~~~~~
#  140|   
#  141|   typedef struct
#  142|-> {
#  143|       gchar            **repos_dir;
#  144|       gchar            **vars_dir;

Error: GCC_ANALYZER_WARNING (CWE-457): [#def12]
libdnf-0.75.0/libdnf/dnf-context.h:38:1: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘ctx’
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1029:1: enter_function: entry to ‘dnf_repo_loader_gpg_wrong_asc_func’
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1045:17: call_function: calling ‘dnf_test_get_filename’ from ‘dnf_repo_loader_gpg_wrong_asc_func’
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1045:17: return_function: returning to ‘dnf_repo_loader_gpg_wrong_asc_func’ from ‘dnf_test_get_filename’
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1050:5: branch_true: following ‘true’ branch...
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1053:19: branch_true: ...to here
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1056:5: branch_true: following ‘true’ branch...
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1059:13: branch_true: ...to here
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1064:8: branch_true: following ‘true’ branch...
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1067:9: branch_true: ...to here
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1037:25: call_function: inlined call to ‘glib_autoptr_cleanup_DnfState’ from ‘dnf_repo_loader_gpg_wrong_asc_func’
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1036:27: call_function: inlined call to ‘glib_autoptr_cleanup_DnfContext’ from ‘dnf_repo_loader_gpg_wrong_asc_func’
#   36|   
#   37|   #define DNF_TYPE_CONTEXT (dnf_context_get_type ())
#   38|-> G_DECLARE_DERIVABLE_TYPE (DnfContext, dnf_context, DNF, CONTEXT, GObject)
#   39|   
#   40|   struct _DnfContextClass

Error: COMPILER_WARNING: [#def13]
libdnf-0.75.0/libdnf/dnf-goal.cpp: scope_hint: In function ‘GPtrArray* dnf_goal_get_packages(HyGoal, ...)’
libdnf-0.75.0/libdnf/dnf-goal.cpp:164:11: warning[-Wunused-but-set-variable=]: variable ‘j’ set but not used
#  164 |     guint j;
#      |           ^
#  162|       gint info_tmp;
#  163|       guint i;
#  164|->     guint j;
#  165|       va_list args;
#  166|   

Error: COMPILER_WARNING (CWE-477): [#def14]
libdnf-0.75.0/libdnf/dnf-repo-loader.cpp: scope_hint: In function ‘gboolean dnf_repo_loader_get_repos_removable(DnfRepoLoader*, GError**)’
libdnf-0.75.0/libdnf/dnf-repo-loader.cpp:249:31: warning[-Wdeprecated-declarations]: ‘GList* g_unix_mounts_get(guint64*)’ is deprecated: Use 'g_unix_mount_entries_get' instead
#  249 |     mounts = g_unix_mounts_get(NULL);
#      |              ~~~~~~~~~~~~~~~~~^~~~~~
libdnf-0.75.0/libdnf/dnf-repo-loader.cpp:37: included_from: Included from here.
/usr/include/gio-unix-2.0/gio/gunixmounts.h:199:16: note: declared here
#  199 | GList *        g_unix_mounts_get                    (guint64            *time_read);
#      |                ^~~~~~~~~~~~~~~~~
#  247|   
#  248|       /* coldplug the mounts */
#  249|->     mounts = g_unix_mounts_get(NULL);
#  250|       for (l = mounts; l != NULL; l = l->next) {
#  251|           GUnixMountEntry *e =(GUnixMountEntry *) l->data;

Error: COMPILER_WARNING (CWE-477): [#def15]
libdnf-0.75.0/libdnf/dnf-repo-loader.cpp:252:38: warning[-Wdeprecated-declarations]: ‘gboolean g_unix_mount_is_readonly(GUnixMountEntry*)’ is deprecated: Use 'g_unix_mount_entry_is_readonly' instead
#  252 |         if (!g_unix_mount_is_readonly(e))
#      |              ~~~~~~~~~~~~~~~~~~~~~~~~^~~
/usr/include/gio-unix-2.0/gio/gunixmounts.h:125:16: note: declared here
#  125 | gboolean       g_unix_mount_is_readonly             (GUnixMountEntry    *mount_entry);
#      |                ^~~~~~~~~~~~~~~~~~~~~~~~
#  250|       for (l = mounts; l != NULL; l = l->next) {
#  251|           GUnixMountEntry *e =(GUnixMountEntry *) l->data;
#  252|->         if (!g_unix_mount_is_readonly(e))
#  253|               continue;
#  254|           if (g_strcmp0(g_unix_mount_get_fs_type(e), "iso9660") != 0)

Error: COMPILER_WARNING (CWE-477): [#def16]
libdnf-0.75.0/libdnf/dnf-repo-loader.cpp:254:47: warning[-Wdeprecated-declarations]: ‘const char* g_unix_mount_get_fs_type(GUnixMountEntry*)’ is deprecated: Use 'g_unix_mount_entry_get_fs_type' instead
#  254 |         if (g_strcmp0(g_unix_mount_get_fs_type(e), "iso9660") != 0)
#      |                       ~~~~~~~~~~~~~~~~~~~~~~~~^~~
/usr/include/gio-unix-2.0/gio/gunixmounts.h:115:16: note: declared here
#  115 | const char *   g_unix_mount_get_fs_type             (GUnixMountEntry    *mount_entry);
#      |                ^~~~~~~~~~~~~~~~~~~~~~~~
#  252|           if (!g_unix_mount_is_readonly(e))
#  253|               continue;
#  254|->         if (g_strcmp0(g_unix_mount_get_fs_type(e), "iso9660") != 0)
#  255|               continue;
#  256|           ret = dnf_repo_loader_add_sack_from_mount_point(self,

Error: COMPILER_WARNING (CWE-477): [#def17]
libdnf-0.75.0/libdnf/dnf-repo-loader.cpp:257:78: warning[-Wdeprecated-declarations]: ‘const char* g_unix_mount_get_mount_path(GUnixMountEntry*)’ is deprecated: Use 'g_unix_mount_entry_get_mount_path' instead
#  257 |                                                   g_unix_mount_get_mount_path(e),
#      |                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
/usr/include/gio-unix-2.0/gio/gunixmounts.h:100:16: note: declared here
#  100 | const char *   g_unix_mount_get_mount_path          (GUnixMountEntry    *mount_entry);
#      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
#  255|               continue;
#  256|           ret = dnf_repo_loader_add_sack_from_mount_point(self,
#  257|->                                                   g_unix_mount_get_mount_path(e),
#  258|                                                     &idx,
#  259|                                                     error);

Error: COMPILER_WARNING (CWE-477): [#def18]
libdnf-0.75.0/libdnf/dnf-repo-loader.cpp:264:35: warning[-Wdeprecated-declarations]: ‘void g_unix_mount_free(GUnixMountEntry*)’ is deprecated: Use 'g_unix_mount_entry_free' instead
#  264 |     g_list_foreach(mounts,(GFunc) g_unix_mount_free, NULL);
#      |                                   ^~~~~~~~~~~~~~~~~
/usr/include/gio-unix-2.0/gio/gunixmounts.h:78:16: note: declared here
#   78 | void           g_unix_mount_free                    (GUnixMountEntry    *mount_entry);
#      |                ^~~~~~~~~~~~~~~~~
#  262|       }
#  263|   out:
#  264|->     g_list_foreach(mounts,(GFunc) g_unix_mount_free, NULL);
#  265|       g_list_free(mounts);
#  266|       return ret;

Error: GCC_ANALYZER_WARNING (CWE-457): [#def19]
libdnf-0.75.0/libdnf/dnf-repo-loader.h:36:1: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘repo_loader’
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:852:11: throw: if ‘dnf_context_new’ throws an exception...
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:848:30: call_function: inlined call to ‘glib_autoptr_cleanup_DnfRepoLoader’ from ‘dnf_repo_loader_func’
#   34|   
#   35|   #define DNF_TYPE_REPO_LOADER (dnf_repo_loader_get_type ())
#   36|-> G_DECLARE_DERIVABLE_TYPE (DnfRepoLoader, dnf_repo_loader, DNF, REPO_LOADER, GObject)
#   37|   
#   38|   struct _DnfRepoLoaderClass

Error: GCC_ANALYZER_WARNING (CWE-457): [#def20]
libdnf-0.75.0/libdnf/dnf-state.h:34:1: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘state’
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1040:12: throw: if ‘dnf_lock_new’ throws an exception...
libdnf-0.75.0/tests/libdnf/dnf-self-test.c:1037:25: call_function: inlined call to ‘glib_autoptr_cleanup_DnfState’ from ‘dnf_repo_loader_gpg_wrong_asc_func’
#   32|   
#   33|   #define DNF_TYPE_STATE (dnf_state_get_type ())
#   34|-> G_DECLARE_DERIVABLE_TYPE (DnfState, dnf_state, DNF, STATE, GObject)
#   35|   
#   36|   /**

Error: COMPILER_WARNING: [#def21]
libdnf-0.75.0/libdnf/goal/Goal.cpp: scope_hint: In member function ‘bool libdnf::Goal::Impl::protectedInRemovals()’
libdnf-0.75.0/libdnf/goal/Goal.cpp:1703:11: warning[-Wunused-but-set-variable=]: variable ‘i’ set but not used
# 1703 |     guint i = 0;
#      |           ^
# 1701|   Goal::Impl::protectedInRemovals()
# 1702|   {
# 1703|->     guint i = 0;
# 1704|       bool ret = false;
# 1705|       if ((!protectedPkgs || !protectedPkgs->size()) && !protect_running_kernel)

Error: CPPCHECK_WARNING (CWE-562): [#def22]
libdnf-0.75.0/libdnf/hy-iutil.cpp:548: error[returnDanglingLifetime]: Returning pointer to local variable 'dup' that will be invalid when returning.
#  546|   {
#  547|       char *dup = pool_alloctmpspace(pool, strlen(s) + 1);
#  548|->     return strcpy(dup, s);
#  549|   }
#  550|   

Error: COMPILER_WARNING: [#def23]
libdnf-0.75.0/libdnf/hy-package.cpp:58:3: warning[-Wodr]: type ‘struct DnfPackagePrivate’ violates the C++ One Definition Rule
#   58 | } DnfPackagePrivate;
#      |   ^
libdnf-0.75.0/libdnf/dnf-package.cpp:62:3: note: a different type is defined in another translation unit
#   62 | } DnfPackagePrivate;
#      |   ^
libdnf-0.75.0/libdnf/hy-package.cpp:55:22: note: the first difference of corresponding definitions is field ‘loaded’
#   55 |     gboolean         loaded;
#      |                      ^
libdnf-0.75.0/libdnf/dnf-package.cpp:54:22: note: a field with different name is defined in another translation unit
#   54 |     char            *checksum_str;
#      |                      ^
#   56|       Id               id;
#   57|       DnfSack         *sack;
#   58|-> } DnfPackagePrivate;
#   59|   
#   60|   G_DEFINE_TYPE_WITH_PRIVATE(DnfPackage, dnf_package, G_TYPE_OBJECT)

Error: CPPCHECK_WARNING (CWE-398): [#def24]
libdnf-0.75.0/libdnf/utils/sqlite3/Sqlite3.hpp:337: error[throwInNoexceptFunction]: Unhandled exception thrown in function declared not to throw exceptions.
#  335|       }
#  336|   
#  337|->     ~SQLite3() { close(); }
#  338|   
#  339|       const std::string &getPath() const { return path; }

Error: CPPCHECK_WARNING (CWE-476): [#def25]
libdnf-0.75.0/tests/hawkey/test_iutil.cpp:42: warning[nullPointerOutOfResources]: If resource allocation fails, then there is a possible null pointer dereference: fp
#   40|       FILE *fp = fopen(filename, "w+");
#   41|       fail_if(fp == NULL);
#   42|->     fail_unless(fwrite("empty", 5, 1, fp) == 1);
#   43|       fclose(fp);
#   44|   }

Error: CPPCHECK_WARNING (CWE-476): [#def26]
libdnf-0.75.0/tests/hawkey/test_iutil.cpp:43: warning[nullPointerOutOfResources]: If resource allocation fails, then there is a possible null pointer dereference: fp
#   41|       fail_if(fp == NULL);
#   42|       fail_unless(fwrite("empty", 5, 1, fp) == 1);
#   43|->     fclose(fp);
#   44|   }
#   45|   

Error: CPPCHECK_WARNING (CWE-476): [#def27]
libdnf-0.75.0/tests/hawkey/test_sack.cpp:170: warning[nullPointerOutOfResources]: If resource allocation fails, then there is a possible null pointer dereference: fp
#  168|       FILE *fp = g_fopen (path_null_rpm, "w");
#  169|       fail_unless (fp != NULL);
#  170|->     fclose (fp);
#  171|       fail_unless (dnf_sack_add_cmdline_package (sack, path_null_rpm) == NULL);
#  172|   }

Scan Properties