Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-457): [#def1]
libmtp-1.1.19/src/libusb1-glue.c:1089:23: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value '*handler.getfunc'
libmtp-1.1.19/src/libusb1-glue.c:1303:1: enter_function: entry to 'ptp_usb_senddata'
libmtp-1.1.19/src/libusb1-glue.c:1329:12: branch_true: following 'true' branch...
libmtp-1.1.19/src/libusb1-glue.c:1344:9: branch_true: ...to here
libmtp-1.1.19/src/libusb1-glue.c:1344:9: call_function: calling 'ptp_init_send_memory_handler' from 'ptp_usb_senddata'
libmtp-1.1.19/src/libusb1-glue.c:1344:9: return_function: returning to 'ptp_usb_senddata' from 'ptp_init_send_memory_handler'
libmtp-1.1.19/src/libusb1-glue.c:1346:15: call_function: calling 'ptp_write_func' from 'ptp_usb_senddata'
# 1087|         }
# 1088|       }
# 1089|->     int getfunc_ret = handler->getfunc(NULL, handler->priv,towrite,bytes,&towrite);
# 1090|       if (getfunc_ret != PTP_RC_OK) {
# 1091|         free(bytes);

Error: GCC_ANALYZER_WARNING (CWE-457): [#def2]
libmtp-1.1.19/src/libusb1-glue.c:1237:31: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value 'memhandler.priv'
libmtp-1.1.19/src/libusb1-glue.c:1303:1: enter_function: entry to 'ptp_usb_senddata'
libmtp-1.1.19/src/libusb1-glue.c:1329:12: branch_true: following 'true' branch...
libmtp-1.1.19/src/libusb1-glue.c:1344:9: branch_true: ...to here
libmtp-1.1.19/src/libusb1-glue.c:1344:9: call_function: calling 'ptp_init_send_memory_handler' from 'ptp_usb_senddata'
libmtp-1.1.19/src/libusb1-glue.c:1344:9: return_function: returning to 'ptp_usb_senddata' from 'ptp_init_send_memory_handler'
libmtp-1.1.19/src/libusb1-glue.c:1346:15: call_function: calling 'ptp_write_func' from 'ptp_usb_senddata'
libmtp-1.1.19/src/libusb1-glue.c:1346:15: return_function: returning to 'ptp_usb_senddata' from 'ptp_write_func'
libmtp-1.1.19/src/libusb1-glue.c:1347:9: call_function: inlined call to 'ptp_exit_send_memory_handler' from 'ptp_usb_senddata'
# 1235|   static uint16_t
# 1236|   ptp_exit_send_memory_handler (PTPDataHandler *handler) {
# 1237|-> 	PTPMemHandlerPrivate* priv = (PTPMemHandlerPrivate*)handler->priv;
# 1238|   	/* data is owned by caller */
# 1239|   	free (priv);

Error: CPPCHECK_WARNING (CWE-476): [#def3]
libmtp-1.1.19/src/mtpz.c:88: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: str
#   86|   	char *result = str;
#   87|   
#   88|-> 	if ((result = fgets(str, num, stream)))
#   89|   	{
#   90|   		size_t newlen = strlen(result);

Error: COMPILER_WARNING (CWE-681): [#def4]
libmtp-1.1.19/src/mtpz.c: scope_hint: In function 'mtpz_loaddata'
libmtp-1.1.19/src/mtpz.c:151:29: warning[-Wpointer-sign]: pointer targets in assignment from 'char *' to 'unsigned char *' differ in signedness
#  151 |         MTPZ_ENCRYPTION_KEY = hex_to_bytes(hexenckey, strlen(hexenckey));
#      |                             ^
#  149|   	}
#  150|   
#  151|-> 	MTPZ_ENCRYPTION_KEY = hex_to_bytes(hexenckey, strlen(hexenckey));
#  152|   	if (!MTPZ_ENCRYPTION_KEY)
#  153|   	{

Scan Properties