xfce4-settings-4.20.2-1.fc44

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-404): [#def1]
xfce4-settings-4.20.2/common/debug.c:85:5: warning[-Wanalyzer-va-list-leak]: missing call to 'va_end'
xfce4-settings-4.20.2/common/debug.c:95:1: enter_function: entry to 'xfsettings_dbg'
xfce4-settings-4.20.2/common/debug.c:101:5: branch_true: following 'true' branch (when 'message' is non-NULL)...
xfce4-settings-4.20.2/common/debug.c:104:9: branch_true: ...to here
xfce4-settings-4.20.2/common/debug.c:104:8: branch_false: following 'false' branch...
xfce4-settings-4.20.2/common/debug.c:107:5: branch_false: ...to here
xfce4-settings-4.20.2/common/debug.c:107:5: acquire_resource: 'va_start' called here
xfce4-settings-4.20.2/common/debug.c:108:5: call_function: calling 'xfsettings_dbg_print' from 'xfsettings_dbg'
#   83|       }
#   84|   
#   85|->     g_assert (domain_name != NULL);
#   86|   
#   87|       string = g_strdup_vprintf (message, args);

Error: GCC_ANALYZER_WARNING (CWE-404): [#def2]
xfce4-settings-4.20.2/common/debug.c:87:14: warning[-Wanalyzer-va-list-leak]: missing call to 'va_end'
xfce4-settings-4.20.2/common/debug.c:95:1: enter_function: entry to 'xfsettings_dbg'
xfce4-settings-4.20.2/common/debug.c:101:5: branch_true: following 'true' branch (when 'message' is non-NULL)...
xfce4-settings-4.20.2/common/debug.c:104:9: branch_true: ...to here
xfce4-settings-4.20.2/common/debug.c:104:8: branch_false: following 'false' branch...
xfce4-settings-4.20.2/common/debug.c:107:5: branch_false: ...to here
xfce4-settings-4.20.2/common/debug.c:107:5: acquire_resource: 'va_start' called here
xfce4-settings-4.20.2/common/debug.c:108:5: call_function: calling 'xfsettings_dbg_print' from 'xfsettings_dbg'
#   85|       g_assert (domain_name != NULL);
#   86|   
#   87|->     string = g_strdup_vprintf (message, args);
#   88|       g_printerr (PACKAGE_NAME "(%s): %s\n", domain_name, string);
#   89|       g_free (string);

Error: GCC_ANALYZER_WARNING (CWE-121): [#def3]
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:245:5: warning[-Wanalyzer-out-of-bounds]: stack-based buffer overflow
#  243|       XfceWlrOutput *output = g_ptr_array_index (outputs, 0);
#  244|       XfceWlrMode *modes[outputs->len];
#  245|->     modes[outputs->len - 1] = NULL;
#  246|   
#  247|       /* walk supported modes from the first output */

Error: GCC_ANALYZER_WARNING (CWE-121): [#def4]
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:275:13: warning[-Wanalyzer-out-of-bounds]: stack-based buffer over-read
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:248:37: branch_true: following ‘true’ branch (when ‘lp’ is non-NULL)...
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:250:20: branch_true: ...to here
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:275:13: danger: read of 8 bytes at offset ‘*outputs.len * 8 + 34359738360’ exceeds the buffer
#  273|   
#  274|           /* modes[0] is supported by all outputs: let's go with it */
#  275|->         if (modes[outputs->len - 1] != NULL)
#  276|               break;
#  277|       }

Error: GCC_ANALYZER_WARNING (CWE-121): [#def5]
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:279:9: warning[-Wanalyzer-out-of-bounds]: stack-based buffer over-read
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:248:37: branch_false: following ‘false’ branch (when ‘lp’ is NULL)...
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:279:9: branch_false: ...to here
xfce4-settings-4.20.2/dialogs/display-settings/display-settings-wayland.c:279:9: danger: read of 8 bytes at offset ‘*outputs.len * 8 + 34359738360’ exceeds the buffer
#  277|       }
#  278|   
#  279|->     if (modes[outputs->len - 1] != NULL)
#  280|           return g_memdup2 (modes, sizeof (XfceWlrMode *) * outputs->len);
#  281|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def6]
xfce4-settings-4.20.2/dialogs/display-settings/main.c:357:25: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:336:1: enter_function: entry to ‘update_output_positions’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:351:8: branch_true: following ‘true’ branch (when ‘mirrored == 0’)...
xfce4-settings-4.20.2/dialogs/display-settings/main.c:353:30: branch_true: ...to here
xfce4-settings-4.20.2/dialogs/display-settings/main.c:353:30: call_function: calling ‘get_nth_xfce_output’ from ‘update_output_positions’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:353:30: return_function: returning to ‘update_output_positions’ from ‘get_nth_xfce_output’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:357:25: danger: dereference of NULL ‘get_nth_xfce_output(settings,  selected_id)’
#  355|           GrabInfo info = { 0 };
#  356|   
#  357|->         info.output_x = output->x;
#  358|           info.output_y = output->y;
#  359|           keep_output_snapped (output, &event, &info, settings);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def7]
xfce4-settings-4.20.2/dialogs/display-settings/main.c:630:27: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:599:1: enter_function: entry to ‘display_setting_refresh_rates_populate’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:616:8: branch_false: following ‘false’ branch...
xfce4-settings-4.20.2/dialogs/display-settings/main.c:622:5: branch_false: ...to here
xfce4-settings-4.20.2/dialogs/display-settings/main.c:629:14: call_function: calling ‘get_nth_xfce_output’ from ‘display_setting_refresh_rates_populate’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:629:14: return_function: returning to ‘display_setting_refresh_rates_populate’ from ‘get_nth_xfce_output’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:630:27: danger: dereference of NULL ‘get_nth_xfce_output(settings,  selected_id)’
#  628|       /* Walk all supported modes */
#  629|       output = get_nth_xfce_output (settings, selected_id);
#  630|->     for (guint n = 0; n < output->n_modes; n++)
#  631|       {
#  632|           /* The mode resolution does not match the selected one */

Error: GCC_ANALYZER_WARNING (CWE-476): [#def8]
xfce4-settings-4.20.2/dialogs/display-settings/main.c:744:5: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:708:1: enter_function: entry to ‘display_setting_resolutions_populate’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:727:14: call_function: calling ‘get_nth_xfce_output’ from ‘display_setting_resolutions_populate’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:727:14: return_function: returning to ‘display_setting_resolutions_populate’ from ‘get_nth_xfce_output’
xfce4-settings-4.20.2/dialogs/display-settings/main.c:730:8: branch_false: following ‘false’ branch...
xfce4-settings-4.20.2/dialogs/display-settings/main.c:737:5: branch_false: ...to here
xfce4-settings-4.20.2/dialogs/display-settings/main.c:744:5: danger: dereference of NULL ‘get_nth_xfce_output(settings,  selected_id)’
#  742|   
#  743|       /* Walk all supported modes */
#  744|->     modes = output->modes;
#  745|       for (guint n = 0; n < output->n_modes; n++)
#  746|       {

Error: COMPILER_WARNING (CWE-704): [#def9]
xfce4-settings-4.20.2/xfce4-settings-editor/xfce-settings-prop-dialog.c: scope_hint: In function ‘xfce_settings_prop_dialog_set_parent_property’
xfce4-settings-4.20.2/xfce4-settings-editor/xfce-settings-prop-dialog.c:676:11: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  676 |         p = strrchr (property, '/');
#      |           ^
#  674|       if (property != NULL && *property == '/')
#  675|       {
#  676|->         p = strrchr (property, '/');
#  677|           if (G_LIKELY (p != NULL))
#  678|               length = (p - property) + 1;

Error: COMPILER_WARNING (CWE-704): [#def10]
xfce4-settings-4.20.2/xfce4-settings-editor/xfce-settings-prop-dialog.c:676:11: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  674|       if (property != NULL && *property == '/')
#  675|       {
#  676|->         p = strrchr (property, '/');
#  677|           if (G_LIKELY (p != NULL))
#  678|               length = (p - property) + 1;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def11]
xfce4-settings-4.20.2/xfsettingsd/pointers.c:892:21: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘val’
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1068:1: enter_function: entry to ‘xfce_pointers_helper_channel_property_changed’
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1080:9: branch_false: following ‘false’ branch (when ‘property_name’ is non-NULL)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1084:9: branch_false: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1084:8: branch_false: following ‘false’ branch (when the strings are non-equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1085:12: branch_false: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1084:9: branch_false: following ‘false’ branch (when the strings are non-equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1092:13: branch_false: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1094:8: branch_true: following ‘true’ branch...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1098:12: branch_false: following ‘false’ branch...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1104:21: branch_true: following ‘true’ branch...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1107:39: branch_true: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1114:16: branch_true: following ‘true’ branch (when the strings are equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1117:17: branch_true: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1119:20: branch_false: following ‘false’ branch...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1126:20: branch_false: following ‘false’ branch (when the strings are non-equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1131:26: branch_false: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1131:25: branch_false: following ‘false’ branch (when the strings are non-equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1136:26: branch_false: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1136:25: branch_false: following ‘false’ branch (when the strings are non-equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1141:26: branch_false: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1141:25: branch_false: following ‘false’ branch (when the strings are non-equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1147:26: branch_false: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1147:25: branch_true: following ‘true’ branch (when the strings are equal)...
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1149:21: branch_true: ...to here
xfce4-settings-4.20.2/xfsettingsd/pointers.c:1149:21: call_function: calling ‘xfce_pointers_helper_change_property’ from ‘xfce_pointers_helper_channel_property_changed’
#  890|                   else
#  891|                   {
#  892|->                     g_critical ("Unknown property type %s: target = %s, format = %d",
#  893|                                   G_VALUE_TYPE_NAME (val), XGetAtomName (xdisplay, type), format);
#  894|                       break;

Scan Properties