Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-480): [#def1]
/usr/bin/genfstab:103:11: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  101|   
#  102|   mangle() {
#  103|->   local i= chr= out=
#  104|     local {a..f}= {A..F}=
#  105|   

Error: SHELLCHECK_WARNING (CWE-480): [#def2]
/usr/bin/genfstab:103:16: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  101|   
#  102|   mangle() {
#  103|->   local i= chr= out=
#  104|     local {a..f}= {A..F}=
#  105|   

Error: SHELLCHECK_WARNING (CWE-480): [#def3]
/usr/bin/genfstab:121:11: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  119|   
#  120|   unmangle() {
#  121|->   local i= chr= out= len=$(( ${#1} - 4 ))
#  122|     local {a..f}= {A..F}=
#  123|   

Error: SHELLCHECK_WARNING (CWE-480): [#def4]
/usr/bin/genfstab:121:16: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  119|   
#  120|   unmangle() {
#  121|->   local i= chr= out= len=$(( ${#1} - 4 ))
#  122|     local {a..f}= {A..F}=
#  123|   

Error: SHELLCHECK_WARNING (CWE-480): [#def5]
/usr/bin/genfstab:121:21: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  119|   
#  120|   unmangle() {
#  121|->   local i= chr= out= len=$(( ${#1} - 4 ))
#  122|     local {a..f}= {A..F}=
#  123|   

Error: SHELLCHECK_WARNING (CWE-398): [#def6]
/usr/bin/genfstab:195:9: warning[SC2178]: Variable was used as an array but is now assigned a string.
#  193|   
#  194|   optstring_prepend_option() {
#  195|->   local options_=$1
#  196|   
#  197|     if ! optstring_has_option "$1" "$2"; then

Error: SHELLCHECK_WARNING (CWE-480): [#def7]
/usr/bin/genfstab:245:21: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  243|   
#  244|   write_source() {
#  245|->   local src=$1 spec= label= uuid= comment=()
#  246|   
#  247|     label=$(lsblk -rno LABEL "$1" 2>/dev/null)

Error: SHELLCHECK_WARNING (CWE-480): [#def8]
/usr/bin/genfstab:245:28: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  243|   
#  244|   write_source() {
#  245|->   local src=$1 spec= label= uuid= comment=()
#  246|   
#  247|     label=$(lsblk -rno LABEL "$1" 2>/dev/null)

Error: SHELLCHECK_WARNING (CWE-480): [#def9]
/usr/bin/genfstab:245:34: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
#  243|   
#  244|   write_source() {
#  245|->   local src=$1 spec= label= uuid= comment=()
#  246|   
#  247|     label=$(lsblk -rno LABEL "$1" 2>/dev/null)

Error: SHELLCHECK_WARNING (CWE-670): [#def10]
/usr/bin/genfstab:273:6: warning[SC2128]: Expanding an array without an index only gives the first element.
#  271|     esac
#  272|   
#  273|->   [[ $comment ]] && printf '# %s\n' "${comment[*]}"
#  274|   
#  275|     if [[ $spec ]]; then

Error: SHELLCHECK_WARNING (CWE-457): [#def11]
/usr/bin/genfstab:317:57: warning[SC2154]: codepage is referenced but not assigned.
#  315|       vfat)
#  316|         # Before Linux v3.8, "cp" is prepended to the value of the codepage.
#  317|->       if optstring_get_option "$varname" codepage && [[ $codepage = cp* ]]; then
#  318|           optstring_remove_option "$varname" codepage
#  319|           optstring_append_option "$varname" "codepage=${codepage#cp}"

Scan Properties