Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-457): [#def1]
/usr/bin/dracut:1610:28: warning[SC2154]: systemdversion is referenced but not assigned.
# 1608|   USE_SYSTEMD_DLOPEN_DEPS=
# 1609|   # shellcheck disable=SC2034 # USE_SYSTEMD_DLOPEN_DEPS is used in modules
# 1610|-> [[ $DRACUT_INSTALL_JSON && ${systemdversion%%.*} -ge 256 ]] && USE_SYSTEMD_DLOPEN_DEPS=1
# 1611|   
# 1612|   if [[ $no_kernel != yes ]] && [[ -d $srcmods ]]; then

Error: SHELLCHECK_WARNING (CWE-457): [#def2]
/usr/bin/dracut:1680:44: warning[SC2154]: systemdprefix is referenced but not assigned.
# 1678|   
# 1679|           if ! [[ -s $uefi_stub ]]; then
# 1680|->             uefi_stub="${dracutsysrootdir-}${systemdprefix}/lib/systemd/boot/efi/linux${EFI_MACHINE_TYPE_NAME}.efi.stub"
# 1681|           fi
# 1682|   

Error: SHELLCHECK_WARNING (CWE-457): [#def3]
/usr/lib/dracut/dracut-init.sh:434:39: warning[SC2154]: udevdir is referenced but not assigned.
#  432|       for _prog in $(sed -nr 's/.*PROGRAM==?"([^ "]+).*/\1/p' "$1"); do
#  433|           _bin=""
#  434|->         if [[ -x "${dracutsysrootdir-}${udevdir}/$_prog" ]]; then
#  435|               _bin="${udevdir}"/$_prog
#  436|           elif [[ ${_prog/\$env\{/} == "$_prog" ]]; then

Error: SHELLCHECK_WARNING (CWE-758): [#def4]
/usr/lib/dracut/dracut-version.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
#    1|-> DRACUT_VERSION=108-3.fc44

Error: SHELLCHECK_WARNING (CWE-563): [#def5]
/usr/lib/dracut/dracut-version.sh:1:1: warning[SC2034]: DRACUT_VERSION appears unused. Verify use (or export if used externally).
#    1|-> DRACUT_VERSION=108-3.fc44

Error: SHELLCHECK_WARNING (CWE-457): [#def6]
/usr/lib/dracut/modules.d/11fips/module-setup.sh:49:33: warning[SC2154]: hostonly_default_device is referenced but not assigned.
#   47|   
#   48|       # with hostonly_default_device fs module for /boot is not installed by default
#   49|->     if [[ ${hostonly-} ]] && [[ $hostonly_default_device == "no" ]]; then
#   50|           _bootfstype=$(find_mp_fstype /boot)
#   51|           if [[ -n $_bootfstype ]]; then

Error: SHELLCHECK_WARNING (CWE-457): [#def7]
/usr/lib/dracut/modules.d/11systemd-cryptsetup/module-setup.sh:59:36: warning[SC2154]: initdir is referenced but not assigned.
#   57|           "$systemdsystemunitdir"/initrd-root-device.target.wants/remote-cryptsetup.target
#   58|   
#   59|->     if [[ ${hostonly-} ]] && [[ -f $initdir/etc/crypttab ]]; then
#   60|           # for each entry in /etc/crypttab check if the key file is backed by a socket unit and if so,
#   61|           # include it along with its corresponding service unit.

Error: SHELLCHECK_WARNING (CWE-457): [#def8]
/usr/lib/dracut/modules.d/11systemd-cryptsetup/module-setup.sh:73:83: warning[SC2154]: systemdsystemconfdir is referenced but not assigned.
#   71|               fi
#   72|   
#   73|->             find "${dracutsysrootdir-}$systemdsystemunitdir" "${dracutsysrootdir-}$systemdsystemconfdir" -type f -name "*.socket" | while read -r socket_unit; do
#   74|                   # systemd-cryptsetup utility only supports SOCK_STREAM (ListenStream) sockets, so we ignore
#   75|                   # other types like SOCK_DGRAM (ListenDatagram), SOCK_SEQPACKET (ListenSequentialPacket), etc.

Error: SHELLCHECK_WARNING (CWE-457): [#def9]
/usr/lib/dracut/modules.d/11systemd-sysext/module-setup.sh:38:32: warning[SC2154]: systemdsystemunitdir is referenced but not assigned.
#   36|   
#   37|       # systemd >= v258
#   38|->     [[ -e "${dracutsysrootdir-}$systemdsystemunitdir"/systemd-sysext-initrd.service ]] && _suffix="-initrd"
#   39|   
#   40|       # It's intended to work only with raw binary disk images contained in

Error: SHELLCHECK_WARNING (CWE-457): [#def10]
/usr/lib/dracut/modules.d/11systemd-udevd/module-setup.sh:25:38: warning[SC2154]: omit_dracutmodules is referenced but not assigned.
#   23|       for module in systemd-sysctl systemd-modules-load; do
#   24|           module_check $module > /dev/null 2>&1
#   25|->         if [[ $? == 255 ]] && ! [[ " $omit_dracutmodules " == *\ $module\ * ]]; then
#   26|               deps+=" $module"
#   27|           fi

Error: SHELLCHECK_WARNING (CWE-457): [#def11]
/usr/lib/dracut/modules.d/20i18n/module-setup.sh:139:43: warning[SC2154]: systemdsystemunitdir is referenced but not assigned.
#  137|               inst_rules 90-vconsole.rules
#  138|   
#  139|->             if [[ -e "${dracutsysrootdir-}$systemdsystemunitdir"/systemd-vconsole-setup.service ]]; then
#  140|                   inst_multiple -o \
#  141|                       "$systemdutildir"/systemd-vconsole-setup \

Error: SHELLCHECK_WARNING (CWE-457): [#def12]
/usr/lib/dracut/modules.d/20i18n/module-setup.sh:312:39: warning[SC2154]: i18n_install_all is referenced but not assigned.
#  310|           install_base
#  311|   
#  312|->         if [[ ${hostonly-} ]] && ! [[ ${i18n_install_all} == "yes" ]]; then
#  313|               install_local_i18n || install_all_kbd
#  314|           else

Error: SHELLCHECK_WARNING (CWE-457): [#def13]
/usr/lib/dracut/modules.d/35network-manager/module-setup.sh:55:19: warning[SC2154]: systemdsystemunitdir is referenced but not assigned.
#   53|   
#   54|           # Install systemd service units
#   55|->         if [[ -e "$systemdsystemunitdir"/NetworkManager-config-initrd.service ]]; then
#   56|               # NetworkManager-1.54 provides its own initrd services
#   57|               inst_multiple -o \

Error: SHELLCHECK_WARNING (CWE-457): [#def14]
/usr/lib/dracut/modules.d/35network-manager/module-setup.sh:68:35: warning[SC2154]: initdir is referenced but not assigned.
#   66|                   "$systemdsystemunitdir/NetworkManager-wait-online-initrd.service.d/NetworkManager-wait-online-initrd-dracut.conf"
#   67|   
#   68|->             $SYSTEMCTL -q --root "$initdir" enable NetworkManager-initrd.service
#   69|           else
#   70|               #TODO: remove custom systemd services when NetworkManager-1.54 is the minimum supported version

Error: SHELLCHECK_WARNING (CWE-457): [#def15]
/usr/lib/dracut/modules.d/35network-manager/module-setup.sh:81:52: warning[SC2154]: systemdnetworkconfdir is referenced but not assigned.
#   79|               "${systemdnetwork}/99-default.link" \
#   80|               "${systemdnetwork}/98-default-mac-none.link"
#   81|->         [[ ${hostonly-} ]] && inst_multiple -H -o "${systemdnetworkconfdir}/*.link"
#   82|       fi
#   83|   

Error: SHELLCHECK_WARNING (CWE-457): [#def16]
/usr/lib/dracut/modules.d/45plymouth/module-setup.sh:39:77: warning[SC2154]: initdir is referenced but not assigned.
#   37|       else
#   38|           PLYMOUTH_POPULATE_SOURCE_FUNCTIONS="$dracutfunctions" \
#   39|->             "${dracutsysrootdir-}${PKGLIBDIR}"/plymouth-populate-initrd -t "$initdir" 2> /dev/null
#   40|       fi
#   41|   

Error: SHELLCHECK_WARNING (CWE-457): [#def17]
/usr/lib/dracut/modules.d/68systemd-sysusers/module-setup.sh:24:34: warning[SC2154]: initdir is referenced but not assigned.
#   22|       {
#   23|           set -o pipefail
#   24|->         systemd-sysusers --root="$initdir" 2>&1 >&3 | grep -v "^Creating " >&2
#   25|       } 3>&1
#   26|   

Error: SHELLCHECK_WARNING (CWE-457): [#def18]
/usr/lib/dracut/modules.d/70kernel-modules/module-setup.sh:112:15: warning[SC2154]: hostonly_mode is referenced but not assigned.
#  110|           # if not on strict hostonly mode, or there are hostonly block device
#  111|           # install block drivers
#  112|->         if [[ $hostonly_mode != "strict" ]] \
#  113|               || for_each_host_dev_and_slaves_all record_block_dev_drv; then
#  114|               hostonly='' instmods sg sr_mod sd_mod scsi_dh ata_piix

Error: SHELLCHECK_WARNING (CWE-457): [#def19]
/usr/lib/dracut/modules.d/70lvm/module-setup.sh:61:33: warning[SC2154]: lvmconf is referenced but not assigned (did you mean '_lvmconf'?).
#   59|       inst_rules "$moddir/64-lvm.rules"
#   60|   
#   61|->     if [[ ${hostonly-} ]] || [[ $lvmconf == "yes" ]]; then
#   62|           if [[ -f "${dracutsysrootdir-}/etc/lvm/lvm.conf" ]]; then
#   63|               inst_simple -H /etc/lvm/lvm.conf

Error: SHELLCHECK_WARNING (CWE-457): [#def20]
/usr/lib/dracut/modules.d/70mdraid/module-setup.sh:94:33: warning[SC2154]: mdadmconf is referenced but not assigned.
#   92|       inst_rules "$moddir/59-persistent-storage-md.rules"
#   93|   
#   94|->     if [[ ${hostonly-} ]] || [[ $mdadmconf == "yes" ]]; then
#   95|           if [[ -f "${dracutsysrootdir-}/etc/mdadm.conf" ]]; then
#   96|               inst -H /etc/mdadm.conf

Error: SHELLCHECK_WARNING (CWE-457): [#def21]
/usr/lib/dracut/modules.d/70mdraid/module-setup.sh:118:39: warning[SC2154]: systemdsystemunitdir is referenced but not assigned.
#  116|       inst_script "$moddir/mdraid_start.sh" /sbin/mdraid_start
#  117|       if dracut_module_included "systemd"; then
#  118|->         if [[ -e "${dracutsysrootdir-}$systemdsystemunitdir/mdmon@.service" ]]; then
#  119|               inst_simple "$systemdsystemunitdir"/mdmon@.service
#  120|           fi

Error: SHELLCHECK_WARNING (CWE-457): [#def22]
/usr/lib/dracut/modules.d/70multipath/module-setup.sh:114:37: warning[SC2154]: hostonly_mode is referenced but not assigned.
#  112|   
#  113|       mpathconf_installed \
#  114|->         && [[ ${hostonly-} ]] && [[ $hostonly_mode == "strict" ]] && {
#  115|           for_each_host_dev_and_slaves_all add_hostonly_mpath_conf
#  116|           if ((${#_allow[@]} > 0)); then

Error: SHELLCHECK_WARNING (CWE-457): [#def23]
/usr/lib/dracut/modules.d/70ppcmac/module-setup.sh:36:15: warning[SC2154]: hostonly_mode is referenced but not assigned.
#   34|       # only PowerMac3,6 has a module, special case
#   35|       if [[ ${DRACUT_ARCH:-$(uname -m)} != ppc64* ]]; then
#   36|->         if [[ $hostonly_mode != "strict" ]] || [[ ${hostonly-} && "$(pmac_model)" == "PowerMac3,6" ]]; then
#   37|               hostonly=$(optional_hostonly) instmods therm_windtunnel
#   38|           fi

Error: SHELLCHECK_WARNING (CWE-457): [#def24]
/usr/lib/dracut/modules.d/73crypt-gpg/module-setup.sh:35:44: warning[SC2154]: initdir is referenced but not assigned.
#   33|   
#   34|           while IFS= read -r -d '' key; do
#   35|->             cp "${dracutsysrootdir-}$key" "${initdir}/root/"
#   36|           done < <(sc_public_key)
#   37|       fi

Error: SHELLCHECK_WARNING (CWE-457): [#def25]
/usr/lib/dracut/modules.d/74debug/module-setup.sh:50:73: warning[SC2154]: initdir is referenced but not assigned.
#   48|           vi
#   49|   
#   50|->     grep '^tcpdump:' "${dracutsysrootdir-}"/etc/passwd 2> /dev/null >> "$initdir/etc/passwd"
#   51|   }

Error: SHELLCHECK_WARNING (CWE-457): [#def26]
/usr/lib/dracut/modules.d/74resume/module-setup.sh:70:71: warning[SC2154]: systemdutildir is referenced but not assigned.
#   68|   
#   69|       # if systemd is included and has the hibernate-resume tool, use it and nothing else
#   70|->     if dracut_module_included "systemd" && [[ -x "${dracutsysrootdir-}$systemdutildir/systemd-hibernate-resume" ]]; then
#   71|           inst_multiple -o \
#   72|               "$systemdutildir"/system-generators/systemd-hibernate-resume-generator \

Error: SHELLCHECK_WARNING (CWE-457): [#def27]
/usr/lib/dracut/modules.d/74rootfs-block-fallback/module-setup.sh:14:37: warning[SC2154]: moddir is referenced but not assigned.
#   12|   # called by dracut
#   13|   install() {
#   14|->     inst_hook initqueue/timeout 99 "$moddir/rootfallback.sh"
#   15|   }

Error: SHELLCHECK_WARNING (CWE-457): [#def28]
/usr/lib/dracut/modules.d/74terminfo/module-setup.sh:14:31: warning[SC2154]: initdir is referenced but not assigned.
#   12|           for i in "l/linux" "v/vt100" "v/vt102" "v/vt220"; do
#   13|               inst_dir "$_terminfodir/${i%/*}"
#   14|->             $DRACUT_CP -L -t "${initdir}/${_terminfodir}/${i%/*}" "${dracutsysrootdir-}$_terminfodir/$i"
#   15|           done
#   16|       fi

Error: SHELLCHECK_WARNING (CWE-457): [#def29]
/usr/lib/dracut/modules.d/77initqueue/module-setup.sh:16:57: warning[SC2154]: systemdsystemunitdir is referenced but not assigned.
#   14|       if dracut_module_included "systemd"; then
#   15|           inst_script "$moddir/dracut-initqueue.sh" /usr/bin/dracut-initqueue
#   16|->         inst_simple "$moddir/dracut-initqueue.service" "$systemdsystemunitdir/dracut-initqueue.service"
#   17|           $SYSTEMCTL -q --root "$initdir" add-wants initrd.target dracut-initqueue.service
#   18|       fi

Error: SHELLCHECK_WARNING (CWE-457): [#def30]
/usr/lib/dracut/modules.d/77initqueue/module-setup.sh:17:31: warning[SC2154]: initdir is referenced but not assigned.
#   15|           inst_script "$moddir/dracut-initqueue.sh" /usr/bin/dracut-initqueue
#   16|           inst_simple "$moddir/dracut-initqueue.service" "$systemdsystemunitdir/dracut-initqueue.service"
#   17|->         $SYSTEMCTL -q --root "$initdir" add-wants initrd.target dracut-initqueue.service
#   18|       fi
#   19|   

Error: SHELLCHECK_WARNING: [#def31]
/usr/lib/dracut/modules.d/80base/dracut-lib.sh:277:5: warning[SC3043]: In POSIX sh, 'local' is undefined.
#  275|       CMDLINE=$(getcmdline)
#  276|       export CMDLINE
#  277|->     local _val _i _gfound="" _deprecated=""
#  278|       unset _val
#  279|       _newoption="$1"

Error: SHELLCHECK_WARNING (CWE-457): [#def32]
/usr/lib/dracut/modules.d/80base/module-setup.sh:84:18: warning[SC2154]: moddir is referenced but not assigned.
#   82|   
#   83|       # install our scripts and hooks
#   84|->     inst_script "$moddir/loginit.sh" "/sbin/loginit"
#   85|       inst_script "$moddir/rdsosreport.sh" "/sbin/rdsosreport"
#   86|   

Scan Properties