livesys-scripts-0.8.0-3.fc44

List of Findings

Error: SHELLCHECK_WARNING (CWE-477): [#def1]
/usr/libexec/livesys/livesys-main:29:39: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
#   27|     . /etc/sysconfig/livesys
#   28|   
#   29|->   if [ "${livesys_session}" = "gnome" -a -d /var/lib/gnome-initial-setup/ ]; then
#   30|         autouser=0
#   31|     fi

Error: SHELLCHECK_WARNING (CWE-477): [#def2]
/usr/libexec/livesys/sessions.d/livesys-gnome:83:57: warning[SC2166]: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
#   81|   
#   82|   # set up auto-login if it's a non-persistent boot
#   83|-> if [ "${cmdline##* rd.live.overlay[= ]}" != "$cmdline"  -o ! -d /var/lib/gnome-initial-setup ]; then
#   84|     cat > /etc/gdm/custom.conf <<- "  FOE"
#   85|   	[daemon]

Error: SHELLCHECK_WARNING (CWE-829): [#def3]
/usr/libexec/livesys/sessions.d/livesys-kde:9:4: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#    7|   
#    8|   # set up autologin for user liveuser
#    9|-> if $(rpm -q plasma-mobile > /dev/null 2>&1) ; then
#   10|     DEFAULT_DESKTOP="plasma-mobile.desktop"
#   11|     IS_MOBILE=1

Error: SHELLCHECK_WARNING: [#def4]
/usr/libexec/livesys/sessions.d/livesys-kde:9:4: warning[SC2327]: This command substitution will be empty because the command's output gets redirected away.
#    7|   
#    8|   # set up autologin for user liveuser
#    9|-> if $(rpm -q plasma-mobile > /dev/null 2>&1) ; then
#   10|     DEFAULT_DESKTOP="plasma-mobile.desktop"
#   11|     IS_MOBILE=1

Error: SHELLCHECK_WARNING: [#def5]
/usr/libexec/livesys/sessions.d/livesys-kde:9:27: error[SC2328]: This redirection takes output away from the command substitution.
#    7|   
#    8|   # set up autologin for user liveuser
#    9|-> if $(rpm -q plasma-mobile > /dev/null 2>&1) ; then
#   10|     DEFAULT_DESKTOP="plasma-mobile.desktop"
#   11|     IS_MOBILE=1

Error: SHELLCHECK_WARNING (CWE-829): [#def6]
/usr/libexec/livesys/sessions.d/livesys-lxqt:9:4: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#    7|   
#    8|   # determine if wayland session is available
#    9|-> if $(rpm -q lxqt-wayland-session > /dev/null 2>&1) ; then
#   10|     DEFAULT_DESKTOP="lxqt-wayland.desktop"
#   11|   else

Error: SHELLCHECK_WARNING: [#def7]
/usr/libexec/livesys/sessions.d/livesys-lxqt:9:4: warning[SC2327]: This command substitution will be empty because the command's output gets redirected away.
#    7|   
#    8|   # determine if wayland session is available
#    9|-> if $(rpm -q lxqt-wayland-session > /dev/null 2>&1) ; then
#   10|     DEFAULT_DESKTOP="lxqt-wayland.desktop"
#   11|   else

Error: SHELLCHECK_WARNING: [#def8]
/usr/libexec/livesys/sessions.d/livesys-lxqt:9:34: error[SC2328]: This redirection takes output away from the command substitution.
#    7|   
#    8|   # determine if wayland session is available
#    9|-> if $(rpm -q lxqt-wayland-session > /dev/null 2>&1) ; then
#   10|     DEFAULT_DESKTOP="lxqt-wayland.desktop"
#   11|   else

Scan Properties